Docker: fix build on docker hub

.codecov.yml

@@ -1,35 +0,0 @@
-codecov:
-  notify:
-    require_ci_to_pass: yes
-
-coverage:
-  precision: 2
-  round: down
-  range: "60...100"
-
-  status:
-    project:
-      default:
-        target: auto
-        threshold: 2%
-        base: auto
-    patch:
-      default:
-        target: auto
-        threshold: 2%
-        base: auto
-    changes: no
-
-parsers:
-  gcov:
-    branch_detection:
-      conditional: yes
-      loop: yes
-      method: no
-      macro: no
-
-comment:
-  require_changes: yes
-  layout: "header, diff, files"
-  behavior: default
-  require_changes: no

.gitattributes

@@ -3,18 +3,4 @@ src/static/lightbox/* linguist-vendored
 src/static/typeahead/* linguist-vendored
 src/static/moment/* linguist-vendored
 src/static/datetimepicker/* linguist-vendored
-src/static/colorpicker/* linguist-vendored
-src/static/fileupload/* linguist-vendored
 src/static/charts/* linguist-vendored
-src/pretix/plugins/ticketoutputpdf/static/pretixplugins/ticketoutputpdf/fabric.* linguist-vendored
-src/pretix/plugins/ticketoutputpdf/static/pretixplugins/ticketoutputpdf/pdf.* linguist-vendored
-
-# Denote all files that are truly binary and should not be modified.
-*.eot binary
-*.otf binary
-*.ttf binary
-*.woff binary
-*.zip binary
-*.png binary
-*.gif binary
-*.jpg binary

.gitignore

@@ -21,6 +21,4 @@ pretixeu/
 local/
 .project
 .pydevproject
-.DS_Store
-
 

.gitlab-ci.yml

@@ -2,31 +2,11 @@ before_script:
 tests:
     stage: test
     script:
-        - virtualenv env
+        - virtualenv-3.4 env
         - source env/bin/activate
         - pip install -U pip wheel setuptools
+        - XDG_CACHE_HOME=/cache bash .travis.sh style
         - XDG_CACHE_HOME=/cache bash .travis.sh tests
+        - XDG_CACHE_HOME=/cache bash .travis.sh doctests
     tags:
         - python3
-pypi:
-    stage: release
-    script:
-        - cp /keys/.pypirc ~/.pypirc
-        - virtualenv env
-        - source env/bin/activate
-        - pip install -U pip wheel setuptools
-        - XDG_CACHE_HOME=/cache pip3 install -Ur src/requirements.txt -r src/requirements/dev.txt -r src/requirements/py34.txt
-        - cd src
-        - python setup.py sdist upload
-        - python setup.py bdist_wheel upload
-    tags:
-        - python3
-    only:
-        - release
-    artifacts:
-        paths:
-            - src/dist/
-stages:
-    - test
-    - build
-    - release

.travis.sh

@@ -4,16 +4,6 @@ set -x
 
 echo "Executing job $1"
 
-if [ "$PRETIX_CONFIG_FILE" == "tests/travis_mysql.cfg" ]; then
-    mysql -u root -e 'CREATE DATABASE pretix DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_general_ci;'
-    pip3 install -Ur src/requirements/mysql.txt
-fi
-
-if [ "$PRETIX_CONFIG_FILE" == "tests/travis_postgres.cfg" ]; then
-    psql -c 'create database travis_ci_test;' -U postgres
-    pip3 install -Ur src/requirements/postgres.txt
-fi
-
 if [ "$1" == "style" ]; then
 	XDG_CACHE_HOME=/cache pip3 install -Ur src/requirements.txt -r src/requirements/dev.txt -r src/requirements/py34.txt
 	cd src
@@ -30,27 +20,12 @@ if [ "$1" == "tests" ]; then
 	cd src
 	python manage.py check
 	make all compress
-	py.test --rerun 5 tests
+	coverage run -m py.test --rerun 5 tests && coverage report
 fi
 if [ "$1" == "tests-cov" ]; then
 	pip3 install -r src/requirements.txt -Ur src/requirements/dev.txt -r src/requirements/py34.txt
 	cd src
 	python manage.py check
 	make all compress
-	coverage run -m py.test --rerun 5 tests && codecov
-fi
-if [ "$1" == "plugins" ]; then
-	pip3 install -r src/requirements.txt -Ur src/requirements/dev.txt -r src/requirements/py34.txt
-	cd src
-	python setup.py develop
-	make all compress
-
-	pushd ~
-    git clone --depth 1 https://github.com/pretix/pretix-cartshare.git
-    cd pretix-cartshare
-    python setup.py develop
-    make
-	py.test --rerun 5 tests
-    popd
-
+	coverage run -m py.test --rerun 5 tests && coveralls
 fi

.travis.yml

@@ -1,40 +1,15 @@
 language: python
 sudo: false
+python:
+    - "3.4"
 install:
-  - pip install -U pip wheel setuptools==28.6.1
+    - pip install -U pip wheel setuptools==28.6.1
 script:
-  - bash .travis.sh $JOB
+    - bash .travis.sh $JOB
 cache:
-  directories:
-    - $HOME/.cache/pip
-services:
-  - mysql
-  - postgresql
-matrix:
-  include:
-    - python: 3.4
-      env: JOB=tests PRETIX_CONFIG_FILE=tests/sqlite.cfg
-    - python: 3.5
-      env: JOB=tests PRETIX_CONFIG_FILE=tests/sqlite.cfg
-    - python: 3.6
-      env: JOB=tests PRETIX_CONFIG_FILE=tests/sqlite.cfg
-    - python: 3.4
-      env: JOB=tests PRETIX_CONFIG_FILE=tests/travis_mysql.cfg
-    - python: 3.5
-      env: JOB=tests PRETIX_CONFIG_FILE=tests/travis_mysql.cfg
-    - python: 3.6
-      env: JOB=tests PRETIX_CONFIG_FILE=tests/travis_mysql.cfg
-    - python: 3.4
-      env: JOB=tests PRETIX_CONFIG_FILE=tests/travis_postgres.cfg
-    - python: 3.5
-      env: JOB=tests PRETIX_CONFIG_FILE=tests/travis_postgres.cfg
-    - python: 3.6
-      env: JOB=tests PRETIX_CONFIG_FILE=tests/travis_postgres.cfg
-    - python: 3.4
-      env: JOB=style
-    - python: 3.4
-      env: JOB=plugins
-    - python: 3.4
-      env: JOB=tests-cov
-addons:
-  postgresql: "9.4"
+    directories:
+        - $HOME/.cache/pip
+env:
+    - JOB=style
+    - JOB=doctests
+    - JOB=tests-cov

AUTHORS

@@ -3,31 +3,18 @@ people who have submitted patches, reported bugs, added translations, helped
 answer newbie questions, improved the documentation, and generally made pretix
 an awesome project. Thank you all!
 
-	Adam K. Sumner <asumner101@gmail.com>
-	Ahrdie <robert.deppe@me.com>
 	Alexander Brock <Brock.Alexander@web.de>
-	Brandon Pineda
-	Bolutife Lawrence
+	Ben Oswald
 	Christian Franke <nobody@nowhere.ws>
 	Christopher Dambamuromo <me@chridam.com>
-	chotee <chotee@openended.eu>
-	Cpt. Foo
-	Daniel Rosenblüh
 	Enrique Saez
 	Flavia Bastos
 	informancer <informancer@web.de>
-	Jakob Schnell <github@ezelo.de>
-	Jan Felix Wiebe <git@jfwie.be>
-	Jan Weiß
 	Jason Estibeiro <jasonestibeiro@live.com>
-	jlwt90
+	Jan Weiß
 	Jonas Große Sundrup <cherti@letopolis.de>
 	Kevin Nelson
-	Leah Oswald
-	Lukas Martini
 	Nathan Mattes
-	Nicole Klünder
-	Marc-Pascal Clement
 	Martin Gross <martin@pc-coholic.de>
 	Raphael Michel <mail@raphaelmichel.de>
 	Team MRMCD

README.rst

@@ -10,12 +10,11 @@ pretix
 .. image:: https://travis-ci.org/pretix/pretix.svg?branch=master
    :target: https://travis-ci.org/pretix/pretix
 
-.. image:: https://codecov.io/gh/pretix/pretix/branch/master/graph/badge.svg
-   :target: https://codecov.io/gh/pretix/pretix
+.. image:: https://coveralls.io/repos/github/pretix/pretix/badge.svg?branch=master
+   :target: https://coveralls.io/r/pretix/pretix
 
 
-
-Reinventing ticket presales, one ticket at a time.
+Reinventing ticket presales, one bit at a time.
 
 Project status & release cycle
 ------------------------------

deployment/docker/nginx.conf

@@ -22,11 +22,9 @@ http {
 
 	include /etc/nginx/mime.types;
 	default_type application/octet-stream;
-	add_header X-Content-Type-Options nosniff;
 
 	access_log /var/log/nginx/access.log private;
 	error_log /var/log/nginx/error.log;
-	add_header Referrer-Policy same-origin;
 
 	gzip on;
 	gzip_disable "msie6";

doc/admin/config.rst

@@ -102,10 +102,6 @@ Example::
 ``user``, ``password``, ``host``, ``port``
     Connection details for the database connection. Empty by default.
 
-``galera``
-    Indicates if the database backend is a MySQL/MariaDB Galera cluster and
-    turns on some optimizations/special case handlers. Default: ``False``
-
 URLs
 ----
 
@@ -155,8 +151,6 @@ Example::
 ``admins``
     Comma-separated list of email addresses that should receive a report about every error code 500 thrown by pretix.
 
-.. _`django-settings`:
-
 Django settings
 ---------------
 
@@ -181,11 +175,6 @@ Example::
 
     .. WARNING:: Never set this to ``True`` in production!
 
-``profile``
-    Enable code profiling for a random subset of requests. Disabled by default, see
-    :ref:`perf-monitoring` for details.
-
-.. _`metrics-settings`:
 
 Metrics
 -------

doc/admin/index.rst

@@ -10,4 +10,3 @@ Contents:
 
    installation/index
    config
-   maintainance

doc/admin/installation/docker_smallscale.rst

@@ -141,9 +141,9 @@ See :ref:`email configuration <mail-settings>` to learn more about configuring m
 Docker image and service
 ------------------------
 
-First of all, download the latest stable pretix image by running::
+First of all, download the latest pretix image by running::
 
-    $ docker pull pretix/standalone:stable
+    $ docker pull pretix/standalone:latest
 
 We recommend starting the docker container using systemd to make sure it runs correctly after a reboot. Create a file
 named ``/etc/systemd/system/pretix.service`` with the following content::
@@ -222,8 +222,6 @@ Yay, you are done! You should now be able to reach pretix at https://pretix.your
 *admin@localhost* with a password of *admin*. Don't forget to change that password! Create an organizer first, then
 create an event and start selling tickets!
 
-You should probably read :ref:`maintainance` next.
-
 Updates
 -------
 
@@ -231,13 +229,11 @@ Updates
 
 Updates are fairly simple, but require at least a short downtime::
 
-    # docker pull pretix/standalone:stable
+    # docker pull pretix/standalone
     # systemctl restart pretix.service
     # docker exec -it pretix.service pretix upgrade
 
 Restarting the service can take a few seconds, especially if the update requires changes to the database.
-Replace ``stable`` above with a specific version number like ``1.0`` or with ``latest`` for the development
-version, if you want to.
 
 Install a plugin
 ----------------
@@ -246,11 +242,11 @@ To install a plugin, you need to build your own docker image. To do so, create a
 named ``Dockerfile`` in it. The Dockerfile could look like this (replace ``pretix-passbook`` with the plugins of your
 choice)::
 
-    FROM pretix/standalone:stable
+    FROM pretix/standalone
     USER root
     RUN pip3 install pretix-passbook
     USER pretixuser
-    RUN cd /pretix/src && make production
+    RUN make production
 
 Then, go to that directory and build the image::
 

doc/admin/installation/general.rst

@@ -5,7 +5,7 @@ General remarks
 
 Requirements
 ------------
-To use pretix, you will need the following things:
+To use pretix, you wull need the following things:
 
 * **pretix** and the python packages it depends on
 

doc/admin/installation/manual_smallscale.rst

@@ -190,7 +190,7 @@ Cronjob
 You need to set up a cronjob that runs the management command ``runperiodic``. The exact interval is not important
 but should be something between every minute and every hour. You could for example configure cron like this::
 
-    15,45 * * * * export PATH=/var/pretix/venv/bin:$PATH && cd /var/pretix && python -m pretix runperiodic
+    15,45 * * * * export PATH=/var/pretix/venv/bin:$PATH && cd /var/pretix/source/src && python -m pretix runperiodic
 
 The cronjob should run as the ``pretix`` user (``crontab -e -u pretix``).
 
@@ -213,9 +213,6 @@ The following snippet is an example on how to configure a nginx proxy for pretix
         ssl_certificate /path/to/cert.chain.pem;
         ssl_certificate_key /path/to/key.pem;
 
-        add_header Referrer-Options same-origin;
-        add_header X-Content-Type-Options nosniff;
-
         location / {
             proxy_pass http://localhost:8345/;
             proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
@@ -239,15 +236,13 @@ The following snippet is an example on how to configure a nginx proxy for pretix
         }
 
         location /static/ {
-            alias /var/pretix/venv/lib/python3.5/site-packages/pretix/static.dist/;
+            alias /var/pretix/source/src/pretix/static.dist/;
             access_log off;
             expires 365d;
             add_header Cache-Control "public";
         }
     }
 
-.. note:: Remember to replace the ``python3.5`` in the ``/static/`` path in the config 
-          above with your python version.
 
 We recommend reading about setting `strong encryption settings`_ for your web server.
 
@@ -258,8 +253,6 @@ Yay, you are done! You should now be able to reach pretix at https://pretix.your
 *admin@localhost* with a password of *admin*. Don't forget to change that password! Create an organizer first, then
 create an event and start selling tickets!
 
-You should probably read :ref:`maintainance` next.
-
 Updates
 -------
 

doc/admin/maintainance.rst

@@ -1,99 +0,0 @@
-.. highlight:: ini
-
-.. _`maintainance`:
-
-Backups and Monitoring
-======================
-
-If you host your own pretix instance, you also need to care about the availability
-of your service and the safety of your data yourself. This page gives you some
-information that you might need to do so properly.
-
-Backups
--------
-
-There are essentially two things which you should create backups of:
-
-Database
-    Your SQL database (MySQL or PostgreSQL). This is critical and you should **absolutely
-    always create automatic backups of your database**. There are tons of tutorials on the
-    internet on how to do this, and the exact process depends on the choice of your database.
-    For MySQL, see ``mysqldump`` and for PostgreSQL, see the ``pg_dump`` tool. You probably
-    want to create a cronjob that does the backups for you on a regular schedule.
-
-Data directory
-    The data directory of your pretix configuration might contain some things that you should
-    back up. If you did not specify a secret in your config file, back up the ``.secret`` text
-    file in the data directory. If you lose your secret, all currently active user sessions,
-    password reset links and similar things will be rendered invalid. Also, you probably want
-    to backup the ``media`` subdirectory of the data directory which contains all user-uploaded
-    and generated files. This includes files you could in theory regenerate (ticket downloads)
-    but also files that you might be legally required to keep (invoice PDFs) or files that you
-    would need to re-upload (event logos, product pictures, etc.). It is up to you if you
-    create regular backups of this data, but we strongly advise you to do so. You can create
-    backups e.g. using ``rsync``. There is a lot of information on the internet on how to create
-    backups of folders on a Linux machine.
-
-There is no need to create backups of the redis database, if you use it. We only use it for
-non-critical, temporary or cached data.
-
-Uptime monitoring
------------------
-
-To monitor whether your pretix instance is running, you can issue a GET request to
-``https://pretix.mydomain.com/healthcheck/``. This endpoint tests if the connection to the
-database, to the configured cache and to redis (if used) is working correctly. If everything
-appears to work fine, an empty response with status code ``200`` is returned.
-If there is a problem, a status code in the ``5xx`` range will be returned.
-
-.. _`perf-monitoring`:
-
-Performance monitoring
-----------------------
-
-If you want to generate detailed performance statistics of your pretix installation, there is an
-endpoint at ``https://pretix.mydomain.com/metrics`` (no slash at the end) which returns a
-number of values in the text format understood by monitoring tools like Prometheus_. This data
-is only collected and exposed if you enable it in the :ref:`metrics-settings` section of your
-pretix configuration. You can also configure basic auth credentials there to protect your
-statistics against unauthorized access. The data is temporarily collected in redis, so the
-performance impact of this feature depends on the connection to your redis database.
-
-Currently, mostly response times of HTTP requests and background tasks are exposed.
-
-If you want to go even further, you can set the ``profile`` option in the :ref:`django-settings`
-section to a value between 0 and 1. If you set it for example to 0.1, then 10% of your requests
-(randomly selected) will be run with cProfile_ activated. The profiling results will be saved
-to your data directory. As this might impact performance significantly and writes a lot of data
-to disk, we recommend to only enable it for a small number of requests -- and only if you are
-really interested in the results.
-
-Available metrics
-^^^^^^^^^^^^^^^^^
-
-The metrics available in pretix follow the standard `metric types`_ from the Prometheus world.
-Currently, the following metrics are exported:
-
-pretix_view_requests_total
-    Counter. Counts requests to Django views, labeled with the resolved ``url_name``, the used
-    HTTP ``method`` and the ``status_code`` returned.
-
-pretix_view_durations_seconds
-    Histogram. Measures duration of requests to Django views, labeled with the resolved
-    ``url_name``, the used HTTP ``method`` and the ``status_code`` returned.
-
-pretix_task_runs_total
-    Counter. Counts executions of background tasks, labeled with the ``task_name`` and the
-    ``status``. The latter can be ``success``, ``error`` or ``expected-error``.
-
-pretix_task_duration_seconds
-    Histogram. Measures duration of successful background task executions, labeled with the
-    ``task_name``.
-
-pretix_model_instances
-    Gauge. Measures number of instances of a certain model within the database, labeled with
-    the ``model`` name.
-
-.. _metric types: https://prometheus.io/docs/concepts/metric_types/
-.. _Prometheus: https://prometheus.io/
-.. _cProfile: https://docs.python.org/3/library/profile.html

doc/conf.py

@@ -55,17 +55,16 @@ master_doc = 'index'
 
 # General information about the project.
 project = 'pretix'
-copyright = '2014-2017, Raphael Michel'
+copyright = '2014-2016, Raphael Michel'
 
 # The version info for the project you're documenting, acts as replacement for
 # |version| and |release|, also used in various other places throughout the
 # built documents.
 #
 # The short X.Y version.
-from pretix import __version__
-version = '.'.join(__version__.split('.')[:2])
+version = '0.0.0'
 # The full version, including alpha/beta/rc tags.
-release = __version__
+release = '0.0.0'
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.

doc/development/api/general.rst

@@ -11,7 +11,7 @@ Core
 ----
 
 .. automodule:: pretix.base.signals
-   :members: periodic_task, event_live_issues, event_copy_data
+   :members: periodic_task, event_live_issues
 
 Order events
 """"""""""""
@@ -25,7 +25,7 @@ Frontend
 --------
 
 .. automodule:: pretix.presale.signals
-   :members: html_head, html_footer, footer_links, front_page_top, front_page_bottom, contact_form_fields, checkout_confirm_messages
+   :members: html_head, footer_links, front_page_top, front_page_bottom
 
 
 .. automodule:: pretix.presale.signals
@@ -47,7 +47,7 @@ Backend
 -------
 
 .. automodule:: pretix.control.signals
-   :members: nav_event, html_head, quota_detail_html, nav_topbar, nav_global, nav_organizer
+   :members: nav_event, html_head, quota_detail_html, nav_topbar, organizer_edit_tabs
 
 
 .. automodule:: pretix.base.signals

doc/development/contribution/general.rst

@@ -18,9 +18,8 @@ If you improved pretix in any way, we'd be very happy if you contribute it
 back to the main code base! The easiest way to do so is to `create a pull request`_
 on our `GitHub repository`_.
 
-We recommend that you create a feature branch for every issue you work on so the changes can
-be reviewed individually.
-Please use the test suite to check whether your changes break any existing features and run
+Before you do so, please `squash all your changes`_ into one single commit. Please
+use the test suite to check whether your changes break any existing features and run
 the code style checks to confirm you are consistent with pretix's coding style. You'll
 find instructions on this in the :ref:`checksandtests` section of the development setup guide.
 
@@ -35,3 +34,4 @@ Again: If you get stuck, do not hesitate to contact any of us, or Raphael person
 
 .. _create a pull request: https://help.github.com/articles/creating-a-pull-request/
 .. _GitHub repository: https://github.com/pretix/pretix
+.. _squash all your changes: https://davidwalsh.name/squash-commits-git

doc/development/implementation/i18n.rst

@@ -6,18 +6,116 @@ One of pretix's major selling points is its multi-language capability. We make h
 way to translate *user-generated content*. In our case, we need to translate strings like product names
 or event descriptions, so we need event organizers to be able to fill in all fields in multiple languages.
 
-For this purpose, we use ``django-i18nfield`` which started out as part of pretix and then got refactored into
-its own library. It has comprehensive documentation on how to work with its `strings`_, `database fields`_ and
-`forms`_.
+.. note:: Implementing object-level translation in a relational database is a task that requires some difficult
+          trade-off. We decided for a design that is not elegant on the database level (as it violates the `1NF`_) and
+          makes searching in the respective database fields very hard, but allows for a simple design on the ORM level
+          and adds only minimal performance overhead.
 
+All classes and functions introduced in this document are located in ``pretix.base.i18n`` if not stated otherwise.
+
+Database storage
+----------------
+
+pretix provides two custom model field types that allow you to work with localized strings: ``I18nCharField`` and
+``I18nTextField``. Both of them are stored in the database as a ``TextField`` internally, they only differ in the
+default form widget that is used by ``ModelForm``.
+
+As pretix does not use these fields in places that need to be searched, the negative performance impact when searching
+and indexing these fields in negligible, as mentioned above. Lookups are currently not even implemented on these
+fields. In the database, the strings will be stored as a JSON-encoded mapping of language codes to strings.
+
+Whenever you interact with those fields, you will either provide or receive an instance of the following class:
+
+.. autoclass:: pretix.base.i18n.LazyI18nString
+   :members: __init__, localize, __str__
+
+Usage
+-----
+
+The following examples are given to illustrate how you can work with ``LazyI18nString``.
+
+.. testsetup:: *
+
+   from pretix.base.i18n import LazyI18nString, language
+
+To create a LazyI18nString, we can cast a simple string:
+
+.. doctest::
+
+   >>> naive = LazyI18nString('Naive untranslated string')
+   >>> naive
+   <LazyI18nString: 'Naive untranslated string'>
+
+Or we can provide a dictionary with multiple translations:
+
+.. doctest::
+
+   >>> translated = LazyI18nString({'en': 'English String', 'de': 'Deutscher String'})
+
+We can use ``localize`` to get the string in a specific language:
+
+.. doctest::
+
+   >>> translated.localize('de')
+   'Deutscher String'
+
+   >>> translated.localize('en')
+   'English String'
+
+If we try a locale that does not exist for the string, we might get a it either in a similar locale or in the system's default language:
+
+.. doctest::
+
+   >>> translated.localize('de-AT')
+   'Deutscher String'
+
+   >>> translated.localize('zh')
+   'English String'
+
+   >>> naive.localize('de')
+   'Naive untranslated string'
+
+If we cast a ``LazyI18nString`` to ``str``, ``localize`` will be called with the currently active language:
+
+.. doctest::
+
+   >>> from django.utils import translation
+   >>> str(translated)
+   'English String'
+   >>> translation.activate('de')
+   >>> str(translated)
+   'Deutscher String'
+
+You can also use our handy context manager to set the locale temporarily:
+
+.. doctest::
+
+   >>> translation.activate('en')
+   >>> with language('de'):
+   ...     str(translated)
+   'Deutscher String'
+   >>> str(translated)
+   'English String'
 
 Forms
 -----
 
-For backwards-compatibility with older parts of pretix' code base and older plugins, ``pretix.base.forms`` still
-contains a number of forms that are equivalent in name and usage to their counterparts in ``i18nfield.forms`` with
-the difference that they take an ``event`` keyword argument and then set the ``locales`` argument based on
-``event.settings.get('locales')``.
+We provide i18n-aware versions of the respective form fields and widgets: ``I18nFormField`` with the ``I18nTextInput``
+and ``I18nTextarea`` widgets. They transparently allow you to use ``LazyI18nString`` values in forms and render text
+inputs for multiple languages.
+
+.. autoclass:: pretix.base.i18n.I18nFormField
+
+To easily limit the displayed languages to the languages relevant to an event, there is a custom ``ModelForm`` subclass
+that deals with this for you:
+
+.. autoclass:: pretix.base.forms.I18nModelForm
+
+There are equivalents for ``BaseModelFormSet`` and ``BaseInlineFormSet``:
+
+.. autoclass:: pretix.base.forms.I18nFormSet
+
+.. autoclass:: pretix.base.forms.I18nInlineFormSet
 
 Useful utilities
 ----------------
@@ -37,6 +135,4 @@ action that causes the mail to be sent.
 
 .. _translation features: https://docs.djangoproject.com/en/1.9/topics/i18n/translation/
 .. _GNU gettext: https://www.gnu.org/software/gettext/
-.. _strings: https://django-i18nfield.readthedocs.io/en/latest/strings.html
-.. _database fields: https://django-i18nfield.readthedocs.io/en/latest/quickstart.html
-.. _forms: https://django-i18nfield.readthedocs.io/en/latest/forms.html
+.. _1NF: https://en.wikipedia.org/wiki/First_normal_form

doc/development/implementation/models.rst

@@ -20,10 +20,13 @@ Organizers and events
 .. autoclass:: pretix.base.models.Organizer
    :members:
 
+.. autoclass:: pretix.base.models.OrganizerPermission
+   :members:
+
 .. autoclass:: pretix.base.models.Event
    :members:
 
-.. autoclass:: pretix.base.models.Team
+.. autoclass:: pretix.base.models.EventPermission
    :members:
 
 .. autoclass:: pretix.base.models.RequiredAction
@@ -64,7 +67,7 @@ Carts and Orders
    :members:
 
 .. autoclass:: pretix.base.models.QuestionAnswer
-   :members:
+:members:
 
 .. autoclass:: pretix.base.models.Checkin
    :members:
@@ -89,3 +92,5 @@ Vouchers
 
 .. autoclass:: pretix.base.models.Voucher
    :members:
+
+.. _cleanerversion: https://github.com/swisscom/cleanerversion

doc/development/implementation/settings.rst

@@ -2,10 +2,7 @@ Settings storage
 ================
 
 pretix is highly configurable and therefore needs to store a lot of per-event and per-organizer settings.
-For this purpose, we use `django-hierarkey`_ which started out as part of pretix and then got refactored into
-its own library. It has a comprehensive `documentation`_ which you should read if you work with settings in pretix.
-
-The settings are stored in the database and accessed through a ``HierarkeyProxy`` instance. You can obtain
+Those settings are stored in the database and accessed through a ``SettingsProxy`` instance. You can obtain
 such an instance from any event or organizer model instance by just accessing ``event.settings`` or
 ``organizer.settings``, respectively.
 
@@ -20,10 +17,12 @@ includes serializers for serializing the following types:
 
 In code, we recommend to always use the ``.get()`` method on the settings object to access a value, but for
 convenience in templates you can also access settings values at ``settings[name]`` and ``settings.name``.
-See the hierarkey `documentation`_ for more information.
+
+.. autoclass:: pretix.base.settings.SettingsProxy
+   :members: get, set, delete, freeze
 
 To avoid naming conflicts, plugins are requested to prefix all settings they use with the name of the plugin
-or something unique, e.g. ``payment_paypal_api_key``. To reduce redundant typing of this prefix, we provide
+or something unique, e.g. ``payment.paypal.api_key``. To reduce redundant typing of this prefix, we provide
 another helper class:
 
 .. autoclass:: pretix.base.settings.SettingsSandbox
@@ -34,10 +33,10 @@ you will just be passed a sandbox object with a prefix generated from your provi
 Forms
 -----
 
-Hierarkey also provides a base class for forms that allow the modification of settings. pretix contains a
-subclass that also adds suport for internationalized fields:
+We also provide a base class for forms that allow the modification of settings:
 
 .. autoclass:: pretix.base.forms.SettingsForm
+   :members: save
 
 You can simply use it like this::
 
@@ -52,17 +51,3 @@ You can simply use it like this::
            help_text=_("The number of days after placing an order the user has to pay to "
                        "preserve his reservation."),
        )
-
-Defaults in plugins
--------------------
-
-Plugins can add custom hardcoded defaults in the following way::
-
-    from pretix.base.settings import settings_hierarkey
-
-    settings_hierarkey.add_default('key', 'value', type)
-
-Make sure that you include this code in a module that is imported at app loading time.
-
-.. _django-hierarkey: https://github.com/raphaelm/django-hierarkey
-.. _documentation: https://django-hierarkey.readthedocs.io/en/latest/

doc/development/setup.rst

@@ -15,7 +15,6 @@ External Dependencies
 * Python 3.4 or newer
 * ``pip`` for Python 3 (Debian package: ``python3-pip``)
 * ``pyvenv`` for Python 3 (Debian package: ``python3-venv``)
-* ``python-dev`` for Python 3 (Debian package: ``python3-dev``)
 * ``libffi`` (Debian package: ``libffi-dev``)
 * ``libssl`` (Debian package: ``libssl-dev``)
 * ``libxml2`` (Debian package ``libxml2-dev``)
@@ -40,7 +39,7 @@ automatically). If you are working on Ubuntu or Debian, we strongly recommend up
 your pip and setuptools installation inside the virtual environment, otherwise some of
 the dependencies might fail::
 
-    pip3 install -U pip setuptools
+    pip3 install -U pip setuptools==28.6.1
 
 Working with the code
 ---------------------
@@ -81,11 +80,7 @@ and head to http://localhost:8000/
 
 As we did not implement an overall front page yet, you need to go directly to
 http://localhost:8000/control/ for the admin view or, if you imported the test
-data as suggested above, to the event page at http://localhost:8000/bigevents/2018/
-
-.. note:: If you want the development server to listen on a different interface or
-          port (for example because you develop on `pretixdroid`_), you can check
-          `Django's documentation`_ for more options.
+data as suggested above, to the event page at http://localhost:8000/bigevents/2017/
 
 .. _`checksandtests`:
 
@@ -152,7 +147,3 @@ To build the documentation, run the following command from the ``doc/`` director
     make html
 
 You will now find the generated documentation in the ``doc/_build/html/`` subdirectory.
-
-
-.. _Django's documentation: https://docs.djangoproject.com/en/1.11/ref/django-admin/#runserver
-.. _pretixdroid: https://github.com/pretix/pretixdroid

doc/development/structure.rst

@@ -26,11 +26,8 @@ pretix/
     multidomain/
         Additional code implementing our customized :ref:`URL handling <urlconf>`.
 
-    static/
-        Contains all static files (CSS, JavaScript, images)
-
-    static/
-        Contains some pretix plugins that ship with pretix itself
+static/
+    Contains all static files (CSS, JavaScript, images)
 
 tests/
     This is the root directory for all test codes. It includes subdirectories ``base``,
@@ -40,8 +37,7 @@ tests/
 
 Language files
 --------------
-
-The language files live in ``pretix/locale/*/LC_MESSAGES/``.
+The language files live in ``locale/*/LC_MESSAGES/``.
 
 Static files
 ------------
@@ -53,14 +49,27 @@ We use libsass as a preprocessor for CSS. Our own sass code is built in the same
 step as Bootstrap and FontAwesome, so their mixins etc. are fully available.
 
 pretix.control
-    pretixcontrol has two main SCSS files, ``pretix/static/pretixcontrol/scss/main.scss`` and
-    ``pretix/static/pretixcontrol/scss/auth.scss``, importing everything else.
+    pretixcontrol has two main SCSS files, ``pretix/control/static/pretixcontrol/scss/main.scss`` and
+    ``pretix/control/static/pretixcontrol/scss/auth.scss``, importing everything else.
 
 pretix.presale
-    pretixpresale has one main SCSS files, ``pretix/pretixpresale/scss/main.scss``,
+    pretixpresale has one main SCSS files, ``pretix/control/static/pretix/presale/scss/main.scss``,
     importing everything else.
 
 3rd-party assets
 ^^^^^^^^^^^^^^^^
 
-Most client-side 3rd-party assets are vendored in various subdirectories of ``pretix/static``.
+Bootstrap
+    Bootstrap lives vendored at ``static/bootstrap/``
+
+Font Awesome
+    Font Awesome lives vendored at ``static/fontawesome/``
+
+jQuery
+    jQuery lives as a single JavaScript file in ``static/jquery/js/``
+
+jQuery plugin: Django formsets
+    Our own modified version of `django-formset-js`_ is available as an independent
+    django app and installed via ``pip``.
+
+.. _django-formset-js: https://github.com/pretix/django-formset-js

doc/index.rst

@@ -6,7 +6,6 @@ Contents:
 .. toctree::
    :maxdepth: 2
 
-   user/index
    admin/index
    development/index
    plugins/index

doc/plugins/list.rst

@@ -15,34 +15,20 @@ ways that pretix itself is:
 * PDF ticket output
 
 The following plugins are not shipped with pretix but are maintained by the
-same team. We update them regularly to make them compatible with the latest
-pretix releases:
+same team:
 
 * `SEPA direct debit`_
 * `Pages`_
 * `Passbook/Wallet ticket output`_
 * `Cartshare`_
-* `Fontpack Free fonts`_
-
-The following closed-source plugins are available to customers of the hosted pretix.eu platform.
-Please get in touch with the pretix team if you want to have them for your self-hosted
-pretix installation:
-
-* Campaign tracking
-* Integration with Google Analytics and Facebook Pixel
-* Integration with Slack
-* Integration with MailChimp
 
 The following plugins are from independent third-party authors, so we can make
-no statements about their stability or compatibility:
+no statements about their stability:
 
 * `esPass ticket output`_
-* `IcePay integration`_
 
 .. _SEPA direct debit: https://github.com/pretix/pretix-sepadebit
 .. _Passbook/Wallet ticket output: https://github.com/pretix/pretix-passbook
 .. _Cartshare: https://github.com/pretix/pretix-cartshare
 .. _Pages: https://github.com/pretix/pretix-pages
 .. _esPass ticket output: https://github.com/esPass/pretix-espass
-.. _IcePay integration: https://github.com/chotee/pretix-icepay
-.. _Fontpack Free fonts: https://github.com/pretix/pretix-fontpack-free

doc/plugins/pretixdroid.rst

@@ -4,10 +4,6 @@ pretixdroid HTTP API
 The pretixdroid plugin provides a HTTP API that the `pretixdroid Android app`_
 uses to communicate with the pretix server.
 
-.. warning:: This API is intended **only** to serve the pretixdroid Android app. There are no backwards compatibility
-             guarantees on this API. We will not add features that are not required for the Android App. There will be
-             a proper general-use API for pretix at a later point in time.
-
 .. http:post:: /pretixdroid/api/(organizer)/(event)/redeem/
 
    Redeems a ticket, i.e. checks the user in.
@@ -23,16 +19,6 @@ uses to communicate with the pretix server.
 
       secret=az9u4mymhqktrbupmwkvv6xmgds5dk3
 
-   You can optionally include the additional parameter ``datetime`` in the body containing an ISO8601-encoded
-   datetime of the entry attempt. If you don't, the current date and time will be used.
-
-   You can optionally include the additional parameter ``force`` to indicate that the request should be logged
-   regardless of previous check-ins for the same ticket. This might be useful if you made the entry decision offline.
-
-   You can optionally include the additional parameter ``nonce`` with a globally unique random value to identify this
-   check-in. This is meant to be used to prevent duplicate check-ins when you are just retrying after a connection
-   failure.
-
    **Example successful response**:
 
    .. sourcecode:: http
@@ -65,9 +51,9 @@ uses to communicate with the pretix server.
    * ``unknown_ticket`` - Secret does not match a ticket in the database
 
    :query key: Secret API key
-   :statuscode 200: Valid request
-   :statuscode 404: Unknown organizer or event
-   :statuscode 403: Invalid authorization key
+         :statuscode 200: Valid request
+         :statuscode 404: Unknown organizer or event
+         :statuscode 403: Invalid authorization key
 
 .. http:get:: /pretixdroid/api/(organizer)/(event)/search/
 
@@ -111,46 +97,6 @@ uses to communicate with the pretix server.
          :statuscode 404: Unknown organizer or event
          :statuscode 403: Invalid authorization key
 
-.. http:get:: /pretixdroid/api/(organizer)/(event)/download/
-
-   Download data for all tickets.
-
-   **Example request**:
-
-   .. sourcecode:: http
-
-      GET /pretixdroid/api/demoorga/democon/download/?key=ABCDEF HTTP/1.1
-      Host: demo.pretix.eu
-      Accept: application/json, text/javascript
-
-   **Example response**:
-
-   .. sourcecode:: http
-
-      HTTP/1.1 200 OK
-      Content-Type: text/json
-
-      {
-        "results": [
-          {
-            "secret": "az9u4mymhqktrbupmwkvv6xmgds5dk3",
-            "order": "ABCE6",
-            "item": "Standard ticket",
-            "variation": null,
-            "attendee_name": "Peter Higgs",
-            "redeemed": false,
-            "paid": true
-          },
-          ...
-        ],
-        "version": 2
-      }
-
-   :query key: Secret API key
-   :statuscode 200: Valid request
-   :statuscode 404: Unknown organizer or event
-   :statuscode 403: Invalid authorization key
-
 .. http:get:: /pretixdroid/api/(organizer)/(event)/status/
 
    Returns status information, such as the total number of tickets and the

doc/user/index.rst

@@ -1,9 +0,0 @@
-User Guide
-==========
-
-Contents:
-
-.. toctree::
-   :maxdepth: 2
-
-   payments/index

doc/user/payments/banktransfer.rst

@@ -1,31 +0,0 @@
-.. _`banktransfer`:
-
-Bank transfer
-=============
-
-To accept payments with bank transfer, you only need to fill one important field in pretix' settings: In "Bank
-account details" you should specify everything one needs to know to transfer money to you, e.g. your IBAN and BIC,
-the name of your bank and for international transfers, preferably also your address and the bank's address.
-
-pretix will automatically tell the user to include the order code in the payment reference so incoming transfers can
-automatically be matched to payments.
-
-Importing payment data
-----------------------
-
-The easiest way to import payment data is to download a CSV file from your online banking. Most banks provide a CSV
-export of some sort. You can go to "Import bank data" in pretix to upload a new file:
-
-.. image:: img/bank1.png
-
-If you upload a file for the first time, pretix will not know what information is contained in which column as every
-bank builds completely different CSV files. Therefore, pretix will ask you for that information. It will show you the
-data of the file you imported and ask you to define the column's meanings. You can select one column that contains
-the payment date and one that contains the paid amount. You can select multiple columns that contain information
-about the payer or the payment reference. All other columns will be ignored.
-
-Once you continue, pretix will try to match the payments to the respective orders automatically. It will tell you how
-many orders could be processed correctly and how many could not. You can then go back to the upload page to see all
-transfers from your bank statement that are not yet matched to an order. Using the input field and the buttons on the
-left of each transaction, you can manually enter an order code to match it to or just discard it from the list, e.g.
-if the transaction is not related to the event at all.

doc/user/payments/fees.rst

@@ -1,52 +0,0 @@
-Payment method fees
-===================
-
-Most external payment providers like PayPal or Stripe charge substantial fees for your service. In general, you have
-two options to deal with this:
-
-1. Pay the fees yourself
-
-2. Add the fees to your customer's total
-
-The choice totally depends on you and what your customers expect from you. Option two might be appropriate if you
-offer different payment methods and want to encourage your customers to use the ones that come you cheaper, but you
-might also decide to go for option one to make it easier for customers who don't have the option.
-
-If you go for the second option, you can configure pretix to charge the payment method fees to your user. You can
-define both an absolute fee as well as a percental fee based on the order total. If you do so, there are two
-different ways in which pretix can calculate the fee. Normally, it is fine to just go with the default setting, but
-in case you are interested, here are all the details:
-
-Payment fee calculation
------------------------
-
-If you configure a fee for a payment method, there are two possible ways for us to calculate this. Let's
-assume that your payment provider, e.g. PayPal, charges you 5 % fees and you want to charge your users the
-same 5 %, such that for a ticket with a list price of 100 € you will get your full 100 €.
-
-**Method A: Calculate the fee from the subtotal and add it to the bill.**
-
-    For a ticket price of 100 €, this will lead to the following calculation:
-
-    ============================================== ============
-    Ticket price                                       100.00 €
-    pretix calculates the fee as 5 % of 100 €           +5.00 €
-    Subtotal that will be paid by the customer         105.00 €
-    PayPal calculates its fee as 5 % of 105 €           -5.25 €
-    End total that is on your bank account          **99.75 €**
-    ============================================== ============
-
-**Method B (default): Calculate the fee from the total value including the fee.**
-
-    For a ticket price of 100 €, this will lead to the following calculation:
-
-    ===================================================== =============
-    Ticket price                                               100.00 €
-    pretix calculates the fee as 100/(100 - 5) % of 100 €       +5.26 €
-    Subtotal that will be paid by the customer                 105.26 €
-    PayPal calculates its fee as 5 % of 105 €                   -5.26 €
-    End total that is on your bank account                 **100.00 €**
-    ===================================================== =============
-
-    Due to the various rounding steps performed by pretix and by the payment provider, the end total on
-    your bank account might stil vary by one cent.

doc/user/payments/index.rst

@@ -1,14 +0,0 @@
-Accepting payments
-==================
-
-Contents:
-
-.. toctree::
-   :maxdepth: 2
-
-   overview
-   fees
-   paypal
-   stripe
-   banktransfer
-

doc/user/payments/overview.rst

@@ -1,34 +0,0 @@
-Payment method overview
-=======================
-
-pretix allows you to accept payments using a variety of payment methods to fit the needs of very different events.
-This page gives you a short overview over them and links to more detailled descriptions in some cases.
-
-Payment methods are built as pretix plugins. For this reason, you might first need to enable a certain plugin at
-"Settings" → "Plugins" in your event settings. Then, you can configure them in detail at "Settings" -> "Payment".
-
-If you host pretix on your own server, you might need to install a plugin first for some of the payment methods listed
-on this page as well as for additional ones.
-
-:ref:`stripe`
-    Stripe is a US-based company that offers you an easy way to accept credit card payments from all over the world.
-    To accept payments with Stripe, you need to have a Stripe merchant account that is easy to create. Click on the link
-    above to get more details about the Stripe integration into pretix.
-
-:ref:`paypal`
-    If you want to accept online payments via PayPal, you can do so using pretix. You will need a PayPal merchant
-    account and it is a little bit complicated to obtain the required technical details, but we've got you covered.
-    Click on the link above to learn more.
-
-:ref:`banktransfer`
-    Classical IBAN wire transfers are a common payment method in central Europe that has the large benefit that it
-    often does not cause any additional fees. However, it requires you to invest some more effort as you need to
-    check your bank account for incoming payments regularly. We provide some tools to make this easier for you.
-
-SEPA debit
-    In some Europen countries, a very popular online payment method is SEPA direct debit. If you want to offer this
-    option in your pretix ticket shop, we provide a convenient plugin that allows users to enter their SEPA bank
-    account details and issue a SEPA mandate. You will then need to regularly download a SEPA XML file from pretix
-    and upload it to your bank's interface to actually perform the debits.
-
-

doc/user/payments/paypal.rst

@@ -1,50 +0,0 @@
-.. _`paypal`:
-
-PayPal
-======
-
-To integrate PayPal with pretix, you first need to have an active PayPal merchant account. If you do not already have a
-PayPal account, you can create one on `paypal.com`_.
-If you look into pretix' settings, you are required to fill in two keys:
-
-.. image:: img/paypal_pretix.png
-
-Unfortunately, it is not straightforward how to get those keys from PayPal's website. In order to do so, you
-need to go to `developer.paypal.com`_ to link the account to your pretix event.
-Click on "Log In" in the top-right corner and log in with your PayPal account.
-
-.. image:: img/paypal2.png
-
-Then, click on "Dashboard" in the top-right corner.
-
-.. image:: img/paypal3.png
-
-In the dashboard, scroll down until you see the headline "REST API Apps". Click "Create App".
-
-.. image:: img/paypal4.png
-
-Enter any name for the application that helps you to identify it later. Then confirm with "Create App".
-
-.. image:: img/paypal5.png
-
-On the next page, before you do anything else, switch the mode on the right to "Live" to get the correct keys.
-Then, copy the "Client ID" and the "Secret" and enter them into the appropriate fields in the payment settings in
-pretix.
-
-.. image:: img/paypal6.png
-
-Finally, we need to create a webhook. The webhook tells PayPal to notify pretix e.g. if a payment gets cancelled so
-pretix can cancel the ticket as well. If you have multiple events connected to your PayPal account, you need multiple
-webhooks. To create one, scroll a bit down and click "Add Webhook".
-
-.. image:: img/paypal7.png
-
-Then, enter the webhook URL that you find on the pretix settings page. It should look similar to the one in the
-screenshot but contain your event name. Tick the box "All events" and save.
-
-.. image:: img/paypal8.png
-
-That's it, you are ready to go!
-
-.. _paypal.com: https://www.paypal.com/webapps/mpp/account-selection
-.. _developer.paypal.com: https://developer.paypal.com/

doc/user/payments/stripe.rst

@@ -1,28 +0,0 @@
-.. _stripe:
-
-Stripe
-======
-
-To integrate Stripe with pretix, you first need to have an active Stripe merchant account. If you do not already have a
-Stripe account, you can create one on `stripe.com`_. Then, click on "API" in the left navigation of the Stripe
-Dashboard. As you can see in the following screenshot, you will be presented with two sets of API keys, one for test
-and one for live payments. In each set, there is a secret and a publishable keys.
-
-.. image:: img/stripe1.png
-
-Choose one of the two sets and copy the two keys to the appropriate fields in pretix' settings. To perform actual
-payments, you will need to use the live keys, but you can use the test keys to test the payment flow before you go live.
-In test mode, you cannot use your real credit card, but only `test cards`_ like ``4242424242424242`` that you can
-find in Stripe's documentation.
-
-If you want Stripe to notify pretix automatically once a payment gets cancelled, so pretix can cancel the ticket as
-well, you need to create a so-called webhook. To do so, click "Webhooks" on top of the page in the Stripe dashboard
-that you are currently on. Then, click "Add endpoint" and enter the URL that you find directly below the key
-configuration in pretix' settings.
-
-.. image:: img/stripe2.png
-
-Again, you can choose between live mode and test mode here.
-
-.. _stripe.com: https://dashboard.stripe.com/register
-.. _test cards: https://stripe.com/docs/testing#cards

src/MANIFEST.in

@@ -16,5 +16,3 @@ recursive-include pretix/plugins/statistics/templates *
 recursive-include pretix/plugins/statistics/static *
 recursive-include pretix/plugins/stripe/templates *
 recursive-include pretix/plugins/stripe/static *
-recursive-include pretix/plugins/ticketoutputpdf/templates *
-recursive-include pretix/plugins/ticketoutputpdf/static *

src/make_testdata.py

@@ -23,6 +23,9 @@ user.save()
 organizer = Organizer.objects.create(
     name='BigEvents LLC', slug='bigevents'
 )
+OrganizerPermission.objects.get_or_create(
+    organizer=organizer, user=user
+)
 year = now().year + 1
 event = Event.objects.create(
     organizer=organizer, name='Demo Conference {}'.format(year),
@@ -30,13 +33,9 @@ event = Event.objects.create(
     date_from=datetime(year, 9, 4, 17, 0, 0),
     date_to=datetime(year, 9, 6, 17, 0, 0),
 )
-t = Team.objects.get_or_create(
-    organizer=organizer, name='Admin Team',
-    all_events=True, can_create_events=True, can_change_teams=True,
-    can_change_organizer_settings=True, can_change_event_settings=True, can_change_items=True,
-    can_view_orders=True, can_change_orders=True, can_view_vouchers=True, can_change_vouchers=True
+EventPermission.objects.get_or_create(
+    event=event, user=user
 )
-t[0].members.add(user)
 cat_tickets = ItemCategory.objects.create(
     event=event, name='Tickets'
 )

src/pretix/__init__.py

@@ -1 +1 @@
-__version__ = "1.4.1"
+__version__ = "1.0.0"

src/pretix/base/__init__.py

@@ -9,7 +9,7 @@ class PretixBaseConfig(AppConfig):
         from . import exporter  # NOQA
         from . import payment  # NOQA
         from . import exporters  # NOQA
-        from .services import export, mail, tickets, cart, orders, cleanup, update_check  # NOQA
+        from .services import export, mail, tickets, cart, orders, cleanup  # NOQA
 
         try:
             from .celery_app import app as celery_app  # NOQA

src/pretix/base/exporters/invoices.py

@@ -3,7 +3,7 @@ import tempfile
 from zipfile import ZipFile
 
 from django.dispatch import receiver
-from django.utils.translation import ugettext_lazy as _
+from django.utils.translation import ugettext as _
 
 from ..exporter import BaseExporter
 from ..services.invoices import invoice_pdf_task

src/pretix/base/exporters/json.py

@@ -68,9 +68,7 @@ class JSONExporter(BaseExporter):
                                 'variation': position.variation_id,
                                 'price': position.price,
                                 'attendee_name': position.attendee_name,
-                                'attendee_email': position.attendee_email,
                                 'secret': position.secret,
-                                'addon_to': position.addon_to_id,
                                 'answers': [
                                     {
                                         'question': answer.question_id,

src/pretix/base/exporters/mail.py

@@ -2,9 +2,7 @@ from collections import OrderedDict
 
 from django import forms
 from django.dispatch import receiver
-from django.utils.translation import ugettext_lazy as _
-
-from pretix.base.models import OrderPosition
+from django.utils.translation import ugettext as _
 
 from ..exporter import BaseExporter
 from ..models import Order
@@ -18,11 +16,7 @@ class MailExporter(BaseExporter):
     def render(self, form_data: dict):
         qs = self.event.orders.filter(status__in=form_data['status'])
         addrs = qs.values('email')
-        pos = OrderPosition.objects.filter(
-            order__event=self.event, order__status__in=form_data['status']
-        ).values('attendee_email')
-        data = "\r\n".join(set(a['email'] for a in addrs)
-                           | set(a['attendee_email'] for a in pos if a['attendee_email']))
+        data = "\r\n".join(set(a['email'] for a in addrs))
         return 'pretixemails.txt', 'text/plain', data.encode("utf-8")
 
     @property

src/pretix/base/exporters/orderlist.py

@@ -1,14 +1,14 @@
+import csv
 import io
 from collections import OrderedDict
 from decimal import Decimal
 
 import pytz
-from defusedcsv import csv
 from django import forms
 from django.db.models import Sum
 from django.dispatch import receiver
 from django.utils.formats import localize
-from django.utils.translation import ugettext as _, ugettext_lazy
+from django.utils.translation import ugettext as _
 
 from pretix.base.models import InvoiceAddress, Order, OrderPosition
 
@@ -18,7 +18,7 @@ from ..signals import register_data_exporters, register_payment_providers
 
 class OrderListExporter(BaseExporter):
     identifier = 'orderlistcsv'
-    verbose_name = ugettext_lazy('List of orders (CSV)')
+    verbose_name = _('List of orders (CSV)')
 
     @property
     def export_form_fields(self):
@@ -59,7 +59,7 @@ class OrderListExporter(BaseExporter):
         headers = [
             _('Order code'), _('Order total'), _('Status'), _('Email'), _('Order date'),
             _('Company'), _('Name'), _('Address'), _('ZIP code'), _('City'), _('Country'), _('VAT ID'),
-            _('Payment date'), _('Payment type'), _('Payment method fee'),
+            _('Payment date'), _('Payment type'), _('Payment method fee'), _('Invoice numbers')
         ]
 
         for tr in tax_rates:
@@ -69,8 +69,6 @@ class OrderListExporter(BaseExporter):
                 _('Tax value at {rate} % tax').format(rate=tr),
             ]
 
-        headers.append(_('Invoice numbers'))
-
         writer.writerow(headers)
 
         provider_names = {}

src/pretix/base/forms/__init__.py

@@ -1,68 +1,151 @@
 import logging
 
-import i18nfield.forms
-from django.forms.models import ModelFormMetaclass
+from django import forms
+from django.core.files import File
+from django.core.files.storage import default_storage
+from django.core.files.uploadedfile import UploadedFile
+from django.forms.models import (
+    BaseInlineFormSet, BaseModelForm, BaseModelFormSet, ModelFormMetaclass,
+)
 from django.utils import six
 from django.utils.crypto import get_random_string
-from hierarkey.forms import HierarkeyForm
+from django.utils.translation import ugettext_lazy as _
 
+from pretix.base.i18n import I18nFormField
 from pretix.base.models import Event
 
-from .validators import PlaceholderValidator  # NOQA
-
 logger = logging.getLogger('pretix.plugins.ticketoutputpdf')
 
 
-class BaseI18nModelForm(i18nfield.forms.BaseI18nModelForm):
-    # compatibility shim for django-i18nfield library
-
+class BaseI18nModelForm(BaseModelForm):
+    """
+    This is a helperclass to construct an I18nModelForm.
+    """
     def __init__(self, *args, **kwargs):
         event = kwargs.pop('event', None)
-        if event:
-            kwargs['locales'] = event.settings.get('locales')
+        locales = kwargs.pop('locales', None)
         super().__init__(*args, **kwargs)
+        if event or locales:
+            for k, field in self.fields.items():
+                if isinstance(field, I18nFormField):
+                    field.widget.enabled_langcodes = event.settings.get('locales') if event else locales
 
 
 class I18nModelForm(six.with_metaclass(ModelFormMetaclass, BaseI18nModelForm)):
+    """
+    This is a modified version of Django's ModelForm which differs from ModelForm in
+    only one way: The constructor takes one additional optional argument ``event``
+    expecting an `Event` instance. If given, this instance is used to select
+    the visible languages in all I18nFormFields of the form. If not given, all languages
+    will be displayed.
+    """
     pass
 
 
-class I18nFormSet(i18nfield.forms.I18nModelFormSet):
-    # compatibility shim for django-i18nfield library
+class I18nFormSet(BaseModelFormSet):
+    """
+    This is equivalent to a normal BaseModelFormset, but cares for the special needs
+    of I18nForms (see there for more information).
+    """
 
     def __init__(self, *args, **kwargs):
-        event = kwargs.pop('event', None)
-        if event:
-            kwargs['locales'] = event.settings.get('locales')
+        self.event = kwargs.pop('event', None)
         super().__init__(*args, **kwargs)
 
+    def _construct_form(self, i, **kwargs):
+        kwargs['event'] = self.event
+        return super()._construct_form(i, **kwargs)
 
-class I18nInlineFormSet(i18nfield.forms.I18nInlineFormSet):
-    # compatibility shim for django-i18nfield library
+    @property
+    def empty_form(self):
+        form = self.form(
+            auto_id=self.auto_id,
+            prefix=self.add_prefix('__prefix__'),
+            empty_permitted=True,
+            event=self.event
+        )
+        self.add_fields(form, None)
+        return form
+
+
+class I18nInlineFormSet(BaseInlineFormSet):
+    """
+    This is equivalent to a normal BaseInlineFormset, but cares for the special needs
+    of I18nForms (see there for more information).
+    """
 
     def __init__(self, *args, **kwargs):
-        event = kwargs.pop('event', None)
-        if event:
-            kwargs['locales'] = event.settings.get('locales')
+        self.event = kwargs.pop('event', None)
         super().__init__(*args, **kwargs)
 
+    def _construct_form(self, i, **kwargs):
+        kwargs['event'] = self.event
+        return super()._construct_form(i, **kwargs)
 
-class SettingsForm(i18nfield.forms.I18nFormMixin, HierarkeyForm):
+
+class SettingsForm(forms.Form):
+    """
+    This form is meant to be used for modifying EventSettings or OrganizerSettings. It takes
+    care of loading the current values of the fields and saving the field inputs to the
+    settings storage. It also deals with setting the available languages for internationalized
+    fields.
+
+    :param obj: The event or organizer object which should be used for the settings storage
+    """
+    BOOL_CHOICES = (
+        ('False', _('disabled')),
+        ('True', _('enabled')),
+    )
 
     def __init__(self, *args, **kwargs):
-        self.obj = kwargs.get('obj', None)
-        self.locales = self.obj.settings.get('locales') if self.obj else kwargs.pop('locales', None)
-        kwargs['attribute_name'] = 'settings'
-        kwargs['locales'] = self.locales
+        self.obj = kwargs.pop('obj', None)
+        self.locales = kwargs.pop('locales', None)
         kwargs['initial'] = self.obj.settings.freeze()
         super().__init__(*args, **kwargs)
+        if self.obj or self.locales:
+            for k, field in self.fields.items():
+                if isinstance(field, I18nFormField):
+                    field.widget.enabled_langcodes = self.obj.settings.get('locales') if self.obj else self.locales
 
-    def get_new_filename(self, name: str) -> str:
-        nonce = get_random_string(length=8)
-        if isinstance(self.obj, Event):
-            fname = '%s/%s/%s.%s.%s' % (
-                self.obj.organizer.slug, self.obj.slug, name, nonce, name.split('.')[-1]
-            )
-        else:
-            fname = '%s/%s.%s.%s' % (self.obj.slug, name, nonce, name.split('.')[-1])
-        return fname
+    def save(self):
+        """
+        Performs the save operation
+        """
+        for name, field in self.fields.items():
+            value = self.cleaned_data[name]
+            if isinstance(value, UploadedFile):
+                # Delete old file
+                fname = self.obj.settings.get(name, as_type=File)
+                if fname:
+                    try:
+                        default_storage.delete(fname.name)
+                    except OSError:
+                        logger.error('Deleting file %s failed.' % fname.name)
+
+                # Create new file
+                nonce = get_random_string(length=8)
+                if isinstance(self.obj, Event):
+                    fname = '%s/%s/%s.%s.%s' % (
+                        self.obj.organizer.slug, self.obj.slug, name, nonce, value.name.split('.')[-1]
+                    )
+                else:
+                    fname = '%s/%s.%s.%s' % (self.obj.slug, name, nonce, value.name.split('.')[-1])
+                newname = default_storage.save(fname, value)
+                value._name = newname
+                self.obj.settings.set(name, value)
+            elif isinstance(value, File):
+                # file is unchanged
+                continue
+            elif isinstance(field, forms.FileField):
+                # file is deleted
+                fname = self.obj.settings.get(name, as_type=File)
+                if fname:
+                    try:
+                        default_storage.delete(fname.name)
+                    except OSError:
+                        logger.error('Deleting file %s failed.' % fname.name)
+                del self.obj.settings[name]
+            elif value is None:
+                del self.obj.settings[name]
+            elif self.obj.settings.get(name, as_type=type(value)) != value:
+                self.obj.settings.set(name, value)

src/pretix/base/forms/user.py

@@ -104,7 +104,7 @@ class UserSettingsForm(forms.ModelForm):
 
 
 class User2FADeviceAddForm(forms.Form):
-    name = forms.CharField(label=_('Device name'), max_length=64)
+    name = forms.CharField(label=_('Device name'))
     devicetype = forms.ChoiceField(label=_('Device type'), widget=forms.RadioSelect, choices=(
         ('totp', _('Smartphone with the Authenticator application')),
         ('u2f', _('U2F-compatible hardware token (e.g. Yubikey)')),

src/pretix/base/forms/validators.py

@@ -1,38 +0,0 @@
-import re
-
-from django.core.exceptions import ValidationError
-from django.core.validators import BaseValidator
-from django.utils.translation import ugettext_lazy as _
-from i18nfield.strings import LazyI18nString
-
-
-class PlaceholderValidator(BaseValidator):
-    """
-    Takes list of allowed placeholders,
-    validates form field by checking for placeholders,
-    which are not presented in taken list.
-    """
-
-    def __init__(self, limit_value):
-        super().__init__(limit_value)
-        self.limit_value = limit_value
-
-    def __call__(self, value):
-        if isinstance(value, LazyI18nString):
-            for l, v in value.data.items():
-                self.__call__(v)
-            return
-
-        data_placeholders = list(re.findall(r'({[\w\s]*})', value, re.X))
-        invalid_placeholders = []
-        for placeholder in data_placeholders:
-            if placeholder not in self.limit_value:
-                invalid_placeholders.append(placeholder)
-        if invalid_placeholders:
-            raise ValidationError(
-                _('Invalid placeholder(s): %(value)s'),
-                code='invalid',
-                params={'value': ", ".join(invalid_placeholders,)})
-
-    def clean(self, x):
-        return x

src/pretix/base/i18n.py

@@ -1,16 +1,346 @@
+import copy
+import json
 from contextlib import contextmanager
+from typing import Dict, List, Optional, Union
 
+from django import forms
 from django.conf import settings
+from django.core.serializers.json import DjangoJSONEncoder
+from django.db.models import Model, QuerySet, TextField
 from django.utils import translation
 from django.utils.formats import date_format, number_format
+from django.utils.safestring import mark_safe
 from django.utils.translation import ugettext
-from i18nfield.fields import (  # noqa
-    I18nCharField, I18nTextarea, I18nTextField, I18nTextInput,
-)
-from i18nfield.forms import I18nFormField  # noqa
-# Compatibility imports
-from i18nfield.strings import LazyI18nString  # noqa
-from i18nfield.utils import I18nJSONEncoder  # noqa
+
+
+class LazyI18nString:
+    """
+    This represents an internationalized string that is/was/will be stored in the database.
+    """
+
+    def __init__(self, data: Optional[Union[str, Dict[str, str]]]):
+        """
+        Creates a new i18n-aware string.
+
+        :param data: If this is a dictionary, it is expected to map language codes to translations.
+            If this is a string that can be parsed as JSON, it will be parsed and used as such a dictionary.
+            If this is anything else, it will be cast to a string and used for all languages.
+        """
+        self.data = data
+        if isinstance(self.data, str) and self.data is not None:
+            try:
+                j = json.loads(self.data)
+            except ValueError:
+                pass
+            else:
+                self.data = j
+
+    def __str__(self) -> str:
+        """
+        Evaluate the given string with respect to the currently active locale.
+
+        If no string is available in the currently active language, this will give you
+        the string in the system's default language. If this is unavailable as well, it
+        will give you the string in the first language available.
+        """
+        return self.localize(translation.get_language() or settings.LANGUAGE_CODE)
+
+    def __bool__(self):
+        if not self.data:
+            return False
+        if isinstance(self.data, dict):
+            return any(self.data.values())
+        return True
+
+    def localize(self, lng: str) -> str:
+        """
+        Evaluate the given string with respect to the locale defined by ``lng``.
+
+        If no string is available in the currently active language, this will give you
+        the string in the system's default language. If this is unavailable as well, it
+        will give you the string in the first language available.
+
+        :param lng: A locale code, e.g. ``de``. If you specify a code including a country
+            or region like ``de-AT``, exact matches will be used preferably, but if only
+            a ``de`` or ``de-AT`` translation exists, this might be returned as well.
+        """
+        if self.data is None:
+            return ""
+
+        if isinstance(self.data, dict):
+            firstpart = lng.split('-')[0]
+            similar = [l for l in self.data.keys() if (l.startswith(firstpart + "-") or firstpart == l) and l != lng]
+            if self.data.get(lng):
+                return self.data[lng]
+            elif self.data.get(firstpart):
+                return self.data[firstpart]
+            elif similar and any([self.data.get(s) for s in similar]):
+                for s in similar:
+                    if self.data.get(s):
+                        return self.data.get(s)
+            elif self.data.get(settings.LANGUAGE_CODE):
+                return self.data[settings.LANGUAGE_CODE]
+            elif len(self.data):
+                return list(self.data.items())[0][1]
+            else:
+                return ""
+        else:
+            return str(self.data)
+
+    def __repr__(self) -> str:  # NOQA
+        return '<LazyI18nString: %s>' % repr(self.data)
+
+    def __lt__(self, other) -> bool:  # NOQA
+        return str(self) < str(other)
+
+    def __format__(self, format_spec):
+        return self.__str__()
+
+    def __eq__(self, other):
+        if other is None:
+            return False
+        if hasattr(other, 'data'):
+            return self.data == other.data
+        return self.data == other
+
+    class LazyGettextProxy:
+        def __init__(self, lazygettext):
+            self.lazygettext = lazygettext
+
+        def __getitem__(self, item):
+            with language(item):
+                return str(ugettext(self.lazygettext))
+
+        def __contains__(self, item):
+            return True
+
+        def __str__(self):
+            return str(ugettext(self.lazygettext))
+
+    @classmethod
+    def from_gettext(cls, lazygettext):
+        l = LazyI18nString({})
+        l.data = cls.LazyGettextProxy(lazygettext)
+        return l
+
+
+class I18nWidget(forms.MultiWidget):
+    """
+    The default form widget for I18nCharField and I18nTextField. It makes
+    use of Django's MultiWidget mechanism and does some magic to save you
+    time.
+    """
+    widget = forms.TextInput
+
+    def __init__(self, langcodes: List[str], field: forms.Field, attrs=None):
+        widgets = []
+        self.langcodes = langcodes
+        self.enabled_langcodes = langcodes
+        self.field = field
+        for lng in self.langcodes:
+            a = copy.copy(attrs) or {}
+            a['lang'] = lng
+            widgets.append(self.widget(attrs=a))
+        super().__init__(widgets, attrs)
+
+    def decompress(self, value):
+        data = []
+        first_enabled = None
+        any_filled = False
+        any_enabled_filled = False
+        if not isinstance(value, LazyI18nString):
+            value = LazyI18nString(value)
+        for i, lng in enumerate(self.langcodes):
+            dataline = (
+                value.data[lng]
+                if value is not None and (
+                    isinstance(value.data, dict) or isinstance(value.data, LazyI18nString.LazyGettextProxy)
+                ) and lng in value.data
+                else None
+            )
+            any_filled = any_filled or (lng in self.enabled_langcodes and dataline)
+            if not first_enabled and lng in self.enabled_langcodes:
+                first_enabled = i
+                if dataline:
+                    any_enabled_filled = True
+            data.append(dataline)
+        if value and not isinstance(value.data, dict):
+            data[first_enabled] = value.data
+        elif value and not any_enabled_filled:
+            data[first_enabled] = value.localize(self.enabled_langcodes[0])
+        return data
+
+    def render(self, name, value, attrs=None):
+        if self.is_localized:
+            for widget in self.widgets:
+                widget.is_localized = self.is_localized
+        # value is a list of values, each corresponding to a widget
+        # in self.widgets.
+        if not isinstance(value, list):
+            value = self.decompress(value)
+        output = []
+        final_attrs = self.build_attrs(attrs)
+        id_ = final_attrs.get('id', None)
+        for i, widget in enumerate(self.widgets):
+            if self.langcodes[i] not in self.enabled_langcodes:
+                continue
+            try:
+                widget_value = value[i]
+            except IndexError:
+                widget_value = None
+            if id_:
+                final_attrs = dict(
+                    final_attrs,
+                    id='%s_%s' % (id_, i),
+                    title=self.langcodes[i]
+                )
+            output.append(widget.render(name + '_%s' % i, widget_value, final_attrs))
+        return mark_safe(self.format_output(output))
+
+    def format_output(self, rendered_widgets):
+        return '<div class="i18n-form-group">%s</div>' % super().format_output(rendered_widgets)
+
+
+class I18nTextInput(I18nWidget):
+    widget = forms.TextInput
+
+
+class I18nTextarea(I18nWidget):
+    widget = forms.Textarea
+
+
+class I18nFormField(forms.MultiValueField):
+    """
+    The form field that is used by I18nCharField and I18nTextField. It makes use
+    of Django's MultiValueField mechanism to create one sub-field per available
+    language.
+
+    It contains special treatment to make sure that a field marked as "required" is validated
+    as "filled out correctly" if *at least one* translation is filled it. It is never required
+    to fill in all of them. This has the drawback that the HTML property ``required`` is set on
+    none of the fields as this would lead to irritating behaviour.
+
+    :param langcodes: An iterable of locale codes that the widget should render a field for. If
+        omitted, fields will be rendered for all languages supported by pretix.
+    """
+
+    def compress(self, data_list):
+        langcodes = self.langcodes
+        data = {}
+        for i, value in enumerate(data_list):
+            data[langcodes[i]] = value
+        return LazyI18nString(data)
+
+    def clean(self, value):
+        if isinstance(value, LazyI18nString):
+            # This happens e.g. if the field is disabled
+            return value
+        found = False
+        clean_data = []
+        errors = []
+        for i, field in enumerate(self.fields):
+            try:
+                field_value = value[i]
+            except IndexError:
+                field_value = None
+            if field_value not in self.empty_values:
+                found = True
+            try:
+                clean_data.append(field.clean(field_value))
+            except forms.ValidationError as e:
+                # Collect all validation errors in a single list, which we'll
+                # raise at the end of clean(), rather than raising a single
+                # exception for the first error we encounter. Skip duplicates.
+                errors.extend(m for m in e.error_list if m not in errors)
+        if errors:
+            raise forms.ValidationError(errors)
+        if self.one_required and not found:
+            raise forms.ValidationError(self.error_messages['required'], code='required')
+
+        out = self.compress(clean_data)
+        self.validate(out)
+        self.run_validators(out)
+        return out
+
+    def __init__(self, *args, **kwargs):
+        fields = []
+        defaults = {
+            'widget': self.widget,
+            'max_length': kwargs.pop('max_length', None),
+        }
+        self.langcodes = kwargs.pop('langcodes', [l[0] for l in settings.LANGUAGES])
+        self.one_required = kwargs.get('required', True)
+        kwargs['required'] = False
+        kwargs['widget'] = kwargs['widget'](
+            langcodes=self.langcodes, field=self, **kwargs.pop('widget_kwargs', {})
+        )
+        defaults.update(**kwargs)
+        for lngcode in self.langcodes:
+            defaults['label'] = '%s (%s)' % (defaults.get('label'), lngcode)
+            fields.append(forms.CharField(**defaults))
+        super().__init__(
+            fields=fields, require_all_fields=False, *args, **kwargs
+        )
+
+
+class I18nFieldMixin:
+    form_class = I18nFormField
+    widget = I18nTextInput
+
+    def __init__(self, *args, **kwargs):
+        self.event = kwargs.pop('event', None)
+        super().__init__(*args, **kwargs)
+
+    def to_python(self, value):
+        if isinstance(value, LazyI18nString):
+            return value
+        return LazyI18nString(value)
+
+    def get_prep_value(self, value):
+        if isinstance(value, LazyI18nString):
+            value = value.data
+        if isinstance(value, dict):
+            return json.dumps({k: v for k, v in value.items() if v}, sort_keys=True)
+        return value
+
+    def get_prep_lookup(self, lookup_type, value):  # NOQA
+        raise TypeError('Lookups on i18n string currently not supported.')
+
+    def from_db_value(self, value, expression, connection, context):
+        return LazyI18nString(value)
+
+    def formfield(self, **kwargs):
+        defaults = {'form_class': self.form_class, 'widget': self.widget}
+        defaults.update(kwargs)
+        return super().formfield(**defaults)
+
+
+class I18nCharField(I18nFieldMixin, TextField):
+    """
+    A CharField which takes internationalized data. Internally, a TextField dabase
+    field is used to store JSON. If you interact with this field, you will work
+    with LazyI18nString instances.
+    """
+    widget = I18nTextInput
+
+
+class I18nTextField(I18nFieldMixin, TextField):
+    """
+    Like I18nCharField, but for TextFields.
+    """
+    widget = I18nTextarea
+
+
+class I18nJSONEncoder(DjangoJSONEncoder):
+    def default(self, obj):
+        if isinstance(obj, LazyI18nString):
+            return obj.data
+        elif isinstance(obj, QuerySet):
+            return list(obj)
+        elif isinstance(obj, Model):
+            return {'type': obj.__class__.__name__, 'id': obj.id}
+        else:
+            return super().default(obj)
 
 
 class LazyDate:
@@ -47,11 +377,10 @@ def language(lng):
 
 
 class LazyLocaleException(Exception):
-    def __init__(self, *args):
-        self.msg = args[0]
-        self.msgargs = args[1] if len(args) > 1 else None
-        self.args = args
-        super().__init__(self.msg, self.msgargs)
+    def __init__(self, msg, msgargs=None):
+        self.msg = msg
+        self.msgargs = msgargs
+        super().__init__(msg, msgargs)
 
     def __str__(self):
         if self.msgargs:

src/pretix/base/management/commands/rebuild.py

@@ -1,8 +1,6 @@
 from django.core.management import call_command
 from django.core.management.base import BaseCommand
 
-from pretix.base.settings import GlobalSettingsObject
-
 
 class Command(BaseCommand):
     help = "Rebuild static files and language files"
@@ -12,12 +10,3 @@ class Command(BaseCommand):
         call_command('compilejsi18n', verbosity=1, interactive=False)
         call_command('collectstatic', verbosity=1, interactive=False)
         call_command('compress', verbosity=1, interactive=False)
-        try:
-            gs = GlobalSettingsObject()
-            del gs.settings.update_check_last
-            del gs.settings.update_check_result
-            del gs.settings.update_check_result_warning
-        except:
-            # Fails when this is executed without a valid database configuration.
-            # We don't care.
-            pass

src/pretix/base/metrics.py

@@ -1,28 +1,10 @@
-import math
-from collections import defaultdict
-
-from django.apps import apps
 from django.conf import settings
 
 if settings.HAS_REDIS:
     import django_redis
     redis = django_redis.get_redis_connection("redis")
 
-REDIS_KEY = "pretix_metrics"
-_INF = float("inf")
-_MINUS_INF = float("-inf")
-
-
-def _float_to_go_string(d):
-    # inspired by https://github.com/prometheus/client_python/blob/master/prometheus_client/core.py
-    if d == _INF:
-        return '+Inf'
-    elif d == _MINUS_INF:
-        return '-Inf'
-    elif math.isnan(d):
-        return 'NaN'
-    else:
-        return repr(float(d))
+REDIS_KEY_PREFIX = "pretix_metrics_"
 
 
 class Metric(object):
@@ -52,7 +34,7 @@ class Metric(object):
         if len(labels) != len(self.labelnames):
             raise ValueError("Unknown labels used: {}".format(", ".join(set(labels) - set(self.labelnames))))
 
-    def _construct_metric_identifier(self, metricname, labels=None, labelnames=None):
+    def _construct_metric_identifier(self, metricname, labels=None):
         """
         Constructs the scrapable metricname usable in the output format.
         """
@@ -60,36 +42,26 @@ class Metric(object):
             return metricname
         else:
             named_labels = []
-            for labelname in (labelnames or self.labelnames):
-                named_labels.append('{}="{}"'.format(labelname, labels[labelname]))
+            for labelname in self.labelnames:
+                named_labels.append('{}="{}",'.format(labelname, labels[labelname]))
 
             return metricname + "{" + ",".join(named_labels) + "}"
 
-    def _inc_in_redis(self, key, amount, pipeline=None):
+    def _inc_in_redis(self, key, amount):
         """
         Increments given key in Redis.
         """
+        rkey = REDIS_KEY_PREFIX + key
         if settings.HAS_REDIS:
-            if not pipeline:
-                pipeline = redis
-            pipeline.hincrbyfloat(REDIS_KEY, key, amount)
+            redis.incrbyfloat(rkey, amount)
 
-    def _set_in_redis(self, key, value, pipeline=None):
+    def _set_in_redis(self, key, value):
         """
         Sets given key in Redis.
         """
+        rkey = REDIS_KEY_PREFIX + key
         if settings.HAS_REDIS:
-            if not pipeline:
-                pipeline = redis
-            pipeline.hset(REDIS_KEY, key, value)
-
-    def _get_redis_pipeline(self):
-        if settings.HAS_REDIS:
-            return redis.pipeline()
-
-    def _execute_redis_pipeline(self, pipeline):
-        if settings.HAS_REDIS:
-            return pipeline.execute()
+            redis.set(rkey, value)
 
 
 class Counter(Metric):
@@ -152,79 +124,21 @@ class Gauge(Metric):
         self._inc_in_redis(fullmetric, amount * -1)
 
 
-class Histogram(Metric):
-    """
-    Histogram Metric Object
-    """
-
-    def __init__(self, name, helpstring, labelnames=None,
-                 buckets=(.005, .01, .025, .05, .075, .1, .25, .5, .75, 1.0, 2.5, 5.0, 7.5, 10.0, 30.0, _INF)):
-        if list(buckets) != sorted(buckets):
-            # This is probably an error on the part of the user,
-            # so raise rather than sorting for them.
-            raise ValueError('Buckets not in sorted order')
-
-        if buckets and buckets[-1] != _INF:
-            buckets.append(_INF)
-
-        if len(buckets) < 2:
-            raise ValueError('Must have at least two buckets')
-
-        self.buckets = buckets
-        super().__init__(name, helpstring, labelnames)
-
-    def observe(self, amount, **kwargs):
-        """
-        Stores a value in the histogram for the labels specified in kwargs.
-        """
-        if amount < 0:
-            raise ValueError("Amount must be greater than zero. Otherwise use inc().")
-
-        self._check_label_consistency(kwargs)
-
-        pipe = self._get_redis_pipeline()
-
-        countmetric = self._construct_metric_identifier(self.name + '_count', kwargs)
-        self._inc_in_redis(countmetric, 1, pipeline=pipe)
-
-        summetric = self._construct_metric_identifier(self.name + '_sum', kwargs)
-        self._inc_in_redis(summetric, amount, pipeline=pipe)
-
-        kwargs_le = dict(kwargs.items())
-        for i, bound in enumerate(self.buckets):
-            if amount <= bound:
-                kwargs_le['le'] = _float_to_go_string(bound)
-                bmetric = self._construct_metric_identifier(self.name + '_bucket', kwargs_le,
-                                                            labelnames=self.labelnames + ["le"])
-                self._inc_in_redis(bmetric, 1, pipeline=pipe)
-
-        self._execute_redis_pipeline(pipe)
-
-
 def metric_values():
     """
-    Produces the the values to be presented to the monitoring system
+    Produces the scrapable textformat to be presented to the monitoring system
     """
-    metrics = defaultdict(dict)
+    if not settings.HAS_REDIS:
+        return ""
 
-    # Metrics from redis
-    if settings.HAS_REDIS:
-        for key, value in redis.hscan_iter(REDIS_KEY):
-            dkey = key.decode("utf-8")
-            splitted = dkey.split("{", 2)
-            value = float(value.decode("utf-8"))
-            metrics[splitted[0]]["{" + splitted[1]] = value
+    metrics = {}
 
-    # Aliases
-    aliases = {
-        'pretix_view_requests_total': 'pretix_view_duration_seconds_count'
-    }
-    for a, atarget in aliases.items():
-        metrics[a] = metrics[atarget]
+    for key in redis.scan_iter(match=REDIS_KEY_PREFIX + "*"):
+        dkey = key.decode("utf-8")
+        _, _, output_key = dkey.split("_", 2)
+        value = float(redis.get(dkey).decode("utf-8"))
 
-    # Throwaway metrics
-    for m in apps.get_models():  # Count all models
-        metrics['pretix_model_instances']['{model="%s"}' % m._meta] = m.objects.count()
+        metrics[output_key] = value
 
     return metrics
 
@@ -232,9 +146,5 @@ def metric_values():
 """
 Provided metrics
 """
-pretix_view_duration_seconds = Histogram("pretix_view_duration_seconds", "Return time of views.",
-                                         ["status_code", "method", "url_name"])
-pretix_task_runs_total = Counter("pretix_task_runs_total", "Total calls to a celery task",
-                                 ["task_name", "status"])
-pretix_task_duration_seconds = Histogram("pretix_task_duration_seconds", "Call time of a celery task",
-                                         ["task_name"])
+http_requests_total = Counter("http_requests_total", "Total number of HTTP requests made.", ["code", "handler", "method"])
+# usage: http_requests_total.inc(code="200", handler="/foo", method="GET")

src/pretix/base/middleware.py

@@ -135,30 +135,18 @@ def get_language_from_request(request: HttpRequest) -> str:
     )
 
 
-def _parse_csp(header):
-    h = {}
-    for part in header.split(';'):
-        k, v = part.strip().split(' ', 1)
-        h[k.strip()] = v.split(' ')
-    return h
-
-
-def _render_csp(h):
-    return "; ".join(k + ' ' + ' '.join(v) for k, v in h.items())
-
-
-def _merge_csp(a, b):
-    for k, v in a.items():
-        if k in b:
-            a[k] += b[k]
-
-    for k, v in b.items():
-        if k not in a:
-            a[k] = b[k]
-
-
 class SecurityMiddleware(MiddlewareMixin):
 
+    def _parse_csp(self, header):
+        h = {}
+        for part in header.split(';'):
+            k, v = part.strip().split(' ', 1)
+            h[k.strip()] = v
+        return h
+
+    def _render_csp(self, h):
+        return "; ".join(k + ' ' + v for k, v in h.items())
+
     def process_response(self, request, resp):
         if settings.DEBUG and resp.status_code >= 400:
             # Don't use CSP on debug error page as it breaks of Django's fancy error
@@ -167,23 +155,23 @@ class SecurityMiddleware(MiddlewareMixin):
 
         resp['X-XSS-Protection'] = '1'
         h = {
-            'default-src': ["{static}"],
-            'script-src': ['{static}', 'https://checkout.stripe.com', 'https://js.stripe.com'],
-            'object-src': ["'none'"],
+            'default-src': "{static}",
+            'script-src': '{static} https://checkout.stripe.com https://js.stripe.com',
+            'object-src': "'none'",
             # frame-src is deprecated but kept for compatibility with CSP 1.0 browsers, e.g. Safari 9
-            'frame-src': ['{static}', 'https://checkout.stripe.com', 'https://js.stripe.com'],
-            'child-src': ['{static}', 'https://checkout.stripe.com', 'https://js.stripe.com'],
-            'style-src': ["{static}"],
-            'connect-src': ["{dynamic}", "https://checkout.stripe.com"],
-            'img-src': ["{static}", "data:", "https://*.stripe.com"],
+            'frame-src': '{static} https://checkout.stripe.com https://js.stripe.com',
+            'child-src': '{static} https://checkout.stripe.com https://js.stripe.com',
+            'style-src': "{static}",
+            'connect-src': "{dynamic} https://checkout.stripe.com",
+            'img-src': "{static} data: https://*.stripe.com",
             # form-action is not only used to match on form actions, but also on URLs
             # form-actions redirect to. In the context of e.g. payment providers or
             # single-sign-on this can be nearly anything so we cannot really restrict
             # this. However, we'll restrict it to HTTPS.
-            'form-action': ["{dynamic}", "https:"],
+            'form-action': "{dynamic} https:",
         }
         if 'Content-Security-Policy' in resp:
-            _merge_csp(h, _parse_csp(resp['Content-Security-Policy']))
+            h.update(self._parse_csp(resp['Content-Security-Policy']))
 
         staticdomain = "'self'"
         dynamicdomain = "'self'"
@@ -196,5 +184,5 @@ class SecurityMiddleware(MiddlewareMixin):
             else:
                 staticdomain += " " + settings.SITE_URL
                 dynamicdomain += " " + settings.SITE_URL
-        resp['Content-Security-Policy'] = _render_csp(h).format(static=staticdomain, dynamic=dynamicdomain)
+        resp['Content-Security-Policy'] = self._render_csp(h).format(static=staticdomain, dynamic=dynamicdomain)
         return resp

src/pretix/base/migrations/0001_squashed_0028_auto_20160816_1242.py

@@ -8,11 +8,11 @@ from decimal import Decimal
 
 import django.core.validators
 import django.db.models.deletion
-import i18nfield.fields
 from django.conf import settings
 from django.contrib.auth.hashers import make_password
 from django.db import migrations, models
 
+import pretix.base.i18n
 import pretix.base.models.base
 import pretix.base.models.invoices
 import pretix.base.models.items
@@ -107,7 +107,7 @@ class Migration(migrations.Migration):
             name='Event',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('name', i18nfield.fields.I18nCharField(max_length=200, verbose_name='Name')),
+                ('name', pretix.base.i18n.I18nCharField(max_length=200, verbose_name='Name')),
                 ('slug', models.SlugField(help_text='Should be short, only contain lowercase letters and numbers, and must be unique among your events. This is being used in addresses and bank transfer references.', validators=[django.core.validators.RegexValidator(message='The slug may only contain letters, numbers, dots and dashes.', regex='^[a-zA-Z0-9.-]+$')], verbose_name='Slug')),
                 ('currency', models.CharField(default='EUR', max_length=10, verbose_name='Default currency')),
                 ('date_from', models.DateTimeField(verbose_name='Event start time')),
@@ -163,9 +163,9 @@ class Migration(migrations.Migration):
             name='Item',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('name', i18nfield.fields.I18nCharField(max_length=255, verbose_name='Item name')),
+                ('name', pretix.base.i18n.I18nCharField(max_length=255, verbose_name='Item name')),
                 ('active', models.BooleanField(default=True, verbose_name='Active')),
-                ('description', i18nfield.fields.I18nTextField(blank=True, help_text='This is shown below the product name in lists.', null=True, verbose_name='Description')),
+                ('description', pretix.base.i18n.I18nTextField(blank=True, help_text='This is shown below the product name in lists.', null=True, verbose_name='Description')),
                 ('default_price', models.DecimalField(decimal_places=2, max_digits=7, null=True, verbose_name='Default price')),
                 ('tax_rate', models.DecimalField(blank=True, decimal_places=2, max_digits=7, null=True, verbose_name='Taxes included in percent')),
                 ('admission', models.BooleanField(default=False, help_text='Whether or not buying this product allows a person to enter your event', verbose_name='Is an admission ticket')),
@@ -185,10 +185,10 @@ class Migration(migrations.Migration):
             name='ItemCategory',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('name', i18nfield.fields.I18nCharField(max_length=255, verbose_name='Category name')),
+                ('name', pretix.base.i18n.I18nCharField(max_length=255, verbose_name='Category name')),
                 ('position', models.IntegerField(default=0)),
                 ('event', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='categories', to='pretixbase.Event')),
-                ('description', i18nfield.fields.I18nTextField(blank=True, verbose_name='Category description')),
+                ('description', pretix.base.i18n.I18nTextField(blank=True, verbose_name='Category description')),
             ],
             options={
                 'verbose_name': 'Product category',
@@ -201,7 +201,7 @@ class Migration(migrations.Migration):
             name='ItemVariation',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('value', i18nfield.fields.I18nCharField(max_length=255, verbose_name='Description')),
+                ('value', pretix.base.i18n.I18nCharField(max_length=255, verbose_name='Description')),
                 ('active', models.BooleanField(default=True, verbose_name='Active')),
                 ('position', models.PositiveIntegerField(default=0, verbose_name='Position')),
                 ('default_price', models.DecimalField(blank=True, decimal_places=2, max_digits=7, null=True, verbose_name='Default price')),
@@ -309,7 +309,7 @@ class Migration(migrations.Migration):
             name='Question',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('question', i18nfield.fields.I18nTextField(verbose_name='Question')),
+                ('question', pretix.base.i18n.I18nTextField(verbose_name='Question')),
                 ('type', models.CharField(choices=[('N', 'Number'), ('S', 'Text (one line)'), ('T', 'Multiline text'), ('B', 'Yes/No')], max_length=5, verbose_name='Question type')),
                 ('required', models.BooleanField(default=False, verbose_name='Required question')),
                 ('event', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='questions', to='pretixbase.Event')),
@@ -566,7 +566,7 @@ class Migration(migrations.Migration):
             name='QuestionOption',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('answer', i18nfield.fields.I18nCharField(verbose_name='Answer')),
+                ('answer', pretix.base.i18n.I18nCharField(verbose_name='Answer')),
             ],
         ),
         migrations.AlterField(

src/pretix/base/migrations/0002_auto_20160209_0940.py

@@ -7,10 +7,10 @@ from decimal import Decimal
 
 import django.core.validators
 import django.db.models.deletion
-import i18nfield.fields
 from django.conf import settings
 from django.db import migrations, models
 
+import pretix.base.i18n
 import pretix.base.models.base
 import pretix.base.models.items
 import pretix.base.models.orders
@@ -64,7 +64,7 @@ class Migration(migrations.Migration):
             name='Event',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('name', i18nfield.fields.I18nCharField(max_length=200, verbose_name='Name')),
+                ('name', pretix.base.i18n.I18nCharField(max_length=200, verbose_name='Name')),
                 ('slug', models.SlugField(help_text='Should be short, only contain lowercase letters and numbers, and must be unique among your events. This is being used in addresses and bank transfer references.', validators=[django.core.validators.RegexValidator(message='The slug may only contain letters, numbers, dots and dashes.', regex='^[a-zA-Z0-9.-]+$')], verbose_name='Slug')),
                 ('currency', models.CharField(default='EUR', max_length=10, verbose_name='Default currency')),
                 ('date_from', models.DateTimeField(verbose_name='Event start time')),
@@ -119,9 +119,9 @@ class Migration(migrations.Migration):
             name='Item',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('name', i18nfield.fields.I18nCharField(max_length=255, verbose_name='Item name')),
+                ('name', pretix.base.i18n.I18nCharField(max_length=255, verbose_name='Item name')),
                 ('active', models.BooleanField(default=True, verbose_name='Active')),
-                ('description', i18nfield.fields.I18nTextField(blank=True, help_text='This is shown below the product name in lists.', null=True, verbose_name='Description')),
+                ('description', pretix.base.i18n.I18nTextField(blank=True, help_text='This is shown below the product name in lists.', null=True, verbose_name='Description')),
                 ('default_price', models.DecimalField(decimal_places=2, max_digits=7, null=True, verbose_name='Default price')),
                 ('tax_rate', models.DecimalField(blank=True, decimal_places=2, max_digits=7, null=True, verbose_name='Taxes included in percent')),
                 ('admission', models.BooleanField(default=False, help_text='Whether or not buying this product allows a person to enter your event', verbose_name='Is an admission ticket')),
@@ -141,7 +141,7 @@ class Migration(migrations.Migration):
             name='ItemCategory',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('name', i18nfield.fields.I18nCharField(max_length=255, verbose_name='Category name')),
+                ('name', pretix.base.i18n.I18nCharField(max_length=255, verbose_name='Category name')),
                 ('position', models.IntegerField(default=0)),
                 ('event', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='categories', to='pretixbase.Event')),
             ],
@@ -156,7 +156,7 @@ class Migration(migrations.Migration):
             name='ItemVariation',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('value', i18nfield.fields.I18nCharField(max_length=255, verbose_name='Description')),
+                ('value', pretix.base.i18n.I18nCharField(max_length=255, verbose_name='Description')),
                 ('active', models.BooleanField(default=True, verbose_name='Active')),
                 ('position', models.PositiveIntegerField(default=0, verbose_name='Position')),
                 ('default_price', models.DecimalField(blank=True, decimal_places=2, max_digits=7, null=True, verbose_name='Default price')),
@@ -264,7 +264,7 @@ class Migration(migrations.Migration):
             name='Question',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('question', i18nfield.fields.I18nTextField(verbose_name='Question')),
+                ('question', pretix.base.i18n.I18nTextField(verbose_name='Question')),
                 ('type', models.CharField(choices=[('N', 'Number'), ('S', 'Text (one line)'), ('T', 'Multiline text'), ('B', 'Yes/No')], max_length=5, verbose_name='Question type')),
                 ('required', models.BooleanField(default=False, verbose_name='Required question')),
                 ('event', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='questions', to='pretixbase.Event')),

src/pretix/base/migrations/0018_auto_20160326_1104.py

@@ -3,9 +3,10 @@
 from __future__ import unicode_literals
 
 import django.db.models.deletion
-import i18nfield.fields
 from django.db import migrations, models
 
+import pretix.base.i18n
+
 
 class Migration(migrations.Migration):
 
@@ -18,7 +19,7 @@ class Migration(migrations.Migration):
             name='QuestionOption',
             fields=[
                 ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('answer', i18nfield.fields.I18nCharField(verbose_name='Answer')),
+                ('answer', pretix.base.i18n.I18nCharField(verbose_name='Answer')),
             ],
         ),
         migrations.AlterField(

src/pretix/base/migrations/0020_auto_20160421_1943.py

@@ -2,9 +2,10 @@
 # Generated by Django 1.9.4 on 2016-04-21 19:43
 from __future__ import unicode_literals
 
-import i18nfield.fields
 from django.db import migrations, models
 
+import pretix.base.i18n
+
 
 class Migration(migrations.Migration):
 
@@ -16,7 +17,7 @@ class Migration(migrations.Migration):
         migrations.AddField(
             model_name='itemcategory',
             name='description',
-            field=i18nfield.fields.I18nTextField(blank=True, verbose_name='Category description'),
+            field=pretix.base.i18n.I18nTextField(blank=True, verbose_name='Category description'),
         ),
         migrations.AlterField(
             model_name='questionanswer',

src/pretix/base/migrations/0050_orderposition_positionid_squashed_0061_event_location.py

@@ -6,10 +6,10 @@ import django.core.validators
 import django.db.migrations.operations.special
 import django.db.models.deletion
 import django.utils.timezone
-import i18nfield.fields
 from django.conf import settings
 from django.db import migrations, models
 
+import pretix.base.i18n
 import pretix.base.models.event
 import pretix.base.models.orders
 import pretix.base.models.organizer
@@ -214,6 +214,6 @@ class Migration(migrations.Migration):
         migrations.AddField(
             model_name='event',
             name='location',
-            field=i18nfield.fields.I18nCharField(blank=True, max_length=200, null=True, verbose_name='Location'),
+            field=pretix.base.i18n.I18nCharField(blank=True, max_length=200, null=True, verbose_name='Location'),
         ),
     ]

src/pretix/base/migrations/0051_auto_20170206_2027.py

@@ -1,42 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.4 on 2017-02-06 20:27
-from __future__ import unicode_literals
-
-import django.db.models.deletion
-from django.db import migrations, models
-
-import pretix.base.models.base
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0050_orderposition_positionid_squashed_0061_event_location'),
-    ]
-
-    operations = [
-        migrations.CreateModel(
-            name='WaitingListEntry',
-            fields=[
-                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('created', models.DateTimeField(auto_now_add=True, verbose_name='On waiting list since')),
-                ('email', models.EmailField(max_length=254, verbose_name='E-mail address')),
-                ('locale', models.CharField(default='en', max_length=190)),
-                ('event', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='waitinglistentries', to='pretixbase.Event', verbose_name='Event')),
-                ('item', models.ForeignKey(help_text='The product the user waits for.', on_delete=django.db.models.deletion.CASCADE, related_name='waitinglistentries', to='pretixbase.Item', verbose_name='Product')),
-                ('variation', models.ForeignKey(blank=True, help_text='The variation of the product selected above.', null=True, on_delete=django.db.models.deletion.CASCADE, related_name='waitinglistentries', to='pretixbase.ItemVariation', verbose_name='Product variation')),
-                ('voucher', models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, to='pretixbase.Voucher', verbose_name='Assigned voucher')),
-            ],
-            options={
-                'ordering': ['created'],
-                'verbose_name': 'Waiting list entry',
-                'verbose_name_plural': 'Waiting list entries',
-            },
-            bases=(models.Model, pretix.base.models.base.LoggingMixin),
-        ),
-        migrations.AlterField(
-            model_name='cachedcombinedticket',
-            name='created',
-            field=models.DateTimeField(auto_now_add=True),
-        ),
-    ]

src/pretix/base/migrations/0052_auto_20170324_1506.py

@@ -1,38 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.6 on 2017-03-24 15:06
-from __future__ import unicode_literals
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0051_auto_20170206_2027'),
-    ]
-
-    operations = [
-        migrations.AlterModelOptions(
-            name='invoice',
-            options={'ordering': ('invoice_no',)},
-        ),
-        migrations.AlterModelOptions(
-            name='orderposition',
-            options={'ordering': ('positionid', 'id'), 'verbose_name': 'Order position', 'verbose_name_plural': 'Order positions'},
-        ),
-        migrations.AddField(
-            model_name='item',
-            name='max_per_order',
-            field=models.IntegerField(blank=True, help_text='This product can only be bought at most this times within one order. If you keep the field empty or set it to 0, there is no special limit for this product. The limit for the maximum number of items in the whole order applies regardless.', null=True, verbose_name='Maximum times per order'),
-        ),
-        migrations.AlterField(
-            model_name='item',
-            name='allow_cancel',
-            field=models.BooleanField(default=True, help_text='If this is active and the general event settings allo wit, orders containing this product can be canceled by the user until the order is paid for. Users cannot cancel paid orders on their own and you can cancel orders at all times, regardless of this setting', verbose_name='Allow product to be canceled'),
-        ),
-        migrations.AlterField(
-            model_name='item',
-            name='default_price',
-            field=models.DecimalField(decimal_places=2, help_text='If this product has multiple variations, you can set different prices for each of the variations. If a variation does not have a special price or if you do not have variations, this price will be used.', max_digits=7, null=True, verbose_name='Default price'),
-        ),
-    ]

src/pretix/base/migrations/0052_team_teaminvite.py

@@ -1,114 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.7 on 2017-04-27 09:11
-from __future__ import unicode_literals
-
-import django.db.models.deletion
-from django.conf import settings
-from django.db import migrations, models
-
-import pretix.base.models.organizer
-
-
-def create_teams(apps, schema_editor):
-    Event = apps.get_model('pretixbase', 'Event')
-    Organizer = apps.get_model('pretixbase', 'Organizer')
-    Team = apps.get_model('pretixbase', 'Team')
-    TeamInvite = apps.get_model('pretixbase', 'TeamInvite')
-    EventPermission = apps.get_model('pretixbase', 'EventPermission')
-    OrganizerPermission = apps.get_model('pretixbase', 'OrganizerPermission')
-
-    for o in Organizer.objects.prefetch_related('events'):
-        for e in o.events.all():
-            teams = {}
-
-            for p in e.user_perms.all():
-                pkey = (p.can_change_settings, p.can_change_items, p.can_view_orders,
-                        p.can_change_permissions, p.can_change_orders, p.can_view_vouchers,
-                        p.can_change_vouchers)
-                if pkey not in teams:
-                    team = Team()
-                    team.can_change_event_settings = p.can_change_settings
-                    team.can_change_items = p.can_change_items
-                    team.can_view_orders = p.can_view_orders
-                    team.can_change_orders = p.can_change_orders
-                    team.can_view_vouchers = p.can_view_vouchers
-                    team.can_change_vouchers = p.can_change_vouchers
-                    team.organizer = o
-                    team.name = '{} Team {}'.format(
-                        str(e.name), len(teams) + 1
-                    )
-                    team.save()
-                    team.limit_events.add(e)
-
-                    teams[pkey] = team
-
-                if p.user:
-                    teams[pkey].members.add(p.user)
-                else:
-                    teams[pkey].invites.create(email=p.invite_email, token=p.invite_token)
-
-        teams = {}
-        for p in o.user_perms.all():
-            pkey = (p.can_create_events, p.can_change_permissions)
-            if pkey not in teams:
-                team = Team()
-                team.can_change_organizer_settings = True
-                team.can_create_events = p.can_create_events
-                team.can_change_teams = p.can_change_permissions
-                team.organizer = o
-                team.name = '{} Team {}'.format(
-                    str(o.name), len(teams) + 1
-                )
-                team.save()
-                teams[pkey] = team
-
-            if p.user:
-                teams[pkey].members.add(p.user)
-            else:
-                teams[pkey].invites.create(email=p.invite_email, token=p.invite_token)
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0051_auto_20170206_2027_squashed_0057_auto_20170501_2116'),
-    ]
-
-    operations = [
-        migrations.CreateModel(
-            name='Team',
-            fields=[
-                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('name', models.CharField(max_length=190, verbose_name='Team name')),
-                ('all_events', models.BooleanField(default=False, verbose_name='All events (including newly created ones)')),
-                ('can_create_events', models.BooleanField(default=False, verbose_name='Can create events')),
-                ('can_change_teams', models.BooleanField(default=False, verbose_name='Can change permissions')),
-                ('can_change_organizer_settings', models.BooleanField(default=False, verbose_name='Can change organizer settings')),
-                ('can_change_event_settings', models.BooleanField(default=False, verbose_name='Can change event settings')),
-                ('can_change_items', models.BooleanField(default=False, verbose_name='Can change product settings')),
-                ('can_view_orders', models.BooleanField(default=False, verbose_name='Can view orders')),
-                ('can_change_orders', models.BooleanField(default=False, verbose_name='Can change orders')),
-                ('can_view_vouchers', models.BooleanField(default=False, verbose_name='Can view vouchers')),
-                ('can_change_vouchers', models.BooleanField(default=False, verbose_name='Can change vouchers')),
-                ('limit_events', models.ManyToManyField(to='pretixbase.Event', verbose_name='Limit to events')),
-                ('members', models.ManyToManyField(related_name='teams', to=settings.AUTH_USER_MODEL, verbose_name='Team members')),
-                ('organizer', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='teams', to='pretixbase.Organizer')),
-            ],
-            options={
-                'verbose_name_plural': 'Teams',
-                'verbose_name': 'Team',
-            },
-        ),
-        migrations.CreateModel(
-            name='TeamInvite',
-            fields=[
-                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('email', models.EmailField(blank=True, max_length=254, null=True)),
-                ('token', models.CharField(blank=True, default=pretix.base.models.organizer.generate_invite_token, max_length=64, null=True)),
-                ('team', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='invites', to='pretixbase.Team')),
-            ],
-        ),
-        migrations.RunPython(
-            create_teams, migrations.RunPython.noop
-        )
-    ]

src/pretix/base/migrations/0053_auto_20170409_1651.py

@@ -1,59 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.7 on 2017-04-09 16:51
-from __future__ import unicode_literals
-
-import django.db.models.deletion
-from django.db import migrations, models
-
-
-def migrate_global_settings(apps, schema_editor):
-    GlobalSetting = apps.get_model('pretixbase', 'GlobalSetting')
-    GlobalSettingsObject_SettingsStore = apps.get_model('pretixbase', 'GlobalSettingsObject_SettingsStore')
-
-    l = []
-    for s in GlobalSetting.objects.all():
-        l.append(GlobalSettingsObject_SettingsStore(key=s.key, value=s.value))
-
-    GlobalSettingsObject_SettingsStore.objects.bulk_create(l)
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0052_auto_20170324_1506'),
-    ]
-
-    operations = [
-        migrations.RenameModel(
-            old_name='EventSetting',
-            new_name='Event_SettingsStore',
-        ),
-        migrations.RenameModel(
-            old_name='OrganizerSetting',
-            new_name='Organizer_SettingsStore',
-        ),
-        migrations.CreateModel(
-            name='GlobalSettingsObject_SettingsStore',
-            fields=[
-                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('key', models.CharField(db_index=True, max_length=255)),
-                ('value', models.TextField()),
-            ],
-        ),
-        migrations.RunPython(
-            migrate_global_settings, migrations.RunPython.noop
-        ),
-        migrations.DeleteModel(
-            name='GlobalSetting',
-        ),
-        migrations.AlterField(
-            model_name='event_settingsstore',
-            name='object',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='_settings_objects', to='pretixbase.Event'),
-        ),
-        migrations.AlterField(
-            model_name='organizer_settingsstore',
-            name='object',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='_settings_objects', to='pretixbase.Organizer'),
-        ),
-    ]

src/pretix/base/migrations/0055_auto_20170413_1537.py

@@ -1,40 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.7 on 2017-04-13 15:37
-from __future__ import unicode_literals
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0054_auto_20170413_1050'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='cartposition',
-            name='attendee_email',
-            field=models.EmailField(blank=True, help_text='Empty, if this product is not an admission ticket', max_length=254, null=True, verbose_name='Attendee email'),
-        ),
-        migrations.AddField(
-            model_name='orderposition',
-            name='attendee_email',
-            field=models.EmailField(blank=True, help_text='Empty, if this product is not an admission ticket', max_length=254, null=True, verbose_name='Attendee email'),
-        ),
-        migrations.AlterField(
-            model_name='event_settingsstore',
-            name='key',
-            field=models.CharField(max_length=255),
-        ),
-        migrations.AlterField(
-            model_name='globalsettingsobject_settingsstore',
-            name='key',
-            field=models.CharField(max_length=255),
-        ),
-        migrations.AlterField(
-            model_name='organizer_settingsstore',
-            name='key',
-            field=models.CharField(max_length=255),
-        ),
-    ]

src/pretix/base/migrations/0056_auto_20170414_1044.py

@@ -1,58 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.7 on 2017-04-14 10:44
-from __future__ import unicode_literals
-
-import django.db.models.deletion
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0055_auto_20170413_1537'),
-    ]
-
-    operations = [
-        migrations.CreateModel(
-            name='ItemAddOn',
-            fields=[
-                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('min_count', models.PositiveIntegerField(default=0, verbose_name='Minimum number')),
-                ('max_count', models.PositiveIntegerField(default=1, verbose_name='Maximum number')),
-            ],
-        ),
-        migrations.AddField(
-            model_name='cartposition',
-            name='addon_to',
-            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='addons', to='pretixbase.CartPosition'),
-        ),
-        migrations.AddField(
-            model_name='itemcategory',
-            name='is_addon',
-            field=models.BooleanField(default=False, help_text='If selected, the products belonging to this category are not for sale on their own. They can only be bought in combination with a product that has this category configured as a possible source for add-ons.', verbose_name='Products in this category are add-on products'),
-        ),
-        migrations.AddField(
-            model_name='orderposition',
-            name='addon_to',
-            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='addons', to='pretixbase.OrderPosition'),
-        ),
-        migrations.AlterField(
-            model_name='item',
-            name='free_price',
-            field=models.BooleanField(default=False, help_text='If this option is active, your users can choose the price themselves. The price configured above is then interpreted as the minimum price a user has to enter. You could use this e.g. to collect additional donations for your event. This is currently not supported for products that are bought as an add-on to other products.', verbose_name='Free price input'),
-        ),
-        migrations.AddField(
-            model_name='itemaddon',
-            name='addon_category',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='addon_to', to='pretixbase.ItemCategory', verbose_name='Category'),
-        ),
-        migrations.AddField(
-            model_name='itemaddon',
-            name='base_item',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='addons', to='pretixbase.Item'),
-        ),
-        migrations.AlterUniqueTogether(
-            name='itemaddon',
-            unique_together=set([('base_item', 'addon_category')]),
-        ),
-    ]

src/pretix/base/migrations/0057_auto_20170501_2116.py

@@ -1,30 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.7 on 2017-05-01 21:16
-from __future__ import unicode_literals
-
-import i18nfield.fields
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0056_auto_20170414_1044'),
-    ]
-
-    operations = [
-        migrations.AlterModelOptions(
-            name='itemaddon',
-            options={'ordering': ('position', 'pk')},
-        ),
-        migrations.AddField(
-            model_name='itemaddon',
-            name='position',
-            field=models.PositiveIntegerField(default=0, verbose_name='Position'),
-        ),
-        migrations.AddField(
-            model_name='itemvariation',
-            name='description',
-            field=i18nfield.fields.I18nTextField(blank=True, help_text='This is shown below the variation name in lists.', null=True, verbose_name='Description'),
-        ),
-    ]

src/pretix/base/migrations/0058_auto_20170429_1020.py

@@ -1,55 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.7 on 2017-04-29 10:20
-from __future__ import unicode_literals
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0052_team_teaminvite'),
-    ]
-
-    operations = [
-        migrations.RemoveField(
-            model_name='eventpermission',
-            name='event',
-        ),
-        migrations.RemoveField(
-            model_name='eventpermission',
-            name='user',
-        ),
-        migrations.RemoveField(
-            model_name='organizerpermission',
-            name='organizer',
-        ),
-        migrations.RemoveField(
-            model_name='organizerpermission',
-            name='user',
-        ),
-        migrations.RemoveField(
-            model_name='event',
-            name='permitted',
-        ),
-        migrations.RemoveField(
-            model_name='organizer',
-            name='permitted',
-        ),
-        migrations.AlterField(
-            model_name='team',
-            name='can_change_teams',
-            field=models.BooleanField(default=False, verbose_name='Can change teams and permissions'),
-        ),
-        migrations.AlterField(
-            model_name='team',
-            name='limit_events',
-            field=models.ManyToManyField(blank=True, to='pretixbase.Event', verbose_name='Limit to events'),
-        ),
-        migrations.DeleteModel(
-            name='EventPermission',
-        ),
-        migrations.DeleteModel(
-            name='OrganizerPermission',
-        ),
-    ]

src/pretix/base/migrations/0059_checkin_nonce.py

@@ -1,20 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.7 on 2017-05-04 07:06
-from __future__ import unicode_literals
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0058_auto_20170429_1020'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='checkin',
-            name='nonce',
-            field=models.CharField(blank=True, max_length=190, null=True),
-        ),
-    ]

src/pretix/base/migrations/0060_auto_20170510_1027.py

@@ -1,26 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.7 on 2017-05-10 10:27
-from __future__ import unicode_literals
-
-import i18nfield.fields
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0059_checkin_nonce'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='event',
-            name='date_admission',
-            field=models.DateTimeField(blank=True, null=True, verbose_name='Admission time'),
-        ),
-        migrations.AlterField(
-            model_name='event',
-            name='location',
-            field=i18nfield.fields.I18nTextField(blank=True, max_length=200, null=True, verbose_name='Location'),
-        ),
-    ]

src/pretix/base/migrations/0061_auto_20170521_0942.py

@@ -1,27 +0,0 @@
-# -*- coding: utf-8 -*-
-# Generated by Django 1.10.7 on 2017-05-21 09:42
-from __future__ import unicode_literals
-
-from django.core.cache import cache
-from django.db import migrations
-
-
-def rename_placeholder(app, schema_editor):
-    EventSettingsStore = app.get_model('pretixbase', 'Event_SettingsStore')
-
-    for setting in EventSettingsStore.objects.all():
-        if setting.key == 'mail_text_order_placed':
-            new_value = setting.value.replace('{paymentinfo}', '{payment_info}')
-            setting.value = new_value
-            cache.delete('hierarkey_{}_{}'.format('event', setting.object_id))
-            setting.save()
-
-
-class Migration(migrations.Migration):
-    dependencies = [
-        ('pretixbase', '0060_auto_20170510_1027'),
-    ]
-
-    operations = [
-        migrations.RunPython(rename_placeholder, migrations.RunPython.noop)
-    ]

src/pretix/base/migrations/0061_event_location.py

@@ -2,9 +2,10 @@
 # Generated by Django 1.10.5 on 2017-02-01 04:31
 from __future__ import unicode_literals
 
-import i18nfield.fields
 from django.db import migrations
 
+import pretix.base.i18n
+
 
 class Migration(migrations.Migration):
 
@@ -16,6 +17,6 @@ class Migration(migrations.Migration):
         migrations.AddField(
             model_name='event',
             name='location',
-            field=i18nfield.fields.I18nCharField(blank=True, max_length=200, null=True, verbose_name='Location'),
+            field=pretix.base.i18n.I18nCharField(blank=True, max_length=200, null=True, verbose_name='Location'),
         ),
     ]

src/pretix/base/models/__init__.py

@@ -1,15 +1,14 @@
-from ..settings import GlobalSettingsObject_SettingsStore
 from .auth import U2FDevice, User
 from .base import CachedFile, LoggedModel, cachedfile_name
 from .checkin import Checkin
 from .event import (
-    Event, Event_SettingsStore, EventLock, RequiredAction,
+    Event, EventLock, EventPermission, EventSetting, RequiredAction,
     generate_invite_token,
 )
 from .invoices import Invoice, InvoiceLine, invoice_filename
 from .items import (
-    Item, ItemAddOn, ItemCategory, ItemVariation, Question, QuestionOption,
-    Quota, itempicture_upload_to,
+    Item, ItemCategory, ItemVariation, Question, QuestionOption, Quota,
+    itempicture_upload_to,
 )
 from .log import LogEntry
 from .orders import (
@@ -18,6 +17,5 @@ from .orders import (
     cachedcombinedticket_name, cachedticket_name, generate_position_secret,
     generate_secret,
 )
-from .organizer import Organizer, Organizer_SettingsStore, Team, TeamInvite
+from .organizer import Organizer, OrganizerPermission, OrganizerSetting
 from .vouchers import Voucher
-from .waitinglist import WaitingListEntry

src/pretix/base/models/auth.py

@@ -1,12 +1,9 @@
-from typing import Union
-
 from django.conf import settings
 from django.contrib.auth.models import (
     AbstractBaseUser, BaseUserManager, PermissionsMixin,
 )
 from django.contrib.contenttypes.models import ContentType
 from django.db import models
-from django.db.models import Q
 from django.utils.translation import ugettext_lazy as _
 from django_otp.models import Device
 
@@ -84,10 +81,6 @@ class User(AbstractBaseUser, PermissionsMixin, LoggingMixin):
 
     objects = UserManager()
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-        self._teamcache = {}
-
     class Meta:
         verbose_name = _("User")
         verbose_name_plural = _("Users")
@@ -154,103 +147,6 @@ class User(AbstractBaseUser, PermissionsMixin, LoggingMixin):
         return LogEntry.objects.filter(content_type=ContentType.objects.get_for_model(User),
                                        object_id=self.pk)
 
-    def _get_teams_for_organizer(self, organizer):
-        if 'o{}'.format(organizer.pk) not in self._teamcache:
-            self._teamcache['o{}'.format(organizer.pk)] = list(self.teams.filter(organizer=organizer))
-        return self._teamcache['o{}'.format(organizer.pk)]
-
-    def _get_teams_for_event(self, organizer, event):
-        if 'e{}'.format(event.pk) not in self._teamcache:
-            self._teamcache['e{}'.format(event.pk)] = list(self.teams.filter(organizer=organizer).filter(
-                Q(all_events=True) | Q(limit_events=event)
-            ))
-        return self._teamcache['e{}'.format(event.pk)]
-
-    class SuperuserPermissionSet:
-        def __contains__(self, item):
-            return True
-
-    def get_event_permission_set(self, organizer, event) -> Union[set, SuperuserPermissionSet]:
-        """
-        Gets a set of permissions (as strings) that a user holds for a particular event
-
-        :param organizer: The organizer of the event
-        :param event: The event to check
-        :return: set in case of a normal user and a SuperuserPermissionSet in case of a superuser (fake object where
-                 a in b always returns true).
-        """
-        if self.is_superuser:
-            return self.SuperuserPermissionSet()
-
-        teams = self._get_teams_for_event(organizer, event)
-        return set.union(*[t.permission_set() for t in teams])
-
-    def get_organizer_permission_set(self, organizer) -> Union[set, SuperuserPermissionSet]:
-        """
-        Gets a set of permissions (as strings) that a user holds for a particular organizer
-
-        :param organizer: The organizer of the event
-        :return: set in case of a normal user and a SuperuserPermissionSet in case of a superuser (fake object where
-                 a in b always returns true).
-        """
-        if self.is_superuser:
-            return self.SuperuserPermissionSet()
-
-        teams = self._get_teams_for_organizer(organizer)
-        return set.union(*[t.permission_set() for t in teams])
-
-    def has_event_permission(self, organizer, event, perm_name=None) -> bool:
-        """
-        Checks if this user is part of any team that grants access of type ``perm_name``
-        to the event ``event``.
-
-        :param organizer: The organizer of the event
-        :param event: The event to check
-        :param perm_name: The permission, e.g. ``can_change_teams``
-        :return: bool
-        """
-        if self.is_superuser:
-            return True
-        teams = self._get_teams_for_event(organizer, event)
-        if teams:
-            self._teamcache['e{}'.format(event.pk)] = teams
-            if not perm_name or any([team.has_permission(perm_name) for team in teams]):
-                return True
-        return False
-
-    def has_organizer_permission(self, organizer, perm_name=None):
-        """
-        Checks if this user is part of any team that grants access of type ``perm_name``
-        to the organizer ``organizer``.
-
-        :param organizer: The organizer to check
-        :param perm_name: The permission, e.g. ``can_change_teams``
-        :return: bool
-        """
-        if self.is_superuser:
-            return True
-        teams = self._get_teams_for_organizer(organizer)
-        if teams:
-            if not perm_name or any([team.has_permission(perm_name) for team in teams]):
-                return True
-        return False
-
-    def get_events_with_any_permission(self):
-        """
-        Returns a queryset of events the user has any permissions to.
-
-        :return: Iterable of Events
-        """
-        from .event import Event
-
-        if self.is_superuser:
-            return Event.objects.all()
-
-        return Event.objects.filter(
-            Q(organizer_id__in=self.teams.filter(all_events=True).values_list('organizer', flat=True))
-            | Q(id__in=self.teams.values_list('limit_events__id', flat=True))
-        )
-
 
 class U2FDevice(Device):
     json_data = models.TextField()

src/pretix/base/models/base.py

@@ -1,12 +1,13 @@
 import json
 import uuid
 
-from django.contrib.contenttypes.models import ContentType
+from django.contrib.contenttypes.fields import GenericRelation
 from django.db import models
 from django.db.models.signals import post_delete
 from django.dispatch import receiver
 from django.utils.crypto import get_random_string
-from i18nfield.utils import I18nJSONEncoder
+
+from pretix.base.i18n import I18nJSONEncoder
 
 
 def cachedfile_name(instance, filename: str) -> str:
@@ -59,6 +60,7 @@ class LoggingMixin:
 
 
 class LoggedModel(models.Model, LoggingMixin):
+    logentries = GenericRelation('pretixbase.LogEntry')
 
     class Meta:
         abstract = True
@@ -69,8 +71,4 @@ class LoggedModel(models.Model, LoggingMixin):
 
         :return: A QuerySet of LogEntry objects
         """
-        from .log import LogEntry
-
-        return LogEntry.objects.filter(
-            content_type=ContentType.objects.get_for_model(type(self)), object_id=self.pk
-        ).select_related('user', 'event')
+        return self.logentries.all().select_related('user', 'event')

src/pretix/base/models/checkin.py

@@ -8,4 +8,3 @@ class Checkin(models.Model):
     """
     position = models.ForeignKey('pretixbase.OrderPosition', related_name='checkins')
     datetime = models.DateTimeField(default=now)
-    nonce = models.CharField(max_length=190, null=True, blank=True)

src/pretix/base/models/event.py

@@ -11,20 +11,22 @@ from django.core.validators import RegexValidator
 from django.db import models
 from django.template.defaultfilters import date as _date
 from django.utils.crypto import get_random_string
+from django.utils.functional import cached_property
 from django.utils.timezone import make_aware, now
 from django.utils.translation import ugettext_lazy as _
-from i18nfield.fields import I18nCharField, I18nTextField
 
 from pretix.base.email import CustomSMTPBackend
+from pretix.base.i18n import I18nCharField
 from pretix.base.models.base import LoggedModel
+from pretix.base.settings import SettingsProxy
 from pretix.base.validators import EventSlugBlacklistValidator
 from pretix.helpers.daterange import daterange
 
-from ..settings import settings_hierarkey
+from .auth import User
 from .organizer import Organizer
+from .settings import EventSetting
 
 
-@settings_hierarkey.add(parent_field='organizer', cache_namespace='event')
 class Event(LoggedModel):
     """
     This model represents an event. An event is anything you can buy
@@ -57,7 +59,6 @@ class Event(LoggedModel):
     """
 
     settings_namespace = 'event'
-    CURRENCY_CHOICES = [(c.alpha_3, c.alpha_3 + " - " + c.name) for c in settings.CURRENCIES]
     organizer = models.ForeignKey(Organizer, related_name="events", on_delete=models.PROTECT)
     name = I18nCharField(
         max_length=200,
@@ -78,15 +79,14 @@ class Event(LoggedModel):
         verbose_name=_("Short form"),
     )
     live = models.BooleanField(default=False, verbose_name=_("Shop is live"))
+    permitted = models.ManyToManyField(User, through='EventPermission',
+                                       related_name="events", )
     currency = models.CharField(max_length=10,
                                 verbose_name=_("Default currency"),
-                                choices=CURRENCY_CHOICES,
                                 default=settings.DEFAULT_CURRENCY)
     date_from = models.DateTimeField(verbose_name=_("Event start time"))
     date_to = models.DateTimeField(null=True, blank=True,
                                    verbose_name=_("Event end time"))
-    date_admission = models.DateTimeField(null=True, blank=True,
-                                          verbose_name=_("Admission time"))
     is_public = models.BooleanField(default=False,
                                     verbose_name=_("Visible in public lists"),
                                     help_text=_("If selected, this event may show up on the ticket system's start page "
@@ -101,7 +101,7 @@ class Event(LoggedModel):
         verbose_name=_("Start of presale"),
         help_text=_("No products will be sold before this date."),
     )
-    location = I18nTextField(
+    location = I18nCharField(
         null=True, blank=True,
         max_length=200,
         verbose_name=_("Location"),
@@ -139,7 +139,7 @@ class Event(LoggedModel):
             return []
         return self.plugins.split(",")
 
-    def get_date_from_display(self, tz=None, show_times=True) -> str:
+    def get_date_from_display(self, tz=None) -> str:
         """
         Returns a formatted string containing the start date of the event with respect
         to the current locale and to the ``show_times`` setting.
@@ -147,17 +147,7 @@ class Event(LoggedModel):
         tz = tz or pytz.timezone(self.settings.timezone)
         return _date(
             self.date_from.astimezone(tz),
-            "DATETIME_FORMAT" if self.settings.show_times and show_times else "DATE_FORMAT"
-        )
-
-    def get_time_from_display(self, tz=None) -> str:
-        """
-        Returns a formatted string containing the start time of the event, ignoring
-        the ``show_times`` setting.
-        """
-        tz = tz or pytz.timezone(self.settings.timezone)
-        return _date(
-            self.date_from.astimezone(tz), "TIME_FORMAT"
+            "DATETIME_FORMAT" if self.settings.show_times else "DATE_FORMAT"
         )
 
     def get_date_to_display(self, tz=None) -> str:
@@ -191,6 +181,17 @@ class Event(LoggedModel):
 
         return ObjectRelatedCache(self)
 
+    @cached_property
+    def settings(self) -> SettingsProxy:
+        """
+        Returns an object representing this event's settings.
+        """
+        try:
+            return SettingsProxy(self, type=EventSetting, parent=self.organizer)
+        except Organizer.DoesNotExist:
+            # Should only happen when creating new events
+            return SettingsProxy(self, type=EventSetting)
+
     @property
     def presale_has_ended(self):
         if self.presale_end and now() > self.presale_end:
@@ -234,9 +235,7 @@ class Event(LoggedModel):
         ), tz)
 
     def copy_data_from(self, other):
-        from . import ItemAddOn, ItemCategory, Item, Question, Quota
-        from ..signals import event_copy_data
-
+        from . import ItemCategory, Item, Question, Quota
         self.plugins = other.plugins
         self.save()
 
@@ -265,12 +264,6 @@ class Event(LoggedModel):
                 v.item = i
                 v.save()
 
-        for ia in ItemAddOn.objects.filter(base_item__event=other).prefetch_related('base_item', 'addon_category'):
-            ia.pk = None
-            ia.base_item = item_map[ia.base_item.pk]
-            ia.addon_category = category_map[ia.addon_category.pk]
-            ia.save()
-
         for q in Quota.objects.filter(event=other).prefetch_related('items', 'variations'):
             items = list(q.items.all())
             vars = list(q.variations.all())
@@ -278,8 +271,7 @@ class Event(LoggedModel):
             q.event = self
             q.save()
             for i in items:
-                if i.pk in item_map:
-                    q.items.add(item_map[i.pk])
+                q.items.add(item_map[i.pk])
             for v in vars:
                 q.variations.add(variation_map[v.pk])
 
@@ -296,7 +288,7 @@ class Event(LoggedModel):
                 o.question = q
                 o.save()
 
-        for s in other.settings._objects.all():
+        for s in EventSetting.objects.filter(object=other):
             s.object = self
             s.pk = None
             if s.value.startswith('file://'):
@@ -309,13 +301,74 @@ class Event(LoggedModel):
                 s.value = 'file://' + newname
             s.save()
 
-        event_copy_data.send(sender=self, other=other)
-
 
 def generate_invite_token():
     return get_random_string(length=32, allowed_chars=string.ascii_lowercase + string.digits)
 
 
+class EventPermission(models.Model):
+    """
+    The relation between an Event and a User who has permissions to
+    access an event.
+
+    :param event: The event this permission refers to
+    :type event: Event
+    :param user: The user this permission set applies to
+    :type user: User
+    :param can_change_settings: If ``True``, the user can change all basic settings for this event.
+    :type can_change_settings: bool
+    :param can_change_items: If ``True``, the user can change and add items and related objects for this event.
+    :type can_change_items: bool
+    :param can_view_orders: If ``True``, the user can inspect details of all orders.
+    :type can_view_orders: bool
+    :param can_change_orders: If ``True``, the user can change details of orders
+    :type can_change_orders: bool
+    """
+
+    event = models.ForeignKey(Event, related_name="user_perms", on_delete=models.CASCADE)
+    user = models.ForeignKey(User, related_name="event_perms", on_delete=models.CASCADE, null=True, blank=True)
+    invite_email = models.EmailField(null=True, blank=True)
+    invite_token = models.CharField(default=generate_invite_token, max_length=64, null=True, blank=True)
+    can_change_settings = models.BooleanField(
+        default=True,
+        verbose_name=_("Can change event settings")
+    )
+    can_change_items = models.BooleanField(
+        default=True,
+        verbose_name=_("Can change product settings")
+    )
+    can_view_orders = models.BooleanField(
+        default=True,
+        verbose_name=_("Can view orders")
+    )
+    can_change_permissions = models.BooleanField(
+        default=True,
+        verbose_name=_("Can change permissions")
+    )
+    can_change_orders = models.BooleanField(
+        default=True,
+        verbose_name=_("Can change orders")
+    )
+    can_view_vouchers = models.BooleanField(
+        default=True,
+        verbose_name=_("Can view vouchers")
+    )
+    can_change_vouchers = models.BooleanField(
+        default=True,
+        verbose_name=_("Can change vouchers")
+    )
+
+    class Meta:
+        verbose_name = _("Event permission")
+        verbose_name_plural = _("Event permissions")
+
+    def __str__(self):
+        return _("%(name)s on %(object)s") % {
+            'name': str(self.user),
+            'object': str(self.event),
+        }
+
+
 class EventLock(models.Model):
     event = models.CharField(max_length=36, primary_key=True)
     date = models.DateTimeField(auto_now=True)

src/pretix/base/models/invoices.py

@@ -122,7 +122,6 @@ class Invoice(models.Model):
 
     class Meta:
         unique_together = ('event', 'invoice_no')
-        ordering = ('invoice_no',)
 
 
 class InvoiceLine(models.Model):

src/pretix/base/models/items.py

@@ -5,15 +5,13 @@ from decimal import Decimal
 from typing import Tuple
 
 from django.conf import settings
-from django.core.exceptions import ValidationError
 from django.db import models
 from django.db.models import F, Func, Q, Sum
 from django.utils.functional import cached_property
 from django.utils.timezone import now
 from django.utils.translation import ugettext_lazy as _
-from i18nfield.fields import I18nCharField, I18nTextField
 
-from pretix.base.decimal import round_decimal
+from pretix.base.i18n import I18nCharField, I18nTextField
 from pretix.base.models.base import LoggedModel
 
 from .event import Event
@@ -45,13 +43,6 @@ class ItemCategory(LoggedModel):
     position = models.IntegerField(
         default=0
     )
-    is_addon = models.BooleanField(
-        default=False,
-        verbose_name=_('Products in this category are add-on products'),
-        help_text=_('If selected, the products belonging to this category are not for sale on their own. They can '
-                    'only be bought in combination with a product that has this category configured as a possible '
-                    'source for add-ons.')
-    )
 
     class Meta:
         verbose_name = _("Product category")
@@ -59,8 +50,6 @@ class ItemCategory(LoggedModel):
         ordering = ('position', 'id')
 
     def __str__(self):
-        if self.is_addon:
-            return _('{category} (Add-On products)').format(category=str(self.name))
         return str(self.name)
 
     def delete(self, *args, **kwargs):
@@ -121,10 +110,6 @@ class Item(LoggedModel):
     :type hide_without_voucher: bool
     :param allow_cancel: If set to ``False``, an order with this product can not be canceled by the user.
     :type allow_cancel: bool
-    :param max_per_order: Maximum number of times this item can be in an order. None for unlimited.
-    :type max_per_order: int
-    :param min_per_order: Minimum number of times this item needs to be in an order if bought at all. None for unlimited.
-    :type min_per_order: int
     """
 
     event = models.ForeignKey(
@@ -155,9 +140,6 @@ class Item(LoggedModel):
     )
     default_price = models.DecimalField(
         verbose_name=_("Default price"),
-        help_text=_("If this product has multiple variations, you can set different prices for each of the "
-                    "variations. If a variation does not have a special price or if you do not have variations, "
-                    "this price will be used."),
         max_digits=7, decimal_places=2, null=True
     )
     free_price = models.BooleanField(
@@ -165,8 +147,7 @@ class Item(LoggedModel):
         verbose_name=_("Free price input"),
         help_text=_("If this option is active, your users can choose the price themselves. The price configured above "
                     "is then interpreted as the minimum price a user has to enter. You could use this e.g. to collect "
-                    "additional donations for your event. This is currently not supported for products that are "
-                    "bought as an add-on to other products.")
+                    "additional donations for your event.")
     )
     tax_rate = models.DecimalField(
         verbose_name=_("Taxes included in percent"),
@@ -214,25 +195,9 @@ class Item(LoggedModel):
     allow_cancel = models.BooleanField(
         verbose_name=_('Allow product to be canceled'),
         default=True,
-        help_text=_('If this is active and the general event settings allo wit, orders containing this product can be '
-                    'canceled by the user until the order is paid for. Users cannot cancel paid orders on their own '
-                    'and you can cancel orders at all times, regardless of this setting')
+        help_text=_('If you deactivate this, an order including this product might not be canceled by the user. '
+                    'It may still be canceled by you.')
     )
-    min_per_order = models.IntegerField(
-        verbose_name=_('Minimum amount per order'),
-        null=True, blank=True,
-        help_text=_('This product can only be bought if it is added to the cart at least this many times. If you keep '
-                    'the field empty or set it to 0, there is no special limit for this product.')
-    )
-    max_per_order = models.IntegerField(
-        verbose_name=_('Maximum amount per order'),
-        null=True, blank=True,
-        help_text=_('This product can only be bought at most this many times within one order. If you keep the field '
-                    'empty or set it to 0, there is no special limit for this product. The limit for the maximum '
-                    'number of items in the whole order applies regardless.')
-    )
-    # !!! Attention: If you add new fields here, also add them to the copying code in
-    # pretix/control/views/item.py if applicable.
 
     class Meta:
         verbose_name = _("Product")
@@ -252,11 +217,6 @@ class Item(LoggedModel):
         if self.event:
             self.event.get_cache().clear()
 
-    @property
-    def default_price_net(self):
-        tax_value = round_decimal(self.default_price * (1 - 100 / (100 + self.tax_rate)))
-        return self.default_price - tax_value
-
     def is_available(self, now_dt: datetime=None) -> bool:
         """
         Returns whether this item is available according to its ``active`` flag
@@ -271,7 +231,7 @@ class Item(LoggedModel):
             return False
         return True
 
-    def check_quotas(self, ignored_quotas=None, count_waitinglist=True, _cache=None):
+    def check_quotas(self, ignored_quotas=None, _cache=None):
         """
         This method is used to determine whether this Item is currently available
         for sale.
@@ -293,7 +253,7 @@ class Item(LoggedModel):
         if self.variations.count() > 0:  # NOQA
             raise ValueError('Do not call this directly on items which have variations '
                              'but call this on their ItemVariation objects')
-        return min([q.availability(count_waitinglist=count_waitinglist, _cache=_cache) for q in check_quotas],
+        return min([q.availability(_cache=_cache) for q in check_quotas],
                    key=lambda s: (s[0], s[1] if s[1] is not None else sys.maxsize))
 
     @cached_property
@@ -310,8 +270,6 @@ class ItemVariation(models.Model):
     :type item: Item
     :param value: A string defining this variation
     :type value: str
-    :param description: A short description
-    :type description: str
     :param active: Whether this variation is being sold.
     :type active: bool
     :param default_price: This variation's default price
@@ -329,11 +287,6 @@ class ItemVariation(models.Model):
         default=True,
         verbose_name=_("Active"),
     )
-    description = I18nTextField(
-        verbose_name=_("Description"),
-        help_text=_("This is shown below the variation name in lists."),
-        null=True, blank=True,
-    )
     position = models.PositiveIntegerField(
         default=0,
         verbose_name=_("Position")
@@ -352,15 +305,6 @@ class ItemVariation(models.Model):
     def __str__(self):
         return str(self.value)
 
-    @property
-    def price(self):
-        return self.default_price if self.default_price is not None else self.item.default_price
-
-    @property
-    def net_price(self):
-        tax_value = round_decimal(self.price * (1 - 100 / (100 + self.item.tax_rate)))
-        return self.price - tax_value
-
     def delete(self, *args, **kwargs):
         super().delete(*args, **kwargs)
         if self.item:
@@ -371,7 +315,7 @@ class ItemVariation(models.Model):
         if self.item:
             self.item.event.get_cache().clear()
 
-    def check_quotas(self, ignored_quotas=None, count_waitinglist=True, _cache=None) -> Tuple[int, int]:
+    def check_quotas(self, ignored_quotas=None, _cache=None) -> Tuple[int, int]:
         """
         This method is used to determine whether this ItemVariation is currently
         available for sale in terms of quotas.
@@ -380,7 +324,6 @@ class ItemVariation(models.Model):
                                quotas will be ignored in the calculation. If this leads
                                to no quotas being checked at all, this method will return
                                unlimited availability.
-        :param count_waitinglist: If ``False``, waiting list entries will be ignored for quota calculation.
         :returns: any of the return codes of :py:meth:`Quota.availability()`.
         """
         check_quotas = set(self.quotas.all())
@@ -388,7 +331,7 @@ class ItemVariation(models.Model):
             check_quotas -= set(ignored_quotas)
         if not check_quotas:
             return Quota.AVAILABILITY_OK, sys.maxsize
-        return min([q.availability(count_waitinglist=count_waitinglist, _cache=_cache) for q in check_quotas],
+        return min([q.availability(_cache=_cache) for q in check_quotas],
                    key=lambda s: (s[0], s[1] if s[1] is not None else sys.maxsize))
 
     def __lt__(self, other):
@@ -397,49 +340,11 @@ class ItemVariation(models.Model):
         return self.position < other.position
 
 
-class ItemAddOn(models.Model):
-    """
-    An instance of this model indicates that buying a ticket of the time ``base_item``
-    allows you to add up to ``max_count`` items from the category ``addon_category``
-    to your order that will be associated with the base item.
-    """
-    base_item = models.ForeignKey(
-        Item,
-        related_name='addons'
-    )
-    addon_category = models.ForeignKey(
-        ItemCategory,
-        related_name='addon_to',
-        verbose_name=_('Category')
-    )
-    min_count = models.PositiveIntegerField(
-        default=0,
-        verbose_name=_('Minimum number')
-    )
-    max_count = models.PositiveIntegerField(
-        default=1,
-        verbose_name=_('Maximum number')
-    )
-    position = models.PositiveIntegerField(
-        default=0,
-        verbose_name=_("Position")
-    )
-
-    class Meta:
-        unique_together = (('base_item', 'addon_category'),)
-        ordering = ('position', 'pk')
-
-    def clean(self):
-        if self.max_count < self.min_count:
-            raise ValidationError(_('The minimum number needs to be lower than the maximum number.'))
-
-
 class Question(LoggedModel):
     """
-    A question is an input field that can be used to extend a ticket by custom information,
-    e.g. "Attendee age". The answers are found next to the position. The answers may be found
-    in QuestionAnswers, attached to OrderPositions/CartPositions. A question can allow one of
-    several input types, currently:
+    A question is an input field that can be used to extend a ticket
+    by custom information, e.g. "Attendee age". A question can allow one of several
+    input types, currently:
 
     * a number (``TYPE_NUMBER``)
     * a one-line string (``TYPE_STRING``)
@@ -629,7 +534,7 @@ class Quota(LoggedModel):
         if self.event:
             self.event.get_cache().clear()
 
-    def availability(self, now_dt: datetime=None, count_waitinglist=True, _cache=None) -> Tuple[int, int]:
+    def availability(self, now_dt: datetime=None, _cache=None) -> Tuple[int, int]:
         """
         This method is used to determine whether Items or ItemVariations belonging
         to this quota should currently be available for sale.
@@ -637,18 +542,14 @@ class Quota(LoggedModel):
         :returns: a tuple where the first entry is one of the ``Quota.AVAILABILITY_`` constants
                   and the second is the number of available tickets.
         """
-        if _cache and count_waitinglist is not _cache.get('_count_waitinglist', True):
-            _cache.clear()
-
         if _cache is not None and self.pk in _cache:
             return _cache[self.pk]
-        res = self._availability(now_dt, count_waitinglist)
+        res = self._availability(now_dt)
         if _cache is not None:
             _cache[self.pk] = res
-            _cache['_count_waitinglist'] = count_waitinglist
         return res
 
-    def _availability(self, now_dt: datetime=None, count_waitinglist=True):
+    def _availability(self, now_dt: datetime=None):
         now_dt = now_dt or now()
         size_left = self.size
         if size_left is None:
@@ -665,17 +566,12 @@ class Quota(LoggedModel):
 
         size_left -= self.count_blocking_vouchers(now_dt)
         if size_left <= 0:
-            return Quota.AVAILABILITY_RESERVED, 0
+            return Quota.AVAILABILITY_ORDERED, 0
 
         size_left -= self.count_in_cart(now_dt)
         if size_left <= 0:
             return Quota.AVAILABILITY_RESERVED, 0
 
-        if count_waitinglist:
-            size_left -= self.count_waiting_list_pending()
-            if size_left <= 0:
-                return Quota.AVAILABILITY_RESERVED, 0
-
         return Quota.AVAILABILITY_OK, size_left
 
     def count_blocking_vouchers(self, now_dt: datetime=None) -> int:
@@ -688,7 +584,6 @@ class Quota(LoggedModel):
             func = 'GREATEST'
 
         return Voucher.objects.filter(
-            Q(event=self.event) &
             Q(block_quota=True) &
             Q(Q(valid_until__isnull=True) | Q(valid_until__gte=now_dt)) &
             Q(Q(self._position_lookup) | Q(quota=self))
@@ -696,19 +591,11 @@ class Quota(LoggedModel):
             free=Sum(Func(F('max_usages') - F('redeemed'), 0, function=func))
         )['free'] or 0
 
-    def count_waiting_list_pending(self) -> int:
-        from pretix.base.models import WaitingListEntry
-        return WaitingListEntry.objects.filter(
-            Q(voucher__isnull=True) &
-            self._position_lookup
-        ).distinct().count()
-
     def count_in_cart(self, now_dt: datetime=None) -> int:
         from pretix.base.models import CartPosition
 
         now_dt = now_dt or now()
         return CartPosition.objects.filter(
-            Q(event=self.event) &
             Q(expires__gte=now_dt) &
             ~Q(
                 Q(voucher__isnull=False) & Q(voucher__block_quota=True)
@@ -722,14 +609,14 @@ class Quota(LoggedModel):
 
         # This query has beeen benchmarked against a Count('id', distinct=True) aggregate and won by a small margin.
         return OrderPosition.objects.filter(
-            self._position_lookup, order__status=Order.STATUS_PENDING, order__event=self.event
+            self._position_lookup, order__status=Order.STATUS_PENDING,
         ).values('id').distinct().count()
 
     def count_paid_orders(self):
         from pretix.base.models import Order, OrderPosition
 
         return OrderPosition.objects.filter(
-            self._position_lookup, order__status=Order.STATUS_PAID, order__event=self.event
+            self._position_lookup, order__status=Order.STATUS_PAID
         ).values('id').distinct().count()
 
     @cached_property

src/pretix/base/models/log.py

@@ -5,7 +5,6 @@ from django.contrib.contenttypes.models import ContentType
 from django.db import models
 from django.urls import reverse
 from django.utils.functional import cached_property
-from django.utils.html import escape
 from django.utils.translation import ugettext_lazy as _
 
 
@@ -67,7 +66,7 @@ class LogEntry(models.Model):
                     'organizer': self.event.organizer.slug,
                     'code': co.code
                 }),
-                'val': escape(co.code),
+                'val': co.code,
             }
         elif isinstance(co, Voucher):
             a_text = _('Voucher {val}…')
@@ -77,7 +76,7 @@ class LogEntry(models.Model):
                     'organizer': self.event.organizer.slug,
                     'voucher': co.id
                 }),
-                'val': escape(co.code[:6]),
+                'val': co.code[:6],
             }
         elif isinstance(co, Item):
             a_text = _('Product {val}')
@@ -87,7 +86,7 @@ class LogEntry(models.Model):
                     'organizer': self.event.organizer.slug,
                     'item': co.id
                 }),
-                'val': escape(co.name),
+                'val': co.name,
             }
         elif isinstance(co, Quota):
             a_text = _('Quota {val}')
@@ -97,7 +96,7 @@ class LogEntry(models.Model):
                     'organizer': self.event.organizer.slug,
                     'quota': co.id
                 }),
-                'val': escape(co.name),
+                'val': co.name,
             }
         elif isinstance(co, ItemCategory):
             a_text = _('Category {val}')
@@ -107,7 +106,7 @@ class LogEntry(models.Model):
                     'organizer': self.event.organizer.slug,
                     'category': co.id
                 }),
-                'val': escape(co.name),
+                'val': co.name,
             }
         elif isinstance(co, Question):
             a_text = _('Question {val}')
@@ -117,7 +116,7 @@ class LogEntry(models.Model):
                     'organizer': self.event.organizer.slug,
                     'question': co.id
                 }),
-                'val': escape(co.question),
+                'val': co.question,
             }
 
         if a_text and a_map:
@@ -131,6 +130,3 @@ class LogEntry(models.Model):
     @cached_property
     def parsed_data(self):
         return json.loads(self.data)
-
-    def delete(self, using=None, keep_parents=False):
-        raise TypeError("Logs cannot be deleted.")

src/pretix/base/models/orders.py

@@ -1,5 +1,4 @@
 import copy
-import json
 import os
 import string
 from datetime import datetime
@@ -8,11 +7,10 @@ from typing import List, Union
 
 from django.conf import settings
 from django.db import models
-from django.db.models import F, Sum
+from django.db.models import F
 from django.db.models.signals import post_delete
 from django.dispatch import receiver
 from django.utils.crypto import get_random_string
-from django.utils.functional import cached_property
 from django.utils.timezone import now
 from django.utils.translation import ugettext_lazy as _
 
@@ -184,10 +182,6 @@ class Order(LoggedModel):
     def __str__(self):
         return self.full_code
 
-    @cached_property
-    def meta_info_data(self):
-        return json.loads(self.meta_info)
-
     @property
     def full_code(self):
         """
@@ -196,10 +190,6 @@ class Order(LoggedModel):
         """
         return '{event}-{code}'.format(event=self.event.slug.upper(), code=self.code)
 
-    @property
-    def changable(self):
-        return self.status in (Order.STATUS_PAID, Order.STATUS_PENDING)
-
     def save(self, *args, **kwargs):
         if not self.code:
             self.assign_code()
@@ -221,18 +211,6 @@ class Order(LoggedModel):
         else:
             self.payment_fee_tax_value = Decimal('0.00')
 
-    @property
-    def payment_fee_net(self):
-        return self.payment_fee - self.payment_fee_tax_value
-
-    @cached_property
-    def tax_total(self):
-        return (self.positions.aggregate(s=Sum('tax_value'))['s'] or 0) + self.payment_fee_tax_value
-
-    @property
-    def net_total(self):
-        return self.total - self.tax_total
-
     @staticmethod
     def normalize_code(code):
         tr = str.maketrans({
@@ -300,7 +278,6 @@ class Order(LoggedModel):
         if self.event.settings.get('payment_term_last'):
             if now() > self.event.payment_term_last:
                 return error_messages['late_lastdate']
-
         if self.status == self.STATUS_PENDING:
             return True
         if not self.event.settings.get('payment_term_accept_late'):
@@ -399,8 +376,6 @@ class AbstractPosition(models.Model):
     :type price: decimal.Decimal
     :param attendee_name: The attendee's name, if entered.
     :type attendee_name: str
-    :param attendee_email: The attendee's email, if entered.
-    :type attendee_email: str
     :param voucher: A voucher that has been applied to this sale
     :type voucher: Voucher
     """
@@ -425,17 +400,9 @@ class AbstractPosition(models.Model):
         blank=True, null=True,
         help_text=_("Empty, if this product is not an admission ticket")
     )
-    attendee_email = models.EmailField(
-        verbose_name=_("Attendee email"),
-        blank=True, null=True,
-        help_text=_("Empty, if this product is not an admission ticket")
-    )
     voucher = models.ForeignKey(
         'Voucher', null=True, blank=True
     )
-    addon_to = models.ForeignKey(
-        'self', null=True, blank=True, on_delete=models.CASCADE, related_name='addons'
-    )
 
     class Meta:
         abstract = True
@@ -460,10 +427,6 @@ class AbstractPosition(models.Model):
             else:
                 q.answer = ""
 
-    @property
-    def net_price(self):
-        return self.price - self.tax_value
-
 
 class OrderPosition(AbstractPosition):
     """
@@ -494,26 +457,19 @@ class OrderPosition(AbstractPosition):
     class Meta:
         verbose_name = _("Order position")
         verbose_name_plural = _("Order positions")
-        ordering = ("positionid", "id")
 
     @classmethod
     def transform_cart_positions(cls, cp: List, order) -> list:
         from . import Voucher
 
         ops = []
-        cp_mapping = {}
-        # The sorting key ensures that all addons come directly after the position they refer to
-        for i, cartpos in enumerate(sorted(cp, key=lambda c: (c.addon_to_id or c.pk, c.addon_to_id or 0))):
+        for i, cartpos in enumerate(cp):
             op = OrderPosition(order=order)
             for f in AbstractPosition._meta.fields:
-                if f.name == 'addon_to':
-                    setattr(op, f.name, cp_mapping.get(cartpos.addon_to_id))
-                else:
-                    setattr(op, f.name, getattr(cartpos, f.name))
+                setattr(op, f.name, getattr(cartpos, f.name))
             op._calculate_tax()
             op.positionid = i + 1
             op.save()
-            cp_mapping[cartpos.pk] = op
             for answ in cartpos.answers.all():
                 answ.orderposition = op
                 answ.cartposition = None

src/pretix/base/models/organizer.py

@@ -3,16 +3,17 @@ import string
 from django.core.validators import RegexValidator
 from django.db import models
 from django.utils.crypto import get_random_string
+from django.utils.functional import cached_property
 from django.utils.translation import ugettext_lazy as _
 
 from pretix.base.models.base import LoggedModel
+from pretix.base.settings import SettingsProxy
 from pretix.base.validators import OrganizerSlugBlacklistValidator
 
-from ..settings import settings_hierarkey
 from .auth import User
+from .settings import OrganizerSetting
 
 
-@settings_hierarkey.add(cache_namespace='organizer')
 class Organizer(LoggedModel):
     """
     This model represents an entity organizing events, e.g. a company, institution,
@@ -42,6 +43,8 @@ class Organizer(LoggedModel):
         ],
         verbose_name=_("Short form"),
     )
+    permitted = models.ManyToManyField(User, through='OrganizerPermission',
+                                       related_name="organizers")
 
     class Meta:
         verbose_name = _("Organizer")
@@ -56,6 +59,14 @@ class Organizer(LoggedModel):
         self.get_cache().clear()
         return obj
 
+    @cached_property
+    def settings(self) -> SettingsProxy:
+        """
+        Returns an object representing this organizer's settings
+        """
+        from pretix.base.settings import GlobalSettingsObject
+        return SettingsProxy(self, type=OrganizerSetting, parent=GlobalSettingsObject())
+
     def get_cache(self) -> "pretix.base.cache.ObjectRelatedCache":
         """
         Returns an :py:class:`ObjectRelatedCache` object. This behaves equivalent to
@@ -72,131 +83,39 @@ def generate_invite_token():
     return get_random_string(length=32, allowed_chars=string.ascii_lowercase + string.digits)
 
 
-class Team(LoggedModel):
+class OrganizerPermission(models.Model):
     """
-    A team is a collection of people given certain access rights to one or more events of an organizer.
+    The relation between an Organizer and a User who has permissions to
+    access an organizer profile.
 
-    :param name: The name of this team
-    :type name: str
-    :param organizer: The organizer this team belongs to
+    :param organizer: The organizer this relation refers to
     :type organizer: Organizer
-    :param members: A set of users who belong to this team
-    :param all_events: Whether this team has access to all events of this organizer
-    :type all_events: bool
-    :param limit_events: A set of events this team has access to. Irrelevant if ``all_events`` is ``True``.
-    :param can_create_events: Whether or not the members can create new events with this organizer account.
+    :param user: The user this set of permissions is valid for
+    :type user: User
+    :param can_create_events: Whether or not this user can create new events with this
+                              organizer account.
     :type can_create_events: bool
-    :param can_change_teams: If ``True``, the members can change the teams of this organizer account.
-    :type can_change_teams: bool
-    :param can_change_organizer_settings: If ``True``, the members can change the settings of this organizer account.
-    :type can_change_organizer_settings: bool
-    :param can_change_event_settings: If ``True``, the members can change the settings of the associated events.
-    :type can_change_event_settings: bool
-    :param can_change_items: If ``True``, the members can change and add items and related objects for the associated events.
-    :type can_change_items: bool
-    :param can_view_orders: If ``True``, the members can inspect details of all orders of the associated events.
-    :type can_view_orders: bool
-    :param can_change_orders: If ``True``, the members can change details of orders of the associated events.
-    :type can_change_orders: bool
-    :param can_view_vouchers: If ``True``, the members can inspect details of all vouchers of the associated events.
-    :type can_view_vouchers: bool
-    :param can_change_vouchers: If ``True``, the members can change and create vouchers for the associated events.
-    :type can_change_vouchers: bool
     """
-    organizer = models.ForeignKey(Organizer, related_name="teams", on_delete=models.CASCADE)
-    name = models.CharField(max_length=190, verbose_name=_("Team name"))
-    members = models.ManyToManyField(User, related_name="teams", verbose_name=_("Team members"))
-    all_events = models.BooleanField(default=False, verbose_name=_("All events (including newly created ones)"))
-    limit_events = models.ManyToManyField('Event', verbose_name=_("Limit to events"), blank=True)
 
+    organizer = models.ForeignKey(Organizer, related_name="user_perms", on_delete=models.CASCADE)
+    user = models.ForeignKey(User, related_name="organizer_perms", on_delete=models.CASCADE, null=True, blank=True)
+    invite_email = models.EmailField(null=True, blank=True)
+    invite_token = models.CharField(default=generate_invite_token, max_length=64, null=True, blank=True)
     can_create_events = models.BooleanField(
-        default=False,
+        default=True,
         verbose_name=_("Can create events"),
     )
-    can_change_teams = models.BooleanField(
-        default=False,
-        verbose_name=_("Can change teams and permissions"),
-    )
-    can_change_organizer_settings = models.BooleanField(
-        default=False,
-        verbose_name=_("Can change organizer settings")
+    can_change_permissions = models.BooleanField(
+        default=True,
+        verbose_name=_("Can change permissions"),
     )
 
-    can_change_event_settings = models.BooleanField(
-        default=False,
-        verbose_name=_("Can change event settings")
-    )
-    can_change_items = models.BooleanField(
-        default=False,
-        verbose_name=_("Can change product settings")
-    )
-    can_view_orders = models.BooleanField(
-        default=False,
-        verbose_name=_("Can view orders")
-    )
-    can_change_orders = models.BooleanField(
-        default=False,
-        verbose_name=_("Can change orders")
-    )
-    can_view_vouchers = models.BooleanField(
-        default=False,
-        verbose_name=_("Can view vouchers")
-    )
-    can_change_vouchers = models.BooleanField(
-        default=False,
-        verbose_name=_("Can change vouchers")
-    )
+    class Meta:
+        verbose_name = _("Organizer permission")
+        verbose_name_plural = _("Organizer permissions")
 
     def __str__(self) -> str:
         return _("%(name)s on %(object)s") % {
-            'name': str(self.name),
+            'name': str(self.user),
             'object': str(self.organizer),
         }
-
-    def permission_set(self) -> set:
-        attribs = dir(self)
-        return {
-            a for a in attribs if a.startswith('can_') and self.has_permission(a)
-        }
-
-    @property
-    def can_change_settings(self):  # Legacy compatiblilty
-        return self.can_change_event_settings
-
-    def has_permission(self, perm_name):
-        try:
-            return getattr(self, perm_name)
-        except AttributeError:
-            raise ValueError('Invalid required permission: %s' % perm_name)
-
-    def permission_for_event(self, event):
-        if self.all_events:
-            return event.organizer_id == self.organizer_id
-        else:
-            return self.limit_events.filter(pk=event.pk).exists()
-
-    class Meta:
-        verbose_name = _("Team")
-        verbose_name_plural = _("Teams")
-
-
-class TeamInvite(models.Model):
-    """
-    A TeamInvite represents someone who has been invited to a team but hasn't accept the invitation
-    yet.
-
-    :param team: The team the person is invited to
-    :type team: Team
-    :param email: The email the invite has been sent to
-    :type email: str
-    :param token: The secret required to redeem the invite
-    :type token: str
-    """
-    team = models.ForeignKey(Team, related_name="invites", on_delete=models.CASCADE)
-    email = models.EmailField(null=True, blank=True)
-    token = models.CharField(default=generate_invite_token, max_length=64, null=True, blank=True)
-
-    def __str__(self) -> str:
-        return _("Invite to team '{team}' for '{email}'").format(
-            team=str(self.team), email=self.email
-        )

src/pretix/base/models/settings.py

@@ -0,0 +1,34 @@
+from django.db import models
+
+
+class GlobalSetting(models.Model):
+    """
+    A global setting is a key-value setting which can be set for a
+    pretix instance. It will be inherited by all events and organizers.
+    It is filled via the register_global_settings signal.
+    """
+    key = models.CharField(max_length=255, primary_key=True)
+    value = models.TextField()
+
+    def __init__(self, *args, object=None, **kwargs):
+        super().__init__(*args, **kwargs)
+
+
+class OrganizerSetting(models.Model):
+    """
+    An organizer setting is a key-value setting which can be set for an
+    organizer. It will be inherited by the events of this organizer
+    """
+    object = models.ForeignKey('Organizer', related_name='setting_objects', on_delete=models.CASCADE)
+    key = models.CharField(max_length=255)
+    value = models.TextField()
+
+
+class EventSetting(models.Model):
+    """
+    An event setting is a key-value setting which can be set for a
+    specific event
+    """
+    object = models.ForeignKey('Event', related_name='setting_objects', on_delete=models.CASCADE)
+    key = models.CharField(max_length=255)
+    value = models.TextField()

src/pretix/base/models/vouchers.py

@@ -210,11 +210,11 @@ class Voucher(LoggedModel):
         Returns whether this voucher applies to a given item (and optionally
         a variation).
         """
-        if self.quota_id:
-            return item.quotas.filter(pk=self.quota_id).exists()
-        if self.item_id and not self.variation_id:
-            return self.item_id == item.pk
-        return (self.item_id == item.pk) and (variation and self.variation_id == variation.pk)
+        if self.quota:
+            return item.quotas.filter(pk=self.quota.pk).exists()
+        if self.item and not self.variation:
+            return self.item == item
+        return (self.item == item) and (self.variation == variation)
 
     def is_active(self):
         """

src/pretix/base/models/waitinglist.py

@@ -1,130 +0,0 @@
-from datetime import timedelta
-
-from django.core.exceptions import ValidationError
-from django.db import models, transaction
-from django.utils.timezone import now
-from django.utils.translation import ugettext_lazy as _
-
-from pretix.base.i18n import language
-from pretix.base.models import Voucher
-from pretix.base.services.mail import mail
-from pretix.multidomain.urlreverse import build_absolute_uri
-
-from .base import LoggedModel
-from .event import Event
-from .items import Item, ItemVariation
-
-
-class WaitingListException(Exception):
-    pass
-
-
-class WaitingListEntry(LoggedModel):
-    event = models.ForeignKey(
-        Event,
-        on_delete=models.CASCADE,
-        related_name="waitinglistentries",
-        verbose_name=_("Event"),
-    )
-    created = models.DateTimeField(
-        verbose_name=_("On waiting list since"),
-        auto_now_add=True
-    )
-    email = models.EmailField(
-        verbose_name=_("E-mail address")
-    )
-    voucher = models.ForeignKey(
-        'Voucher',
-        verbose_name=_("Assigned voucher"),
-        null=True, blank=True
-    )
-    item = models.ForeignKey(
-        Item, related_name='waitinglistentries',
-        verbose_name=_("Product"),
-        help_text=_(
-            "The product the user waits for."
-        )
-    )
-    variation = models.ForeignKey(
-        ItemVariation, related_name='waitinglistentries',
-        null=True, blank=True,
-        verbose_name=_("Product variation"),
-        help_text=_(
-            "The variation of the product selected above."
-        )
-    )
-    locale = models.CharField(
-        max_length=190,
-        default='en'
-    )
-
-    class Meta:
-        verbose_name = _("Waiting list entry")
-        verbose_name_plural = _("Waiting list entries")
-        ordering = ['created']
-
-    def __str__(self):
-        return '%s waits for %s' % (str(self.email), str(self.item))
-
-    def clean(self):
-        if WaitingListEntry.objects.filter(
-            item=self.item, variation=self.variation, email=self.email, voucher__isnull=True
-        ).exclude(pk=self.pk).exists():
-            raise ValidationError(_('You are already on this waiting list! We will notify '
-                                    'you as soon as we have a ticket available for you.'))
-        if not self.variation and self.item.has_variations:
-            raise ValidationError(_('Please select a specific variation of this product.'))
-
-    def send_voucher(self, quota_cache=None, user=None):
-        availability = (
-            self.variation.check_quotas(count_waitinglist=False, _cache=quota_cache)
-            if self.variation
-            else self.item.check_quotas(count_waitinglist=False, _cache=quota_cache)
-        )
-        if availability[1] < 1:
-            raise WaitingListException(_('This product is currently not available.'))
-        if self.voucher:
-            raise WaitingListException(_('A voucher has already been sent to this person.'))
-
-        with transaction.atomic():
-            v = Voucher.objects.create(
-                event=self.event,
-                max_usages=1,
-                valid_until=now() + timedelta(hours=self.event.settings.waiting_list_hours),
-                item=self.item,
-                variation=self.variation,
-                tag='waiting-list',
-                comment=_('Automatically created from waiting list entry for {email}').format(
-                    email=self.email
-                ),
-                block_quota=True,
-            )
-            v.log_action('pretix.voucher.added.waitinglist', {
-                'item': self.item.pk,
-                'variation': self.variation.pk if self.variation else None,
-                'tag': 'waiting-list',
-                'block_quota': True,
-                'valid_until': v.valid_until.isoformat(),
-                'max_usages': 1,
-                'email': self.email,
-                'waitinglistentry': self.pk
-            }, user=user)
-            self.log_action('pretix.waitinglist.voucher', user=user)
-            self.voucher = v
-            self.save()
-
-        with language(self.locale):
-            mail(
-                self.email,
-                _('You have been selected from the waitinglist for {event}').format(event=str(self.event)),
-                self.event.settings.mail_text_waiting_list,
-                {
-                    'event': self.event.name,
-                    'url': build_absolute_uri(self.event, 'presale:event.redeem') + '?voucher=' + self.voucher.code,
-                    'code': self.voucher.code,
-                    'product': str(self.item) + (' - ' + str(self.variation) if self.variation else ''),
-                    'hours': self.event.settings.waiting_list_hours,
-                },
-                self.event,
-                locale=self.locale
-            )

src/pretix/base/payment.py

@@ -1,7 +1,7 @@
 from collections import OrderedDict
 from datetime import date
 from decimal import Decimal
-from typing import Any, Dict, Union
+from typing import Any, Dict
 
 import pytz
 from django import forms
@@ -12,10 +12,9 @@ from django.http import HttpRequest
 from django.template.loader import get_template
 from django.utils.timezone import now
 from django.utils.translation import ugettext_lazy as _
-from i18nfield.forms import I18nFormField, I18nTextarea
-from i18nfield.strings import LazyI18nString
 
 from pretix.base.decimal import round_decimal
+from pretix.base.i18n import I18nFormField, I18nTextarea, LazyI18nString
 from pretix.base.models import Event, Order, Quota
 from pretix.base.settings import SettingsSandbox
 from pretix.base.signals import register_payment_providers
@@ -150,9 +149,9 @@ class BasePaymentProvider:
              forms.BooleanField(
                  label=_('Calculate the fee from the total value including the fee.'),
                  help_text=_('We recommend you to enable this if you want your users to pay the payment fees of your '
-                             'payment provider. <a href="{docs_url}" target="_blank">Click here '
+                             'payment provider. <a href="/control/help/payment/fee_reverse" target="_blank">Click here '
                              'for detailled information on what this does.</a> Don\'t forget to set the correct fees '
-                             'above!').format(docs_url='https://docs.pretix.eu/en/latest/user/payments/fees.html'),
+                             'above!'),
                  required=False
              )),
             ('_invoice_text',
@@ -266,7 +265,7 @@ class BasePaymentProvider:
         """
         raise NotImplementedError()  # NOQA
 
-    def checkout_prepare(self, request: HttpRequest, cart: Dict[str, Any]) -> Union[bool, str]:
+    def checkout_prepare(self, request: HttpRequest, cart: Dict[str, Any]) -> "bool|str":
         """
         Will be called after the user selects this provider as his payment method.
         If you provided a form to the user to enter payment data, this method should
@@ -338,7 +337,9 @@ class BasePaymentProvider:
         The default implementation just returns ``None`` and therefore leaves the
         order unpaid. The user will be redirected to the order's detail page by default.
 
-        On errors, you should raise a ``PaymentException``.
+        On errors, you should use Django's message framework to display an error message
+        to the user.
+
         :param order: The order object
         """
         return None
@@ -394,14 +395,14 @@ class BasePaymentProvider:
         """
         return False
 
-    def retry_prepare(self, request: HttpRequest, order: Order) -> Union[bool, str]:
+    def retry_prepare(self, request: HttpRequest, order: Order) -> "bool|str":
         """
         Deprecated, use order_prepare instead
         """
         raise DeprecationWarning('retry_prepare is deprecated, use order_prepare instead')
         return self.order_prepare(request, order)
 
-    def order_prepare(self, request: HttpRequest, order: Order) -> Union[bool, str]:
+    def order_prepare(self, request: HttpRequest, order: Order) -> "bool|str":
         """
         Will be called if the user retries to pay an unpaid order (after the user filled in
         e.g. the form returned by :py:meth:`payment_form`) or if the user changes the payment
@@ -409,10 +410,6 @@ class BasePaymentProvider:
 
         It should return and report errors the same way as :py:meth:`checkout_prepare`, but
         receives an ``Order`` object instead of a cart object.
-
-        Note: The ``Order`` object given to this method might be different from the version
-        stored in the database as it's total will already contain the payment fee for the
-        new payment method.
         """
         form = self.payment_form(request)
         if form.is_valid():
@@ -462,7 +459,7 @@ class BasePaymentProvider:
         return '<div class="alert alert-warning">%s</div>' % _('The money can not be automatically refunded, '
                                                                'please transfer the money back manually.')
 
-    def order_control_refund_perform(self, request: HttpRequest, order: Order) -> Union[bool, str]:
+    def order_control_refund_perform(self, request: HttpRequest, order: Order) -> "bool|str":
         """
         Will be called if the event administrator confirms the refund.
 
@@ -486,10 +483,6 @@ class BasePaymentProvider:
                                     'back to the buyer manually.'))
 
 
-class PaymentException(Exception):
-    pass
-
-
 class FreeOrderProvider(BasePaymentProvider):
 
     @property
@@ -518,7 +511,7 @@ class FreeOrderProvider(BasePaymentProvider):
         try:
             mark_order_paid(order, 'free', send_mail=False)
         except Quota.QuotaExceededException as e:
-            raise PaymentException(str(e))
+            messages.error(request, str(e))
 
     @property
     def settings_form_fields(self) -> dict:
@@ -527,7 +520,7 @@ class FreeOrderProvider(BasePaymentProvider):
     def order_control_refund_render(self, order: Order) -> str:
         return ''
 
-    def order_control_refund_perform(self, request: HttpRequest, order: Order) -> Union[bool, str]:
+    def order_control_refund_perform(self, request: HttpRequest, order: Order) -> "bool|str":
         """
         Will be called if the event administrator confirms the refund.
 

src/pretix/base/services/async.py

@@ -15,50 +15,26 @@ import time
 from django.conf import settings
 from django.db import transaction
 
-from pretix.base.metrics import (
-    pretix_task_duration_seconds, pretix_task_runs_total,
-)
 from pretix.celery_app import app
 
 
 class ProfiledTask(app.Task):
+
     def __call__(self, *args, **kwargs):
 
         if settings.PROFILING_RATE > 0 and random.random() < settings.PROFILING_RATE / 100:
             profiler = cProfile.Profile()
             profiler.enable()
-            t0 = time.perf_counter()
+            starttime = time.time()
             ret = super().__call__(*args, **kwargs)
-            tottime = time.perf_counter() - t0
             profiler.disable()
+            tottime = time.time() - starttime
             profiler.dump_stats(os.path.join(settings.PROFILE_DIR, '{time:.0f}_{tottime:.3f}_celery_{t}.pstat'.format(
                 t=self.name, tottime=tottime, time=time.time()
             )))
+            return ret
         else:
-            t0 = time.perf_counter()
-            ret = super().__call__(*args, **kwargs)
-            tottime = time.perf_counter() - t0
-
-        if settings.METRICS_ENABLED:
-            pretix_task_duration_seconds.observe(tottime, task_name=self.name)
-        return ret
-
-    def on_failure(self, exc, task_id, args, kwargs, einfo):
-        if settings.METRICS_ENABLED:
-            expected = False
-            for t in self.throws:
-                if isinstance(exc, t):
-                    expected = True
-                    break
-            pretix_task_runs_total.inc(1, task_name=self.name, status="expected-error" if expected else "error")
-
-        return super().on_failure(exc, task_id, args, kwargs, einfo)
-
-    def on_success(self, retval, task_id, args, kwargs):
-        if settings.METRICS_ENABLED:
-            pretix_task_runs_total.inc(1, task_name=self.name, status="success")
-
-        return super().on_success(retval, task_id, args, kwargs)
+            return super().__call__(*args, **kwargs)
 
 
 class TransactionAwareTask(ProfiledTask):

src/pretix/base/services/cart.py

@@ -1,18 +1,14 @@
-from collections import Counter, defaultdict, namedtuple
-from datetime import timedelta
+from datetime import datetime, timedelta
 from decimal import Decimal
 from typing import List, Optional
 
 from celery.exceptions import MaxRetriesExceededError
-from django.db import transaction
 from django.db.models import Q
-from django.utils.timezone import now
 from django.utils.translation import ugettext as _
 
-from pretix.base.decimal import round_decimal
-from pretix.base.i18n import LazyLocaleException, language
+from pretix.base.i18n import LazyLocaleException
 from pretix.base.models import (
-    CartPosition, Event, Item, ItemVariation, Voucher,
+    CartPosition, Event, Item, ItemVariation, Quota, Voucher,
 )
 from pretix.base.services.async import ProfiledTask
 from pretix.base.services.locking import LockTimeoutException
@@ -27,17 +23,12 @@ error_messages = {
     'busy': _('We were not able to process your request completely as the '
               'server was too busy. Please try again.'),
     'empty': _('You did not select any products.'),
-    'unknown_position': _('Unknown cart position.'),
     'not_for_sale': _('You selected a product which is not available for sale.'),
     'unavailable': _('Some of the products you selected are no longer available. '
                      'Please see below for details.'),
     'in_part': _('Some of the products you selected are no longer available in '
                  'the quantity you selected. Please see below for details.'),
     'max_items': _("You cannot select more than %s items per order."),
-    'max_items_per_product': _("You cannot select more than %(max)s items of the product %(product)s."),
-    'min_items_per_product': _("You need to select at least %(min)s items of the product %(product)s."),
-    'min_items_per_product_removed': _("We removed %(product)s from your cart as you can not buy less than "
-                                       "%(min)s items of it."),
     'not_started': _('The presale period for this event has not yet started.'),
     'ended': _('The presale period has ended.'),
     'price_too_high': _('The entered price is to high.'),
@@ -49,590 +40,238 @@ error_messages = {
     'voucher_expired': _('This voucher is expired.'),
     'voucher_invalid_item': _('This voucher is not valid for this product.'),
     'voucher_required': _('You need a valid voucher code to order this product.'),
-    'addon_invalid_base': _('You can not select an add-on for the selected product.'),
-    'addon_duplicate_item': _('You can not select two variations of the same add-on product.'),
-    'addon_max_count': _('You can select at most %(max)s add-ons from the category %(cat)s for the product %(base)s.'),
-    'addon_min_count': _('You need to select at least %(min)s add-ons from the category %(cat)s for the '
-                         'product %(base)s.'),
-    'addon_only': _('One of the products you selected can only be bought as an add-on to another project.'),
 }
 
 
-class CartManager:
-    AddOperation = namedtuple('AddOperation', ('count', 'item', 'variation', 'price', 'voucher', 'quotas',
-                                               'addon_to'))
-    RemoveOperation = namedtuple('RemoveOperation', ('position',))
-    ExtendOperation = namedtuple('ExtendOperation', ('position', 'count', 'item', 'variation', 'price', 'voucher',
-                                                     'quotas'))
-    order = {
-        RemoveOperation: 10,
-        ExtendOperation: 20,
-        AddOperation: 30
-    }
+def _extend_existing(event: Event, cart_id: str, expiry: datetime, now_dt: datetime) -> None:
+    # Extend this user's cart session to 30 minutes from now to ensure all items in the
+    # cart expire at the same time
+    # We can extend the reservation of items which are not yet expired without risk
+    CartPosition.objects.filter(
+        Q(cart_id=cart_id) & Q(event=event) & Q(expires__gt=now_dt)
+    ).update(expires=expiry)
 
-    def __init__(self, event: Event, cart_id: str):
-        self.event = event
-        self.cart_id = cart_id
-        self.now_dt = now()
-        self._operations = []
-        self._quota_diff = Counter()
-        self._voucher_use_diff = Counter()
-        self._items_cache = {}
-        self._variations_cache = {}
-        self._expiry = None
 
-    @property
-    def positions(self):
-        return CartPosition.objects.filter(
-            Q(cart_id=self.cart_id) & Q(event=self.event)
-        ).select_related('item')
+def _re_add_expired_positions(items: List[dict], event: Event, cart_id: str, now_dt: datetime) -> List[CartPosition]:
+    positions = set()
+    # For items that are already expired, we have to delete and re-add them, as they might
+    # be no longer available or prices might have changed. Sorry!
+    expired = CartPosition.objects.filter(
+        Q(cart_id=cart_id) & Q(event=event) & Q(expires__lte=now_dt)
+    )
+    for cp in expired:
+        items.insert(0, {
+            'item': cp.item_id,
+            'variation': cp.variation_id,
+            'count': 1,
+            'price': cp.price,
+            'cp': cp,
+            'voucher': cp.voucher.code if cp.voucher else None
+        })
+        positions.add(cp)
+    return positions
 
-    def _calculate_expiry(self):
-        self._expiry = self.now_dt + timedelta(minutes=self.event.settings.get('reservation_time', as_type=int))
 
-    def _check_presale_dates(self):
-        if self.event.presale_start and self.now_dt < self.event.presale_start:
-            raise CartError(error_messages['not_started'])
-        if self.event.presale_end and self.now_dt > self.event.presale_end:
-            raise CartError(error_messages['ended'])
+def _delete_expired(expired: List[CartPosition], now_dt: datetime) -> None:
+    for cp in expired:
+        if cp.expires <= now_dt:
+            cp.delete()
 
-    def _extend_expiry_of_valid_existing_positions(self):
-        # Extend this user's cart session to ensure all items in the cart expire at the same time
-        # We can extend the reservation of items which are not yet expired without risk
-        self.positions.filter(expires__gt=self.now_dt).update(expires=self._expiry)
 
-    def _delete_expired(self, expired: List[CartPosition]):
-        for cp in expired:
-            if cp.expires <= self.now_dt:
-                cp.delete()
+def _check_date(event: Event, now_dt: datetime) -> None:
+    if event.presale_start and now_dt < event.presale_start:
+        raise CartError(error_messages['not_started'])
+    if event.presale_end and now_dt > event.presale_end:
+        raise CartError(error_messages['ended'])
 
-    def _update_items_cache(self, item_ids: List[int], variation_ids: List[int]):
-        self._items_cache.update(
-            {
-                i.pk: i
-                for i
-                in self.event.items.select_related('category').prefetch_related(
-                    'addons', 'addons__addon_category', 'quotas'
-                ).filter(
-                    id__in=[i for i in item_ids if i and i not in self._items_cache]
+
+def _add_new_items(event: Event, items: List[dict],
+                   cart_id: str, expiry: datetime, now_dt: datetime) -> Optional[str]:
+    err = None
+
+    # Fetch items from the database
+    items_query = Item.objects.filter(event=event, id__in=[i['item'] for i in items]).prefetch_related(
+        "quotas")
+    items_cache = {i.id: i for i in items_query}
+    variations_query = ItemVariation.objects.filter(
+        item__event=event,
+        id__in=[i['variation'] for i in items if i['variation'] is not None]
+    ).select_related("item", "item__event").prefetch_related("quotas")
+    variations_cache = {v.id: v for v in variations_query}
+
+    for i in items:
+        # Check whether the specified items are part of what we just fetched from the database
+        # If they are not, the user supplied item IDs which either do not exist or belong to
+        # a different event
+        if i['item'] not in items_cache or (i['variation'] is not None and i['variation'] not in variations_cache):
+            err = err or error_messages['not_for_sale']
+            continue
+
+        item = items_cache[i['item']]
+        variation = variations_cache[i['variation']] if i['variation'] is not None else None
+
+        # Check whether a voucher has been provided
+        voucher = None
+        if i.get('voucher'):
+            try:
+                voucher = Voucher.objects.get(code=i.get('voucher').strip(), event=event)
+                if voucher.redeemed >= voucher.max_usages:
+                    return error_messages['voucher_redeemed']
+                if voucher.valid_until is not None and voucher.valid_until < now_dt:
+                    return error_messages['voucher_expired']
+                if not voucher.applies_to(item, variation):
+                    return error_messages['voucher_invalid_item']
+
+                redeemed_in_carts = CartPosition.objects.filter(
+                    Q(voucher=voucher) & Q(event=event) &
+                    (Q(expires__gte=now_dt) | Q(cart_id=cart_id))
                 )
-            }
-        )
-        self._variations_cache.update(
-            {v.pk: v for v in
-             ItemVariation.objects.filter(item__event=self.event).prefetch_related(
-                 'quotas'
-             ).select_related('item', 'item__event').filter(
-                 id__in=[i for i in variation_ids if i and i not in self._variations_cache]
-             )}
-        )
+                if 'cp' in i:
+                    redeemed_in_carts = redeemed_in_carts.exclude(pk=i['cp'].pk)
+                v_avail = voucher.max_usages - voucher.redeemed - redeemed_in_carts.count()
 
-    def _check_max_cart_size(self):
-        cartsize = self.positions.filter(addon_to__isnull=True).count()
-        cartsize += sum([op.count for op in self._operations if isinstance(op, self.AddOperation) and not op.addon_to])
-        cartsize -= len([1 for op in self._operations if isinstance(op, self.RemoveOperation) if
-                         not op.position.addon_to_id])
-        if cartsize > int(self.event.settings.max_items_per_order):
-            # TODO: i18n plurals
-            raise CartError(_(error_messages['max_items']) % (self.event.settings.max_items_per_order,))
+                if v_avail < 1:
+                    return error_messages['voucher_redeemed']
+                if i['count'] > v_avail:
+                    return error_messages['voucher_redeemed_partial'] % v_avail
 
-    def _check_item_constraints(self, op):
-        if isinstance(op, self.AddOperation) or isinstance(op, self.ExtendOperation):
-            if op.item.require_voucher and op.voucher is None:
-                raise CartError(error_messages['voucher_required'])
+            except Voucher.DoesNotExist:
+                return error_messages['voucher_invalid']
 
-            if op.item.hide_without_voucher and (op.voucher is None or op.voucher.item is None or op.voucher.item.pk != op.item.pk):
-                raise CartError(error_messages['voucher_required'])
+        # Fetch all quotas. If there are no quotas, this item is not allowed to be sold.
+        quotas = list(item.quotas.all()) if variation is None else list(variation.quotas.all())
 
-            if not op.item.is_available() or (op.variation and not op.variation.active):
-                raise CartError(error_messages['unavailable'])
+        if voucher and voucher.quota and voucher.quota.pk not in [q.pk for q in quotas]:
+            return error_messages['voucher_invalid_item']
 
-            if op.voucher and not op.voucher.applies_to(op.item, op.variation):
-                raise CartError(error_messages['voucher_invalid_item'])
+        if item.require_voucher and voucher is None:
+            return error_messages['voucher_required']
 
-        if isinstance(op, self.AddOperation):
-            if op.item.category and op.item.category.is_addon and not op.addon_to:
-                raise CartError(error_messages['addon_only'])
+        if item.hide_without_voucher and (voucher is None or voucher.item is None or voucher.item.pk != item.pk):
+            return error_messages['voucher_required']
 
-            if op.item.max_per_order or op.item.min_per_order:
-                new_total = (
-                    len([1 for p in self.positions if p.item_id == op.item.pk]) +
-                    sum([_op.count for _op in self._operations
-                         if isinstance(_op, self.AddOperation) and _op.item == op.item]) +
-                    op.count -
-                    len([1 for _op in self._operations
-                         if isinstance(_op, self.RemoveOperation) and _op.position.item_id == op.item.pk])
-                )
+        if len(quotas) == 0 or not item.is_available() or (variation and not variation.active):
+            err = err or error_messages['unavailable']
+            continue
 
-            if op.item.max_per_order and new_total > op.item.max_per_order:
-                raise CartError(
-                    _(error_messages['max_items_per_product']) % {
-                        'max': op.item.max_per_order,
-                        'product': op.item.name
-                    }
-                )
+        # Check that all quotas allow us to buy i['count'] instances of the object
+        quota_ok = i['count']
+        if not voucher or (not voucher.allow_ignore_quota and not voucher.block_quota):
+            for quota in quotas:
+                avail = quota.availability()
+                if avail[1] is not None and avail[1] < i['count']:
+                    # This quota is not available or less than i['count'] items are left, so we have to
+                    # reduce the number of bought items
+                    if avail[0] != Quota.AVAILABILITY_OK:
+                        err = err or error_messages['unavailable']
+                    else:
+                        err = err or error_messages['in_part']
+                    quota_ok = min(quota_ok, avail[1])
 
-            if op.item.min_per_order and new_total < op.item.min_per_order:
-                raise CartError(
-                    _(error_messages['min_items_per_product']) % {
-                        'min': op.item.min_per_order,
-                        'product': op.item.name
-                    }
-                )
-
-    def _get_price(self, item: Item, variation: Optional[ItemVariation],
-                   voucher: Optional[Voucher], custom_price: Optional[Decimal]):
         price = item.default_price if variation is None else (
-            variation.default_price if variation.default_price is not None else item.default_price
-        )
+            variation.default_price if variation.default_price is not None else item.default_price)
         if voucher:
             price = voucher.calculate_price(price)
 
-        if item.free_price and custom_price is not None and custom_price != "":
+        if item.free_price and 'price' in i and i['price'] is not None and i['price'] != "":
+            custom_price = i['price']
             if not isinstance(custom_price, Decimal):
                 custom_price = Decimal(custom_price.replace(",", "."))
             if custom_price > 100000000:
-                raise CartError(error_messages['price_too_high'])
-            if self.event.settings.display_net_prices:
-                custom_price = round_decimal(custom_price * (100 + item.tax_rate) / 100)
+                return error_messages['price_too_high']
             price = max(custom_price, price)
 
-        return price
-
-    def extend_expired_positions(self):
-        expired = self.positions.filter(expires__lte=self.now_dt).select_related(
-            'item', 'variation', 'voucher'
-        ).prefetch_related('item__quotas', 'variation__quotas')
-        for cp in expired:
-            price = self._get_price(cp.item, cp.variation, cp.voucher, cp.price)
-
-            quotas = list(cp.item.quotas.all()) if cp.variation is None else list(cp.variation.quotas.all())
-            if not quotas:
-                raise CartError(error_messages['unavailable'])
-            if not cp.voucher or (not cp.voucher.allow_ignore_quota and not cp.voucher.block_quota):
-                for quota in quotas:
-                    self._quota_diff[quota] += 1
+        # Create a CartPosition for as much items as we can
+        for k in range(quota_ok):
+            if 'cp' in i and i['count'] == 1:
+                # Recreating
+                cp = i['cp']
+                cp.expires = expiry
+                cp.price = price
+                cp.save()
             else:
-                quotas = []
-
-            op = self.ExtendOperation(
-                position=cp, item=cp.item, variation=cp.variation, voucher=cp.voucher, count=1,
-                price=price, quotas=quotas
-            )
-            self._check_item_constraints(op)
-
-            if cp.voucher:
-                self._voucher_use_diff[cp.voucher] += 1
-
-            self._operations.append(op)
-
-    def add_new_items(self, items: List[dict]):
-        # Fetch items from the database
-        self._update_items_cache([i['item'] for i in items], [i['variation'] for i in items])
-        quota_diff = Counter()
-        voucher_use_diff = Counter()
-        operations = []
-
-        for i in items:
-            # Check whether the specified items are part of what we just fetched from the database
-            # If they are not, the user supplied item IDs which either do not exist or belong to
-            # a different event
-            if i['item'] not in self._items_cache or (i['variation'] and i['variation'] not in self._variations_cache):
-                raise CartError(error_messages['not_for_sale'])
-
-            item = self._items_cache[i['item']]
-            variation = self._variations_cache[i['variation']] if i['variation'] is not None else None
-            voucher = None
-
-            if i.get('voucher'):
-                try:
-                    voucher = self.event.vouchers.get(code=i.get('voucher').strip())
-                except Voucher.DoesNotExist:
-                    raise CartError(error_messages['voucher_invalid'])
-                else:
-                    voucher_use_diff[voucher] += i['count']
-
-            # Fetch all quotas. If there are no quotas, this item is not allowed to be sold.
-
-            quotas = list(item.quotas.all()) if variation is None else list(variation.quotas.all())
-            if not quotas:
-                raise CartError(error_messages['unavailable'])
-            if not voucher or (not voucher.allow_ignore_quota and not voucher.block_quota):
-                for quota in quotas:
-                    quota_diff[quota] += i['count']
-            else:
-                quotas = []
-
-            price = self._get_price(item, variation, voucher, i.get('price'))
-            op = self.AddOperation(
-                count=i['count'], item=item, variation=variation, price=price, voucher=voucher, quotas=quotas,
-                addon_to=False
-            )
-            self._check_item_constraints(op)
-            operations.append(op)
-
-        self._quota_diff += quota_diff
-        self._voucher_use_diff += voucher_use_diff
-        self._operations += operations
-
-    def remove_item(self, pos_id: int):
-        # TODO: We could calculate quotadiffs and voucherdiffs here, which would lead to more
-        # flexible usages (e.g. a RemoveOperation and an AddOperation in the same transaction
-        # could cancel each other out quota-wise). However, we are not taking this performance
-        # penalty for now as there is currently no outside interface that would allow building
-        # such a transaction.
-        try:
-            cp = self.positions.get(pk=pos_id)
-        except CartPosition.DoesNotExist:
-            raise CartError(error_messages['unknown_position'])
-        self._operations.append(self.RemoveOperation(position=cp))
-
-    def clear(self):
-        # TODO: We could calculate quotadiffs and voucherdiffs here, which would lead to more
-        # flexible usages (e.g. a RemoveOperation and an AddOperation in the same transaction
-        # could cancel each other out quota-wise). However, we are not taking this performance
-        # penalty for now as there is currently no outside interface that would allow building
-        # such a transaction.
-        for cp in self.positions.all():
-            self._operations.append(self.RemoveOperation(position=cp))
-
-    def set_addons(self, addons):
-        self._update_items_cache(
-            [a['item'] for a in addons],
-            [a['variation'] for a in addons],
-        )
-
-        # Prepare various containers to hold data later
-        current_addons = defaultdict(dict)  # CartPos -> currently attached add-ons
-        input_addons = defaultdict(set)  # CartPos -> add-ons according to input
-        selected_addons = defaultdict(set)  # CartPos -> final desired set of add-ons
-        cpcache = {}  # CartPos.pk -> CartPos
-        quota_diff = Counter()  # Quota -> Number of usages
-        operations = []
-        available_categories = defaultdict(set)  # CartPos -> Category IDs to choose from
-        toplevel_cp = self.positions.filter(
-            addon_to__isnull=True
-        ).prefetch_related(
-            'addons', 'item__addons', 'item__addons__addon_category'
-        ).select_related('item', 'variation')
-
-        # Prefill some of the cache containers
-        for cp in toplevel_cp:
-            available_categories[cp.pk] = {iao.addon_category_id for iao in cp.item.addons.all()}
-            cpcache[cp.pk] = cp
-            current_addons[cp] = {
-                (a.item_id, a.variation_id): a
-                for a in cp.addons.all()
-            }
-
-        # Create operations, perform various checks
-        for a in addons:
-            # Check whether the specified items are part of what we just fetched from the database
-            # If they are not, the user supplied item IDs which either do not exist or belong to
-            # a different event
-            if a['item'] not in self._items_cache or (a['variation'] and a['variation'] not in self._variations_cache):
-                raise CartError(error_messages['not_for_sale'])
-
-            # Only attach addons to things that are actually in this user's cart
-            if a['addon_to'] not in cpcache:
-                raise CartError(error_messages['addon_invalid_base'])
-
-            cp = cpcache[a['addon_to']]
-            item = self._items_cache[a['item']]
-            variation = self._variations_cache[a['variation']] if a['variation'] is not None else None
-
-            if item.category_id not in available_categories[cp.pk]:
-                raise CartError(error_messages['addon_invalid_base'])
-
-            # Fetch all quotas. If there are no quotas, this item is not allowed to be sold.
-            quotas = list(item.quotas.all()) if variation is None else list(variation.quotas.all())
-            if not quotas:
-                raise CartError(error_messages['unavailable'])
-
-            # Every item can be attached to very CartPosition at most once
-            if a['item'] in ([_a[0] for _a in input_addons[cp.id]]):
-                raise CartError(error_messages['addon_duplicate_item'])
-
-            input_addons[cp.id].add((a['item'], a['variation']))
-            selected_addons[cp.id, item.category_id].add((a['item'], a['variation']))
-
-            if (a['item'], a['variation']) not in current_addons[cp]:
-                # This add-on is new, add it to the cart
-                for quota in quotas:
-                    quota_diff[quota] += 1
-
-                price = self._get_price(item, variation, None, None)
-
-                op = self.AddOperation(
-                    count=1, item=item, variation=variation, price=price, voucher=None, quotas=quotas,
-                    addon_to=cp
+                CartPosition.objects.create(
+                    event=event, item=item, variation=variation,
+                    price=price,
+                    expires=expiry,
+                    cart_id=cart_id, voucher=voucher
                 )
-                self._check_item_constraints(op)
-                operations.append(op)
+    return err
 
-        # Check constraints on the add-on combinations
-        for cp in toplevel_cp:
-            item = cp.item
-            for iao in item.addons.all():
-                selected = selected_addons[cp.id, iao.addon_category_id]
-                if len(selected) > iao.max_count:
-                    # TODO: Proper i18n
-                    # TODO: Proper pluralization
-                    raise CartError(
-                        error_messages['addon_max_count'],
-                        {
-                            'base': str(item.name),
-                            'max': iao.max_count,
-                            'cat': str(iao.addon_category.name),
-                        }
-                    )
-                elif len(selected) < iao.min_count:
-                    # TODO: Proper i18n
-                    # TODO: Proper pluralization
-                    raise CartError(
-                        error_messages['addon_min_count'],
-                        {
-                            'base': str(item.name),
-                            'min': iao.min_count,
-                            'cat': str(iao.addon_category.name),
-                        }
-                    )
 
-        # Detect removed add-ons and create RemoveOperations
-        for cp, al in current_addons.items():
-            for k, v in al.items():
-                if k not in input_addons[cp.id]:
-                    if v.expires > self.now_dt:
-                        quotas = list(cp.item.quotas.all()) if cp.variation is None else list(cp.variation.quotas.all())
+def _add_items_to_cart(event: Event, items: List[dict], cart_id: str=None) -> None:
+    with event.lock() as now_dt:
+        _check_date(event, now_dt)
+        existing = CartPosition.objects.filter(Q(cart_id=cart_id) & Q(event=event)).count()
+        if sum(i['count'] for i in items) + existing > int(event.settings.max_items_per_order):
+            # TODO: i18n plurals
+            raise CartError(error_messages['max_items'], (event.settings.max_items_per_order,))
 
-                        for quota in quotas:
-                            quota_diff[quota] -= 1
+        expiry = now_dt + timedelta(minutes=event.settings.get('reservation_time', as_type=int))
+        _extend_existing(event, cart_id, expiry, now_dt)
 
-                    op = self.RemoveOperation(position=v)
-                    operations.append(op)
-
-        self._quota_diff += quota_diff
-        self._operations += operations
-
-    def _get_quota_availability(self):
-        quotas_ok = {}
-        for quota, count in self._quota_diff.items():
-            avail = quota.availability(self.now_dt)
-            if avail[1] is not None and avail[1] < count:
-                quotas_ok[quota] = min(count, avail[1])
-            else:
-                quotas_ok[quota] = count
-        return quotas_ok
-
-    def _get_voucher_availability(self):
-        vouchers_ok = {}
-        for voucher, count in self._voucher_use_diff.items():
-            voucher.refresh_from_db()
-
-            if voucher.valid_until is not None and voucher.valid_until < self.now_dt:
-                raise CartError(error_messages['voucher_expired'])
-
-            redeemed_in_carts = CartPosition.objects.filter(
-                Q(voucher=voucher) & Q(event=self.event) &
-                Q(expires__gte=self.now_dt)
-            ).exclude(pk__in=[
-                op.position.voucher_id for op in self._operations if isinstance(op, self.ExtendOperation)
-            ])
-            v_avail = voucher.max_usages - voucher.redeemed - redeemed_in_carts.count()
-            vouchers_ok[voucher] = v_avail
-
-        return vouchers_ok
-
-    def _check_min_per_product(self):
-        per_product = Counter()
-        min_per_product = {}
-        for p in self.positions:
-            per_product[p.item_id] += 1
-            min_per_product[p.item.pk] = p.item.min_per_order
-
-        for op in self._operations:
-            if isinstance(op, self.AddOperation):
-                per_product[op.item.pk] += op.count
-                min_per_product[op.item.pk] = op.item.min_per_order
-            elif isinstance(op, self.RemoveOperation):
-                per_product[op.position.item_id] -= 1
-                min_per_product[op.position.item.pk] = op.position.item.min_per_order
-
-        err = None
-        for itemid, num in per_product.items():
-            min_p = min_per_product[itemid]
-            if min_p and num < min_p:
-                self._operations = [o for o in self._operations if not (
-                    isinstance(o, self.AddOperation) and o.item.pk == itemid
-                )]
-                removals = [o.position.pk for o in self._operations if isinstance(o, self.RemoveOperation)]
-                for p in self.positions:
-                    if p.item_id == itemid and p.pk not in removals:
-                        self._operations.append(self.RemoveOperation(position=p))
-                        err = _(error_messages['min_items_per_product_removed']) % {
-                            'min': min_p,
-                            'product': p.item.name
-                        }
-
-        return err
-
-    def _perform_operations(self):
-        vouchers_ok = self._get_voucher_availability()
-        quotas_ok = self._get_quota_availability()
-        err = None
-        new_cart_positions = []
-
-        err = err or self._check_min_per_product()
-
-        self._operations.sort(key=lambda a: self.order[type(a)])
-
-        for op in self._operations:
-            if isinstance(op, self.RemoveOperation):
-                op.position.delete()
-
-            elif isinstance(op, self.AddOperation) or isinstance(op, self.ExtendOperation):
-                # Create a CartPosition for as much items as we can
-                requested_count = quota_available_count = voucher_available_count = op.count
-
-                if op.quotas:
-                    quota_available_count = min(requested_count, min(quotas_ok[q] for q in op.quotas))
-
-                if op.voucher:
-                    voucher_available_count = min(voucher_available_count, vouchers_ok[op.voucher])
-
-                if quota_available_count < 1:
-                    err = err or error_messages['unavailable']
-                elif quota_available_count < requested_count:
-                    err = err or error_messages['in_part']
-
-                if voucher_available_count < 1:
-                    err = err or error_messages['voucher_redeemed']
-                elif voucher_available_count < requested_count:
-                    err = err or error_messages['voucher_redeemed_partial'] % voucher_available_count
-
-                available_count = min(quota_available_count, voucher_available_count)
-
-                for q in op.quotas:
-                    quotas_ok[q] -= available_count
-                if op.voucher:
-                    vouchers_ok[op.voucher] -= available_count
-
-                if isinstance(op, self.AddOperation):
-                    for k in range(available_count):
-                        new_cart_positions.append(CartPosition(
-                            event=self.event, item=op.item, variation=op.variation,
-                            price=op.price, expires=self._expiry,
-                            cart_id=self.cart_id, voucher=op.voucher,
-                            addon_to=op.addon_to if op.addon_to else None
-                        ))
-                elif isinstance(op, self.ExtendOperation):
-                    if available_count == 1:
-                        op.position.expires = self._expiry
-                        op.position.price = op.price
-                        op.position.save()
-                    elif available_count == 0:
-                        op.position.delete()
-                    else:
-                        raise AssertionError("ExtendOperation cannot affect more than one item")
-
-        CartPosition.objects.bulk_create(new_cart_positions)
-        return err
-
-    def commit(self):
-        self._check_presale_dates()
-        self._check_max_cart_size()
-        self._calculate_expiry()
-
-        with self.event.lock() as now_dt:
-            with transaction.atomic():
-                self.now_dt = now_dt
-                self._extend_expiry_of_valid_existing_positions()
-                self.extend_expired_positions()
-                err = self._perform_operations()
+        expired = _re_add_expired_positions(items, event, cart_id, now_dt)
+        if items:
+            err = _add_new_items(event, items, cart_id, expiry, now_dt)
+            _delete_expired(expired, now_dt)
             if err:
                 raise CartError(err)
 
 
 @app.task(base=ProfiledTask, bind=True, max_retries=5, default_retry_delay=1, throws=(CartError,))
-def add_items_to_cart(self, event: int, items: List[dict], cart_id: str=None, locale='en') -> None:
+def add_items_to_cart(self, event: int, items: List[dict], cart_id: str=None) -> None:
     """
     Adds a list of items to a user's cart.
     :param event: The event ID in question
-    :param items: A list of dicts with the keys item, variation, number, custom_price, voucher
+    :param items: A list of tuple of the form (item id, variation id or None, number, custom_price, voucher)
     :param session: Session ID of a guest
     :param coupon: A coupon that should also be reeemed
     :raises CartError: On any error that occured
     """
-    with language(locale):
-        event = Event.objects.get(id=event)
+    event = Event.objects.get(id=event)
+    try:
         try:
-            try:
-                cm = CartManager(event=event, cart_id=cart_id)
-                cm.add_new_items(items)
-                cm.commit()
-            except LockTimeoutException:
-                self.retry()
-        except (MaxRetriesExceededError, LockTimeoutException):
-            raise CartError(error_messages['busy'])
+            _add_items_to_cart(event, items, cart_id)
+        except LockTimeoutException:
+            self.retry()
+    except (MaxRetriesExceededError, LockTimeoutException):
+        raise CartError(error_messages['busy'])
+
+
+def _remove_items_from_cart(event: Event, items: List[dict], cart_id: str) -> None:
+    with event.lock():
+        for i in items:
+            cw = Q(cart_id=cart_id) & Q(item_id=i['item']) & Q(event=event)
+            if i['variation']:
+                cw &= Q(variation_id=i['variation'])
+            else:
+                cw &= Q(variation__isnull=True)
+            # Prefer to delete positions that have the same price as the one the user clicked on, after thet
+            # prefer the most expensive ones.
+            cnt = i['count']
+            if i['price']:
+                correctprice = CartPosition.objects.filter(cw).filter(price=Decimal(i['price'].replace(",", ".")))[:cnt]
+                for cp in correctprice:
+                    cp.delete()
+                cnt -= len(correctprice)
+            if cnt > 0:
+                for cp in CartPosition.objects.filter(cw).order_by("-price")[:cnt]:
+                    cp.delete()
 
 
 @app.task(base=ProfiledTask, bind=True, max_retries=5, default_retry_delay=1, throws=(CartError,))
-def remove_cart_position(self, event: int, position: int, cart_id: str=None, locale='en') -> None:
+def remove_items_from_cart(self, event: int, items: List[dict], cart_id: str=None) -> None:
     """
     Removes a list of items from a user's cart.
     :param event: The event ID in question
-    :param position: A cart position ID
+    :param items: A list of tuple of the form (item id, variation id or None, number)
     :param session: Session ID of a guest
     """
-    with language(locale):
-        event = Event.objects.get(id=event)
+    event = Event.objects.get(id=event)
+    try:
         try:
-            try:
-                cm = CartManager(event=event, cart_id=cart_id)
-                cm.remove_item(position)
-                cm.commit()
-            except LockTimeoutException:
-                self.retry()
-        except (MaxRetriesExceededError, LockTimeoutException):
-            raise CartError(error_messages['busy'])
-
-
-@app.task(base=ProfiledTask, bind=True, max_retries=5, default_retry_delay=1, throws=(CartError,))
-def clear_cart(self, event: int, cart_id: str=None, locale='en') -> None:
-    """
-    Removes a list of items from a user's cart.
-    :param event: The event ID in question
-    :param session: Session ID of a guest
-    """
-    with language(locale):
-        event = Event.objects.get(id=event)
-        try:
-            try:
-                cm = CartManager(event=event, cart_id=cart_id)
-                cm.clear()
-                cm.commit()
-            except LockTimeoutException:
-                self.retry()
-        except (MaxRetriesExceededError, LockTimeoutException):
-            raise CartError(error_messages['busy'])
-
-
-@app.task(base=ProfiledTask, bind=True, max_retries=5, default_retry_delay=1, throws=(CartError,))
-def set_cart_addons(self, event: int, addons: List[dict], cart_id: str=None, locale='en') -> None:
-    """
-    Removes a list of items from a user's cart.
-    :param event: The event ID in question
-    :param addons: A list of dicts with the keys addon_to, item, variation
-    :param session: Session ID of a guest
-    """
-    with language(locale):
-        event = Event.objects.get(id=event)
-        try:
-            try:
-                cm = CartManager(event=event, cart_id=cart_id)
-                cm.set_addons(addons)
-                cm.commit()
-            except LockTimeoutException:
-                self.retry()
-        except (MaxRetriesExceededError, LockTimeoutException):
-            raise CartError(error_messages['busy'])
+            _remove_items_from_cart(event, items, cart_id)
+        except LockTimeoutException:
+            self.retry()
+    except (MaxRetriesExceededError, LockTimeoutException):
+        raise CartError(error_messages['busy'])

src/pretix/base/services/export.py

@@ -21,4 +21,3 @@ def export(event: str, fileid: str, provider: str, form_data: Dict[str, Any]) ->
                 file.filename, file.type, data = ex.render(form_data)
                 file.file.save(cachedfile_name(file, file.filename), ContentFile(data))
                 file.save()
-    return file.pk

src/pretix/base/services/invoices.py

@@ -10,7 +10,6 @@ from django.db import transaction
 from django.utils.formats import date_format, localize
 from django.utils.timezone import now
 from django.utils.translation import pgettext, ugettext as _
-from i18nfield.strings import LazyI18nString
 from reportlab.lib import pagesizes
 from reportlab.lib.styles import ParagraphStyle, StyleSheet1
 from reportlab.lib.units import mm
@@ -22,7 +21,7 @@ from reportlab.platypus import (
     Table, TableStyle,
 )
 
-from pretix.base.i18n import language
+from pretix.base.i18n import LazyI18nString, language
 from pretix.base.models import Invoice, InvoiceAddress, InvoiceLine, Order
 from pretix.base.services.async import TransactionAwareTask
 from pretix.base.signals import register_payment_providers
@@ -72,8 +71,6 @@ def build_invoice(invoice: Invoice) -> Invoice:
             desc = str(p.item.name)
             if p.variation:
                 desc += " - " + str(p.variation.value)
-            if p.addon_to_id:
-                desc = "  + " + desc
             InvoiceLine.objects.create(
                 invoice=invoice, description=desc,
                 gross_value=p.price, tax_value=p.tax_value,
@@ -185,29 +182,17 @@ def _invoice_generate_german(invoice, f):
         textobject = canvas.beginText(25 * mm, (297 - 15) * mm)
         textobject.setFont('OpenSansBd', 8)
         textobject.textLine(pgettext('invoice', 'Invoice from').upper())
+        textobject.moveCursor(0, 5)
+        textobject.setFont('OpenSans', 10)
+        textobject.textLines(invoice.invoice_from.strip())
         canvas.drawText(textobject)
 
-        p = Paragraph(invoice.invoice_from.strip().replace('\n', '<br />\n'), style=styles['Normal'])
-        p.wrapOn(canvas, 70 * mm, 50 * mm)
-        p_size = p.wrap(70 * mm, 50 * mm)
-        p.drawOn(canvas, 25 * mm, (297 - 17) * mm - p_size[1])
-
         textobject = canvas.beginText(25 * mm, (297 - 50) * mm)
         textobject.setFont('OpenSansBd', 8)
         textobject.textLine(pgettext('invoice', 'Invoice to').upper())
-        canvas.drawText(textobject)
-
-        p = Paragraph(invoice.invoice_to.strip().replace('\n', '<br />\n'), style=styles['Normal'])
-        p.wrapOn(canvas, 85 * mm, 50 * mm)
-        p_size = p.wrap(85 * mm, 50 * mm)
-        p.drawOn(canvas, 25 * mm, (297 - 52) * mm - p_size[1])
-
-        textobject = canvas.beginText(125 * mm, (297 - 38) * mm)
-        textobject.setFont('OpenSansBd', 8)
-        textobject.textLine(_('Order code').upper())
         textobject.moveCursor(0, 5)
         textobject.setFont('OpenSans', 10)
-        textobject.textLine(invoice.order.full_code)
+        textobject.textLines(invoice.invoice_to.strip())
         canvas.drawText(textobject)
 
         textobject = canvas.beginText(125 * mm, (297 - 50) * mm)
@@ -253,33 +238,39 @@ def _invoice_generate_german(invoice, f):
 
         canvas.drawText(textobject)
 
+        textobject = canvas.beginText(165 * mm, (297 - 50) * mm)
+        textobject.setFont('OpenSansBd', 8)
+        textobject.textLine(_('Order code').upper())
+        textobject.moveCursor(0, 5)
+        textobject.setFont('OpenSans', 10)
+        textobject.textLine(invoice.order.full_code)
+        textobject.moveCursor(0, 5)
+        textobject.setFont('OpenSansBd', 8)
+        textobject.textLine(_('Order date').upper())
+        textobject.moveCursor(0, 5)
+        textobject.setFont('OpenSans', 10)
+        textobject.textLine(date_format(invoice.order.datetime, "DATE_FORMAT"))
+        canvas.drawText(textobject)
+
         if invoice.event.settings.invoice_logo_image:
             logo_file = invoice.event.settings.get('invoice_logo_image', binary_file=True)
             canvas.drawImage(ImageReader(logo_file),
                              95 * mm, (297 - 38) * mm,
                              width=25 * mm, height=25 * mm,
-                             preserveAspectRatio=True, anchor='n',
-                             mask='auto')
-
-        if invoice.event.settings.show_date_to:
-            p_str = (
-                str(invoice.event.name) + '\n' + _('{from_date}\nuntil {to_date}').format(
-                    from_date=invoice.event.get_date_from_display(),
-                    to_date=invoice.event.get_date_to_display())
-            )
-        else:
-            p_str = (
-                str(invoice.event.name) + '\n' + invoice.event.get_date_from_display()
-            )
-
-        p = Paragraph(p_str.strip().replace('\n', '<br />\n'), style=styles['Normal'])
-        p.wrapOn(canvas, 65 * mm, 50 * mm)
-        p_size = p.wrap(65 * mm, 50 * mm)
-        p.drawOn(canvas, 125 * mm, (297 - 17) * mm - p_size[1])
+                             preserveAspectRatio=True, anchor='n')
 
         textobject = canvas.beginText(125 * mm, (297 - 15) * mm)
         textobject.setFont('OpenSansBd', 8)
         textobject.textLine(_('Event').upper())
+        textobject.moveCursor(0, 5)
+        textobject.setFont('OpenSans', 10)
+        textobject.textLine(str(invoice.event.name))
+        if invoice.event.settings.show_date_to:
+            textobject.textLines(
+                _('{from_date}\nuntil {to_date}').format(from_date=invoice.event.get_date_from_display(),
+                                                         to_date=invoice.event.get_date_to_display()))
+        else:
+            textobject.textLine(invoice.event.get_date_from_display())
         canvas.drawText(textobject)
 
         canvas.restoreState()

src/pretix/base/services/mail.py

@@ -1,5 +1,5 @@
 import logging
-from typing import Any, Dict, List, Union
+from typing import Any, Dict, Union
 
 import bleach
 import cssutils
@@ -8,10 +8,9 @@ from django.conf import settings
 from django.core.mail import EmailMultiAlternatives, get_connection
 from django.template.loader import get_template
 from django.utils.translation import ugettext as _
-from i18nfield.strings import LazyI18nString
 from inlinestyler.utils import inline_css
 
-from pretix.base.i18n import language
+from pretix.base.i18n import LazyI18nString, language
 from pretix.base.models import Event, InvoiceAddress, Order
 from pretix.celery_app import app
 from pretix.multidomain.urlreverse import build_absolute_uri
@@ -114,16 +113,6 @@ def mail(email: str, subject: str, template: Union[str, LazyI18nString],
                 subject = "[%s] %s" % (prefix, subject)
 
             body_plain += "\r\n\r\n-- \r\n"
-
-            signature = str(event.settings.get('mail_text_signature'))
-            if signature:
-                signature = signature.format(event=event.name)
-                signature_md = signature.replace('\n', '<br>\n')
-                signature_md = bleach.linkify(bleach.clean(markdown.markdown(signature_md), tags=bleach.ALLOWED_TAGS + ['p', 'br']))
-                htmlctx['signature'] = signature_md
-                body_plain += signature
-                body_plain += "\r\n\r\n-- \r\n"
-
             body_plain += _(
                 "You are receiving this email because you placed an order for {event}."
             ).format(event=event.name)
@@ -148,7 +137,7 @@ def mail(email: str, subject: str, template: Union[str, LazyI18nString],
 
 
 @app.task
-def mail_send_task(to: List[str], subject: str, body: str, html: str, sender: str,
+def mail_send_task(to: str, subject: str, body: str, html: str, sender: str,
                    event: int=None, headers: dict=None) -> bool:
     email = EmailMultiAlternatives(subject, body, sender, to=to, headers=headers)
     email.attach_alternative(inline_css(html), "text/html")

src/pretix/base/services/orders.py

@@ -45,8 +45,6 @@ error_messages = {
                        'meantime. Please see below for details.'),
     'internal': _("An internal error occured, please try again."),
     'empty': _("Your cart is empty."),
-    'max_items_per_product': _("You cannot select more than %(max)s items of the product %(product)s. We removed the "
-                               "surplus items from your cart."),
     'busy': _('We were not able to process your request completely as the '
               'server was too busy. Please try again.'),
     'not_started': _('The presale period for this event has not yet started.'),
@@ -208,10 +206,8 @@ def _check_date(event: Event, now_dt: datetime):
 
 def _check_positions(event: Event, now_dt: datetime, positions: List[CartPosition]):
     err = None
-    errargs = None
     _check_date(event, now_dt)
 
-    products_seen = Counter()
     for i, cp in enumerate(positions):
         if not cp.item.active or (cp.variation and not cp.variation.active):
             err = err or error_messages['unavailable']
@@ -219,14 +215,6 @@ def _check_positions(event: Event, now_dt: datetime, positions: List[CartPositio
             continue
         quotas = list(cp.item.quotas.all()) if cp.variation is None else list(cp.variation.quotas.all())
 
-        products_seen[cp.item] += 1
-        if cp.item.max_per_order and products_seen[cp.item] > cp.item.max_per_order:
-            err = error_messages['max_items_per_product']
-            errargs = {'max': cp.item.max_per_order,
-                       'product': cp.item.name}
-            cp.delete()  # Sorry!
-            break
-
         if cp.voucher:
             redeemed_in_carts = CartPosition.objects.filter(
                 Q(voucher=cp.voucher) & Q(event=event) & Q(expires__gte=now_dt)
@@ -298,7 +286,7 @@ def _check_positions(event: Event, now_dt: datetime, positions: List[CartPositio
         else:
             cp.delete()  # Sorry!
     if err:
-        raise OrderError(err, errargs)
+        raise OrderError(err)
 
 
 def _create_order(event: Event, email: str, positions: List[CartPosition], now_dt: datetime,
@@ -390,36 +378,37 @@ def _perform_order(event: str, payment_provider: str, position_ids: List[str],
         if not order.invoices.exists():
             generate_invoice(order)
 
-    if order.total == Decimal('0.00'):
-        mailtext = event.settings.mail_text_order_free
-    else:
-        mailtext = event.settings.mail_text_order_placed
+    with language(order.locale):
+        if order.total == Decimal('0.00'):
+            mailtext = event.settings.mail_text_order_free
+        else:
+            mailtext = event.settings.mail_text_order_placed
 
-    try:
-        invoice_name = order.invoice_address.name
-        invoice_company = order.invoice_address.company
-    except InvoiceAddress.DoesNotExist:
-        invoice_name = ""
-        invoice_company = ""
+        try:
+            invoice_name = order.invoice_address.name
+            invoice_company = order.invoice_address.company
+        except InvoiceAddress.DoesNotExist:
+            invoice_name = ""
+            invoice_company = ""
 
-    mail(
-        order.email, _('Your order: %(code)s') % {'code': order.code},
-        mailtext,
-        {
-            'total': LazyNumber(order.total),
-            'currency': event.currency,
-            'date': LazyDate(order.expires),
-            'event': event.name,
-            'url': build_absolute_uri(event, 'presale:event.order', kwargs={
-                'order': order.code,
-                'secret': order.secret
-            }),
-            'payment_info': str(pprov.order_pending_mail_render(order)),
-            'invoice_name': invoice_name,
-            'invoice_company': invoice_company,
-        },
-        event, locale=order.locale
-    )
+        mail(
+            order.email, _('Your order: %(code)s') % {'code': order.code},
+            mailtext,
+            {
+                'total': LazyNumber(order.total),
+                'currency': event.currency,
+                'date': LazyDate(order.expires),
+                'event': event.name,
+                'url': build_absolute_uri(event, 'presale:event.order', kwargs={
+                    'order': order.code,
+                    'secret': order.secret
+                }),
+                'paymentinfo': str(pprov.order_pending_mail_render(order)),
+                'invoice_name': invoice_name,
+                'invoice_company': invoice_company,
+            },
+            event, locale=order.locale
+        )
 
     return order.id
 
@@ -491,11 +480,9 @@ class OrderChangeManager:
         'quota': _('The quota {name} does not have enough capacity left to perform the operation.'),
         'product_invalid': _('The selected product is not active or has no price set.'),
         'complete_cancel': _('This operation would leave the order empty. Please cancel the order itself instead.'),
-        'not_pending_or_paid': _('Only pending or paid orders can be changed.'),
+        'not_pending': _('Only pending orders can be changed.'),
         'paid_to_free_exceeded': _('This operation would make the order free and therefore immediately paid, however '
                                    'no quota is available.'),
-        'paid_price_change': _('Currently, paid orders can only be changed in a way that does not change the total '
-                               'price of the order as partial payments or refunds are not yet supported.')
     }
     ItemOperation = namedtuple('ItemOperation', ('position', 'item', 'variation', 'price'))
     PriceOperation = namedtuple('PriceOperation', ('position', 'price'))
@@ -511,8 +498,9 @@ class OrderChangeManager:
     def change_item(self, position: OrderPosition, item: Item, variation: Optional[ItemVariation]):
         if (not variation and item.has_variations) or (variation and variation.item_id != item.pk):
             raise OrderError(self.error_messages['product_without_variation'])
-        price = item.default_price if variation is None else variation.price
-        if price is None:
+        price = item.default_price if variation is None else (
+            variation.default_price if variation.default_price is not None else item.default_price)
+        if not price:
             raise OrderError(self.error_messages['product_invalid'])
         self._totaldiff = price - position.price
         self._quotadiff.update(variation.quotas.all() if variation else item.quotas.all())
@@ -540,10 +528,6 @@ class OrderChangeManager:
         if self.order.total == Decimal('0.00') and self._totaldiff > 0:
             raise OrderError(self.error_messages['free_to_paid'])
 
-    def _check_paid_price_change(self):
-        if self.order.status == Order.STATUS_PAID and self._totaldiff != 0:
-            raise OrderError(self.error_messages['paid_price_change'])
-
     def _check_paid_to_free(self):
         if self.order.total == 0:
             try:
@@ -562,7 +546,6 @@ class OrderChangeManager:
                     'new_item': op.item.pk,
                     'new_variation': op.variation.pk if op.variation else None,
                     'old_price': op.position.price,
-                    'addon_to': op.position.addon_to_id,
                     'new_price': op.price
                 })
                 op.position.item = op.item
@@ -575,29 +558,18 @@ class OrderChangeManager:
                     'position': op.position.pk,
                     'positionid': op.position.positionid,
                     'old_price': op.position.price,
-                    'addon_to': op.position.addon_to_id,
                     'new_price': op.price
                 })
                 op.position.price = op.price
                 op.position._calculate_tax()
                 op.position.save()
             elif isinstance(op, self.CancelOperation):
-                for opa in op.position.addons.all():
-                    self.order.log_action('pretix.event.order.changed.cancel', user=self.user, data={
-                        'position': opa.pk,
-                        'positionid': opa.positionid,
-                        'old_item': opa.item.pk,
-                        'old_variation': opa.variation.pk if opa.variation else None,
-                        'addon_to': opa.addon_to_id,
-                        'old_price': opa.price,
-                    })
                 self.order.log_action('pretix.event.order.changed.cancel', user=self.user, data={
                     'position': op.position.pk,
                     'positionid': op.position.positionid,
                     'old_item': op.position.item.pk,
                     'old_variation': op.position.variation.pk if op.position.variation else None,
                     'old_price': op.position.price,
-                    'addon_to': None,
                 })
                 op.position.delete()
 
@@ -652,10 +624,9 @@ class OrderChangeManager:
             return
         with transaction.atomic():
             with self.order.event.lock():
-                if self.order.status not in (Order.STATUS_PENDING, Order.STATUS_PAID):
-                    raise OrderError(self.error_messages['not_pending_or_paid'])
+                if self.order.status != Order.STATUS_PENDING:
+                    raise OrderError(self.error_messages['not_pending'])
                 self._check_free_to_paid()
-                self._check_paid_price_change()
                 self._check_quotas()
                 self._check_complete_cancel()
                 self._perform_operations()
@@ -682,14 +653,13 @@ class OrderChangeManager:
 @app.task(base=ProfiledTask, bind=True, max_retries=5, default_retry_delay=1, throws=(OrderError,))
 def perform_order(self, event: str, payment_provider: str, positions: List[str],
                   email: str=None, locale: str=None, address: int=None, meta_info: dict=None):
-    with language(locale):
+    try:
         try:
-            try:
-                return _perform_order(event, payment_provider, positions, email, locale, address, meta_info)
-            except LockTimeoutException:
-                self.retry()
-        except (MaxRetriesExceededError, LockTimeoutException):
-            return OrderError(error_messages['busy'])
+            return _perform_order(event, payment_provider, positions, email, locale, address, meta_info)
+        except LockTimeoutException:
+            self.retry()
+    except (MaxRetriesExceededError, LockTimeoutException):
+        return OrderError(error_messages['busy'])
 
 
 @app.task(base=ProfiledTask, bind=True, max_retries=5, default_retry_delay=1, throws=(OrderError,))