MetricsMiddleware: Do not record pretix_view_duration_seconds for urls with no url.url_name

Fix company & vat_id dependencies on is_business (#4777 )
Bugfixes for LogEntryTypes refactoring (#4778 )
2026-01-02 18:42:27 +00:00 · 2025-01-27 16:12:27 +01:00 · 2025-01-27 11:55:39 +01:00 · 2025-01-24 16:19:55 +01:00 · 2025-01-24 14:48:28 +01:00 · 2025-01-24 14:48:28 +01:00
3 changed files with 7 additions and 6 deletions
--- a/src/pretix/control/logdisplay.py
+++ b/src/pretix/control/logdisplay.py
@@ -338,7 +338,7 @@ class CheckinErrorLogEntryType(OrderLogEntryType):
        else:
            data['list'] = _("(unknown)")

-        data['barcode'] = data.get('barcode')[:16]
+        data['barcode'] = data.get('barcode', '')[:16]
        data['posid'] = logentry.parsed_data.get('positionid', '?')

        if 'datetime' in data:
@@ -529,7 +529,7 @@ class VoucherRedeemedLogEntryType(VoucherLogEntryType):
        })
        return format_html(
            self.plain,
-            order_code=format_html('<a href="{}">{}</a>', url, data('order_code', '?')),
+            order_code=format_html('<a href="{}">{}</a>', url, data.get('order_code', '?')),
        )


--- a/src/pretix/helpers/metrics/middleware.py
+++ b/src/pretix/helpers/metrics/middleware.py
@@ -62,7 +62,8 @@ class MetricsMiddleware(object):
        t0 = time.perf_counter()
        resp = self.get_response(request)
        tdiff = time.perf_counter() - t0
-        pretix_view_duration_seconds.observe(tdiff, status_code=resp.status_code, method=request.method,
-                                             url_name=url.namespace + ':' + url.url_name)
+        if url.url_name:
+            pretix_view_duration_seconds.observe(tdiff, status_code=resp.status_code, method=request.method,
+                                                 url_name=url.namespace + ':' + url.url_name)

        return resp
--- a/src/pretix/plugins/paypal2/signals.py
+++ b/src/pretix/plugins/paypal2/signals.py
@@ -51,8 +51,8 @@ def register_payment_provider(sender, **kwargs):
 class PaypalEventLogEntryType(EventLogEntryType):
    action_type = 'pretix.plugins.paypal.event'

-    def display(self, logentry):
-        event_type = logentry.parsed_data.get('event_type')
+    def display(self, logentry, data):
+        event_type = data.get('event_type')
        text = None
        plains = {
            'PAYMENT.SALE.COMPLETED': _('Payment completed.'),
Author	SHA1	Message	Date
Martin Gross	a425377cae	MetricsMiddleware: Do not record pretix_view_duration_seconds for urls with no url.url_name	2025-01-27 16:12:27 +01:00
Mira	af3418db54	Fix company & vat_id dependencies on is_business (#4777 )	2025-01-27 11:55:39 +01:00
Mira	ca8d253114	Bugfixes for LogEntryTypes refactoring (#4778 )	2025-01-24 16:19:55 +01:00
Mira Weller	f014a9bbd3	Reapply "Implement hidden_if_item_available_mode option (Z#23177008) (#4776 )" This reverts commit `5cd7959e86`.	2025-01-24 14:48:28 +01:00
Mira Weller	3e5bfb44d2	Revert "Preliminary migration" This reverts commit `1736efbdc3`.	2025-01-24 14:48:28 +01:00
Mira Weller	1736efbdc3	Preliminary migration	2025-01-24 14:08:13 +01:00
Mira Weller	5cd7959e86	Revert "Implement hidden_if_item_available_mode option (Z#23177008) (#4776 )" This reverts commit `b847612e1a`.	2025-01-24 14:07:55 +01:00