Show invoice_dirty status on order details page (Z#23230731)

pyproject.toml

@@ -92,7 +92,7 @@ dependencies = [
   "qrcode==8.2",
   "redis==7.4.*",
   "reportlab==4.4.*",
-  "requests==2.34.*",
+  "requests==2.32.*",
   "sentry-sdk==2.58.*",
   "sepaxml==2.7.*",
   "stripe==7.9.*",

src/pretix/control/templates/pretixcontrol/order/index.html

@@ -134,6 +134,39 @@
         </div>
     {% endif %}
 
+    {% if invoice_qualified and order.invoice_dirty %}
+        <div class="alert alert-warning">
+            <p>
+                {% blocktrans trimmed %}
+                    This order was changed after the last invoice was generated. A new invoice was not generated yet, because invoices are configured to be generated on payment or if required by the payment method.
+                    A new invoice will be generated once the customer pays the invoice or selects a payment method that requires an invoice.
+                {% endblocktrans %}
+            </p>
+            {% if "event.orders:write" in request.eventpermset %}
+                <p>
+                    {% if uncancelled_invoice %}
+                        <form action="{% url "control:event.order.reissueinvoice" event=request.event.slug organizer=request.event.organizer.slug code=order.code id=uncancelled_invoice.pk %}"
+                                method="post">
+                            {% csrf_token %}
+                            <button class="btn btn-default" type="submit">
+                                {% blocktrans trimmed %}
+                                    Reissue invoice
+                                {% endblocktrans %}
+                            </button>
+                        </form>
+                    {% elif can_generate_invoice %}
+                        <form method="post" action="{% url "control:event.order.geninvoice" event=request.event.slug organizer=request.event.organizer.slug code=order.code %}">
+                            {% csrf_token %}
+                            <button class="btn btn-default">
+                                {% trans "Generate invoice" %}
+                            </button>
+                        </form>
+                    {% endif %}
+                </p>
+            {% endif %}
+        </div>
+    {% endif %}
+
     <div class="row">
         <div class="col-xs-12 col-lg-10">
             {% for cr in order.cancellation_requests.all %}

src/pretix/control/templates/pretixcontrol/orders/index.html

@@ -108,7 +108,7 @@
                 </a>
             </p>
         {% endif %}
-        <form action="#will-be-overridden" method="post">
+        <form action="{% url "control:organizer.device.bulk_edit" organizer=request.organizer.slug %}" method="post">
             {% csrf_token %}
             {% for field in filter_form %}
                 {{ field.as_hidden }}

src/pretix/control/views/orders.py

@@ -554,6 +554,9 @@ class OrderDetail(OrderView):
         ctx['download_buttons'] = self.download_buttons
         ctx['payment_refund_sum'] = self.order.payment_refund_sum
         ctx['pending_sum'] = self.order.pending_sum
+        ctx['uncancelled_invoice'] = self.order.invoices.exclude(
+            Exists(self.order.invoices.filter(refers=OuterRef('pk'), is_cancellation=True))
+        ).exclude(is_cancellation=True).first()
 
         return ctx
 

src/pretix/static/pretixcontrol/js/ui/checkinrules/App.vue

@@ -75,14 +75,10 @@ const missingItems = computed(() => {
 			li.active(role="presentation")
 				a(href="#rules-edit", role="tab", data-toggle="tab")
 					span.fa.fa-edit
-					// space between icon and string
-					|
 					| {{ gettext("Edit") }}
 			li(role="presentation")
 				a(href="#rules-viz", role="tab", data-toggle="tab")
 					span.fa.fa-eye
-					// space between icon and string
-					|
 					| {{ gettext("Visualize") }}
 
 		//- Tab panes

src/pretix/static/pretixcontrol/js/ui/checkinrules/django-interop.ts

@@ -17,7 +17,7 @@ export const rules = ref<any>({})
 // grab rules from hidden input
 const rulesInput = document.querySelector<HTMLInputElement>('#id_rules')
 if (rulesInput?.value) {
-	rules.value = JSON.parse(rulesInput.value) ?? {}
+	rules.value = JSON.parse(rulesInput.value)
 }
 
 // sync back to hidden input