Provide explicit orderings to all models used in paginated queries

This commit is contained in:
Raphael Michel
2019-04-07 14:09:21 +02:00
parent 289878689b
commit f14c12546d
6 changed files with 15 additions and 0 deletions
+3
View File
@@ -77,6 +77,9 @@ class WebHook(models.Model):
all_events = models.BooleanField(default=True, verbose_name=_("All events (including newly created ones)"))
limit_events = models.ManyToManyField('pretixbase.Event', verbose_name=_("Limit to events"), blank=True)
class Meta:
ordering = ('id',)
@property
def action_types(self):
return [
+1
View File
@@ -111,6 +111,7 @@ class User(AbstractBaseUser, PermissionsMixin, LoggingMixin):
class Meta:
verbose_name = _("User")
verbose_name_plural = _("Users")
ordering = ('email',)
def save(self, *args, **kwargs):
self.email = self.email.lower()
+3
View File
@@ -118,6 +118,9 @@ class TaxRule(LoggedModel):
)
custom_rules = models.TextField(blank=True, null=True)
class Meta:
ordering = ('event', 'rate', 'id')
def allow_delete(self):
from pretix.base.models.orders import OrderFee, OrderPosition
+3
View File
@@ -52,3 +52,6 @@ class BadgeItem(models.Model):
on_delete=models.CASCADE)
layout = models.ForeignKey('BadgeLayout', on_delete=models.CASCADE, related_name='item_assignments',
null=True, blank=True)
class Meta:
ordering = ('id',)
@@ -21,6 +21,9 @@ class BankImportJob(models.Model):
created = models.DateTimeField(auto_now_add=True)
state = models.CharField(max_length=32, choices=STATES, default=STATE_PENDING)
class Meta:
ordering = ('id',)
@property
def owner_kwargs(self):
if self.event:
@@ -76,3 +79,4 @@ class BankTransaction(models.Model):
class Meta:
unique_together = ('event', 'organizer', 'checksum')
ordering = ('date', 'id')
@@ -73,3 +73,4 @@ class TicketLayoutItem(models.Model):
class Meta:
unique_together = (('item', 'layout', 'sales_channel'),)
ordering = ("id",)