Vouchers: fix code min-length check on bulk creation

This commit is contained in:
Richard Schreiber
2023-09-26 09:15:23 +02:00
committed by GitHub
parent ca23073760
commit ca79436e36
2 changed files with 13 additions and 0 deletions
+9
View File
@@ -395,6 +395,15 @@ class VoucherBulkForm(VoucherForm):
codes_seen = set()
for c in data['codes']:
if len(c) < 5:
raise ValidationError({
'codes': [
_('The voucher code {code} ist too short. Make sure all voucher codes are at least {min_length} characters long.').format(
code=c,
min_length=5
)
]
})
if c in codes_seen:
raise ValidationError(_('The voucher code {code} appears in your list twice.').format(code=c))
codes_seen.add(c)
+4
View File
@@ -477,6 +477,10 @@ class VoucherFormTest(SoupTestMixin, TransactionTestCase):
self._create_bulk_vouchers({
'codes': 'ABCDE\nDEFGH\nIJKLM\nNOPQR\nSTUVW\nXYZ',
'itemvar': '%d' % self.ticket.pk,
}, expected_failure=True)
self._create_bulk_vouchers({
'codes': 'ABCDE\nDEFGH\nIJKLM\nNOPQR\nSTUVW',
'itemvar': '%d' % self.ticket.pk,
})
def test_create_blocking_bulk_quota_full(self):