Apply suggestions from code review

Co-authored-by: Raphael Michel <mail@raphaelmichel.de>
This commit is contained in:
pajowu
2026-04-28 15:11:03 +02:00
committed by GitHub
parent cf52cccb8a
commit a7b8056335

View File

@@ -138,7 +138,7 @@ class OrderQuerySet(models.QuerySet):
from .invoices import Invoice from .invoices import Invoice
if not isinstance(status, list): if not isinstance(status, list):
raise ValueError("`status` needs to be a list of strings") raise TypeError("`status` needs to be a list of strings")
filter = Q() filter = Q()
@@ -155,7 +155,7 @@ class OrderQuerySet(models.QuerySet):
filter |= Q(status__in=[Order.STATUS_PENDING, Order.STATUS_EXPIRED]) filter |= Q(status__in=[Order.STATUS_PENDING, Order.STATUS_EXPIRED])
if 'pv' in status: if 'pv' in status:
filter |= Q(status=Order.STATUS_PAID) | Q(status=Order.STATUS_PENDING, valid_if_pending=True) filter |= Q(status=Order.STATUS_PAID) | Q(status=Order.STATUS_PENDING, valid_if_pending=True)
for s in ('p', 'n', 'e', 'c', 'r'): for s in ('p', 'n', 'e', 'c'):
if s in status: if s in status:
filter |= Q(status=s) filter |= Q(status=s)
if 'overpaid' in status: if 'overpaid' in status: