mirror of
https://github.com/pretix/pretix.git
synced 2026-05-11 16:13:59 +00:00
Apply suggestions from code review
Co-authored-by: Raphael Michel <mail@raphaelmichel.de>
This commit is contained in:
@@ -138,7 +138,7 @@ class OrderQuerySet(models.QuerySet):
|
|||||||
from .invoices import Invoice
|
from .invoices import Invoice
|
||||||
|
|
||||||
if not isinstance(status, list):
|
if not isinstance(status, list):
|
||||||
raise ValueError("`status` needs to be a list of strings")
|
raise TypeError("`status` needs to be a list of strings")
|
||||||
|
|
||||||
filter = Q()
|
filter = Q()
|
||||||
|
|
||||||
@@ -155,7 +155,7 @@ class OrderQuerySet(models.QuerySet):
|
|||||||
filter |= Q(status__in=[Order.STATUS_PENDING, Order.STATUS_EXPIRED])
|
filter |= Q(status__in=[Order.STATUS_PENDING, Order.STATUS_EXPIRED])
|
||||||
if 'pv' in status:
|
if 'pv' in status:
|
||||||
filter |= Q(status=Order.STATUS_PAID) | Q(status=Order.STATUS_PENDING, valid_if_pending=True)
|
filter |= Q(status=Order.STATUS_PAID) | Q(status=Order.STATUS_PENDING, valid_if_pending=True)
|
||||||
for s in ('p', 'n', 'e', 'c', 'r'):
|
for s in ('p', 'n', 'e', 'c'):
|
||||||
if s in status:
|
if s in status:
|
||||||
filter |= Q(status=s)
|
filter |= Q(status=s)
|
||||||
if 'overpaid' in status:
|
if 'overpaid' in status:
|
||||||
|
|||||||
Reference in New Issue
Block a user