From a7b8056335ce3d9cc69ebcc59a6f6396d39d4d89 Mon Sep 17 00:00:00 2001 From: pajowu Date: Tue, 28 Apr 2026 15:11:03 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Raphael Michel --- src/pretix/base/models/orders.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pretix/base/models/orders.py b/src/pretix/base/models/orders.py index 27b18dad02..d6b2344fba 100644 --- a/src/pretix/base/models/orders.py +++ b/src/pretix/base/models/orders.py @@ -138,7 +138,7 @@ class OrderQuerySet(models.QuerySet): from .invoices import Invoice if not isinstance(status, list): - raise ValueError("`status` needs to be a list of strings") + raise TypeError("`status` needs to be a list of strings") filter = Q() @@ -155,7 +155,7 @@ class OrderQuerySet(models.QuerySet): filter |= Q(status__in=[Order.STATUS_PENDING, Order.STATUS_EXPIRED]) if 'pv' in status: filter |= Q(status=Order.STATUS_PAID) | Q(status=Order.STATUS_PENDING, valid_if_pending=True) - for s in ('p', 'n', 'e', 'c', 'r'): + for s in ('p', 'n', 'e', 'c'): if s in status: filter |= Q(status=s) if 'overpaid' in status: