Fix crash on too old time machine date (Z#23245824)

dateutil.parser seems to reject dates with second-precision timezone-offsets, which datetime produces for some dates aroung the year 200. datetime.fromisoformat has no problem parsing them
This commit is contained in:
Kara Engelhardt
2026-09-25 14:27:12 +02:00
parent 2791d5e49e
commit 212967b412
2 changed files with 24 additions and 9 deletions
+14 -3
View File
@@ -21,9 +21,11 @@
#
import contextvars
from contextlib import contextmanager
from datetime import datetime
from dateutil.parser import parse
from django.contrib import messages
from django.utils.timezone import now
from django.utils.translation import gettext_lazy as _
from pretix.base.auth import has_event_access_permission
@@ -34,8 +36,17 @@ timemachine_now_var = contextvars.ContextVar('timemachine_now', default=None)
def time_machine_now_assigned_from_request(request):
if hasattr(request, 'event') and f'timemachine_now_dt:{request.event.pk}' in request.session and \
request.event.testmode and has_event_access_permission(request):
request.now_dt = parse(request.session[f'timemachine_now_dt:{request.event.pk}'])
request.now_dt_is_fake = True
try:
request.now_dt = datetime.fromisoformat(request.session[f'timemachine_now_dt:{request.event.pk}'])
request.now_dt_is_fake = True
except ValueError:
del request.session[f'timemachine_now_dt:{request.event.pk}']
messages.error(
request, _('Invalid date.')
)
request.now_dt = now()
request.now_dt_is_fake = False
else:
request.now_dt = now()
request.now_dt_is_fake = False
+10 -6
View File
@@ -41,7 +41,6 @@ from importlib import import_module
from urllib.parse import urlencode
import isoweek
from dateutil import parser
from django import forms
from django.conf import settings
from django.contrib import messages
@@ -603,12 +602,17 @@ class EventTimeMachine(EventViewMixin, TemplateView):
raise PermissionDenied(_('You are not allowed to access time machine mode.'))
if not request.event.testmode:
raise PermissionDenied(_('This feature is only available in test mode.'))
initial = {}
if request.session.get(f'timemachine_now_dt:{request.event.pk}', None):
try:
initial['now_dt'] = datetime.fromisoformat(request.session.get(f'timemachine_now_dt:{request.event.pk}', None))
except ValueError:
pass
self.timemachine_form = TimemachineForm(
data=request.method == 'POST' and request.POST or None,
initial=(
{'now_dt': parser.parse(request.session.get(f'timemachine_now_dt:{request.event.pk}', None))}
if request.session.get(f'timemachine_now_dt:{request.event.pk}', None) else {}
)
initial=initial
)
def get_context_data(self, **kwargs):
@@ -622,7 +626,7 @@ class EventTimeMachine(EventViewMixin, TemplateView):
messages.success(self.request, _('Time machine disabled!'))
return redirect(self.get_success_url())
elif self.timemachine_form.is_valid():
request.session[f'timemachine_now_dt:{request.event.pk}'] = str(self.timemachine_form.cleaned_data['now_dt'])
request.session[f'timemachine_now_dt:{request.event.pk}'] = self.timemachine_form.cleaned_data['now_dt'].isoformat()
return redirect(eventreverse(request.event, "presale:event.index"))
else:
return self.get(request)