Control: fix yes/no-question not being optional in order edit form

.github/dependabot.yml

@@ -6,7 +6,7 @@
 version: 2
 updates:
   - package-ecosystem: "pip"
-    directory: "/"
+    directory: "/src"
     schedule:
       interval: "daily"
     versioning-strategy: increase

.github/workflows/strings.yml

@@ -38,6 +38,7 @@ jobs:
         run: sudo apt update && sudo apt install gettext
       - name: Install Dependencies
         run: pip3 install -e ".[dev]"
+        working-directory: ./src
       - name: Compile messages
         run: python manage.py compilemessages
         working-directory: ./src
@@ -63,6 +64,7 @@ jobs:
         run: sudo apt update && sudo apt install enchant-2 hunspell hunspell-de-de aspell-en aspell-de
       - name: Install Dependencies
         run: pip3 install -e ".[dev]"
+        working-directory: ./src
       - name: Spellcheck translations
         run: potypo
         working-directory: ./src

.github/workflows/style.yml

@@ -36,6 +36,7 @@ jobs:
             ${{ runner.os }}-pip-
       - name: Install Dependencies
         run: pip3 install -e ".[dev]" mysqlclient psycopg2-binary
+        working-directory: ./src
       - name: Run isort
         run: isort -c .
         working-directory: ./src
@@ -56,6 +57,7 @@ jobs:
             ${{ runner.os }}-pip-
       - name: Install Dependencies
         run: pip3 install -e ".[dev]" mysqlclient psycopg2-binary
+        working-directory: ./src
       - name: Run flake8
         run: flake8 .
         working-directory: ./src

.github/workflows/tests.yml

@@ -64,6 +64,7 @@ jobs:
         run: sudo apt update && sudo apt install gettext mariadb-client
       - name: Install Python dependencies
         run: pip3 install --ignore-requires-python -e ".[dev]" mysqlclient psycopg2-binary  # We ignore that flake8 needs newer python as we don't run flake8 during tests
+        working-directory: ./src
       - name: Run checks
         run: python manage.py check
         working-directory: ./src

.gitignore

@@ -1,6 +1,4 @@
 env/
-build/
-dist/
 .coverage
 htmlcov/
 .ropeproject

.gitlab-ci.yml

@@ -5,8 +5,8 @@ tests:
         - virtualenv env
         - source env/bin/activate
         - pip install -U pip wheel setuptools
-        - XDG_CACHE_HOME=/cache pip3 install -e ".[dev]"
         - cd src
+        - XDG_CACHE_HOME=/cache pip3 install -e ".[dev]"
         - python manage.py check
         - make all compress
         - py.test --reruns 3 -n 3 tests
@@ -21,8 +21,8 @@ pypi:
         - virtualenv env
         - source env/bin/activate
         - pip install -U pip wheel setuptools check-manifest twine
-        - XDG_CACHE_HOME=/cache pip3 install -e ".[dev]"
         - cd src
+        - XDG_CACHE_HOME=/cache pip3 install -e ".[dev]"
         - python setup.py sdist
         - pip install dist/pretix-*.tar.gz
         - python -m pretix migrate

Dockerfile

@@ -19,8 +19,6 @@ RUN apt-get update && \
             python3-dev \
             sudo \
             supervisor \
-            libmaxminddb0 \
-            libmaxminddb-dev \
             zlib1g-dev && \
     apt-get clean && \
     rm -rf /var/lib/apt/lists/* && \

MANIFEST.in

@@ -1,33 +0,0 @@
-include LICENSE
-include README.rst
-global-include *.proto
-recursive-include src/pretix/static *
-recursive-include src/pretix/static.dist *
-recursive-include src/pretix/locale *
-recursive-include src/pretix/helpers/locale *
-recursive-include src/pretix/base/templates *
-recursive-include src/pretix/control/templates *
-recursive-include src/pretix/presale/templates *
-recursive-include src/pretix/plugins/banktransfer/templates *
-recursive-include src/pretix/plugins/banktransfer/static *
-recursive-include src/pretix/plugins/manualpayment/templates *
-recursive-include src/pretix/plugins/manualpayment/static *
-recursive-include src/pretix/plugins/paypal/templates *
-recursive-include src/pretix/plugins/paypal/static *
-recursive-include src/pretix/plugins/paypal2/templates *
-recursive-include src/pretix/plugins/paypal2/static *
-recursive-include src/pretix/plugins/src/pretixdroid/templates *
-recursive-include src/pretix/plugins/src/pretixdroid/static *
-recursive-include src/pretix/plugins/sendmail/templates *
-recursive-include src/pretix/plugins/statistics/templates *
-recursive-include src/pretix/plugins/statistics/static *
-recursive-include src/pretix/plugins/stripe/templates *
-recursive-include src/pretix/plugins/stripe/static *
-recursive-include src/pretix/plugins/ticketoutputpdf/templates *
-recursive-include src/pretix/plugins/ticketoutputpdf/static *
-recursive-include src/pretix/plugins/badges/templates *
-recursive-include src/pretix/plugins/badges/static *
-recursive-include src/pretix/plugins/returnurl/templates *
-recursive-include src/pretix/plugins/returnurl/static *
-recursive-include src/pretix/plugins/webcheckin/templates *
-recursive-include src/pretix/plugins/webcheckin/static *

doc/admin/config.rst

@@ -481,18 +481,3 @@ You can configure the maximum file size for uploading various files::
     ; Max upload size for other files in MiB, defaults to 10 MiB
     ; This includes all file upload type order questions
     max_size_other = 100
-
-
-GeoIP
------
-
-pretix can optionally make use of a GeoIP database for some features. It needs a file in ``mmdb`` format, for example
-`GeoLite2`_ or `GeoAcumen`_::
-
-    [geoip]
-    path=/var/geoipdata/
-    filename_country=GeoLite2-Country.mmdb
-
-
-.. _GeoAcumen: https://github.com/geoacumen/geoacumen-country
-.. _GeoLite2: https://dev.maxmind.com/geoip/geolite2-free-geolocation-data

doc/admin/installation/dev_version.rst

@@ -16,7 +16,7 @@ Manual installation
 You can use ``pip`` to update pretix directly to the development branch. Then, upgrade as usual::
 
     $ source /var/pretix/venv/bin/activate
-    (venv)$ pip3 install -U "git+https://github.com/pretix/pretix.git#egg=pretix"
+    (venv)$ pip3 install -U "git+https://github.com/pretix/pretix.git#egg=pretix&subdirectory=src"
     (venv)$ python -m pretix migrate
     (venv)$ python -m pretix rebuild
     (venv)$ python -m pretix updatestyles

doc/admin/scaling.rst

@@ -25,7 +25,7 @@ and what you should think of.
 Scaling reasons
 ---------------
 
-There are two main reasons for scaling up a pretix installation beyond a single server:
+There's mainly two reasons to scale up a pretix installation beyond a single server:
 
 * **Availability:** Distributing pretix over multiple servers can allow you to survive failure of one or more single machines, leading to a higher uptime and reliability of your system.
 
@@ -92,7 +92,7 @@ them from a different URL <config-urls>`.
 pretix-web
 """"""""""
 
-The ``pretix-web`` process does not carry any internal state and can be easily started on as many machines as you like, and you can
+The ``pretix-web`` process does not carry any internal state can be easily started on as many machines as you like, and you can
 use the load balancing features of your frontend web server to redirect to all of them.
 
 You can adjust the number of processes in the ``gunicorn`` command line, and we recommend choosing roughly two times the number
@@ -154,7 +154,7 @@ files, otherwise you **will** run into errors with the user interface.
 The easiest solution for this is probably to store them on a NFS server that you mount
 on each of the other servers.
 
-Since we use Django's file storage mechanism internally, you can in theory also use an object-storage solution like Amazon S3, Ceph, or Minio to store these files, although we currently do not expose this through pretix' configuration file and this would require you to ship your own variant of ``pretix/settings.py`` and reference it through the ``DJANGO_SETTINGS_MODULE`` environment variable.
+Since we use Django's file storage mechanism internally, you can in theory also use a object-storage solution like Amazon S3, Ceph, or Minio to store these files, although we currently do not expose this through pretix' configuration file and this would require you to ship your own variant of ``pretix/settings.py`` and reference it through the ``DJANGO_SETTINGS_MODULE`` environment variable.
 
 At pretix.eu, we use a custom-built `object storage cluster`_.
 
@@ -171,12 +171,12 @@ you configure, so make sure to set this memory usage as high as you can afford.
 memory available allows your database to make more use of caching, which is usually good.
 
 Scaling your database to multiple machines needs to be treated with great caution. It's a
-good idea to have a replica of your database for availability reasons. In case your primary
+good to have a replica of your database for availability reasons. In case your primary
 database server fails, you can easily switch over to the replica and continue working.
 
-However, using database replicas for performance gain is much more complicated. When using
+However, using database replicas for performance gains is much more complicated. When using
 replicated database systems, you are always trading in consistency or availability to get
-additional performance and the consequences of this can be subtle. It is important
+additional performance and the consequences of this can be subtle and it is important
 that you have a deep understanding of the semantics of your replication mechanism.
 
 .. warning::
@@ -187,7 +187,7 @@ that you have a deep understanding of the semantics of your replication mechanis
    As an example, if you buy a ticket, pretix first needs to calculate how many tickets
    are left to sell. If this calculation is done on a database replica that lags behind
    even for fractions of a second, the decision to allow selling the ticket will be made
-   on stale data and you can end up with more tickets sold than configured. Similarly,
+   on out-of-data data and you can end up with more tickets sold than configured. Similarly,
    you could imagine situations leading to double payments etc.
 
 If you do have a replica, you *can* tell pretix about it :ref:`in your configuration <config-replica>`.
@@ -204,9 +204,9 @@ redis
 While redis is a very important part that glues together some of the components, it isn't used
 heavily and can usually handle a fairly large pretix installation easily on a single modern
 CPU core.
-Having some memory available is good, e.g. if lots of tasks queue up during a traffic peak, but we wouldn't expect ever needing more than a gigabyte of it.
+Having some memory available is good in case of e.g. lots of tasks queuing up during a traffic peak, but we wouldn't expect ever needing more than a gigabyte of it.
 
-Feel free to set up a redis cluster for availability – but you probably won't need it for performance.
+Feel free to set up a redis cluster for availability – but you won't need it for performance in a long time.
 
 The limitations
 ---------------
@@ -228,9 +228,9 @@ if you add more hardware.
 If you have an unlimited number of tickets, we can apply fewer locking and we've reached **approx.
 1500 orders per minute per event** in benchmarks, although even more should be possible.
 
-We're working on reducing the number of cases in which this is relevant and thereby improve the possible
+We're working to reduce the number of cases in which this is relevant and thereby improve the possible
 throughput. If you want to use pretix for an event with 10,000+ tickets that are likely to be sold out
 within minutes, please get in touch to discuss possible solutions. We'll work something out for you!
 
 
-.. _object storage cluster: https://behind.pretix.eu/2018/03/20/high-available-cdn/
+.. _object storage cluster: https://behind.pretix.eu/2018/03/20/high-available-cdn/

doc/api/deviceauth.rst

@@ -225,3 +225,4 @@ You can get three response codes:
       "subevent": 23,
       "checkinlist": 5
    }
+

doc/api/resources/checkin.rst

@@ -13,10 +13,6 @@ failed scans.
 
     The endpoints listed on this page have been added.
 
-.. versionchanged:: 4.18
-
-    The ``source_type`` parameter has been added.
-
 .. _`rest-checkin-redeem`:
 
 Checking a ticket in
@@ -32,7 +28,6 @@ Checking a ticket in
    passed needs to be from a distinct event.
 
    :<json string secret: Scanned QR code corresponding to the ``secret`` attribute of a ticket.
-   :<json string source_type: Type of source the ``secret`` was obtained form. Defaults to ``"barcode"``.
    :<json array lists: List of check-in list IDs to search on. No two check-in lists may be from the same event.
    :<json string type: Send ``"exit"`` for an exit and ``"entry"`` (default) for an entry.
    :<json datetime datetime: Specifies the datetime of the check-in. If not supplied, the current time will be used.
@@ -77,7 +72,6 @@ Checking a ticket in
 
       {
         "secret": "M5BO19XmFwAjLd4nDYUAL9ISjhti0e9q",
-        "source_type": "barcode",
         "lists": [1],
         "force": false,
         "ignore_unpaid": false,
@@ -219,8 +213,8 @@ Checking a ticket in
    * ``revoked`` - Ticket code has been revoked.
    * ``error`` - Internal error.
 
-   In case of reason ``rules`` and ``invalid_time``, there might be an additional response field ``reason_explanation``
-   with a human-readable description of the violated rules. However, that field can also be missing or be ``null``.
+   In case of reason ``rules``, there might be an additional response field ``reason_explanation`` with a human-readable
+   description of the violated rules. However, that field can also be missing or be ``null``.
 
    :param organizer: The ``slug`` field of the organizer to fetch
    :statuscode 201: no error

doc/api/resources/checkinlists.rst

@@ -753,8 +753,8 @@ Order position endpoints
    * ``ambiguous`` - Multiple tickets match scan, rejected.
    * ``revoked`` - Ticket code has been revoked.
 
-   In case of reason ``rules`` or ``invalid_time``, there might be an additional response field ``reason_explanation``
-   with a human-readable description of the violated rules. However, that field can also be missing or be ``null``.
+   In case of reason ``rules``, there might be an additional response field ``reason_explanation`` with a human-readable
+   description of the violated rules. However, that field can also be missing or be ``null``.
 
    :param organizer: The ``slug`` field of the organizer to fetch
    :param event: The ``slug`` field of the event to fetch

doc/api/resources/events.rst

@@ -137,7 +137,6 @@ Endpoints
    :query page: The page number in case of a multi-page result set, default is 1
    :query is_public: If set to ``true``/``false``, only events with a matching value of ``is_public`` are returned.
    :query live: If set to ``true``/``false``, only events with a matching value of ``live`` are returned.
-   :query testmode: If set to ``true``/``false``, only events with a matching value of ``testmode`` are returned.
    :query has_subevents: If set to ``true``/``false``, only events with a matching value of ``has_subevents`` are returned.
    :query is_future: If set to ``true`` (``false``), only events that happen currently or in the future are (not) returned. Event series are never (always) returned.
    :query is_past: If set to ``true`` (``false``), only events that are over are (not) returned. Event series are never (always) returned.
@@ -547,9 +546,6 @@ Therefore, we're also not including a list of the options here, but instead reco
 to see available options. The ``explain=true`` flag enables a verbose mode that provides you with human-readable
 information about the properties.
 
-Note that some settings are read-only, e.g. because they can be read on event level but currently only be changed on
-organizer level.
-
 .. note:: Please note that this is not a complete representation of all event settings. You will find more settings
           in the web interface.
 
@@ -596,7 +592,6 @@ organizer level.
           {
             "value": "https://pretix.eu",
             "label": "Imprint URL",
-            "readonly": false,
             "help_text": "This should point e.g. to a part of your website that has your contact details and legal information."
           }
         },
@@ -610,10 +605,6 @@ organizer level.
    :statuscode 401: Authentication failure
    :statuscode 403: The requested organizer/event does not exist **or** you have no permission to view this resource.
 
-   .. versionchanged:: 4.18
-
-       The ``readonly`` flag has been added.
-
 .. http:patch:: /api/v1/organizers/(organizer)/events/(event)/settings/
 
    Updates event settings. Note that ``PUT`` is not allowed here, only ``PATCH``.

doc/api/resources/index.rst

@@ -32,7 +32,6 @@ at :ref:`plugin-docs`.
    membershiptypes
    memberships
    giftcards
-   reusablemedia
    carts
    teams
    devices

doc/api/resources/items.rst

@@ -108,9 +108,6 @@ generate_tickets                        boolean                    If ``false``,
 allow_waitinglist                       boolean                    If ``false``, no waiting list will be shown for this
                                                                    product when it is sold out.
 issue_giftcard                          boolean                    If ``true``, buying this product will yield a gift card.
-media_policy                            string                     Policy on how to handle reusable media (experimental feature).
-                                                                   Possible values are ``null``, ``"new"``, ``"reuse"``, and ``"reuse_or_new"``.
-media_type                              string                     Type of reusable media to work on (experimental feature). See :ref:`rest-reusablemedia` for possible choices.
 show_quota_left                         boolean                    Publicly show how many tickets are still available.
                                                                    If this is ``null``, the event default is used.
 has_variations                          boolean                    Shows whether or not this item has variations.
@@ -192,10 +189,6 @@ meta_data                               object                     Values set fo
 
    The ``validity_*`` attributes have been added.
 
-.. versionchanged:: 4.18
-
-   The ``media_policy`` and ``media_type`` attributes have been added.
-
 Notes
 -----
 
@@ -251,8 +244,6 @@ Endpoints
             "admission": false,
             "personalized": false,
             "issue_giftcard": false,
-            "media_policy": null,
-            "media_type": null,
             "meta_data": {},
             "position": 0,
             "picture": null,
@@ -382,8 +373,6 @@ Endpoints
         "admission": false,
         "personalized": false,
         "issue_giftcard": false,
-        "media_policy": null,
-        "media_type": null,
         "meta_data": {},
         "position": 0,
         "picture": null,
@@ -494,8 +483,6 @@ Endpoints
         "admission": false,
         "personalized": false,
         "issue_giftcard": false,
-        "media_policy": null,
-        "media_type": null,
         "meta_data": {},
         "position": 0,
         "picture": null,
@@ -593,8 +580,6 @@ Endpoints
         "admission": false,
         "personalized": false,
         "issue_giftcard": false,
-        "media_policy": null,
-        "media_type": null,
         "meta_data": {},
         "position": 0,
         "picture": null,
@@ -724,8 +709,6 @@ Endpoints
         "admission": false,
         "personalized": false,
         "issue_giftcard": false,
-        "media_policy": null,
-        "media_type": null,
         "meta_data": {},
         "position": 0,
         "picture": null,

doc/api/resources/orders.rst

@@ -910,7 +910,6 @@ Creating orders
       * ``valid_from`` (optional, if both ``valid_from`` and ``valid_until`` are **missing** (not ``null``) the availability will be computed from the given product)
       * ``valid_until`` (optional, if both ``valid_from`` and ``valid_until`` are **missing** (not ``null``) the availability will be computed from the given product)
       * ``requested_valid_from`` (optional, can be set **instead** of ``valid_from`` and ``valid_until`` to signal a user choice for the start time that may or may not be respected)
-      * ``use_reusable_medium`` (optional, causes the new ticket to take over the given reusable medium, identified by its ID)
       * ``answers``
 
         * ``question``

doc/api/resources/organizers.rst

@@ -157,7 +157,6 @@ information about the properties.
           {
             "value": "calendar",
             "label": "Default overview style",
-            "readonly": false,
             "help_text": "If your event series has more than 50 dates in the future, only the month or week calendar can be used."
           }
         },

doc/api/resources/questions.rst

@@ -63,7 +63,6 @@ valid_date_max                        date                       Maximum value f
 valid_datetime_min                    datetime                   Minimum value for date and time questions (optional)
 valid_datetime_max                    datetime                   Maximum value for date and time questions (optional)
 valid_file_portrait                   boolean                    Turn on file validation for portrait photos
-valid_string_length_max               integer                    Maximum length for string questions (optional)
 dependency_question                   integer                    Internal ID of a different question. The current
                                                                  question will only be shown if the question given in
                                                                  this attribute is set to the value given in
@@ -123,7 +122,6 @@ Endpoints
             "valid_date_max": null,
             "valid_datetime_min": null,
             "valid_datetime_max": null,
-            "valid_string_length_max": null,
             "valid_file_portrait": false,
             "dependency_question": null,
             "dependency_value": null,
@@ -203,7 +201,6 @@ Endpoints
         "valid_datetime_min": null,
         "valid_datetime_max": null,
         "valid_file_portrait": false,
-        "valid_string_length_max": null,
         "dependency_question": null,
         "dependency_value": null,
         "dependency_values": [],
@@ -305,7 +302,6 @@ Endpoints
         "valid_datetime_min": null,
         "valid_datetime_max": null,
         "valid_file_portrait": false,
-        "valid_string_length_max": null,
         "options": [
           {
             "id": 1,
@@ -388,7 +384,6 @@ Endpoints
         "valid_datetime_min": null,
         "valid_datetime_max": null,
         "valid_file_portrait": false,
-        "valid_string_length_max": null,
         "options": [
           {
             "id": 1,

doc/api/resources/reusablemedia.rst

@@ -1,317 +0,0 @@
-.. _`rest-reusablemedia`:
-
-Reusable media
-==============
-
-Reusable media represent things, typically physical tokens like plastic cards or NFC wristbands, which can represent
-other entities inside the system. For example, a medium can link to an order position or to a gift card and can be used
-in their place. Later, the medium might be reused for a different ticket.
-
-Resource description
---------------------
-
-The reusable medium resource contains the following public fields:
-
-.. rst-class:: rest-resource-table
-
-===================================== ========================== =======================================================
-Field                                 Type                       Description
-===================================== ========================== =======================================================
-id                                    integer                    Internal ID of the medium
-type                                  string                     Type of medium, e.g. ``"barcode"`` or ``"nfc_uid"``.
-identifier                            string                     Unique identifier of the medium. The format depends on the ``type``.
-active                                boolean                    Whether this medium may be used.
-created                               datetime                   Date of creation
-updated                               datetime                   Date of last modification
-expires                               datetime                   Expiry date (or ``null``)
-customer                              string                     Identifier of a customer account this medium belongs to.
-linked_orderposition                  integer                    Internal ID of a ticket this medium is linked to.
-linked_giftcard                       integer                    Internal ID of a gift card this medium is linked to.
-info                                  object                     Additional data, content depends on the ``type``. Consider
-                                                                 this internal to the system and don't use it for your own data.
-notes                                 string                     Internal notes and comments (or ``null``)
-===================================== ========================== =======================================================
-
-Existing media types are:
-
-- ``barcode``
-- ``nfc_uid``
-
-Endpoints
----------
-
-.. http:get:: /api/v1/organizers/(organizer)/reusablemedia/
-
-   Returns a list of all media issued by a given organizer.
-
-   **Example request**:
-
-   .. sourcecode:: http
-
-      GET /api/v1/organizers/bigevents/reusablemedia/ HTTP/1.1
-      Host: pretix.eu
-      Accept: application/json, text/javascript
-
-   **Example response**:
-
-   .. sourcecode:: http
-
-      HTTP/1.1 200 OK
-      Vary: Accept
-      Content-Type: application/json
-
-      {
-        "count": 1,
-        "next": null,
-        "previous": null,
-        "results": [
-          {
-            "id": 1,
-            "identifier": "ABCDEFGH",
-            "created": "2021-04-06T13:44:22.809377Z",
-            "updated": "2021-04-06T13:44:22.809377Z",
-            "type": "barcode",
-            "active": True,
-            "expires": None,
-            "customer": None,
-            "linked_orderposition": None,
-            "linked_giftcard": None,
-            "notes": None,
-            "info": {}
-          }
-        ]
-      }
-
-   :query integer page: The page number in case of a multi-page result set, default is 1.
-   :query string identifier: Only show media with the given identifier. Note that you should use the lookup endpoint described below for most use cases.
-   :query string type: Only show media with the given type.
-   :query boolean active: Only show media that are (not) active.
-   :query string customer: Only show media linked to the given customer.
-   :query string created_since: Only show media created since a given date.
-   :query string updated_since: Only show media updated since a given date.
-   :query integer linked_orderposition: Only show media linked to the given ticket.
-   :query integer linked_giftcard: Only show media linked to the given gift card.
-   :query string expand: If you pass ``"linked_giftcard"``, ``"linked_orderposition"``, oder ``"customer"``, the respective
-                         field will be shown as a nested value instead of just an ID. The nested objects are identical to
-                         the respective resources, except that the ``linked_orderposition`` will have an attribute of the
-                         format ``"order": {"code": "ABCDE", "event": "eventslug"}`` to make matching easier. The parameter
-                         can be given multiple times.
-   :param organizer: The ``slug`` field of the organizer to fetch
-   :statuscode 200: no error
-   :statuscode 401: Authentication failure
-   :statuscode 403: The requested organizer does not exist **or** you have no permission to view this resource.
-
-.. http:get:: /api/v1/organizers/(organizer)/reusablemedia/(id)/
-
-   Returns information on one medium, identified by its ID.
-
-   **Example request**:
-
-   .. sourcecode:: http
-
-      GET /api/v1/organizers/bigevents/reusablemedia/1/ HTTP/1.1
-      Host: pretix.eu
-      Accept: application/json, text/javascript
-
-   **Example response**:
-
-   .. sourcecode:: http
-
-      HTTP/1.1 200 OK
-      Vary: Accept
-      Content-Type: application/json
-
-      {
-        "id": 1,
-        "identifier": "ABCDEFGH",
-        "created": "2021-04-06T13:44:22.809377Z",
-        "updated": "2021-04-06T13:44:22.809377Z",
-        "type": "barcode",
-        "active": True,
-        "expires": None,
-        "customer": None,
-        "linked_orderposition": None,
-        "linked_giftcard": None,
-        "notes": None,
-        "info": {}
-      }
-
-   :param organizer: The ``slug`` field of the organizer to fetch
-   :param id: The ``id`` field of the medium to fetch
-   :query string expand: If you pass ``"linked_giftcard"``, ``"linked_orderposition"``, oder ``"customer"``, the respective
-                         field will be shown as a nested value instead of just an ID. The nested objects are identical to
-                         the respective resources, except that the ``linked_orderposition`` will have an attribute of the
-                         format ``"order": {"code": "ABCDE", "event": "eventslug"}`` to make matching easier. The parameter
-                         can be given multiple times.
-   :statuscode 200: no error
-   :statuscode 401: Authentication failure
-   :statuscode 403: The requested organizer does not exist **or** you have no permission to view this resource.
-
-.. http:post:: /api/v1/organizers/(organizer)/reusablemedia/lookup/
-
-   Look up a new reusable medium by its identifier. In some cases, this might lead to the automatic creation of a new
-   medium behind the scenes.
-
-   **Example request**:
-
-   .. sourcecode:: http
-
-      POST /api/v1/organizers/bigevents/reusablemedia/ HTTP/1.1
-      Host: pretix.eu
-      Accept: application/json, text/javascript
-      Content-Type: application/json
-
-      {
-        "identifier": "ABCDEFGH",
-        "type": "barcode",
-      }
-
-   **Example response**:
-
-   .. sourcecode:: http
-
-      HTTP/1.1 200 OK
-      Vary: Accept
-      Content-Type: application/json
-
-      {
-        "id": 1,
-        "identifier": "ABCDEFGH",
-        "created": "2021-04-06T13:44:22.809377Z",
-        "updated": "2021-04-06T13:44:22.809377Z",
-        "type": "barcode",
-        "active": True,
-        "expires": None,
-        "customer": None,
-        "linked_orderposition": None,
-        "linked_giftcard": None,
-        "notes": None,
-        "info": {}
-      }
-
-   :param organizer: The ``slug`` field of the organizer to look up a medium for
-   :query string expand: If you pass ``"linked_giftcard"``, ``"linked_orderposition"``, oder ``"customer"``, the respective
-                         field will be shown as a nested value instead of just an ID. The nested objects are identical to
-                         the respective resources, except that the ``linked_orderposition`` will have an attribute of the
-                         format ``"order": {"code": "ABCDE", "event": "eventslug"}`` to make matching easier. The parameter
-                         can be given multiple times.
-   :statuscode 201: no error
-   :statuscode 400: The medium could not be looked up due to invalid submitted data.
-   :statuscode 401: Authentication failure
-   :statuscode 403: The requested organizer does not exist **or** you have no permission to create this resource.
-
-.. http:post:: /api/v1/organizers/(organizer)/reusablemedia/
-
-   Creates a new reusable medium.
-
-   **Example request**:
-
-   .. sourcecode:: http
-
-      POST /api/v1/organizers/bigevents/reusablemedia/ HTTP/1.1
-      Host: pretix.eu
-      Accept: application/json, text/javascript
-      Content-Type: application/json
-
-      {
-        "identifier": "ABCDEFGH",
-        "type": "barcode",
-        "active": True,
-        "expires": None,
-        "customer": None,
-        "linked_orderposition": None,
-        "linked_giftcard": None,
-        "notes": None,
-        "info": {}
-      }
-
-   **Example response**:
-
-   .. sourcecode:: http
-
-      HTTP/1.1 201 Created
-      Vary: Accept
-      Content-Type: application/json
-
-      {
-        "id": 1,
-        "identifier": "ABCDEFGH",
-        "created": "2021-04-06T13:44:22.809377Z",
-        "updated": "2021-04-06T13:44:22.809377Z",
-        "type": "barcode",
-        "active": True,
-        "expires": None,
-        "customer": None,
-        "linked_orderposition": None,
-        "linked_giftcard": None,
-        "notes": None,
-        "info": {}
-      }
-
-   :param organizer: The ``slug`` field of the organizer to create a medium for
-   :query string expand: If you pass ``"linked_giftcard"``, ``"linked_orderposition"``, oder ``"customer"``, the respective
-                         field will be shown as a nested value instead of just an ID. The nested objects are identical to
-                         the respective resources, except that the ``linked_orderposition`` will have an attribute of the
-                         format ``"order": {"code": "ABCDE", "event": "eventslug"}`` to make matching easier. The parameter
-                         can be given multiple times.
-   :statuscode 201: no error
-   :statuscode 400: The medium could not be created due to invalid submitted data.
-   :statuscode 401: Authentication failure
-   :statuscode 403: The requested organizer does not exist **or** you have no permission to create this resource.
-
-.. http:patch:: /api/v1/organizers/(organizer)/reusablemedia/(id)/
-
-   Update a reusable medium. You can also use ``PUT`` instead of ``PATCH``. With ``PUT``, you have to provide all fields of
-   the resource, other fields will be reset to default. With ``PATCH``, you only need to provide the fields that you
-   want to change.
-
-   You can change all fields of the resource except the ``id``, ``identifier`` and ``type`` fields.
-
-   **Example request**:
-
-   .. sourcecode:: http
-
-      PATCH /api/v1/organizers/bigevents/reusablemedia/1/ HTTP/1.1
-      Host: pretix.eu
-      Accept: application/json, text/javascript
-      Content-Type: application/json
-      Content-Length: 94
-
-      {
-        "linked_orderposition": 13
-      }
-
-   **Example response**:
-
-   .. sourcecode:: http
-
-      HTTP/1.1 200 OK
-      Vary: Accept
-      Content-Type: application/json
-
-      {
-        "id": 1,
-        "identifier": "ABCDEFGH",
-        "created": "2021-04-06T13:44:22.809377Z",
-        "updated": "2021-04-06T13:44:22.809377Z",
-        "type": "barcode",
-        "active": True,
-        "expires": None,
-        "customer": None,
-        "linked_orderposition": 13,
-        "linked_giftcard": None,
-        "notes": None,
-        "info": {}
-      }
-
-   :param organizer: The ``slug`` field of the organizer to modify
-   :param id: The ``id`` field of the medium to modify
-   :query string expand: If you pass ``"linked_giftcard"``, ``"linked_orderposition"``, oder ``"customer"``, the respective
-                         field will be shown as a nested value instead of just an ID. The nested objects are identical to
-                         the respective resources, except that the ``linked_orderposition`` will have an attribute of the
-                         format ``"order": {"code": "ABCDE", "event": "eventslug"}`` to make matching easier. The parameter
-                         can be given multiple times.
-   :statuscode 200: no error
-   :statuscode 400: The medium could not be modified due to invalid submitted data
-   :statuscode 401: Authentication failure
-   :statuscode 403: The requested organizer does not exist **or** you have no permission to change this resource.

doc/api/resources/teams.rst

@@ -26,7 +26,6 @@ can_create_events                     boolean
 can_change_teams                      boolean
 can_change_organizer_settings         boolean
 can_manage_customers                  boolean
-can_manage_reusable_media             boolean
 can_manage_gift_cards                 boolean
 can_change_event_settings             boolean
 can_change_items                      boolean
@@ -37,10 +36,6 @@ can_change_vouchers                   boolean
 can_checkin_orders                    boolean
 ===================================== ========================== =======================================================
 
-.. versionchanged:: 4.18
-
-    The ``can_manage_reusable_media`` permission has been added.
-
 Team member resource
 --------------------
 

doc/api/resources/webhooks.rst

@@ -47,7 +47,6 @@ The following values for ``action_types`` are valid with pretix core:
     * ``pretix.event.order.refund.done``
     * ``pretix.event.order.refund.canceled``
     * ``pretix.event.order.refund.failed``
-    * ``pretix.event.order.payment.confirmed``
     * ``pretix.event.order.approved``
     * ``pretix.event.order.denied``
     * ``pretix.event.checkin``

doc/development/setup.rst

@@ -58,11 +58,11 @@ If you do not have a recent installation of ``nodejs``, install it now::
 
 To make sure it is on your path variable, close and reopen your terminal. Now, install the Python-level dependencies of pretix::
 
+    cd src/
     pip3 install -e ".[dev]"
 
 Next, you need to copy the SCSS files from the source folder to the STATIC_ROOT directory::
 
-    cd src/
     python manage.py collectstatic --noinput
 
 Then, create the local database::
@@ -150,13 +150,6 @@ Add this to your ``src/pretix.cfg``::
 
 Then execute ``python -m smtpd -n -c DebuggingServer localhost:1025``.
 
-Working with periodic tasks
-^^^^^^^^^^^^^^^^^^^^^^^^^^^
-Periodic tasks (like sendmail rules) are run when an external scheduler (like cron)
-triggers the ``runperiodic`` command.
-
-To run periodic tasks, execute ``python manage.py runperiodic``.
-
 Working with translations
 ^^^^^^^^^^^^^^^^^^^^^^^^^
 If you want to translate new strings that are not yet known to the translation system,

doc/images/checkin_online.puml

@@ -38,27 +38,27 @@ else
 endif
 
 "Is the order in status PAID or PENDING\nand is the position not canceled?" --> if "" then
-    -right->[no && !force] "Return error CANCELED"
+    -right->[no] "Return error CANCELED"
 else
-    -down->[yes || force] "Is one or more block set on the ticket?"
+    -down->[yes] "Is one or more block set on the ticket?"
     --> if "" then
-        -right->[no && !force] "Return error BLOCKED"
+        -right->[no] "Return error BLOCKED"
     else
-        -down->[yes || force] "If this is not an exit, is the valid_from/valid_until\nconstraint on the ticket fulfilled?"
+        -down->[yes] "If this is not an exit, is the valid_from/valid_until\nconstraint on the ticket fulfilled?"
         --> if "" then
-            -right->[no && !force] "Return error INVALID_TIME"
+            -right->[no] "Return error INVALID_TIME"
         else
-            -down->[yes || force] "Is the product part of the check-in list?"
+            -down->[yes] "Is the product part of the check-in list?"
             --> if "" then
-                -right->[no && !force] "Return error PRODUCT"
+                -right->[no] "Return error PRODUCT"
             else
-                -down->[yes || force] "Is the subevent part of the check-in list?"
+                -down->[yes] "Is the subevent part of the check-in list?"
                 --> if "" then
-                    -right->[no && !force] "Return error PRODUCT "
+                    -right->[no] "Return error PRODUCT "
                 else
-                    -down->[yes] "Is the order in status PAID?"
+                    -down->[yes] "Is the order in status PAID\nor is this a forced upload?"
                     --> if "" then
-                        -right->[no && !force] "Is Order.require_approval set?"
+                        -right->[no] "Is Order.require_approval set?"
                         --> if "" then
                             -->[no] "Is Order.valid_if_pending set?"
                             --> if "" then
@@ -80,7 +80,7 @@ else
                             -->[yes] "Return error UNPAID "
                         endif
                     else
-                        -down->[yes || force] "Is this an entry or exit?\nIs the upload forced?"
+                        -down->[yes] "Is this an entry or exit?\nIs the upload forced?"
                     endif
                 endif
             endif

doc/requirements.rtd.txt

@@ -1,10 +1,10 @@
-sphinx==6.2.*
+sphinx==6.1.*
 jinja2==3.1.*
 sphinx-rtd-theme
 sphinxcontrib-httpdomain
 sphinxcontrib-images
 sphinxcontrib-jquery
-sphinxcontrib-spelling==8.*
+sphinxcontrib-spelling==7.*
 sphinxemoji
 pygments-markdown-lexer
 pyenchant==3.2.*

doc/requirements.txt

@@ -1,11 +1,11 @@
--e ../
-sphinx==6.2.*
+-e ../src/
+sphinx==6.1.*
 jinja2==3.1.*
 sphinx-rtd-theme
 sphinxcontrib-httpdomain
 sphinxcontrib-images
 sphinxcontrib-jquery
-sphinxcontrib-spelling==8.*
+sphinxcontrib-spelling==7.*
 sphinxemoji
 pygments-markdown-lexer
 pyenchant==3.2.*

doc/user/events/widget.rst

@@ -318,10 +318,7 @@ Currently, the following attributes are understood by pretix itself:
 
 * If ``data-consent="…"`` is given, the cookie consent mechanism will be initialized with consent for the given cookie
   providers. All other providers will be disabled, no consent dialog will be shown. This is useful if you already
-  asked the user for consent and don't want them to be asked again. Example: ``data-consent="facebook,google_analytics"``  
-
-  When using the pretix-tracking plugin, the following values are supported::  
-  ``adform, facebook, gosquared, google_ads, google_analytics, hubspot, linkedin, matomo, twitter``
+  asked the user for consent and don't want them to be asked again. Example: ``data-consent="facebook,google_analytics"``
 
 Any configured pretix plugins might understand more data fields. For example, if the appropriate plugins on pretix
 Hosted or pretix Enterprise are active, you can pass the following fields:

pyproject.toml

@@ -1,185 +0,0 @@
-[project]
-name = "pretix"
-dynamic = ["version"]
-description = "Reinventing presales, one ticket at a time"
-readme = "README.rst"
-requires-python = ">=3.9"
-license = {file = "LICENSE"}
-keywords = ["tickets", "web", "shop", "ecommerce"]
-authors = [
-  {name = "pretix team", email = "support@pretix.eu"},
-]
-maintainers = [
-  {name = "pretix team", email = "support@pretix.eu"},
-]
-classifiers = [
-  "Development Status :: 5 - Production/Stable",
-  "Intended Audience :: Developers",
-  "Intended Audience :: Other Audience",
-  "Topic :: Internet :: WWW/HTTP :: Dynamic Content",
-  "Environment :: Web Environment",
-  "License :: OSI Approved :: GNU Affero General Public License v3",
-  "Programming Language :: Python :: 3.9",
-  "Programming Language :: Python :: 3.10",
-  "Programming Language :: Python :: 3.11",
-  "Framework :: Django :: 3.2",
-]
-
-dependencies = [
-  # Note that many of these are repeated as build-time dependencies down below -- change them too in case of updates!
-  "arabic-reshaper==3.0.0",  # Support for Arabic in reportlab
-  "babel",
-  "BeautifulSoup4==4.12.*",
-  "bleach==5.0.*",
-  "celery==5.2.*",
-  "chardet==5.1.*",
-  "cryptography>=3.4.2",
-  "css-inline==0.8.*",
-  "defusedcsv>=1.1.0",
-  "dj-static",
-  "Django==3.2.*,>=3.2.18",
-  "django-bootstrap3==23.1.*",
-  "django-compressor==4.3.*",
-  "django-countries==7.5.*",
-  "django-filter==23.1",
-  "django-formset-js-improved==0.5.0.3",
-  "django-formtools==2.4",
-  "django-hierarkey==1.1.*",
-  "django-hijack==3.3.*",
-  "django-i18nfield==1.9.*,>=1.9.4",
-  "django-libsass==0.9",
-  "django-localflavor==4.0",
-  "django-markup",
-  "django-mysql",
-  "django-oauth-toolkit==2.2.*",
-  "django-otp==1.1.*",
-  "django-phonenumber-field==7.0.*",
-  "django-redis==5.2.*",
-  "django-scopes==1.2.*",
-  "django-statici18n==2.3.*",
-  "djangorestframework==3.14.*",
-  "dnspython==2.2.*",
-  "drf_ujson2==1.7.*",
-  "geoip2==4.*",
-  "importlib_metadata==6.6.*",  # Polyfill, we can probably drop this once we require Python 3.10+
-  "isoweek",
-  "jsonschema",
-  "kombu==5.2.*",
-  "libsass==0.22.*",
-  "lxml",
-  "markdown==3.4.3",  # 3.3.5 requires importlib-metadata>=4.4, but django-bootstrap3 requires importlib-metadata<3.
-  # We can upgrade markdown again once django-bootstrap3 upgrades or once we drop Python 3.6 and 3.7
-  "mt-940==4.23.*",
-  "oauthlib==3.2.*",
-  "openpyxl==3.1.*",
-  "packaging",
-  "paypalrestsdk==1.13.*",
-  "paypal-checkout-serversdk==1.0.*",
-  "PyJWT==2.6.*",
-  "phonenumberslite==8.13.*",
-  "Pillow==9.5.*",
-  "protobuf==4.22.*",
-  "psycopg2-binary",
-  "pycountry",
-  "pycparser==2.21",
-  "pycryptodome==3.17.*",
-  "pypdf==3.8.*",
-  "python-bidi==0.4.*",  # Support for Arabic in reportlab
-  "python-dateutil==2.8.*",
-  "python-u2flib-server==4.*",
-  "pytz",
-  "pyuca",
-  "qrcode==7.4.*",
-  "redis==4.5.*,>=4.5.4",
-  "reportlab==3.6.*",
-  "requests==2.28.*",
-  "sentry-sdk==1.15.*",
-  "sepaxml==2.6.*",
-  "slimit",
-  "static3==0.7.*",
-  "stripe==5.4.*",
-  "text-unidecode==1.*",
-  "tlds>=2020041600",
-  "tqdm==4.*",
-  "vat_moss_forked==2020.3.20.0.11.0",
-  "vobject==0.9.*",
-  "webauthn==0.4.*",
-  "zeep==4.2.*"
-]
-
-[project.optional-dependencies]
-memcached = ["pylibmc"]
-mysql = ["mysqlclient"]
-dev = [
-  "coverage",
-  "coveralls",
-  "django-debug-toolbar==4.0.*",
-  "django-formset-js-improved==0.5.0.3",
-  "django-oauth-toolkit==2.2.*",
-  "flake8==6.0.*",
-  "freezegun",
-  "isort==5.12.*",
-  "oauthlib==3.2.*",
-  "pep8-naming==0.13.*",
-  "potypo",
-  "pycodestyle==2.10.*",
-  "pyflakes==3.0.*",
-  "pytest-cache",
-  "pytest-cov",
-  "pytest-django==4.*",
-  "pytest-mock==3.10.*",
-  "pytest-rerunfailures==11.*",
-  "pytest-sugar",
-  "pytest-xdist==3.2.*",
-  "pytest==7.3.*",
-  "responses",
-]
-
-[project.entry-points."distutils.commands"]
-build = "pretix._build:CustomBuild"
-build_ext = "pretix._build:CustomBuildExt"
-
-[build-system]
-requires = [
-  "setuptools",
-  "setuptools-rust",
-  "wheel",
-  "importlib_metadata",
-
-  # These are runtime dependencies that we unfortunately need to be import in the step that generates
-  # all CSS and JS asset files. We should keep their versions in sync with the definition above.
-  "babel",
-  "Django==3.2.*,>=3.2.18",
-  "django-bootstrap3==23.1.*",
-  "django-compressor==4.3.*",
-  "django-countries==7.5.*",
-  "django-formtools==2.4",
-  "django-hierarkey==1.1.*",
-  "django-i18nfield==1.9.*,>=1.9.4",
-  "django-libsass==0.9",
-  "django-phonenumber-field==7.0.*",
-  "django-statici18n==2.3.*",
-  "djangorestframework==3.14.*",
-  "libsass==0.22.*",
-  "phonenumberslite==8.13.*",
-  "pycountry",
-  "pyuca",
-  "slimit",
-]
-
-[project.urls]
-homepage = "https://pretix.eu"
-documentation = "https://docs.pretix.eu"
-repository = "https://github.com/pretix/pretix.git"
-changelog = "https://pretix.eu/about/en/blog/"
-
-[tool.setuptools]
-include-package-data = true
-
-[tool.setuptools.dynamic]
-version = {attr = "pretix.__version__"}
-
-[tool.setuptools.packages.find]
-where = ["src"]
-include = ["pretix*"]
-namespaces = false

setup.py

@@ -1,26 +0,0 @@
-#
-# This file is part of pretix (Community Edition).
-#
-# Copyright (C) 2014-2020 Raphael Michel and contributors
-# Copyright (C) 2020-2021 rami.io GmbH and contributors
-#
-# This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General
-# Public License as published by the Free Software Foundation in version 3 of the License.
-#
-# ADDITIONAL TERMS APPLY: Pursuant to Section 7 of the GNU Affero General Public License, additional terms are
-# applicable granting you additional permissions and placing additional restrictions on your usage of this software.
-# Please refer to the pretix LICENSE file to obtain the full terms applicable to this work. If you did not receive
-# this file, see <https://pretix.eu/about/en/license>.
-#
-# This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
-# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more
-# details.
-#
-# You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
-# <https://www.gnu.org/licenses/>.
-#
-
-import setuptools
-
-if __name__ == "__main__":
-    setuptools.setup()

src/MANIFEST.in

@@ -0,0 +1,33 @@
+include LICENSE
+include README.rst
+global-include *.proto
+recursive-include pretix/static *
+recursive-include pretix/static.dist *
+recursive-include pretix/locale *
+recursive-include pretix/helpers/locale *
+recursive-include pretix/base/templates *
+recursive-include pretix/control/templates *
+recursive-include pretix/presale/templates *
+recursive-include pretix/plugins/banktransfer/templates *
+recursive-include pretix/plugins/banktransfer/static *
+recursive-include pretix/plugins/manualpayment/templates *
+recursive-include pretix/plugins/manualpayment/static *
+recursive-include pretix/plugins/paypal/templates *
+recursive-include pretix/plugins/paypal/static *
+recursive-include pretix/plugins/paypal2/templates *
+recursive-include pretix/plugins/paypal2/static *
+recursive-include pretix/plugins/pretixdroid/templates *
+recursive-include pretix/plugins/pretixdroid/static *
+recursive-include pretix/plugins/sendmail/templates *
+recursive-include pretix/plugins/statistics/templates *
+recursive-include pretix/plugins/statistics/static *
+recursive-include pretix/plugins/stripe/templates *
+recursive-include pretix/plugins/stripe/static *
+recursive-include pretix/plugins/ticketoutputpdf/templates *
+recursive-include pretix/plugins/ticketoutputpdf/static *
+recursive-include pretix/plugins/badges/templates *
+recursive-include pretix/plugins/badges/static *
+recursive-include pretix/plugins/returnurl/templates *
+recursive-include pretix/plugins/returnurl/static *
+recursive-include pretix/plugins/webcheckin/templates *
+recursive-include pretix/plugins/webcheckin/static *

src/pretix/__init__.py

@@ -19,4 +19,4 @@
 # You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
 # <https://www.gnu.org/licenses/>.
 #
-__version__ = "4.19.0"
+__version__ = "4.18.0.dev0"

src/pretix/_base_settings.py

@@ -1,251 +0,0 @@
-#
-# This file is part of pretix (Community Edition).
-#
-# Copyright (C) 2014-2020 Raphael Michel and contributors
-# Copyright (C) 2020-2021 rami.io GmbH and contributors
-#
-# This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General
-# Public License as published by the Free Software Foundation in version 3 of the License.
-#
-# ADDITIONAL TERMS APPLY: Pursuant to Section 7 of the GNU Affero General Public License, additional terms are
-# applicable granting you additional permissions and placing additional restrictions on your usage of this software.
-# Please refer to the pretix LICENSE file to obtain the full terms applicable to this work. If you did not receive
-# this file, see <https://pretix.eu/about/en/license>.
-#
-# This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
-# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more
-# details.
-#
-# You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
-# <https://www.gnu.org/licenses/>.
-#
-
-import os
-
-import django.conf.locale
-from pycountry import currencies
-
-from django.utils.translation import gettext_lazy as _  # NOQA
-
-BASE_DIR = os.path.dirname(os.path.dirname(__file__))
-
-USE_I18N = True
-USE_L10N = True
-USE_TZ = True
-
-INSTALLED_APPS = [
-    'django.contrib.auth',
-    'django.contrib.contenttypes',
-    'django.contrib.sessions',
-    'django.contrib.messages',
-    'django.contrib.staticfiles',
-    'django.contrib.humanize',
-    'pretix.base',
-    'pretix.control',
-    'pretix.presale',
-    'pretix.multidomain',
-    'pretix.api',
-    'pretix.helpers',
-    'rest_framework',
-    'djangoformsetjs',
-    'compressor',
-    'bootstrap3',
-    'pretix.plugins.banktransfer',
-    'pretix.plugins.stripe',
-    'pretix.plugins.paypal',
-    'pretix.plugins.paypal2',
-    'pretix.plugins.ticketoutputpdf',
-    'pretix.plugins.sendmail',
-    'pretix.plugins.statistics',
-    'pretix.plugins.reports',
-    'pretix.plugins.checkinlists',
-    'pretix.plugins.pretixdroid',
-    'pretix.plugins.badges',
-    'pretix.plugins.manualpayment',
-    'pretix.plugins.returnurl',
-    'pretix.plugins.webcheckin',
-    'django_countries',
-    'oauth2_provider',
-    'phonenumber_field',
-    'statici18n',
-]
-
-FORMAT_MODULE_PATH = [
-    'pretix.helpers.formats',
-]
-
-ALL_LANGUAGES = [
-    ('en', _('English')),
-    ('de', _('German')),
-    ('de-informal', _('German (informal)')),
-    ('ar', _('Arabic')),
-    ('zh-hans', _('Chinese (simplified)')),
-    ('cs', _('Czech')),
-    ('da', _('Danish')),
-    ('nl', _('Dutch')),
-    ('nl-informal', _('Dutch (informal)')),
-    ('fr', _('French')),
-    ('fi', _('Finnish')),
-    ('gl', _('Galician')),
-    ('el', _('Greek')),
-    ('it', _('Italian')),
-    ('lv', _('Latvian')),
-    ('pl', _('Polish')),
-    ('pt-pt', _('Portuguese (Portugal)')),
-    ('pt-br', _('Portuguese (Brazil)')),
-    ('ro', _('Romanian')),
-    ('ru', _('Russian')),
-    ('es', _('Spanish')),
-    ('tr', _('Turkish')),
-    ('uk', _('Ukrainian')),
-]
-LANGUAGES_OFFICIAL = {
-    'en', 'de', 'de-informal'
-}
-LANGUAGES_RTL = {
-    'ar', 'hw'
-}
-LANGUAGES_INCUBATING = {
-    'pl', 'fi', 'pt-br', 'gl',
-}
-LOCALE_PATHS = [
-    os.path.join(os.path.dirname(__file__), 'locale'),
-]
-
-EXTRA_LANG_INFO = {
-    'de-informal': {
-        'bidi': False,
-        'code': 'de-informal',
-        'name': 'German (informal)',
-        'name_local': 'Deutsch',
-        'public_code': 'de',
-    },
-    'nl-informal': {
-        'bidi': False,
-        'code': 'nl-informal',
-        'name': 'Dutch (informal)',
-        'name_local': 'Nederlands',
-        'public_code': 'nl',
-    },
-    'fr': {
-        'bidi': False,
-        'code': 'fr',
-        'name': 'French',
-        'name_local': 'Français'
-    },
-    'lv': {
-        'bidi': False,
-        'code': 'lv',
-        'name': 'Latvian',
-        'name_local': 'Latviešu'
-    },
-    'pt-pt': {
-        'bidi': False,
-        'code': 'pt-pt',
-        'name': 'Portuguese',
-        'name_local': 'Português',
-    },
-}
-
-django.conf.locale.LANG_INFO.update(EXTRA_LANG_INFO)
-
-template_loaders = (
-    'django.template.loaders.filesystem.Loader',
-    'pretix.helpers.template_loaders.AppLoader',
-)
-
-TEMPLATES = [
-    {
-        'BACKEND': 'django.template.backends.django.DjangoTemplates',
-        'DIRS': [
-            os.path.join(BASE_DIR, 'templates'),
-        ],
-        'OPTIONS': {
-            'context_processors': [
-                'django.contrib.auth.context_processors.auth',
-                'django.template.context_processors.debug',
-                'django.template.context_processors.i18n',
-                'django.template.context_processors.media',
-                "django.template.context_processors.request",
-                'django.template.context_processors.static',
-                'django.template.context_processors.tz',
-                'django.contrib.messages.context_processors.messages',
-                'pretix.base.context.contextprocessor',
-                'pretix.control.context.contextprocessor',
-                'pretix.presale.context.contextprocessor',
-            ],
-            'loaders': template_loaders
-        },
-    },
-]
-
-STATIC_ROOT = os.path.join(os.path.dirname(__file__), 'static.dist')
-
-STATICFILES_FINDERS = (
-    'django.contrib.staticfiles.finders.FileSystemFinder',
-    'django.contrib.staticfiles.finders.AppDirectoriesFinder',
-    'compressor.finders.CompressorFinder',
-)
-
-STATICFILES_DIRS = [
-    os.path.join(BASE_DIR, 'pretix/static')
-] if os.path.exists(os.path.join(BASE_DIR, 'pretix/static')) else []
-
-STATICI18N_ROOT = os.path.join(BASE_DIR, "pretix/static")
-
-STATICFILES_STORAGE = 'django.contrib.staticfiles.storage.ManifestStaticFilesStorage'
-
-# if os.path.exists(os.path.join(DATA_DIR, 'static')):
-#     STATICFILES_DIRS.insert(0, os.path.join(DATA_DIR, 'static'))
-
-COMPRESS_PRECOMPILERS = (
-    ('text/x-scss', 'django_libsass.SassCompiler'),
-    ('text/vue', 'pretix.helpers.compressor.VueCompiler'),
-)
-
-COMPRESS_OFFLINE_CONTEXT = {
-    'basetpl': 'empty.html',
-}
-
-COMPRESS_ENABLED = True
-COMPRESS_OFFLINE = True
-
-COMPRESS_FILTERS = {
-    'css': (
-        # CssAbsoluteFilter is incredibly slow, especially when dealing with our _flags.scss
-        # However, we don't need it if we consequently use the static() function in Sass
-        # 'compressor.filters.css_default.CssAbsoluteFilter',
-        'compressor.filters.cssmin.rCSSMinFilter',
-    ),
-    'js': (
-        'compressor.filters.jsmin.JSMinFilter',
-    )
-}
-
-CURRENCIES = list(currencies)
-CURRENCY_PLACES = {
-    # default is 2
-    'BIF': 0,
-    'CLP': 0,
-    'DJF': 0,
-    'GNF': 0,
-    'JPY': 0,
-    'KMF': 0,
-    'KRW': 0,
-    'MGA': 0,
-    'PYG': 0,
-    'RWF': 0,
-    'VND': 0,
-    'VUV': 0,
-    'XAF': 0,
-    'XOF': 0,
-    'XPF': 0,
-}
-
-PRETIX_EMAIL_NONE_VALUE = 'none@well-known.pretix.eu'
-PRETIX_PRIMARY_COLOR = '#8E44B3'
-
-# pretix includes caching options for some special situations where full HTML responses are cached. This might be
-# stressful for some cache setups so it is enabled by default and currently can't be enabled through pretix.cfg
-CACHE_LARGE_VALUES_ALLOWED = False
-CACHE_LARGE_VALUES_ALIAS = 'default'

src/pretix/_build.py

@@ -1,74 +0,0 @@
-#
-# This file is part of pretix (Community Edition).
-#
-# Copyright (C) 2014-2020 Raphael Michel and contributors
-# Copyright (C) 2020-2021 rami.io GmbH and contributors
-#
-# This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General
-# Public License as published by the Free Software Foundation in version 3 of the License.
-#
-# ADDITIONAL TERMS APPLY: Pursuant to Section 7 of the GNU Affero General Public License, additional terms are
-# applicable granting you additional permissions and placing additional restrictions on your usage of this software.
-# Please refer to the pretix LICENSE file to obtain the full terms applicable to this work. If you did not receive
-# this file, see <https://pretix.eu/about/en/license>.
-#
-# This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
-# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more
-# details.
-#
-# You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
-# <https://www.gnu.org/licenses/>.
-#
-
-import os
-import shutil
-import subprocess
-
-from setuptools.command.build import build
-from setuptools.command.build_ext import build_ext
-
-here = os.path.abspath(os.path.dirname(__file__))
-npm_installed = False
-
-
-def npm_install():
-    global npm_installed
-
-    if not npm_installed:
-        # keep this in sync with Makefile!
-        node_prefix = os.path.join(here, 'static.dist', 'node_prefix')
-        os.makedirs(node_prefix, exist_ok=True)
-        shutil.copytree(os.path.join(here, 'static', 'npm_dir'), node_prefix, dirs_exist_ok=True)
-        subprocess.check_call('npm install', shell=True, cwd=node_prefix)
-        npm_installed = True
-
-
-class CustomBuild(build):
-    def run(self):
-        if "PRETIX_DOCKER_BUILD" in os.environ:
-            return  # this is a hack to allow calling this file early in our docker build to make use of caching
-        os.environ.setdefault("DJANGO_SETTINGS_MODULE", "pretix._build_settings")
-        os.environ.setdefault("PRETIX_IGNORE_CONFLICTS", "True")
-        import django
-        django.setup()
-        from django.conf import settings
-        from django.core import management
-
-        settings.COMPRESS_ENABLED = True
-        settings.COMPRESS_OFFLINE = True
-
-        npm_install()
-        management.call_command('compilemessages', verbosity=1)
-        management.call_command('compilejsi18n', verbosity=1)
-        management.call_command('collectstatic', verbosity=1, interactive=False)
-        management.call_command('compress', verbosity=1)
-
-        build.run(self)
-
-
-class CustomBuildExt(build_ext):
-    def run(self):
-        if "PRETIX_DOCKER_BUILD" in os.environ:
-            return  # this is a hack to allow calling this file early in our docker build to make use of caching
-        npm_install()
-        build_ext.run(self)

src/pretix/_build_settings.py

@@ -1,48 +0,0 @@
-#
-# This file is part of pretix (Community Edition).
-#
-# Copyright (C) 2014-2020 Raphael Michel and contributors
-# Copyright (C) 2020-2021 rami.io GmbH and contributors
-#
-# This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General
-# Public License as published by the Free Software Foundation in version 3 of the License.
-#
-# ADDITIONAL TERMS APPLY: Pursuant to Section 7 of the GNU Affero General Public License, additional terms are
-# applicable granting you additional permissions and placing additional restrictions on your usage of this software.
-# Please refer to the pretix LICENSE file to obtain the full terms applicable to this work. If you did not receive
-# this file, see <https://pretix.eu/about/en/license>.
-#
-# This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
-# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more
-# details.
-#
-# You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
-# <https://www.gnu.org/licenses/>.
-#
-
-"""
-This file contains settings that we need at wheel require time. All settings that we only need at runtime are set
-in settings.py.
-"""
-from ._base_settings import *  # NOQA
-
-ENTROPY = {
-    'order_code': 5,
-    'customer_identifier': 7,
-    'ticket_secret': 32,
-    'voucher_code': 16,
-    'giftcard_secret': 12,
-}
-
-MAIL_FROM_ORGANIZERS = 'invalid@invalid'
-FILE_UPLOAD_MAX_SIZE_EMAIL_AUTO_ATTACHMENT = 10
-FILE_UPLOAD_MAX_SIZE_EMAIL_ATTACHMENT = 10
-FILE_UPLOAD_MAX_SIZE_IMAGE = 10
-DEFAULT_CURRENCY = 'EUR'
-SECRET_KEY = "build-time-secret-key"
-HAS_REDIS = False
-STATIC_URL = '/static/'
-HAS_MEMCACHED = False
-HAS_CELERY = False
-HAS_GEOIP = False
-SENTRY_ENABLED = False

src/pretix/api/auth/devicesecurity.py

@@ -81,7 +81,6 @@ class PretixScanSecurityProfile(AllowListSecurityProfile):
         ('POST', 'api-v1:upload'),
         ('POST', 'api-v1:checkinrpc.redeem'),
         ('GET', 'api-v1:checkinrpc.search'),
-        ('GET', 'api-v1:reusablemedium-list'),
     )
 
 
@@ -221,7 +220,6 @@ class PretixPosSecurityProfile(AllowListSecurityProfile):
         ('POST', 'api-v1:upload'),
         ('POST', 'api-v1:checkinrpc.redeem'),
         ('GET', 'api-v1:checkinrpc.search'),
-        ('POST', 'api-v1:reusablemedium-lookup'),
     )
 
 

src/pretix/api/serializers/checkin.py

@@ -26,7 +26,6 @@ from rest_framework.exceptions import ValidationError
 from pretix.api.serializers.event import SubEventSerializer
 from pretix.api.serializers.i18n import I18nAwareModelSerializer
 from pretix.base.channels import get_all_sales_channels
-from pretix.base.media import MEDIA_TYPES
 from pretix.base.models import Checkin, CheckinList
 
 
@@ -85,7 +84,6 @@ class CheckinRPCRedeemInputSerializer(serializers.Serializer):
     lists = serializers.PrimaryKeyRelatedField(required=True, many=True, queryset=CheckinList.objects.none())
     secret = serializers.CharField(required=True, allow_null=False)
     force = serializers.BooleanField(default=False, required=False)
-    source_type = serializers.ChoiceField(choices=[(k, v) for k, v in MEDIA_TYPES.items()], default='barcode')
     type = serializers.ChoiceField(choices=Checkin.CHECKIN_TYPES, default=Checkin.TYPE_ENTRY)
     ignore_unpaid = serializers.BooleanField(default=False, required=False)
     questions_supported = serializers.BooleanField(default=True, required=False)

src/pretix/api/serializers/event.py

@@ -693,7 +693,6 @@ class EventSettingsSerializer(SettingsSerializer):
         'frontpage_subevent_ordering',
         'event_list_type',
         'event_list_available_only',
-        'event_calendar_future_only',
         'frontpage_text',
         'event_info_text',
         'attendee_names_asked',
@@ -785,7 +784,6 @@ class EventSettingsSerializer(SettingsSerializer):
         'change_allow_user_addons',
         'change_allow_user_until',
         'change_allow_user_price',
-        'change_allow_attendee',
         'primary_color',
         'theme_color_success',
         'theme_color_danger',
@@ -797,21 +795,6 @@ class EventSettingsSerializer(SettingsSerializer):
         'logo_show_title',
         'og_image',
         'name_scheme',
-        'reusable_media_active',
-        'reusable_media_type_barcode',
-        'reusable_media_type_barcode_identifier_length',
-        'reusable_media_type_nfc_uid',
-        'reusable_media_type_nfc_uid_autocreate_giftcard',
-        'reusable_media_type_nfc_uid_autocreate_giftcard_currency',
-    ]
-    readonly_fields = [
-        # These are read-only since they are currently only settable on organizers, not events
-        'reusable_media_active',
-        'reusable_media_type_barcode',
-        'reusable_media_type_barcode_identifier_length',
-        'reusable_media_type_nfc_uid',
-        'reusable_media_type_nfc_uid_autocreate_giftcard',
-        'reusable_media_type_nfc_uid_autocreate_giftcard_currency',
     ]
 
     def __init__(self, *args, **kwargs):
@@ -878,9 +861,6 @@ class DeviceEventSettingsSerializer(EventSettingsSerializer):
         'invoice_address_from_tax_id',
         'invoice_address_from_vat_id',
         'name_scheme',
-        'reusable_media_type_barcode',
-        'reusable_media_type_nfc_uid',
-        'system_question_order',
     ]
 
     def __init__(self, *args, **kwargs):

src/pretix/api/serializers/i18n.py

@@ -20,7 +20,6 @@
 # <https://www.gnu.org/licenses/>.
 #
 from django.conf import settings
-from django.core.validators import URLValidator
 from i18nfield.fields import I18nCharField, I18nTextField
 from i18nfield.strings import LazyI18nString
 from rest_framework.exceptions import ValidationError
@@ -70,17 +69,3 @@ class I18nAwareModelSerializer(ModelSerializer):
 
 I18nAwareModelSerializer.serializer_field_mapping[I18nCharField] = I18nField
 I18nAwareModelSerializer.serializer_field_mapping[I18nTextField] = I18nField
-
-
-class I18nURLField(I18nField):
-    def to_internal_value(self, value):
-        value = super().to_internal_value(value)
-        if not value:
-            return value
-        if isinstance(value.data, dict):
-            for v in value.data.values():
-                if v:
-                    URLValidator()(v)
-        else:
-            URLValidator()(value.data)
-        return value

src/pretix/api/serializers/item.py

@@ -52,7 +52,7 @@ from pretix.base.models import (
 
 
 class InlineItemVariationSerializer(I18nAwareModelSerializer):
-    price = serializers.DecimalField(read_only=True, decimal_places=2, max_digits=13,
+    price = serializers.DecimalField(read_only=True, decimal_places=2, max_digits=10,
                                      coerce_to_string=True)
     meta_data = MetaDataField(required=False, source='*')
 
@@ -76,7 +76,7 @@ class InlineItemVariationSerializer(I18nAwareModelSerializer):
 
 
 class ItemVariationSerializer(I18nAwareModelSerializer):
-    price = serializers.DecimalField(read_only=True, decimal_places=2, max_digits=13,
+    price = serializers.DecimalField(read_only=True, decimal_places=2, max_digits=10,
                                      coerce_to_string=True)
     meta_data = MetaDataField(required=False, source='*')
 
@@ -244,8 +244,7 @@ class ItemSerializer(I18nAwareModelSerializer):
                   'grant_membership_duration_like_event', 'grant_membership_duration_days',
                   'grant_membership_duration_months', 'validity_mode', 'validity_fixed_from', 'validity_fixed_until',
                   'validity_dynamic_duration_minutes', 'validity_dynamic_duration_hours', 'validity_dynamic_duration_days',
-                  'validity_dynamic_duration_months', 'validity_dynamic_start_choice', 'validity_dynamic_start_choice_day_limit',
-                  'media_policy', 'media_type')
+                  'validity_dynamic_duration_months', 'validity_dynamic_start_choice', 'validity_dynamic_start_choice_day_limit')
         read_only_fields = ('has_variations',)
 
     def __init__(self, *args, **kwargs):
@@ -264,7 +263,6 @@ class ItemSerializer(I18nAwareModelSerializer):
 
         Item.clean_per_order(data.get('min_per_order'), data.get('max_per_order'))
         Item.clean_available(data.get('available_from'), data.get('available_until'))
-        Item.clean_media_settings(self.context['event'], data.get('media_policy'), data.get('media_type'), data.get('issue_giftcard'))
 
         if data.get('personalized') and not data.get('admission'):
             raise ValidationError(_('Only admission products can currently be personalized.'))
@@ -306,9 +304,9 @@ class ItemSerializer(I18nAwareModelSerializer):
         if not self.instance:
             for addon_data in value:
                 ItemAddOn.clean_categories(self.context['event'], None, self.instance, addon_data['addon_category'])
-                ItemAddOn.clean_min_count(addon_data.get('min_count', 0))
-                ItemAddOn.clean_max_count(addon_data.get('max_count', 0))
-                ItemAddOn.clean_max_min_count(addon_data.get('max_count', 0), addon_data.get('min_count', 0))
+                ItemAddOn.clean_min_count(addon_data['min_count'])
+                ItemAddOn.clean_max_count(addon_data['max_count'])
+                ItemAddOn.clean_max_min_count(addon_data['max_count'], addon_data['min_count'])
         return value
 
     @cached_property
@@ -442,7 +440,7 @@ class QuestionSerializer(I18nAwareModelSerializer):
                   'ask_during_checkin', 'identifier', 'dependency_question', 'dependency_values',
                   'hidden', 'dependency_value', 'print_on_invoice', 'help_text', 'valid_number_min',
                   'valid_number_max', 'valid_date_min', 'valid_date_max', 'valid_datetime_min', 'valid_datetime_max',
-                  'valid_string_length_max', 'valid_file_portrait')
+                  'valid_file_portrait')
 
     def validate_identifier(self, value):
         Question._clean_identifier(self.context['event'], value, self.instance)

src/pretix/api/serializers/media.py

@@ -1,128 +0,0 @@
-#
-# This file is part of pretix (Community Edition).
-#
-# Copyright (C) 2014-2020 Raphael Michel and contributors
-# Copyright (C) 2020-2021 rami.io GmbH and contributors
-#
-# This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General
-# Public License as published by the Free Software Foundation in version 3 of the License.
-#
-# ADDITIONAL TERMS APPLY: Pursuant to Section 7 of the GNU Affero General Public License, additional terms are
-# applicable granting you additional permissions and placing additional restrictions on your usage of this software.
-# Please refer to the pretix LICENSE file to obtain the full terms applicable to this work. If you did not receive
-# this file, see <https://pretix.eu/about/en/license>.
-#
-# This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
-# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more
-# details.
-#
-# You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
-# <https://www.gnu.org/licenses/>.
-#
-import logging
-from decimal import Decimal
-
-from django.utils.translation import gettext_lazy as _
-from rest_framework import serializers
-from rest_framework.exceptions import ValidationError
-
-from pretix.api.serializers.i18n import I18nAwareModelSerializer
-from pretix.api.serializers.order import OrderPositionSerializer
-from pretix.api.serializers.organizer import (
-    CustomerSerializer, GiftCardSerializer,
-)
-from pretix.base.models import Order, OrderPosition, ReusableMedium
-
-logger = logging.getLogger(__name__)
-
-
-class NestedOrderMiniSerializer(I18nAwareModelSerializer):
-    event = serializers.SlugRelatedField(slug_field='slug', read_only=True)
-
-    class Meta:
-        model = Order
-        fields = ['code', 'event']
-
-
-class NestedOrderPositionSerializer(OrderPositionSerializer):
-    order = NestedOrderMiniSerializer()
-
-
-class NestedGiftCardSerializer(GiftCardSerializer):
-
-    def to_representation(self, instance):
-        d = super().to_representation(instance)
-        if hasattr(instance, 'cached_value'):
-            d['value'] = str(Decimal(instance.cached_value).quantize(Decimal("0.01")))
-        else:
-            d['value'] = str(Decimal(instance.value).quantize(Decimal("0.01")))
-        return d
-
-
-class ReusableMediaSerializer(I18nAwareModelSerializer):
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-
-        if 'linked_giftcard' in self.context['request'].query_params.getlist('expand'):
-            self.fields['linked_giftcard'] = NestedGiftCardSerializer(read_only=True)
-        else:
-            self.fields['linked_giftcard'] = serializers.PrimaryKeyRelatedField(
-                required=False,
-                allow_null=True,
-                queryset=self.context['organizer'].issued_gift_cards.all()
-            )
-
-        if 'linked_orderposition' in self.context['request'].query_params.getlist('expand'):
-            self.fields['linked_orderposition'] = NestedOrderPositionSerializer(read_only=True)
-        else:
-            self.fields['linked_orderposition'] = serializers.PrimaryKeyRelatedField(
-                required=False,
-                allow_null=True,
-                queryset=OrderPosition.all.filter(order__event__organizer=self.context['organizer']),
-            )
-
-        if 'customer' in self.context['request'].query_params.getlist('expand'):
-            self.fields['customer'] = CustomerSerializer(read_only=True)
-        else:
-            self.fields['customer'] = serializers.SlugRelatedField(
-                required=False,
-                allow_null=True,
-                slug_field='identifier',
-                queryset=self.context['organizer'].customers.all()
-            )
-
-    def validate(self, data):
-        data = super().validate(data)
-        if 'type' in data and 'identifier' in data:
-            qs = self.context['organizer'].reusable_media.filter(
-                identifier=data['identifier'], type=data['type']
-            )
-            if self.instance:
-                qs = qs.exclude(pk=self.instance.pk)
-            if qs.exists():
-                raise ValidationError(
-                    {'identifier': _('A medium with the same identifier and type already exists in your organizer account.')}
-                )
-        return data
-
-    class Meta:
-        model = ReusableMedium
-        fields = (
-            'id',
-            'created',
-            'updated',
-            'type',
-            'identifier',
-            'active',
-            'expires',
-            'customer',
-            'linked_orderposition',
-            'linked_giftcard',
-            'info',
-            'notes',
-        )
-
-
-class MediaLookupInputSerializer(serializers.Serializer):
-    type = serializers.CharField(required=True)
-    identifier = serializers.CharField(required=True)

src/pretix/api/serializers/order.py

@@ -33,7 +33,6 @@ from django.utils.encoding import force_str
 from django.utils.timezone import now
 from django.utils.translation import gettext_lazy
 from django_countries.fields import Country
-from django_scopes import scopes_disabled
 from rest_framework import serializers
 from rest_framework.exceptions import ValidationError
 from rest_framework.relations import SlugRelatedField
@@ -49,8 +48,8 @@ from pretix.base.decimal import round_decimal
 from pretix.base.i18n import language
 from pretix.base.models import (
     CachedFile, Checkin, Customer, Invoice, InvoiceAddress, InvoiceLine, Item,
-    ItemVariation, Order, OrderPosition, Question, QuestionAnswer,
-    ReusableMedium, Seat, SubEvent, TaxRule, Voucher,
+    ItemVariation, Order, OrderPosition, Question, QuestionAnswer, Seat,
+    SubEvent, TaxRule, Voucher,
 )
 from pretix.base.models.orders import (
     BlockedTicketSecret, CartPosition, OrderFee, OrderPayment, OrderRefund,
@@ -357,9 +356,6 @@ class PdfDataSerializer(serializers.Field):
     def to_representation(self, instance: OrderPosition):
         res = {}
 
-        if 'event' not in self.context:
-            return {}
-
         ev = instance.subevent or instance.order.event
         with language(instance.order.locale, instance.order.event.settings.region):
             # This needs to have some extra performance improvements to avoid creating hundreds of queries when
@@ -385,9 +381,11 @@ class PdfDataSerializer(serializers.Field):
                 res['meta:' + k] = v
 
             if instance.variation_id:
+                print(instance, instance.variation, instance.variation_id, instance.item)
                 if not hasattr(instance.variation, '_cached_meta_data'):
                     instance.variation.item = instance.item  # saves some database lookups
                     instance.variation._cached_meta_data = instance.variation.meta_data
+                print(instance.variation._cached_meta_data.items())
                 for k, v in instance.variation._cached_meta_data.items():
                     res['itemmeta:' + k] = v
             else:
@@ -783,20 +781,18 @@ class OrderPositionCreateSerializer(I18nAwareModelSerializer):
     attendee_name = serializers.CharField(required=False, allow_null=True)
     seat = serializers.CharField(required=False, allow_null=True)
     price = serializers.DecimalField(required=False, allow_null=True, decimal_places=2,
-                                     max_digits=13)
+                                     max_digits=10)
     voucher = serializers.SlugRelatedField(slug_field='code', queryset=Voucher.objects.none(),
                                            required=False, allow_null=True)
     country = CompatibleCountryField(source='*')
     requested_valid_from = serializers.DateTimeField(required=False, allow_null=True)
-    use_reusable_medium = serializers.PrimaryKeyRelatedField(queryset=ReusableMedium.objects.none(),
-                                                             required=False, allow_null=True)
 
     class Meta:
         model = OrderPosition
         fields = ('positionid', 'item', 'variation', 'price', 'attendee_name', 'attendee_name_parts', 'attendee_email',
                   'company', 'street', 'zipcode', 'city', 'country', 'state', 'is_bundled',
                   'secret', 'addon_to', 'subevent', 'answers', 'seat', 'voucher', 'valid_from', 'valid_until',
-                  'requested_valid_from', 'use_reusable_medium')
+                  'requested_valid_from')
 
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
@@ -805,9 +801,6 @@ class OrderPositionCreateSerializer(I18nAwareModelSerializer):
                 v.required = False
                 v.allow_blank = True
                 v.allow_null = True
-        with scopes_disabled():
-            if 'use_reusable_medium' in self.fields:
-                self.fields['use_reusable_medium'].queryset = ReusableMedium.objects.all()
 
     def validate_secret(self, secret):
         if secret and OrderPosition.all.filter(order__event=self.context['event'], secret=secret).exists():
@@ -816,13 +809,6 @@ class OrderPositionCreateSerializer(I18nAwareModelSerializer):
             )
         return secret
 
-    def validate_use_reusable_medium(self, m):
-        if m.organizer_id != self.context['event'].organizer_id:
-            raise ValidationError(
-                'The specified medium does not belong to this organizer.'
-            )
-        return m
-
     def validate_item(self, item):
         if item.event != self.context['event']:
             raise ValidationError(
@@ -1280,7 +1266,7 @@ class OrderCreateSerializer(I18nAwareModelSerializer):
                     pos_data['attendee_name_parts'] = {
                         '_legacy': attendee_name
                     }
-                pos = OrderPosition(**{k: v for k, v in pos_data.items() if k != 'answers' and k != '_quotas' and k != 'use_reusable_medium'})
+                pos = OrderPosition(**{k: v for k, v in pos_data.items() if k != 'answers' and k != '_quotas'})
                 if simulate:
                     pos.order = order._wrapped
                 else:
@@ -1348,7 +1334,6 @@ class OrderCreateSerializer(I18nAwareModelSerializer):
             # Save instances
             for pos_data in positions_data:
                 answers_data = pos_data.pop('answers', [])
-                use_reusable_medium = pos_data.pop('use_reusable_medium', None)
                 pos = pos_data['__instance']
                 pos._calculate_tax()
 
@@ -1387,17 +1372,6 @@ class OrderCreateSerializer(I18nAwareModelSerializer):
                             answ = pos.answers.create(**answ_data)
                             answ.options.add(*options)
 
-                    if use_reusable_medium:
-                        use_reusable_medium.linked_orderposition = pos
-                        use_reusable_medium.save(update_fields=['linked_orderposition'])
-                        use_reusable_medium.log_action(
-                            'pretix.reusable_medium.linked_orderposition.changed',
-                            data={
-                                'by_order': order.code,
-                                'linked_orderposition': pos.pk,
-                            }
-                        )
-
             if not simulate:
                 for cp in delete_cps:
                     if cp.addon_to_id:

src/pretix/api/serializers/orderchange.py

@@ -47,7 +47,7 @@ class OrderPositionCreateForExistingOrderSerializer(OrderPositionCreateSerialize
     attendee_name = serializers.CharField(required=False, allow_null=True)
     seat = serializers.CharField(required=False, allow_null=True)
     price = serializers.DecimalField(required=False, allow_null=True, decimal_places=2,
-                                     max_digits=13)
+                                     max_digits=10)
     country = CompatibleCountryField(source='*')
 
     class Meta:

src/pretix/api/serializers/organizer.py

@@ -128,7 +128,7 @@ class MembershipSerializer(I18nAwareModelSerializer):
 
 
 class GiftCardSerializer(I18nAwareModelSerializer):
-    value = serializers.DecimalField(max_digits=13, decimal_places=2, min_value=Decimal('0.00'))
+    value = serializers.DecimalField(max_digits=10, decimal_places=2, min_value=Decimal('0.00'))
 
     def validate(self, data):
         data = super().validate(data)
@@ -183,7 +183,7 @@ class TeamSerializer(serializers.ModelSerializer):
             'id', 'name', 'all_events', 'limit_events', 'can_create_events', 'can_change_teams',
             'can_change_organizer_settings', 'can_manage_gift_cards', 'can_change_event_settings',
             'can_change_items', 'can_view_orders', 'can_change_orders', 'can_view_vouchers',
-            'can_change_vouchers', 'can_checkin_orders', 'can_manage_customers', 'can_manage_reusable_media'
+            'can_change_vouchers', 'can_checkin_orders', 'can_manage_customers'
         )
 
     def validate(self, data):
@@ -333,12 +333,6 @@ class OrganizerSettingsSerializer(SettingsSerializer):
         'cookie_consent_dialog_text_secondary',
         'cookie_consent_dialog_button_yes',
         'cookie_consent_dialog_button_no',
-        'reusable_media_active',
-        'reusable_media_type_barcode',
-        'reusable_media_type_barcode_identifier_length',
-        'reusable_media_type_nfc_uid',
-        'reusable_media_type_nfc_uid_autocreate_giftcard',
-        'reusable_media_type_nfc_uid_autocreate_giftcard_currency',
     ]
 
     def __init__(self, *args, **kwargs):

src/pretix/api/serializers/settings.py

@@ -36,7 +36,6 @@ logger = logging.getLogger(__name__)
 
 class SettingsSerializer(serializers.Serializer):
     default_fields = []
-    readonly_fields = []
 
     def __init__(self, *args, **kwargs):
         self.changed_data = []
@@ -60,13 +59,8 @@ class SettingsSerializer(serializers.Serializer):
             f.parent = self
             self.fields[fname] = f
 
-    def validate(self, attrs):
-        return {k: v for k, v in attrs.items() if k not in self.readonly_fields}
-
     def update(self, instance: HierarkeyProxy, validated_data):
         for attr, value in validated_data.items():
-            if attr in self.readonly_fields:
-                continue
             if isinstance(value, FieldFile):
                 # Delete old file
                 fname = instance.get(attr, as_type=File)

src/pretix/api/urls.py

@@ -42,9 +42,9 @@ from rest_framework import routers
 from pretix.api.views import cart
 
 from .views import (
-    checkin, device, discount, event, exporters, idempotency, item, media,
-    oauth, order, organizer, shredders, upload, user, version, voucher,
-    waitinglist, webhooks,
+    checkin, device, discount, event, exporters, idempotency, item, oauth,
+    order, organizer, shredders, upload, user, version, voucher, waitinglist,
+    webhooks,
 )
 
 router = routers.DefaultRouter()
@@ -59,7 +59,6 @@ orga_router.register(r'giftcards', organizer.GiftCardViewSet)
 orga_router.register(r'customers', organizer.CustomerViewSet)
 orga_router.register(r'memberships', organizer.MembershipViewSet)
 orga_router.register(r'membershiptypes', organizer.MembershipTypeViewSet)
-orga_router.register(r'reusablemedia', media.ReusableMediaViewSet)
 orga_router.register(r'teams', organizer.TeamViewSet)
 orga_router.register(r'devices', organizer.DeviceViewSet)
 orga_router.register(r'exporters', exporters.OrganizerExportersViewSet, basename='exporters')

src/pretix/api/views/checkin.py

@@ -59,7 +59,7 @@ from pretix.api.views.order import OrderPositionFilter
 from pretix.base.i18n import language
 from pretix.base.models import (
     CachedFile, Checkin, CheckinList, Device, Event, Order, OrderPosition,
-    Question, ReusableMedium, RevokedTicketSecret, TeamAPIToken,
+    Question, RevokedTicketSecret, TeamAPIToken,
 )
 from pretix.base.services.checkin import (
     CheckInError, RequiredQuestionsError, SQLLogic, perform_checkin,
@@ -396,7 +396,7 @@ def _checkin_list_position_queryset(checkinlists, ignore_status=False, ignore_pr
 
 def _redeem_process(*, checkinlists, raw_barcode, answers_data, datetime, force, checkin_type, ignore_unpaid, nonce,
                     untrusted_input, user, auth, expand, pdf_data, request, questions_supported, canceled_supported,
-                    source_type='barcode', legacy_url_support=False):
+                    legacy_url_support=False):
     if not checkinlists:
         raise ValidationError('No check-in list passed.')
 
@@ -422,7 +422,6 @@ def _redeem_process(*, checkinlists, raw_barcode, answers_data, datetime, force,
 
     common_checkin_args = dict(
         raw_barcode=raw_barcode,
-        raw_source_type=source_type,
         type=checkin_type,
         list=checkinlists[0],
         datetime=datetime,
@@ -434,7 +433,7 @@ def _redeem_process(*, checkinlists, raw_barcode, answers_data, datetime, force,
     raw_barcode_for_checkin = None
     from_revoked_secret = False
 
-    # 1. Gather a list of positions that could be the one we looking for, either from their ID, secret or
+    # 1. Gather a list of positions that could be the one we looking fore, either from their ID, secret or
     #    parent secret
     queryset = _checkin_list_position_queryset(checkinlists, pdf_data=pdf_data, ignore_status=True, ignore_products=True).order_by(
         F('addon_to').asc(nulls_first=True)
@@ -458,111 +457,98 @@ def _redeem_process(*, checkinlists, raw_barcode, answers_data, datetime, force,
 
     # 2. Handle the "nothing found" case: Either it's really a bogus secret that we don't know (-> error), or it
     #    might be a revoked one that we actually know (-> error, but with better error message and logging and
-    #    with respecting the force option), or it's a reusable medium (-> proceed with that)
+    #    with respecting the force option).
     if not op_candidates:
-        try:
-            media = ReusableMedium.objects.select_related('linked_orderposition').active().get(
-                organizer_id=checkinlists[0].event.organizer_id,
-                type=source_type,
-                identifier=raw_barcode,
-                linked_orderposition__isnull=False,
-            )
-            raw_barcode_for_checkin = raw_barcode
-        except ReusableMedium.DoesNotExist:
-            revoked_matches = list(
-                RevokedTicketSecret.objects.filter(event_id__in=list_by_event.keys(), secret=raw_barcode))
-            if len(revoked_matches) == 0:
-                checkinlists[0].event.log_action('pretix.event.checkin.unknown', data={
-                    'datetime': datetime,
-                    'type': checkin_type,
-                    'list': checkinlists[0].pk,
-                    'barcode': raw_barcode,
-                    'searched_lists': [cl.pk for cl in checkinlists]
-                }, user=user, auth=auth)
+        revoked_matches = list(RevokedTicketSecret.objects.filter(event_id__in=list_by_event.keys(), secret=raw_barcode))
+        if len(revoked_matches) == 0:
+            checkinlists[0].event.log_action('pretix.event.checkin.unknown', data={
+                'datetime': datetime,
+                'type': checkin_type,
+                'list': checkinlists[0].pk,
+                'barcode': raw_barcode,
+                'searched_lists': [cl.pk for cl in checkinlists]
+            }, user=user, auth=auth)
 
-                for cl in checkinlists:
-                    for k, s in cl.event.ticket_secret_generators.items():
-                        try:
-                            parsed = s.parse_secret(raw_barcode)
-                            common_checkin_args.update({
-                                'raw_item': parsed.item,
-                                'raw_variation': parsed.variation,
-                                'raw_subevent': parsed.subevent,
-                            })
-                        except:
-                            pass
-
-                Checkin.objects.create(
-                    position=None,
-                    successful=False,
-                    error_reason=Checkin.REASON_INVALID,
-                    **common_checkin_args,
-                )
-
-                if force and legacy_url_support and isinstance(auth, Device):
-                    # There was a bug in libpretixsync: If you scanned a ticket in offline mode that was
-                    # valid at the time but no longer exists at time of upload, the device would retry to
-                    # upload the same scan over and over again. Since we can't update all devices quickly,
-                    # here's a dirty workaround to make it stop.
+            for cl in checkinlists:
+                for k, s in cl.event.ticket_secret_generators.items():
                     try:
-                        brand = auth.software_brand
-                        ver = parse(auth.software_version)
-                        legacy_mode = (
-                            (brand == 'pretixSCANPROXY' and ver < parse('0.0.3')) or
-                            (brand == 'pretixSCAN Android' and ver < parse('1.11.2')) or
-                            (brand == 'pretixSCAN' and ver < parse('1.11.2'))
-                        )
-                        if legacy_mode:
-                            return Response({
-                                'status': 'error',
-                                'reason': Checkin.REASON_ALREADY_REDEEMED,
-                                'reason_explanation': None,
-                                'require_attention': False,
-                                '__warning': 'Compatibility hack active due to detected old pretixSCAN version',
-                            }, status=400)
-                    except:  # we don't care e.g. about invalid version numbers
+                        parsed = s.parse_secret(raw_barcode)
+                        common_checkin_args.update({
+                            'raw_item': parsed.item,
+                            'raw_variation': parsed.variation,
+                            'raw_subevent': parsed.subevent,
+                        })
+                    except:
                         pass
 
-                return Response({
-                    'detail': 'Not found.',  # for backwards compatibility
-                    'status': 'error',
-                    'reason': Checkin.REASON_INVALID,
-                    'reason_explanation': None,
-                    'require_attention': False,
-                    'list': MiniCheckinListSerializer(checkinlists[0]).data,
-                }, status=404)
-            elif revoked_matches and force:
-                op_candidates = [revoked_matches[0].position]
-                if list_by_event[revoked_matches[0].event_id].addon_match:
-                    op_candidates += list(revoked_matches[0].position.addons.all())
-                raw_barcode_for_checkin = raw_barcode_for_checkin or raw_barcode
-                from_revoked_secret = True
-            else:
-                op = revoked_matches[0].position
-                op.order.log_action('pretix.event.checkin.revoked', data={
-                    'datetime': datetime,
-                    'type': checkin_type,
-                    'list': list_by_event[revoked_matches[0].event_id].pk,
-                    'barcode': raw_barcode
-                }, user=user, auth=auth)
-                common_checkin_args['list'] = list_by_event[revoked_matches[0].event_id]
-                Checkin.objects.create(
-                    position=op,
-                    successful=False,
-                    error_reason=Checkin.REASON_REVOKED,
-                    **common_checkin_args
-                )
-                return Response({
-                    'status': 'error',
-                    'reason': Checkin.REASON_REVOKED,
-                    'reason_explanation': None,
-                    'require_attention': False,
-                    'position': CheckinListOrderPositionSerializer(op, context=_make_context(context, revoked_matches[
-                        0].event)).data,
-                    'list': MiniCheckinListSerializer(list_by_event[revoked_matches[0].event_id]).data,
-                }, status=400)
+            Checkin.objects.create(
+                position=None,
+                successful=False,
+                error_reason=Checkin.REASON_INVALID,
+                **common_checkin_args,
+            )
+
+            if force and legacy_url_support and isinstance(auth, Device):
+                # There was a bug in libpretixsync: If you scanned a ticket in offline mode that was
+                # valid at the time but no longer exists at time of upload, the device would retry to
+                # upload the same scan over and over again. Since we can't update all devices quickly,
+                # here's a dirty workaround to make it stop.
+                try:
+                    brand = auth.software_brand
+                    ver = parse(auth.software_version)
+                    legacy_mode = (
+                        (brand == 'pretixSCANPROXY' and ver < parse('0.0.3')) or
+                        (brand == 'pretixSCAN Android' and ver < parse('1.11.2')) or
+                        (brand == 'pretixSCAN' and ver < parse('1.11.2'))
+                    )
+                    if legacy_mode:
+                        return Response({
+                            'status': 'error',
+                            'reason': Checkin.REASON_ALREADY_REDEEMED,
+                            'reason_explanation': None,
+                            'require_attention': False,
+                            '__warning': 'Compatibility hack active due to detected old pretixSCAN version',
+                        }, status=400)
+                except:  # we don't care e.g. about invalid version numbers
+                    pass
+
+            return Response({
+                'detail': 'Not found.',  # for backwards compatibility
+                'status': 'error',
+                'reason': Checkin.REASON_INVALID,
+                'reason_explanation': None,
+                'require_attention': False,
+                'list': MiniCheckinListSerializer(checkinlists[0]).data,
+            }, status=404)
+        elif revoked_matches and force:
+            op_candidates = [revoked_matches[0].position]
+            if list_by_event[revoked_matches[0].event_id].addon_match:
+                op_candidates += list(revoked_matches[0].position.addons.all())
+            raw_barcode_for_checkin = raw_barcode
+            from_revoked_secret = True
         else:
-            op_candidates = [media.linked_orderposition] + list(media.linked_orderposition.addons.all())
+            op = revoked_matches[0].position
+            op.order.log_action('pretix.event.checkin.revoked', data={
+                'datetime': datetime,
+                'type': checkin_type,
+                'list': list_by_event[revoked_matches[0].event_id].pk,
+                'barcode': raw_barcode
+            }, user=user, auth=auth)
+            common_checkin_args['list'] = list_by_event[revoked_matches[0].event_id]
+            Checkin.objects.create(
+                position=op,
+                successful=False,
+                error_reason=Checkin.REASON_REVOKED,
+                **common_checkin_args
+            )
+            return Response({
+                'status': 'error',
+                'reason': Checkin.REASON_REVOKED,
+                'reason_explanation': None,
+                'require_attention': False,
+                'position': CheckinListOrderPositionSerializer(op, context=_make_context(context, revoked_matches[0].event)).data,
+                'list': MiniCheckinListSerializer(list_by_event[revoked_matches[0].event_id]).data,
+            }, status=400)
 
     # 3. Handle the "multiple options found" case: Except for the unlikely case of a secret being also a valid primary
     #    key on the same list, we're probably dealing with the ``addon_match`` case here and need to figure out
@@ -648,7 +634,6 @@ def _redeem_process(*, checkinlists, raw_barcode, answers_data, datetime, force,
                 auth=auth,
                 type=checkin_type,
                 raw_barcode=raw_barcode_for_checkin,
-                raw_source_type=source_type,
                 from_revoked_secret=from_revoked_secret,
             )
         except RequiredQuestionsError as e:
@@ -827,7 +812,6 @@ class CheckinRPCRedeemView(views.APIView):
         return _redeem_process(
             checkinlists=s.validated_data['lists'],
             raw_barcode=s.validated_data['secret'],
-            source_type=s.validated_data['source_type'],
             answers_data=s.validated_data.get('answers'),
             datetime=s.validated_data.get('datetime') or now(),
             force=s.validated_data['force'],

src/pretix/api/views/event.py

@@ -72,7 +72,7 @@ with scopes_disabled():
 
         class Meta:
             model = Event
-            fields = ['is_public', 'live', 'has_subevents', 'testmode']
+            fields = ['is_public', 'live', 'has_subevents']
 
         def ends_after_qs(self, queryset, name, value):
             expr = (
@@ -542,8 +542,7 @@ class EventSettingsView(views.APIView):
                 fname: {
                     'value': s.data[fname],
                     'label': getattr(field, '_label', fname),
-                    'help_text': getattr(field, '_help_text', None),
-                    'readonly': fname in s.readonly_fields,
+                    'help_text': getattr(field, '_help_text', None)
                 } for fname, field in s.fields.items()
             })
         return Response(s.data)

src/pretix/api/views/media.py

@@ -1,160 +0,0 @@
-#
-# This file is part of pretix (Community Edition).
-#
-# Copyright (C) 2014-2020 Raphael Michel and contributors
-# Copyright (C) 2020-2021 rami.io GmbH and contributors
-#
-# This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General
-# Public License as published by the Free Software Foundation in version 3 of the License.
-#
-# ADDITIONAL TERMS APPLY: Pursuant to Section 7 of the GNU Affero General Public License, additional terms are
-# applicable granting you additional permissions and placing additional restrictions on your usage of this software.
-# Please refer to the pretix LICENSE file to obtain the full terms applicable to this work. If you did not receive
-# this file, see <https://pretix.eu/about/en/license>.
-#
-# This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
-# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more
-# details.
-#
-# You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
-# <https://www.gnu.org/licenses/>.
-#
-from decimal import Decimal
-
-import django_filters
-from django.db import transaction
-from django.db.models import OuterRef, Prefetch, Subquery, Sum
-from django.db.models.functions import Coalesce
-from django.utils.timezone import now
-from django_filters.rest_framework import DjangoFilterBackend, FilterSet
-from django_scopes import scopes_disabled
-from rest_framework import serializers, viewsets
-from rest_framework.decorators import action
-from rest_framework.exceptions import MethodNotAllowed
-from rest_framework.filters import OrderingFilter
-from rest_framework.response import Response
-
-from pretix.api.serializers.media import (
-    MediaLookupInputSerializer, ReusableMediaSerializer,
-)
-from pretix.base.media import MEDIA_TYPES
-from pretix.base.models import (
-    Checkin, GiftCard, GiftCardTransaction, OrderPosition, ReusableMedium,
-)
-from pretix.helpers import OF_SELF
-from pretix.helpers.dicts import merge_dicts
-
-with scopes_disabled():
-    class ReusableMediumFilter(FilterSet):
-        identifier = django_filters.CharFilter(field_name='identifier')
-        type = django_filters.CharFilter(field_name='type')
-        customer = django_filters.CharFilter(field_name='customer__identifier')
-        updated_since = django_filters.IsoDateTimeFilter(field_name='updated', lookup_expr='gte')
-        created_since = django_filters.IsoDateTimeFilter(field_name='created', lookup_expr='gte')
-
-        class Meta:
-            model = ReusableMedium
-            fields = ['identifier', 'type', 'active', 'customer', 'linked_orderposition', 'linked_giftcard']
-
-
-class ReusableMediaViewSet(viewsets.ModelViewSet):
-    serializer_class = ReusableMediaSerializer
-    queryset = ReusableMedium.objects.none()
-    permission = 'can_manage_reusable_media'
-    write_permission = 'can_manage_reusable_media'
-    filter_backends = (DjangoFilterBackend, OrderingFilter)
-    ordering = ('-updated', '-id')
-    ordering_fields = ('created', 'updated', 'identifier', 'type', 'id')
-    filterset_class = ReusableMediumFilter
-
-    def get_queryset(self):
-        s = GiftCardTransaction.objects.filter(
-            card=OuterRef('pk')
-        ).order_by().values('card').annotate(s=Sum('value')).values('s')
-        return self.request.organizer.reusable_media.prefetch_related(
-            Prefetch(
-                'linked_orderposition',
-                queryset=OrderPosition.objects.select_related(
-                    'order', 'order__event', 'order__event__organizer', 'seat',
-                ).prefetch_related(
-                    Prefetch('checkins', queryset=Checkin.objects.all()),
-                    'answers', 'answers__options', 'answers__question',
-                )
-            ),
-            Prefetch(
-                'linked_giftcard',
-                queryset=GiftCard.objects.annotate(
-                    cached_value=Coalesce(Subquery(s), Decimal('0.00'))
-                )
-            )
-        )
-
-    def get_serializer_context(self):
-        ctx = super().get_serializer_context()
-        ctx['organizer'] = self.request.organizer
-        return ctx
-
-    @transaction.atomic()
-    def perform_create(self, serializer):
-        inst = serializer.save(organizer=self.request.organizer)
-        inst.log_action(
-            'pretix.reusable_medium.created',
-            user=self.request.user,
-            auth=self.request.auth,
-            data=merge_dicts(self.request.data, {'id': inst.pk})
-        )
-
-    @transaction.atomic()
-    def perform_update(self, serializer):
-        ReusableMedium.objects.select_for_update(of=OF_SELF).get(pk=self.get_object().pk)
-        inst = serializer.save(identifier=serializer.instance.identifier, type=serializer.instance.type)
-        inst.log_action(
-            'pretix.reusable_medium.changed',
-            user=self.request.user,
-            auth=self.request.auth,
-            data=self.request.data,
-        )
-        return inst
-
-    def perform_destroy(self, instance):
-        raise MethodNotAllowed("Media cannot be deleted.")
-
-    @action(methods=["POST"], detail=False)
-    def lookup(self, request, *args, **kwargs):
-        s = MediaLookupInputSerializer(
-            data=request.data,
-        )
-        s.is_valid(raise_exception=True)
-
-        try:
-            m = ReusableMedium.objects.get(
-                type=s.validated_data["type"],
-                identifier=s.validated_data["identifier"],
-                organizer=request.organizer,
-            )
-            s = self.get_serializer(m)
-            return Response({"result": s.data})
-        except ReusableMedium.DoesNotExist:
-            mt = MEDIA_TYPES.get(s.validated_data["type"])
-            if mt:
-                m = mt.handle_unknown(request.organizer, s.validated_data["identifier"], request.user, request.auth)
-                if m:
-                    s = self.get_serializer(m)
-                    return Response({"result": s.data})
-
-            return Response({"result": None})
-
-    @scopes_disabled()  # we are sure enough that get_queryset() is correct, so we save some perforamnce
-    def list(self, request, **kwargs):
-        date = serializers.DateTimeField().to_representation(now())
-        queryset = self.filter_queryset(self.get_queryset())
-
-        page = self.paginate_queryset(queryset)
-        if page is not None:
-            serializer = self.get_serializer(page, many=True)
-            resp = self.get_paginated_response(serializer.data)
-            resp['X-Page-Generated'] = date
-            return resp
-
-        serializer = self.get_serializer(queryset, many=True)
-        return Response(serializer.data, headers={'X-Page-Generated': date})

src/pretix/api/views/oauth.py

@@ -34,7 +34,6 @@ from oauth2_provider.views import (
 
 from pretix.api.models import OAuthApplication
 from pretix.base.models import Organizer
-from pretix.control.views.user import RecentAuthenticationRequiredMixin
 
 logger = logging.getLogger(__name__)
 
@@ -55,7 +54,7 @@ class OAuthAllowForm(AllowForm):
             del self.fields['organizers']
 
 
-class AuthorizationView(RecentAuthenticationRequiredMixin, BaseAuthorizationView):
+class AuthorizationView(BaseAuthorizationView):
     template_name = "pretixcontrol/auth/oauth_authorization.html"
     form_class = OAuthAllowForm
 
@@ -112,7 +111,6 @@ class AuthorizationView(RecentAuthenticationRequiredMixin, BaseAuthorizationView
         self.request.user.log_action('pretix.user.oauth.authorized', user=self.request.user, data={
             'application_id': application.pk,
             'application_name': application.name,
-            'organizers': [o.pk for o in form.cleaned_data.get("organizers")] if form.cleaned_data.get("organizers") else []
         })
 
         return self.redirect(self.success_url, application)

src/pretix/api/views/order.py

@@ -67,8 +67,8 @@ from pretix.base.models import (
     CachedCombinedTicket, CachedTicket, Checkin, Device, EventMetaValue,
     Invoice, InvoiceAddress, ItemMetaValue, ItemVariation,
     ItemVariationMetaValue, Order, OrderFee, OrderPayment, OrderPosition,
-    OrderRefund, Quota, ReusableMedium, SubEvent, SubEventMetaValue, TaxRule,
-    TeamAPIToken, generate_secret,
+    OrderRefund, Quota, SubEvent, SubEventMetaValue, TaxRule, TeamAPIToken,
+    generate_secret,
 )
 from pretix.base.models.orders import (
     BlockedTicketSecret, QuestionAnswer, RevokedTicketSecret,
@@ -148,13 +148,9 @@ with scopes_disabled():
             else:
                 code = Q(code__icontains=Order.normalize_code(u))
 
-            invoice_nos = {u, u.upper()}
-            if u.isdigit():
-                for i in range(2, 12):
-                    invoice_nos.add(u.zfill(i))
-
             matching_invoices = Invoice.objects.filter(
-                Q(invoice_no__in=invoice_nos)
+                Q(invoice_no__iexact=u)
+                | Q(invoice_no__iexact=u.zfill(5))
                 | Q(full_invoice_no__iexact=u)
             ).values_list('order_id', flat=True)
 
@@ -166,15 +162,12 @@ with scopes_disabled():
                 )
             ).values('id')
 
-            matching_media = ReusableMedium.objects.filter(identifier=u).values_list('linked_orderposition__order_id', flat=True)
-
             mainq = (
                 code
                 | Q(email__icontains=u)
                 | Q(invoice_address__name_cached__icontains=u)
                 | Q(invoice_address__company__icontains=u)
                 | Q(pk__in=matching_invoices)
-                | Q(pk__in=matching_media)
                 | Q(comment__icontains=u)
                 | Q(has_pos=True)
             )
@@ -251,8 +244,7 @@ class OrderViewSet(viewsets.ModelViewSet):
                     Prefetch('subevent', queryset=self.request.event.subevents.prefetch_related(
                         Prefetch('meta_values', to_attr='meta_values_cached', queryset=SubEventMetaValue.objects.select_related('property'))
                     )),
-                    Prefetch('addons', opq.select_related('item', 'variation', 'seat')),
-                    'linked_media',
+                    Prefetch('addons', opq.select_related('item', 'variation', 'seat'))
                 ).select_related('seat', 'addon_to', 'addon_to__seat')
             )
         else:
@@ -321,7 +313,7 @@ class OrderViewSet(viewsets.ModelViewSet):
     @action(detail=True, methods=['POST'])
     def mark_paid(self, request, **kwargs):
         order = self.get_object()
-        send_mail = request.data.get('send_email', True) if request.data else True
+        send_mail = request.data.get('send_email', True)
 
         if order.status in (Order.STATUS_PENDING, Order.STATUS_EXPIRED):
 
@@ -380,7 +372,7 @@ class OrderViewSet(viewsets.ModelViewSet):
 
     @action(detail=True, methods=['POST'])
     def mark_canceled(self, request, **kwargs):
-        send_mail = request.data.get('send_email', True) if request.data else True
+        send_mail = request.data.get('send_email', True)
         comment = request.data.get('comment', None)
         cancellation_fee = request.data.get('cancellation_fee', None)
         if cancellation_fee:
@@ -439,7 +431,7 @@ class OrderViewSet(viewsets.ModelViewSet):
 
     @action(detail=True, methods=['POST'])
     def approve(self, request, **kwargs):
-        send_mail = request.data.get('send_email', True) if request.data else True
+        send_mail = request.data.get('send_email', True)
 
         order = self.get_object()
         try:
@@ -457,7 +449,7 @@ class OrderViewSet(viewsets.ModelViewSet):
 
     @action(detail=True, methods=['POST'])
     def deny(self, request, **kwargs):
-        send_mail = request.data.get('send_email', True) if request.data else True
+        send_mail = request.data.get('send_email', True)
         comment = request.data.get('comment', '')
 
         order = self.get_object()
@@ -647,11 +639,13 @@ class OrderViewSet(viewsets.ModelViewSet):
                 raise ValidationError(_('One of the selected products is not available in the selected country.'))
             send_mail = serializer._send_mail
             order = serializer.instance
-
             if not order.pk:
-                # Simulation -- exit here
+                # Simulation
                 serializer = SimulatedOrderSerializer(order, context=serializer.context)
                 return Response(serializer.data, status=status.HTTP_201_CREATED)
+            else:
+                prefetch_related_objects([order], self._positions_prefetch(request))
+                serializer = OrderSerializer(order, context=serializer.context)
 
             order.log_action(
                 'pretix.event.order.placed',
@@ -685,10 +679,6 @@ class OrderViewSet(viewsets.ModelViewSet):
             if gen_invoice:
                 invoice = generate_invoice(order, trigger_pdf=True)
 
-            # Refresh serializer only after running signals
-            prefetch_related_objects([order], self._positions_prefetch(request))
-            serializer = OrderSerializer(order, context=serializer.context)
-
             if send_mail:
                 free_flow = (
                     payment and order.total == Decimal('0.00') and order.status == Order.STATUS_PAID and
@@ -927,7 +917,6 @@ with scopes_disabled():
         search = django_filters.CharFilter(method='search_qs')
 
         def search_qs(self, queryset, name, value):
-            matching_media = ReusableMedium.objects.filter(identifier=value).values_list('linked_orderposition', flat=True)
             return queryset.filter(
                 Q(secret__istartswith=value)
                 | Q(attendee_name_cached__icontains=value)
@@ -937,7 +926,6 @@ with scopes_disabled():
                 | Q(order__code__istartswith=value)
                 | Q(order__invoice_address__name_cached__icontains=value)
                 | Q(order__email__icontains=value)
-                | Q(pk__in=matching_media)
             )
 
         def has_checkin_qs(self, queryset, name, value):
@@ -1017,7 +1005,6 @@ class OrderPositionViewSet(viewsets.ModelViewSet):
                     Prefetch('meta_values', to_attr='meta_values_cached',
                              queryset=SubEventMetaValue.objects.select_related('property'))
                 )),
-                'linked_media',
                 Prefetch('order', self.request.event.orders.select_related('invoice_address').prefetch_related(
                     Prefetch(
                         'positions',
@@ -1453,7 +1440,7 @@ class PaymentViewSet(CreateModelMixin, viewsets.ReadOnlyModelViewSet):
         return order.payments.all()
 
     def create(self, request, *args, **kwargs):
-        send_mail = request.data.get('send_email', True) if request.data else True
+        send_mail = request.data.get('send_email', True)
         serializer = OrderPaymentCreateSerializer(data=request.data, context=self.get_serializer_context())
         serializer.is_valid(raise_exception=True)
         with transaction.atomic():
@@ -1498,7 +1485,7 @@ class PaymentViewSet(CreateModelMixin, viewsets.ReadOnlyModelViewSet):
     def confirm(self, request, **kwargs):
         payment = self.get_object()
         force = request.data.get('force', False)
-        send_mail = request.data.get('send_email', True) if request.data else True
+        send_mail = request.data.get('send_email', True)
 
         if payment.state not in (OrderPayment.PAYMENT_STATE_PENDING, OrderPayment.PAYMENT_STATE_CREATED):
             return Response({'detail': 'Invalid state of payment'}, status=status.HTTP_400_BAD_REQUEST)
@@ -1520,7 +1507,7 @@ class PaymentViewSet(CreateModelMixin, viewsets.ReadOnlyModelViewSet):
     @action(detail=True, methods=['POST'])
     def refund(self, request, **kwargs):
         payment = self.get_object()
-        amount = serializers.DecimalField(max_digits=13, decimal_places=2).to_internal_value(
+        amount = serializers.DecimalField(max_digits=10, decimal_places=2).to_internal_value(
             request.data.get('amount', str(payment.amount))
         )
         if 'mark_refunded' in request.data:

src/pretix/api/views/organizer.py

@@ -197,7 +197,7 @@ class GiftCardViewSet(viewsets.ModelViewSet):
     @transaction.atomic()
     def transact(self, request, **kwargs):
         gc = GiftCard.objects.select_for_update(of=OF_SELF).get(pk=self.get_object().pk)
-        value = serializers.DecimalField(max_digits=13, decimal_places=2).to_internal_value(
+        value = serializers.DecimalField(max_digits=10, decimal_places=2).to_internal_value(
             request.data.get('value')
         )
         text = serializers.CharField(allow_blank=True, allow_null=True).to_internal_value(
@@ -457,8 +457,7 @@ class OrganizerSettingsView(views.APIView):
                 fname: {
                     'value': s.data[fname],
                     'label': getattr(field, '_label', fname),
-                    'help_text': getattr(field, '_help_text', None),
-                    'readonly': fname in s.readonly_fields,
+                    'help_text': getattr(field, '_help_text', None)
                 } for fname, field in s.fields.items()
             })
         return Response(s.data)

src/pretix/api/webhooks.py

@@ -256,10 +256,6 @@ def register_default_webhook_events(sender, **kwargs):
             'pretix.event.order.refund.failed',
             _('Refund of payment failed'),
         ),
-        ParametrizedOrderWebhookEvent(
-            'pretix.event.order.payment.confirmed',
-            _('Payment confirmed'),
-        ),
         ParametrizedOrderWebhookEvent(
             'pretix.event.order.approved',
             _('Order approved'),

src/pretix/base/email.py

@@ -35,14 +35,16 @@ from django.dispatch import receiver
 from django.template.loader import get_template
 from django.utils.formats import date_format
 from django.utils.timezone import now
-from django.utils.translation import get_language, gettext_lazy as _
+from django.utils.translation import (
+    get_language, gettext_lazy as _, pgettext_lazy,
+)
 
 from pretix.base.i18n import (
     LazyCurrencyNumber, LazyDate, LazyExpiresDate, LazyNumber,
 )
 from pretix.base.models import Event
 from pretix.base.reldate import RelativeDateWrapper
-from pretix.base.settings import PERSON_NAME_SCHEMES, get_name_parts_localized
+from pretix.base.settings import PERSON_NAME_SCHEMES
 from pretix.base.signals import (
     register_html_mail_renderers, register_mail_placeholders,
 )
@@ -644,10 +646,6 @@ def base_placeholders(sender, **kwargs):
             'attendee_name', ['position'], lambda position: position.attendee_name,
             _('John Doe'),
         ),
-        SimpleFunctionalMailTextPlaceholder(
-            'positionid', ['position'], lambda position: str(position.positionid),
-            '1'
-        ),
         SimpleFunctionalMailTextPlaceholder(
             'name', ['position_or_address'],
             get_best_name,
@@ -661,11 +659,6 @@ def base_placeholders(sender, **kwargs):
     else:
         concatenation_for_salutation = name_scheme["concatenation"]
 
-    ph.append(SimpleFunctionalMailTextPlaceholder(
-        "name_for_salutation", ["waiting_list_entry"],
-        lambda waiting_list_entry: concatenation_for_salutation(waiting_list_entry.name_parts),
-        _("Mr Doe"),
-    ))
     ph.append(SimpleFunctionalMailTextPlaceholder(
         "name_for_salutation", ["position_or_address"],
         lambda position_or_address: concatenation_for_salutation(get_best_name(position_or_address, parts=True)),
@@ -675,10 +668,6 @@ def base_placeholders(sender, **kwargs):
     for f, l, w in name_scheme['fields']:
         if f == 'full_name':
             continue
-        ph.append(SimpleFunctionalMailTextPlaceholder(
-            'name_%s' % f, ['waiting_list_entry'], lambda waiting_list_entry, f=f: get_name_parts_localized(waiting_list_entry.name_parts, f),
-            name_scheme['sample'][f]
-        ))
         ph.append(SimpleFunctionalMailTextPlaceholder(
             'attendee_name_%s' % f, ['position'], lambda position, f=f: get_name_parts_localized(position.attendee_name_parts, f),
             name_scheme['sample'][f]
@@ -700,3 +689,10 @@ def base_placeholders(sender, **kwargs):
         ))
 
     return ph
+
+
+def get_name_parts_localized(name_parts, key):
+    value = name_parts.get(key, "")
+    if key == "salutation":
+        return pgettext_lazy("person_name_salutation", value)
+    return value

src/pretix/base/exporters/events.py

@@ -94,7 +94,7 @@ class EventDataExporter(ListExporter):
             ]
 
     def get_filename(self):
-        return '{}_events'.format(self.organizer.slug)
+        return '{}_events'.format(self.events.first().organizer.slug)
 
 
 @receiver(register_multievent_data_exporters, dispatch_uid="multiexporter_eventdata")

src/pretix/base/exporters/invoices.py

@@ -155,7 +155,7 @@ class InvoiceExporter(InvoiceExporterMixin, BaseExporter):
                         self.progress_callback(counter / total * 100)
 
             if self.is_multievent:
-                filename = '{}_invoices.zip'.format(self.organizer.slug)
+                filename = '{}_invoices.zip'.format(self.events.first().organizer.slug)
             else:
                 filename = '{}_invoices.zip'.format(self.event.slug)
 
@@ -415,7 +415,7 @@ class InvoiceDataExporter(InvoiceExporterMixin, MultiSheetListExporter):
 
     def get_filename(self):
         if self.is_multievent:
-            return '{}_invoices'.format(self.organizer.slug)
+            return '{}_invoices'.format(self.events.first().organizer.slug)
         else:
             return '{}_invoices'.format(self.event.slug)
 

src/pretix/base/exporters/items.py

@@ -218,9 +218,7 @@ class ItemDataExporter(ListExporter):
                 yield row
 
     def get_filename(self):
-        if self.is_multievent:
-            return '{}_products'.format(self.organizer.slug)
-        return '{}_products'.format(self.event.slug)
+        return '{}_products'.format(self.events.first().organizer.slug)
 
     def prepare_xlsx_sheet(self, ws):
         self.__ws = ws

src/pretix/base/exporters/mail.py

@@ -63,7 +63,7 @@ class MailExporter(BaseExporter):
                            | set(a['attendee_email'] for a in pos if a['attendee_email']))
 
         if self.is_multievent:
-            return '{}_pretixemails.txt'.format(self.organizer.slug), 'text/plain', data.encode("utf-8")
+            return '{}_pretixemails.txt'.format(self.events.first().organizer.slug), 'text/plain', data.encode("utf-8")
         else:
             return '{}_pretixemails.txt'.format(self.event.slug), 'text/plain', data.encode("utf-8")
 

src/pretix/base/exporters/orderlist.py

@@ -56,7 +56,7 @@ from pretix.base.models import (
 )
 from pretix.base.models.orders import OrderFee, OrderPayment, OrderRefund
 from pretix.base.services.quotas import QuotaAvailability
-from pretix.base.settings import PERSON_NAME_SCHEMES, get_name_parts_localized
+from pretix.base.settings import PERSON_NAME_SCHEMES
 
 from ...control.forms.filter import get_all_payment_providers
 from ...helpers import GroupConcat
@@ -340,7 +340,7 @@ class OrderListExporter(MultiSheetListExporter):
                 if name_scheme and len(name_scheme['fields']) > 1:
                     for k, label, w in name_scheme['fields']:
                         row.append(
-                            get_name_parts_localized(order.invoice_address.name_parts, k)
+                            order.invoice_address.name_parts.get(k, '')
                         )
                 row += [
                     order.invoice_address.street,
@@ -477,7 +477,7 @@ class OrderListExporter(MultiSheetListExporter):
                 if name_scheme and len(name_scheme['fields']) > 1:
                     for k, label, w in name_scheme['fields']:
                         row.append(
-                            get_name_parts_localized(order.invoice_address.name_parts, k)
+                            order.invoice_address.name_parts.get(k, '')
                         )
                 row += [
                     order.invoice_address.street,
@@ -660,7 +660,7 @@ class OrderListExporter(MultiSheetListExporter):
                 if name_scheme and len(name_scheme['fields']) > 1:
                     for k, label, w in name_scheme['fields']:
                         row.append(
-                            get_name_parts_localized(op.attendee_name_parts, k)
+                            op.attendee_name_parts.get(k, '')
                         )
                 row += [
                     op.attendee_email,
@@ -688,8 +688,8 @@ class OrderListExporter(MultiSheetListExporter):
 
                 row += [
                     _('Yes') if op.blocked else '',
-                    date_format(op.valid_from.astimezone(tz), 'SHORT_DATETIME_FORMAT') if op.valid_from else '',
-                    date_format(op.valid_until.astimezone(tz), 'SHORT_DATETIME_FORMAT') if op.valid_until else '',
+                    date_format(op.valid_from, 'SHORT_DATETIME_FORMAT') if op.valid_from else '',
+                    date_format(op.valid_until, 'SHORT_DATETIME_FORMAT') if op.valid_until else '',
                 ]
                 row.append(order.comment)
                 row.append(order.custom_followup_at.strftime("%Y-%m-%d") if order.custom_followup_at else "")
@@ -721,7 +721,7 @@ class OrderListExporter(MultiSheetListExporter):
                     if name_scheme and len(name_scheme['fields']) > 1:
                         for k, label, w in name_scheme['fields']:
                             row.append(
-                                get_name_parts_localized(order.invoice_address.name_parts, k)
+                                order.invoice_address.name_parts.get(k, '')
                             )
                     row += [
                         order.invoice_address.street,
@@ -754,7 +754,7 @@ class OrderListExporter(MultiSheetListExporter):
 
     def get_filename(self):
         if self.is_multievent:
-            return '{}_orders'.format(self.organizer.slug)
+            return '{}_orders'.format(self.events.first().organizer.slug)
         else:
             return '{}_orders'.format(self.event.slug)
 
@@ -880,7 +880,7 @@ class PaymentListExporter(ListExporter):
 
     def get_filename(self):
         if self.is_multievent:
-            return '{}_payments'.format(self.organizer.slug)
+            return '{}_payments'.format(self.events.first().organizer.slug)
         else:
             return '{}_payments'.format(self.event.slug)
 
@@ -1037,7 +1037,7 @@ class GiftcardRedemptionListExporter(ListExporter):
 
     def get_filename(self):
         if self.is_multievent:
-            return '{}_giftcardredemptions'.format(self.organizer.slug)
+            return '{}_giftcardredemptions'.format(self.events.first().organizer.slug)
         else:
             return '{}_giftcardredemptions'.format(self.event.slug)
 

src/pretix/base/forms/__init__.py

@@ -36,13 +36,11 @@ import logging
 
 import i18nfield.forms
 from django import forms
-from django.core.validators import URLValidator
 from django.forms.models import ModelFormMetaclass
 from django.utils.crypto import get_random_string
 from django.utils.translation import gettext_lazy as _
 from formtools.wizard.views import SessionWizardView
 from hierarkey.forms import HierarkeyForm
-from i18nfield.strings import LazyI18nString
 
 from pretix.base.reldate import RelativeDateField, RelativeDateTimeField
 
@@ -224,17 +222,3 @@ class SecretKeySettingsField(forms.CharField):
         if value == SECRET_REDACTED:
             return
         return super().run_validators(value)
-
-
-class I18nURLFormField(i18nfield.forms.I18nFormField):
-    def clean(self, value) -> LazyI18nString:
-        value = super().clean(value)
-        if not value:
-            return value
-        if isinstance(value.data, dict):
-            for v in value.data.values():
-                if v:
-                    URLValidator()(v)
-        else:
-            URLValidator()(value.data)
-        return value

src/pretix/base/forms/questions.py

@@ -45,7 +45,6 @@ import pytz
 from django import forms
 from django.conf import settings
 from django.contrib import messages
-from django.contrib.gis.geoip2 import GeoIP2
 from django.core.exceptions import ValidationError
 from django.core.files.uploadedfile import SimpleUploadedFile
 from django.core.validators import (
@@ -92,7 +91,6 @@ from pretix.helpers.countries import (
     CachedCountries, get_phone_prefixes_sorted_and_localized,
 )
 from pretix.helpers.escapejson import escapejson_attr
-from pretix.helpers.http import get_client_ip
 from pretix.helpers.i18n import get_format_without_seconds
 from pretix.presale.signals import question_form_fields
 
@@ -353,15 +351,6 @@ class WrappedPhoneNumberPrefixWidget(PhoneNumberPrefixWidget):
         return ""
 
 
-def guess_country_from_request(request, event):
-    if settings.HAS_GEOIP:
-        g = GeoIP2()
-        res = g.country(get_client_ip(request))
-        if res['country_code'] and len(res['country_code']) == 2:
-            return Country(res['country_code'])
-    return guess_country(event)
-
-
 def guess_country(event):
     # Try to guess the initial country from either the country of the merchant
     # or the locale. This will hopefully save at least some users some scrolling :)
@@ -393,12 +382,6 @@ def guess_phone_prefix(event):
         return get_phone_prefix(country)
 
 
-def guess_phone_prefix_from_request(request, event):
-    with language(get_babel_locale()):
-        country = str(guess_country_from_request(request, event))
-        return get_phone_prefix(country)
-
-
 def get_phone_prefix(country):
     for prefix, values in _COUNTRY_CODE_TO_REGION_CODE.items():
         if country in values:
@@ -581,7 +564,6 @@ class BaseQuestionsForm(forms.Form):
         :param cartpos: The cart position the form should be for
         :param event: The event this belongs to
         """
-        request = kwargs.pop('request', None)
         cartpos = self.cartpos = kwargs.pop('cartpos', None)
         orderpos = self.orderpos = kwargs.pop('orderpos', None)
         pos = cartpos or orderpos
@@ -679,7 +661,7 @@ class BaseQuestionsForm(forms.Form):
                     'autocomplete': 'address-level2',
                 }),
             )
-            country = (cartpos.country if cartpos else orderpos.country) or guess_country_from_request(request, event)
+            country = (cartpos.country if cartpos else orderpos.country) or guess_country(event)
             add_fields['country'] = CountryField(
                 countries=CachedCountries
             ).formfield(
@@ -765,14 +747,12 @@ class BaseQuestionsForm(forms.Form):
             elif q.type == Question.TYPE_STRING:
                 field = forms.CharField(
                     label=label, required=required,
-                    max_length=q.valid_string_length_max,
                     help_text=help_text,
                     initial=initial.answer if initial else None,
                 )
             elif q.type == Question.TYPE_TEXT:
                 field = forms.CharField(
                     label=label, required=required,
-                    max_length=q.valid_string_length_max,
                     help_text=help_text,
                     widget=forms.Textarea,
                     initial=initial.answer if initial else None,
@@ -786,7 +766,7 @@ class BaseQuestionsForm(forms.Form):
                     help_text=help_text,
                     widget=forms.Select,
                     empty_label=' ',
-                    initial=initial.answer if initial else (guess_country_from_request(request, event) if required else None),
+                    initial=initial.answer if initial else (guess_country(event) if required else None),
                 )
             elif q.type == Question.TYPE_CHOICE:
                 field = forms.ModelChoiceField(
@@ -874,7 +854,7 @@ class BaseQuestionsForm(forms.Form):
                         initial = None
 
                 if not initial:
-                    phone_prefix = guess_phone_prefix_from_request(request, event)
+                    phone_prefix = guess_phone_prefix(event)
                     if phone_prefix:
                         initial = "+{}.".format(phone_prefix)
 
@@ -1010,7 +990,7 @@ class BaseInvoiceAddressForm(forms.ModelForm):
 
         kwargs.setdefault('initial', {})
         if not kwargs.get('instance') or not kwargs['instance'].country:
-            kwargs['initial']['country'] = guess_country_from_request(self.request, self.event)
+            kwargs['initial']['country'] = guess_country(self.event)
 
         super().__init__(*args, **kwargs)
         if not event.settings.invoice_address_vatid:

src/pretix/base/invoice.py

@@ -148,7 +148,6 @@ class BaseReportlabInvoiceRenderer(BaseInvoiceRenderer):
         """
         stylesheet = StyleSheet1()
         stylesheet.add(ParagraphStyle(name='Normal', fontName=self.font_regular, fontSize=10, leading=12))
-        stylesheet.add(ParagraphStyle(name='NormalRight', fontName=self.font_regular, fontSize=10, leading=12, alignment=TA_RIGHT))
         stylesheet.add(ParagraphStyle(name='BoldInverseCenter', fontName=self.font_bold, fontSize=10, leading=12,
                                       textColor=colors.white, alignment=TA_CENTER))
         stylesheet.add(ParagraphStyle(name='InvoiceFrom', parent=stylesheet['Normal']))
@@ -611,8 +610,8 @@ class ClassicInvoiceRenderer(BaseReportlabInvoiceRenderer):
                     ),
                     str(len(lines)),
                     localize(tax_rate) + " %",
-                    Paragraph(money_filter(net_value * len(lines), self.invoice.event.currency).replace('\xa0', ' '), self.stylesheet['NormalRight']),
-                    Paragraph(money_filter(gross_value * len(lines), self.invoice.event.currency).replace('\xa0', ' '), self.stylesheet['NormalRight']),
+                    money_filter(net_value * len(lines), self.invoice.event.currency),
+                    money_filter(gross_value * len(lines), self.invoice.event.currency),
                 ))
             else:
                 if len(lines) > 1:
@@ -626,7 +625,7 @@ class ClassicInvoiceRenderer(BaseReportlabInvoiceRenderer):
                         self.stylesheet['Normal']
                     ),
                     str(len(lines)),
-                    Paragraph(money_filter(gross_value * len(lines), self.invoice.event.currency).replace('\xa0', ' '), self.stylesheet['NormalRight']),
+                    money_filter(gross_value * len(lines), self.invoice.event.currency),
                 ))
             taxvalue_map[tax_rate, tax_name] += (gross_value - net_value) * len(lines)
             grossvalue_map[tax_rate, tax_name] += gross_value * len(lines)
@@ -634,14 +633,12 @@ class ClassicInvoiceRenderer(BaseReportlabInvoiceRenderer):
 
         if has_taxes:
             tdata.append([
-                pgettext('invoice', 'Invoice total'), '', '', '',
-                money_filter(total, self.invoice.event.currency)
+                pgettext('invoice', 'Invoice total'), '', '', '', money_filter(total, self.invoice.event.currency)
             ])
             colwidths = [a * doc.width for a in (.50, .05, .15, .15, .15)]
         else:
             tdata.append([
-                pgettext('invoice', 'Invoice total'), '',
-                money_filter(total, self.invoice.event.currency)
+                pgettext('invoice', 'Invoice total'), '', money_filter(total, self.invoice.event.currency)
             ])
             colwidths = [a * doc.width for a in (.65, .20, .15)]
 

src/pretix/base/management/commands/check_order_transactions.py

@@ -44,8 +44,8 @@ class Command(BaseCommand):
                     OrderPosition.objects.filter(
                         order=OuterRef('pk')
                     ).order_by().values('order').annotate(p=Sum('price')).values('p'),
-                    output_field=models.DecimalField(decimal_places=2, max_digits=13)
-                ), Value(0), output_field=models.DecimalField(decimal_places=2, max_digits=13)
+                    output_field=models.DecimalField(decimal_places=2, max_digits=10)
+                ), Value(0), output_field=models.DecimalField(decimal_places=2, max_digits=10)
             ),
             position_cnt=Case(
                 When(Q(status__in=('e', 'c')) | Q(require_approval=True), then=Value(0)),
@@ -64,16 +64,16 @@ class Command(BaseCommand):
                     OrderFee.objects.filter(
                         order=OuterRef('pk')
                     ).order_by().values('order').annotate(p=Sum('value')).values('p'),
-                    output_field=models.DecimalField(decimal_places=2, max_digits=13)
-                ), Value(0), output_field=models.DecimalField(decimal_places=2, max_digits=13)
+                    output_field=models.DecimalField(decimal_places=2, max_digits=10)
+                ), Value(0), output_field=models.DecimalField(decimal_places=2, max_digits=10)
             ),
             tx_total=Coalesce(
                 Subquery(
                     Transaction.objects.filter(
                         order=OuterRef('pk')
                     ).order_by().values('order').annotate(p=Sum(F('price') * F('count'))).values('p'),
-                    output_field=models.DecimalField(decimal_places=2, max_digits=13)
-                ), Value(0), output_field=models.DecimalField(decimal_places=2, max_digits=13)
+                    output_field=models.DecimalField(decimal_places=2, max_digits=10)
+                ), Value(0), output_field=models.DecimalField(decimal_places=2, max_digits=10)
             ),
             tx_cnt=Coalesce(
                 Subquery(
@@ -81,15 +81,15 @@ class Command(BaseCommand):
                         order=OuterRef('pk'),
                         item__isnull=False,
                     ).order_by().values('order').annotate(p=Sum(F('count'))).values('p'),
-                    output_field=models.DecimalField(decimal_places=2, max_digits=13)
-                ), Value(0), output_field=models.DecimalField(decimal_places=2, max_digits=13)
+                    output_field=models.DecimalField(decimal_places=2, max_digits=10)
+                ), Value(0), output_field=models.DecimalField(decimal_places=2, max_digits=10)
             ),
         ).annotate(
             correct_total=Case(
                 When(Q(status=Order.STATUS_CANCELED) | Q(status=Order.STATUS_EXPIRED) | Q(require_approval=True),
                      then=Value(0)),
                 default=F('position_total') + F('fee_total'),
-                output_field=models.DecimalField(decimal_places=2, max_digits=13)
+                output_field=models.DecimalField(decimal_places=2, max_digits=10)
             ),
         ).exclude(
             total=F('position_total') + F('fee_total'),

src/pretix/base/management/commands/shell_scoped.py

@@ -49,7 +49,6 @@ class Command(BaseCommand):
         except ImportError:
             cmd = 'shell'
             del options['skip_checks']
-            del options['print_sql']
 
         if options['print_sql']:
             connection.force_debug_cursor = True

src/pretix/base/media.py

@@ -1,116 +0,0 @@
-#
-# This file is part of pretix (Community Edition).
-#
-# Copyright (C) 2014-2020 Raphael Michel and contributors
-# Copyright (C) 2020-2021 rami.io GmbH and contributors
-#
-# This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General
-# Public License as published by the Free Software Foundation in version 3 of the License.
-#
-# ADDITIONAL TERMS APPLY: Pursuant to Section 7 of the GNU Affero General Public License, additional terms are
-# applicable granting you additional permissions and placing additional restrictions on your usage of this software.
-# Please refer to the pretix LICENSE file to obtain the full terms applicable to this work. If you did not receive
-# this file, see <https://pretix.eu/about/en/license>.
-#
-# This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
-# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more
-# details.
-#
-# You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
-# <https://www.gnu.org/licenses/>.
-#
-from django.db import transaction
-from django.utils.crypto import get_random_string
-from django.utils.translation import gettext_lazy as _
-
-
-class BaseMediaType:
-    medium_created_by_server = False
-    supports_orderposition = False
-    supports_giftcard = False
-
-    @property
-    def identifier(self):
-        raise NotImplementedError()
-
-    @property
-    def verbose_name(self):
-        raise NotImplementedError()
-
-    def generate_identifier(self, organizer):
-        if self.medium_created_by_server:
-            raise NotImplementedError()
-        else:
-            raise ValueError("Media type does not allow to generate identifier")
-
-    def is_active(self, organizer):
-        return organizer.settings.get(f'reusable_media_type_{self.identifier}', as_type=bool, default=False)
-
-    def handle_unknown(self, organizer, identifier, user, auth):
-        pass
-
-    def __str__(self):
-        return str(self.verbose_name)
-
-
-class BarcodePlainMediaType(BaseMediaType):
-    identifier = 'barcode'
-    verbose_name = _('Barcode / QR-Code')
-    medium_created_by_server = True
-    supports_giftcard = False
-    supports_orderposition = True
-
-    def generate_identifier(self, organizer):
-        return get_random_string(
-            length=organizer.settings.reusable_media_type_barcode_identifier_length,
-            # Exclude o,0,1,i to avoid confusion with bad fonts/printers
-            # We use upper case to make collisions with ticket secrets less likely
-            allowed_chars='ABCDEFGHJKLMNPQRSTUVWXYZ23456789'
-        )
-
-
-class NfcUidMediaType(BaseMediaType):
-    identifier = 'nfc_uid'
-    verbose_name = _('NFC UID-based')
-    medium_created_by_server = False
-    supports_giftcard = True
-    supports_orderposition = False
-
-    def handle_unknown(self, organizer, identifier, user, auth):
-        from pretix.base.models import GiftCard, ReusableMedium
-
-        if organizer.settings.get(f'reusable_media_type_{self.identifier}_autocreate_giftcard', as_type=bool):
-            if identifier.startswith("08"):
-                # Don't create gift cards for NFC UIDs that start with 08, which represents NFC cards that issue random
-                # UIDs on every read, so they won't be useful.
-                return
-            with transaction.atomic():
-                gc = GiftCard.objects.create(
-                    issuer=organizer,
-                    expires=organizer.default_gift_card_expiry,
-                    currency=organizer.settings.get(f'reusable_media_type_{self.identifier}_autocreate_giftcard_currency'),
-                )
-                m = ReusableMedium.objects.create(
-                    type=self.identifier,
-                    identifier=identifier,
-                    organizer=organizer,
-                    active=True,
-                    linked_giftcard=gc
-                )
-                m.log_action(
-                    'pretix.reusable_medium.created.auto',
-                    user=user, auth=auth,
-                )
-                gc.log_action(
-                    'pretix.giftcards.created',
-                    user=user, auth=auth,
-                )
-                return m
-
-
-MEDIA_TYPES = {
-    m.identifier: m for m in [
-        BarcodePlainMediaType(),
-        NfcUidMediaType(),
-    ]
-}

src/pretix/base/migrations/0235_auto_20230316_2023.py

@@ -1,165 +0,0 @@
-# Generated by Django 3.2.18 on 2023-03-16 20:23
-
-from decimal import Decimal
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0234_total_ordering'),
-    ]
-
-    operations = [
-        migrations.AlterField(
-            model_name='cancellationrequest',
-            name='cancellation_fee',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='cartposition',
-            name='custom_price_input',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='cartposition',
-            name='line_price_gross',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='cartposition',
-            name='listed_price',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='cartposition',
-            name='price',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='cartposition',
-            name='price_after_voucher',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='discount',
-            name='condition_min_value',
-            field=models.DecimalField(decimal_places=2, default=Decimal('0.00'), max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='giftcardtransaction',
-            name='value',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='invoice',
-            name='foreign_currency_rate',
-            field=models.DecimalField(decimal_places=4, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='invoiceline',
-            name='gross_value',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='invoiceline',
-            name='tax_value',
-            field=models.DecimalField(decimal_places=2, default=Decimal('0.00'), max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='item',
-            name='default_price',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='item',
-            name='original_price',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='itembundle',
-            name='designated_price',
-            field=models.DecimalField(decimal_places=2, default=Decimal('0.00'), max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='itemvariation',
-            name='default_price',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='itemvariation',
-            name='original_price',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='order',
-            name='total',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='orderfee',
-            name='tax_value',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='orderfee',
-            name='value',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='orderpayment',
-            name='amount',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='orderposition',
-            name='price',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='orderposition',
-            name='tax_value',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='orderposition',
-            name='voucher_budget_use',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='orderrefund',
-            name='amount',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='subeventitem',
-            name='price',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='subeventitemvariation',
-            name='price',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='transaction',
-            name='price',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='transaction',
-            name='tax_value',
-            field=models.DecimalField(decimal_places=2, max_digits=13),
-        ),
-        migrations.AlterField(
-            model_name='voucher',
-            name='budget',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-        migrations.AlterField(
-            model_name='voucher',
-            name='value',
-            field=models.DecimalField(decimal_places=2, max_digits=13, null=True),
-        ),
-    ]

src/pretix/base/migrations/0236_reusable_media.py

@@ -1,77 +0,0 @@
-# Generated by Django 3.2.18 on 2023-02-20 12:46
-
-import django.core.serializers.json
-import django.db.models.deletion
-from django.db import migrations, models
-
-import pretix.base.models.base
-
-
-def set_can_manage_reusable_media(apps, schema_editor):
-    Team = apps.get_model('pretixbase', 'Team')
-    Team.objects.filter(can_change_organizer_settings=True).update(can_manage_reusable_media=True)
-    Team.objects.filter(can_change_orders=True, all_events=True).update(can_manage_reusable_media=True)
-
-
-class Migration(migrations.Migration):
-    dependencies = [
-        ('pretixbase', '0235_auto_20230316_2023'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='item',
-            name='media_policy',
-            field=models.CharField(max_length=16, null=True),
-        ),
-        migrations.AddField(
-            model_name='item',
-            name='media_type',
-            field=models.CharField(max_length=100, null=True),
-        ),
-        migrations.AddField(
-            model_name='team',
-            name='can_manage_reusable_media',
-            field=models.BooleanField(default=False),
-        ),
-        migrations.CreateModel(
-            name='ReusableMedium',
-            fields=[
-                ('id', models.BigAutoField(primary_key=True, serialize=False)),
-                ('created', models.DateTimeField(auto_now_add=True)),
-                ('updated', models.DateTimeField(auto_now=True)),
-                ('type', models.CharField(max_length=100)),
-                ('identifier', models.CharField(max_length=200)),
-                ('active', models.BooleanField(default=True)),
-                ('expires', models.DateTimeField(blank=True, null=True)),
-                ('info', models.JSONField(default=dict)),
-                ('notes', models.TextField(null=True, blank=True)),
-                ('customer', models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL,
-                                               related_name='reusable_media', to='pretixbase.customer')),
-                ('linked_giftcard',
-                 models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='linked_media',
-                                   to='pretixbase.giftcard')),
-                ('linked_orderposition',
-                 models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='linked_media',
-                                   to='pretixbase.orderposition')),
-                ('organizer',
-                 models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='reusable_media',
-                                   to='pretixbase.organizer')),
-            ],
-            options={
-                'ordering': ('identifier', 'type', 'organizer'),
-                'unique_together': {('identifier', 'type', 'organizer')},
-                'index_together': {('identifier', 'type', 'organizer'), ('updated', 'id')},
-            },
-            bases=(models.Model, pretix.base.models.base.LoggingMixin),
-        ),
-        migrations.AddField(
-            model_name='checkin',
-            name='raw_source_type',
-            field=models.CharField(max_length=100, null=True),
-        ),
-        migrations.RunPython(
-            set_can_manage_reusable_media,
-            migrations.RunPython.noop,
-        ),
-    ]

src/pretix/base/migrations/0237_question_valid_string_length.py

@@ -1,18 +0,0 @@
-# Generated by Django 3.2.18 on 2023-04-05 10:03
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('pretixbase', '0236_reusable_media'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='question',
-            name='valid_string_length_max',
-            field=models.PositiveIntegerField(null=True),
-        ),
-    ]

src/pretix/base/models/__init__.py

@@ -40,7 +40,6 @@ from .items import (
     SubEventItem, SubEventItemVariation, itempicture_upload_to,
 )
 from .log import LogEntry
-from .media import ReusableMedium
 from .memberships import Membership, MembershipType
 from .notifications import NotificationSetting
 from .orders import (

src/pretix/base/models/checkin.py

@@ -44,7 +44,6 @@ from django.utils.timezone import now
 from django.utils.translation import gettext_lazy as _, pgettext_lazy
 from django_scopes import ScopedManager, scopes_disabled
 
-from pretix.base.media import MEDIA_TYPES
 from pretix.base.models import LoggedModel
 from pretix.base.models.fields import MultiStringField
 from pretix.helpers import PostgresWindowFrame
@@ -56,12 +55,7 @@ class CheckinList(LoggedModel):
     all_products = models.BooleanField(default=True, verbose_name=_("All products (including newly created ones)"))
     limit_products = models.ManyToManyField('Item', verbose_name=_("Limit to products"), blank=True)
     subevent = models.ForeignKey('SubEvent', null=True, blank=True,
-                                 verbose_name=pgettext_lazy('subevent', 'Date'),
-                                 on_delete=models.CASCADE,
-                                 help_text=_('If you choose "all dates", tickets will be considered part of this list '
-                                             'and valid for check-in regardless of which date they are purchased for. '
-                                             'You can limit their validity through the advanced check-in rules, '
-                                             'though.'))
+                                 verbose_name=pgettext_lazy('subevent', 'Date'), on_delete=models.CASCADE)
     include_pending = models.BooleanField(verbose_name=pgettext_lazy('checkin', 'Include pending orders'),
                                           default=False,
                                           help_text=_('With this option, people will be able to check in even if the '
@@ -378,11 +372,6 @@ class Checkin(models.Model):
     # For "raw" scans where we do not know which position they belong to (e.g. scan of signed
     # barcode that is not in database).
     raw_barcode = models.TextField(null=True, blank=True)
-    raw_source_type = models.CharField(
-        max_length=100,
-        null=True, blank=True,
-        choices=[(k, v) for k, v in MEDIA_TYPES.items()],
-    )
     raw_item = models.ForeignKey(
         'pretixbase.Item',
         related_name='checkins',

src/pretix/base/models/customers.py

@@ -142,7 +142,6 @@ class Customer(LoggedModel):
         self.save()
         self.all_logentries().update(data={}, shredded=True)
         self.orders.all().update(customer=None)
-        self.reusable_media.all().update(customer=None)
         self.memberships.all().update(attendee_name_parts=None)
         self.attendee_profiles.all().delete()
         self.invoice_addresses.all().delete()
@@ -222,7 +221,7 @@ class Customer(LoggedModel):
         return salted_hmac(key_salt, payload).hexdigest()
 
     def get_email_context(self):
-        from pretix.base.settings import get_name_parts_localized
+        from pretix.base.email import get_name_parts_localized
         ctx = {
             'name': self.name,
             'organizer': self.organizer.name,

src/pretix/base/models/devices.py

@@ -180,8 +180,7 @@ class Device(LoggedModel):
             'can_view_orders',
             'can_change_orders',
             'can_view_vouchers',
-            'can_manage_gift_cards',
-            'can_manage_reusable_media',
+            'can_manage_gift_cards'
         }
 
     def get_event_permission_set(self, organizer, event) -> set:

src/pretix/base/models/discount.py

@@ -116,7 +116,7 @@ class Discount(LoggedModel):
     condition_min_value = models.DecimalField(
         verbose_name=_('Minimum gross value of matching products'),
         decimal_places=2,
-        max_digits=13,
+        max_digits=10,
         default=Decimal('0.00'),
     )
 

src/pretix/base/models/giftcards.py

@@ -129,7 +129,7 @@ class GiftCardTransaction(models.Model):
     )
     value = models.DecimalField(
         decimal_places=2,
-        max_digits=13
+        max_digits=10
     )
     order = models.ForeignKey(
         'Order',

src/pretix/base/models/invoices.py

@@ -152,7 +152,7 @@ class Invoice(models.Model):
     footer_text = models.TextField(blank=True)
 
     foreign_currency_display = models.CharField(max_length=50, null=True, blank=True)
-    foreign_currency_rate = models.DecimalField(decimal_places=4, max_digits=13, null=True, blank=True)
+    foreign_currency_rate = models.DecimalField(decimal_places=4, max_digits=10, null=True, blank=True)
     foreign_currency_rate_date = models.DateField(null=True, blank=True)
     foreign_currency_source = models.CharField(max_length=100, null=True, blank=True)
 
@@ -347,8 +347,8 @@ class InvoiceLine(models.Model):
     invoice = models.ForeignKey('Invoice', related_name='lines', on_delete=models.CASCADE)
     position = models.PositiveIntegerField(default=0)
     description = models.TextField()
-    gross_value = models.DecimalField(max_digits=13, decimal_places=2)
-    tax_value = models.DecimalField(max_digits=13, decimal_places=2, default=Decimal('0.00'))
+    gross_value = models.DecimalField(max_digits=10, decimal_places=2)
+    tax_value = models.DecimalField(max_digits=10, decimal_places=2, default=Decimal('0.00'))
     tax_rate = models.DecimalField(max_digits=7, decimal_places=2, default=Decimal('0.00'))
     tax_name = models.CharField(max_length=190)
     subevent = models.ForeignKey('SubEvent', null=True, blank=True, on_delete=models.PROTECT)

src/pretix/base/models/items.py

@@ -45,9 +45,7 @@ import dateutil.parser
 import pytz
 from django.conf import settings
 from django.core.exceptions import ValidationError
-from django.core.validators import (
-    MaxLengthValidator, MinValueValidator, RegexValidator,
-)
+from django.core.validators import MinValueValidator, RegexValidator
 from django.db import models
 from django.db.models import Q
 from django.utils import formats
@@ -66,7 +64,6 @@ from pretix.base.models.fields import MultiStringField
 from pretix.base.models.tax import TaxedPrice
 
 from ...helpers.images import ImageSizeValidator
-from ..media import MEDIA_TYPES
 from .event import Event, SubEvent
 
 
@@ -167,7 +164,7 @@ class SubEventItem(models.Model):
     """
     subevent = models.ForeignKey('SubEvent', on_delete=models.CASCADE)
     item = models.ForeignKey('Item', on_delete=models.CASCADE)
-    price = models.DecimalField(max_digits=13, decimal_places=2, null=True, blank=True)
+    price = models.DecimalField(max_digits=7, decimal_places=2, null=True, blank=True)
     disabled = models.BooleanField(default=False, verbose_name=_('Disable product for this date'))
     available_from = models.DateTimeField(
         verbose_name=_("Available from"),
@@ -223,7 +220,7 @@ class SubEventItemVariation(models.Model):
     """
     subevent = models.ForeignKey('SubEvent', on_delete=models.CASCADE)
     variation = models.ForeignKey('ItemVariation', on_delete=models.CASCADE)
-    price = models.DecimalField(max_digits=13, decimal_places=2, null=True, blank=True)
+    price = models.DecimalField(max_digits=7, decimal_places=2, null=True, blank=True)
     disabled = models.BooleanField(default=False, verbose_name=_('Disable product for this date'))
     available_from = models.DateTimeField(
         verbose_name=_("Available from"),
@@ -371,16 +368,6 @@ class Item(LoggedModel):
         (VALIDITY_MODE_DYNAMIC, _('Dynamic validity')),
     )
 
-    MEDIA_POLICY_REUSE = 'reuse'
-    MEDIA_POLICY_NEW = 'new'
-    MEDIA_POLICY_REUSE_OR_NEW = 'reuse_or_new'
-    MEDIA_POLICIES = (
-        (None, _("Don't use re-usable media, use regular one-off tickets")),
-        (MEDIA_POLICY_REUSE, _('Require an existing medium to be re-used')),
-        (MEDIA_POLICY_NEW, _('Require a previously unknown medium to be newly added')),
-        (MEDIA_POLICY_REUSE_OR_NEW, _('Require either an existing or a new medium to be used')),
-    )
-
     objects = ItemQuerySetManager()
 
     event = models.ForeignKey(
@@ -420,7 +407,7 @@ class Item(LoggedModel):
         help_text=_("If this product has multiple variations, you can set different prices for each of the "
                     "variations. If a variation does not have a special price or if you do not have variations, "
                     "this price will be used."),
-        max_digits=13, decimal_places=2, null=True
+        max_digits=7, decimal_places=2, null=True
     )
     free_price = models.BooleanField(
         default=False,
@@ -551,7 +538,7 @@ class Item(LoggedModel):
     original_price = models.DecimalField(
         verbose_name=_('Original price'),
         blank=True, null=True,
-        max_digits=13, decimal_places=2,
+        max_digits=7, decimal_places=2,
         help_text=_('If set, this will be displayed next to the current price to show that the current price is a '
                     'discounted one. This is just a cosmetic setting and will not actually impact pricing.')
     )
@@ -643,29 +630,6 @@ class Item(LoggedModel):
         help_text=_('The selected start date may only be this many days in the future.')
     )
 
-    media_policy = models.CharField(
-        choices=MEDIA_POLICIES,
-        null=True, blank=True, max_length=16,
-        verbose_name=_('Reusable media policy'),
-        help_text=_(
-            'If this product should be stored on a re-usable physical medium, you can attach a physical media policy. '
-            'This is not required for regular tickets, which just use a one-time barcode, but only for products like '
-            'renewable season tickets or re-chargeable gift card wristbands. '
-            'This is an advanced feature that also requires specific configuration of ticketing and printing settings.'
-        )
-    )
-    media_type = models.CharField(
-        max_length=100,
-        null=True, blank=True,
-        choices=[(None, _("Don't use re-usable media, use regular one-off tickets"))] + [(k, v) for k, v in MEDIA_TYPES.items()],
-        verbose_name=_('Reusable media type'),
-        help_text=_(
-            'Select the type of physical medium that should be used for this product. Note that not all media types '
-            'support all types of products, and not all media types are supported across all sales channels or '
-            'check-in processes.'
-        )
-    )
-
     # !!! Attention: If you add new fields here, also add them to the copying code in
     # pretix/control/forms/item.py if applicable.
 
@@ -837,24 +801,6 @@ class Item(LoggedModel):
     def has_variations(self):
         return self.variations.exists()
 
-    @staticmethod
-    def clean_media_settings(event, media_policy, media_type, issue_giftcard):
-        if media_policy:
-            if not media_type:
-                raise ValidationError(_('If you select a reusable media policy, you also need to select a reusable '
-                                        'media type.'))
-            mt = MEDIA_TYPES[media_type]
-            if not mt.is_active(event.organizer):
-                raise ValidationError(_('The selected media type is not enabled in your organizer settings.'))
-            if not mt.supports_orderposition and not issue_giftcard:
-                raise ValidationError(_('The selected media type does not support usage for tickets currently.'))
-            if not mt.supports_giftcard and issue_giftcard:
-                raise ValidationError(_('The selected media type does not support usage for gift cards currently.'))
-            if issue_giftcard:
-                raise ValidationError(_('You currently cannot create gift cards with a reusable media policy. Instead, '
-                                        'gift cards for some reusable media types can be created or re-charged directly '
-                                        'at the POS.'))
-
     @staticmethod
     def clean_per_order(min_per_order, max_per_order):
         if min_per_order is not None and max_per_order is not None:
@@ -1006,14 +952,14 @@ class ItemVariation(models.Model):
         verbose_name=_("Position")
     )
     default_price = models.DecimalField(
-        decimal_places=2, max_digits=13,
+        decimal_places=2, max_digits=7,
         null=True, blank=True,
         verbose_name=_("Default price"),
     )
     original_price = models.DecimalField(
         verbose_name=_('Original price'),
         blank=True, null=True,
-        max_digits=13, decimal_places=2,
+        max_digits=7, decimal_places=2,
         help_text=_('If set, this will be displayed next to the current price to show that the current price is a '
                     'discounted one. This is just a cosmetic setting and will not actually impact pricing.')
     )
@@ -1358,7 +1304,7 @@ class ItemBundle(models.Model):
     )
     designated_price = models.DecimalField(
         default=Decimal('0.00'), blank=True,
-        decimal_places=2, max_digits=13,
+        decimal_places=2, max_digits=10,
         verbose_name=_('Designated price part'),
         help_text=_('If set, it will be shown that this bundled item is responsible for the given value of the total '
                     'gross price. This might be important in cases of mixed taxation, but can be kept blank otherwise. This '
@@ -1542,11 +1488,6 @@ class Question(LoggedModel):
     valid_datetime_max = models.DateTimeField(null=True, blank=True,
                                               verbose_name=_('Maximum value'),
                                               help_text=_('Currently not supported in our apps and during check-in'))
-    valid_string_length_max = models.PositiveIntegerField(null=True, blank=True,
-                                                          verbose_name=_('Maximum length'),
-                                                          help_text=_(
-                                                              'Currently not supported in our apps and during check-in'
-                                                          ))
     valid_file_portrait = models.BooleanField(
         default=False,
         verbose_name=_('Validate file to be a portrait'),
@@ -1693,12 +1634,6 @@ class Question(LoggedModel):
                 return answer
             else:
                 raise ValidationError(_('Unknown country code.'))
-        elif self.type in (Question.TYPE_STRING, Question.TYPE_TEXT):
-            if self.valid_string_length_max is not None and len(answer) > self.valid_string_length_max:
-                raise ValidationError(MaxLengthValidator.message % {
-                    'limit_value': self.valid_string_length_max,
-                    'show_value': len(answer)
-                })
 
         return answer
 

src/pretix/base/models/media.py

@@ -1,125 +0,0 @@
-#
-# This file is part of pretix (Community Edition).
-#
-# Copyright (C) 2014-2020 Raphael Michel and contributors
-# Copyright (C) 2020-2021 rami.io GmbH and contributors
-#
-# This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General
-# Public License as published by the Free Software Foundation in version 3 of the License.
-#
-# ADDITIONAL TERMS APPLY: Pursuant to Section 7 of the GNU Affero General Public License, additional terms are
-# applicable granting you additional permissions and placing additional restrictions on your usage of this software.
-# Please refer to the pretix LICENSE file to obtain the full terms applicable to this work. If you did not receive
-# this file, see <https://pretix.eu/about/en/license>.
-#
-# This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
-# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more
-# details.
-#
-# You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
-# <https://www.gnu.org/licenses/>.
-#
-from django.db import models
-from django.db.models import Q
-from django.utils.functional import cached_property
-from django.utils.timezone import now
-from django.utils.translation import gettext_lazy as _, pgettext_lazy
-from django_scopes import ScopedManager
-
-from pretix.base.media import MEDIA_TYPES
-from pretix.base.models import LoggedModel
-from pretix.base.models.customers import Customer
-from pretix.base.models.giftcards import GiftCard
-from pretix.base.models.orders import OrderPosition
-from pretix.base.models.organizer import Organizer
-
-
-class ReusableMediumQuerySet(models.QuerySet):
-
-    def active(self):
-        return self.filter(
-            Q(expires__isnull=True) | Q(expires__gte=now()),
-            active=True,
-        )
-
-
-class ReusableMediumQuerySetManager(ScopedManager(organizer='organizer').__class__):
-    def __init__(self):
-        super().__init__()
-        self._queryset_class = ReusableMediumQuerySet
-
-    def active(self):
-        return self.get_queryset().active()
-
-
-class ReusableMedium(LoggedModel):
-    id = models.BigAutoField(primary_key=True)
-    created = models.DateTimeField(auto_now_add=True)
-    updated = models.DateTimeField(auto_now=True)
-
-    organizer = models.ForeignKey(
-        Organizer,
-        related_name='reusable_media',
-        on_delete=models.PROTECT
-    )
-
-    type = models.CharField(
-        verbose_name=pgettext_lazy('reusable_medium', 'Media type'),
-        choices=((k, v) for k, v in MEDIA_TYPES.items()),
-        max_length=100,
-    )
-    identifier = models.CharField(
-        max_length=200,
-        verbose_name=pgettext_lazy('reusable_medium', 'Identifier'),
-    )
-
-    active = models.BooleanField(
-        verbose_name=_('Active'),
-        default=True
-    )
-    expires = models.DateTimeField(
-        verbose_name=_('Expiration date'),
-        null=True, blank=True
-    )
-
-    customer = models.ForeignKey(
-        Customer,
-        null=True, blank=True,
-        related_name='reusable_media',
-        on_delete=models.SET_NULL,
-        verbose_name=_('Customer account'),
-    )
-    linked_orderposition = models.ForeignKey(
-        OrderPosition,
-        null=True, blank=True,
-        related_name='linked_media',
-        on_delete=models.SET_NULL,
-        verbose_name=_('Linked ticket'),
-    )
-    linked_giftcard = models.ForeignKey(
-        GiftCard,
-        null=True, blank=True,
-        related_name='linked_media',
-        on_delete=models.SET_NULL,
-        verbose_name=_('Linked gift card'),
-    )
-
-    info = models.JSONField(
-        default=dict
-    )
-    notes = models.TextField(verbose_name=_('Notes'), null=True, blank=True)
-
-    objects = ReusableMediumQuerySetManager()
-
-    @cached_property
-    def media_type(self):
-        return MEDIA_TYPES[self.type]
-
-    @property
-    def is_expired(self):
-        return self.expires and self.expires > now()
-
-    class Meta:
-        unique_together = (("identifier", "type", "organizer"),)
-        index_together = (("identifier", "type", "organizer"), ("updated", "id"))
-        ordering = "identifier", "type", "organizer"

src/pretix/base/models/orders.py

@@ -220,7 +220,7 @@ class Order(LockModel, LoggedModel):
         verbose_name=_("Expiration date")
     )
     total = models.DecimalField(
-        decimal_places=2, max_digits=13,
+        decimal_places=2, max_digits=10,
         verbose_name=_("Total amount")
     )
     comment = models.TextField(
@@ -403,8 +403,8 @@ class Order(LockModel, LoggedModel):
             state__in=(OrderRefund.REFUND_STATE_CREATED, OrderRefund.REFUND_STATE_TRANSIT),
             order=OuterRef('pk')
         )
-        payment_sum_sq = Subquery(payment_sum, output_field=models.DecimalField(decimal_places=2, max_digits=13))
-        refund_sum_sq = Subquery(refund_sum, output_field=models.DecimalField(decimal_places=2, max_digits=13))
+        payment_sum_sq = Subquery(payment_sum, output_field=models.DecimalField(decimal_places=2, max_digits=10))
+        refund_sum_sq = Subquery(refund_sum, output_field=models.DecimalField(decimal_places=2, max_digits=10))
         if sums:
             qs = qs.annotate(
                 payment_sum=payment_sum_sq,
@@ -626,10 +626,7 @@ class Order(LockModel, LoggedModel):
                 has_checkin=Exists(Checkin.objects.filter(position_id=OuterRef('pk')))
             ).select_related('item').prefetch_related('issued_gift_cards')
         )
-        if self.event.settings.change_allow_user_if_checked_in:
-            cancelable = all([op.item.allow_cancel for op in positions])
-        else:
-            cancelable = all([op.item.allow_cancel and not op.has_checkin for op in positions])
+        cancelable = all([op.item.allow_cancel and not op.has_checkin for op in positions])
         if not cancelable or not positions:
             return False
         for op in positions:
@@ -988,7 +985,7 @@ class Order(LockModel, LoggedModel):
                   context: Dict[str, Any]=None, log_entry_type: str='pretix.event.order.email.sent',
                   user: User=None, headers: dict=None, sender: str=None, invoices: list=None,
                   auth=None, attach_tickets=False, position: 'OrderPosition'=None, auto_email=True,
-                  attach_ical=False, attach_other_files: list=None, attach_cached_files: list=None):
+                  attach_ical=False, attach_other_files: list=None):
         """
         Sends an email to the user that placed this order. Basically, this method does two things:
 
@@ -1033,7 +1030,7 @@ class Order(LockModel, LoggedModel):
                     self.event, self.locale, self, headers=headers, sender=sender,
                     invoices=invoices, attach_tickets=attach_tickets,
                     position=position, auto_email=auto_email, attach_ical=attach_ical,
-                    attach_other_files=attach_other_files, attach_cached_files=attach_cached_files,
+                    attach_other_files=attach_other_files,
                 )
             except SendMailException:
                 raise
@@ -1316,7 +1313,7 @@ class AbstractPosition(models.Model):
         on_delete=models.PROTECT
     )
     price = models.DecimalField(
-        decimal_places=2, max_digits=13,
+        decimal_places=2, max_digits=10,
         verbose_name=_("Price")
     )
     attendee_name_cached = models.CharField(
@@ -1548,7 +1545,7 @@ class OrderPayment(models.Model):
         max_length=190, choices=PAYMENT_STATES
     )
     amount = models.DecimalField(
-        decimal_places=2, max_digits=13,
+        decimal_places=2, max_digits=10,
         verbose_name=_("Amount")
     )
     order = models.ForeignKey(
@@ -1932,7 +1929,7 @@ class OrderRefund(models.Model):
         max_length=190, choices=REFUND_SOURCES
     )
     amount = models.DecimalField(
-        decimal_places=2, max_digits=13,
+        decimal_places=2, max_digits=10,
         verbose_name=_("Amount")
     )
     order = models.ForeignKey(
@@ -2081,7 +2078,7 @@ class OrderFee(models.Model):
     )
 
     value = models.DecimalField(
-        decimal_places=2, max_digits=13,
+        decimal_places=2, max_digits=10,
         verbose_name=_("Value")
     )
     order = models.ForeignKey(
@@ -2105,7 +2102,7 @@ class OrderFee(models.Model):
         null=True, blank=True
     )
     tax_value = models.DecimalField(
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         verbose_name=_('Tax value')
     )
     canceled = models.BooleanField(default=False)
@@ -2239,7 +2236,7 @@ class OrderPosition(AbstractPosition):
     )
 
     voucher_budget_use = models.DecimalField(
-        max_digits=13, decimal_places=2, null=True, blank=True,
+        max_digits=10, decimal_places=2, null=True, blank=True,
     )
 
     tax_rate = models.DecimalField(
@@ -2252,7 +2249,7 @@ class OrderPosition(AbstractPosition):
         null=True, blank=True
     )
     tax_value = models.DecimalField(
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         verbose_name=_('Tax value')
     )
 
@@ -2558,27 +2555,6 @@ class OrderPosition(AbstractPosition):
                 attach_tickets=True
             )
 
-    @property
-    @scopes_disabled()
-    def attendee_change_allowed(self) -> bool:
-        """
-        Returns whether or not this order can be changed by the attendee.
-        """
-        from .items import ItemAddOn
-
-        if not self.event.settings.change_allow_attendee or not self.order.user_change_allowed:
-            return False
-
-        positions = list(
-            self.order.positions.filter(Q(pk=self.pk) | Q(addon_to_id=self.pk)).annotate(
-                has_variations=Exists(ItemVariation.objects.filter(item_id=OuterRef('item_id'))),
-            ).select_related('item').prefetch_related('issued_gift_cards')
-        )
-        return (
-            (self.order.event.settings.change_allow_user_variation and any([op.has_variations for op in positions])) or
-            (self.order.event.settings.change_allow_user_addons and ItemAddOn.objects.filter(base_item_id__in=[op.item_id for op in positions]).exists())
-        )
-
 
 class Transaction(models.Model):
     """
@@ -2673,7 +2649,7 @@ class Transaction(models.Model):
         verbose_name=pgettext_lazy("subevent", "Date"),
     )
     price = models.DecimalField(
-        decimal_places=2, max_digits=13,
+        decimal_places=2, max_digits=10,
         verbose_name=_("Price")
     )
     tax_rate = models.DecimalField(
@@ -2686,7 +2662,7 @@ class Transaction(models.Model):
         null=True, blank=True
     )
     tax_value = models.DecimalField(
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         verbose_name=_('Tax value')
     )
     fee_type = models.CharField(
@@ -2764,19 +2740,19 @@ class CartPosition(AbstractPosition):
         verbose_name=_('Tax rate')
     )
     listed_price = models.DecimalField(
-        decimal_places=2, max_digits=13, null=True,
+        decimal_places=2, max_digits=10, null=True,
     )
     price_after_voucher = models.DecimalField(
-        decimal_places=2, max_digits=13, null=True,
+        decimal_places=2, max_digits=10, null=True,
     )
     custom_price_input = models.DecimalField(
-        decimal_places=2, max_digits=13, null=True,
+        decimal_places=2, max_digits=10, null=True,
     )
     custom_price_input_is_net = models.BooleanField(
         default=False,
     )
     line_price_gross = models.DecimalField(
-        decimal_places=2, max_digits=13, null=True,
+        decimal_places=2, max_digits=10, null=True,
     )
     requested_valid_from = models.DateTimeField(
         null=True,
@@ -2846,7 +2822,7 @@ class CartPosition(AbstractPosition):
         # Migrate from pre-discounts position
         if self.item.free_price and self.custom_price_input is None:
             custom_price = self.price
-            if custom_price > 99_999_999_999:
+            if custom_price > 100000000:
                 raise ValueError('price_too_high')
             self.custom_price_input = custom_price
             self.custom_price_input_is_net = not False
@@ -3059,7 +3035,7 @@ class CachedCombinedTicket(models.Model):
 class CancellationRequest(models.Model):
     order = models.ForeignKey(Order, on_delete=models.CASCADE, related_name='cancellation_requests')
     created = models.DateTimeField(auto_now_add=True)
-    cancellation_fee = models.DecimalField(max_digits=13, decimal_places=2)
+    cancellation_fee = models.DecimalField(max_digits=10, decimal_places=2)
     refund_as_giftcard = models.BooleanField(default=False)
 
 

src/pretix/base/models/organizer.py

@@ -236,8 +236,6 @@ class Team(LoggedModel):
     :type can_change_teams: bool
     :param can_manage_customers: If ``True``, the members can view and change organizer-level customer accounts.
     :type can_manage_customers: bool
-    :param can_manage_reusable_media: If ``True``, the members can view and change organizer-level reusable media.
-    :type can_manage_reusable_media: bool
     :param can_change_organizer_settings: If ``True``, the members can change the settings of this organizer account.
     :type can_change_organizer_settings: bool
     :param can_change_event_settings: If ``True``, the members can change the settings of the associated events.
@@ -279,10 +277,6 @@ class Team(LoggedModel):
         default=False,
         verbose_name=_("Can manage customer accounts")
     )
-    can_manage_reusable_media = models.BooleanField(
-        default=False,
-        verbose_name=_("Can manage reusable media")
-    )
     can_manage_gift_cards = models.BooleanField(
         default=False,
         verbose_name=_("Can manage gift cards")

src/pretix/base/models/vouchers.py

@@ -213,7 +213,7 @@ class Voucher(LoggedModel):
         verbose_name=_("Maximum discount budget"),
         help_text=_("This is the maximum monetary amount that will be discounted using this voucher across all usages. "
                     "If this is sum reached, the voucher can no longer be used."),
-        decimal_places=2, max_digits=13,
+        decimal_places=2, max_digits=10,
         null=True, blank=True
     )
     valid_until = models.DateTimeField(
@@ -243,7 +243,7 @@ class Voucher(LoggedModel):
     )
     value = models.DecimalField(
         verbose_name=_("Voucher value"),
-        decimal_places=2, max_digits=13, null=True, blank=True,
+        decimal_places=2, max_digits=10, null=True, blank=True,
     )
     item = models.ForeignKey(
         Item, related_name='vouchers',
@@ -454,7 +454,7 @@ class Voucher(LoggedModel):
 
     @staticmethod
     def clean_voucher_code(data, event, pk):
-        if 'code' in data and Voucher.objects.filter(Q(code__iexact=data['code'].upper()) & Q(event=event) & ~Q(pk=pk)).exists():
+        if 'code' in data and Voucher.objects.filter(Q(code__iexact=data['code']) & Q(event=event) & ~Q(pk=pk)).exists():
             raise ValidationError(_('A voucher with this code already exists.'))
 
     @staticmethod
@@ -599,7 +599,7 @@ class Voucher(LoggedModel):
                 Order.STATUS_PENDING
             ]
         ).order_by().values('voucher_id').annotate(s=Sum('voucher_budget_use')).values('s')
-        return qs.annotate(budget_used_orders=Coalesce(Subquery(opq, output_field=models.DecimalField(max_digits=13, decimal_places=2)), Decimal('0.00')))
+        return qs.annotate(budget_used_orders=Coalesce(Subquery(opq, output_field=models.DecimalField(max_digits=10, decimal_places=2)), Decimal('0.00')))
 
     def budget_used(self):
         ops = OrderPosition.objects.filter(

src/pretix/base/models/waitinglist.py

@@ -219,19 +219,18 @@ class WaitingListEntry(LoggedModel):
             self.voucher = v
             self.save()
 
-        with language(self.locale, self.event.settings.region):
-            self.send_mail(
-                self.event.settings.mail_subject_waiting_list,
-                self.event.settings.mail_text_waiting_list,
-                get_email_context(
-                    event=self.event,
-                    waiting_list_entry=self,
-                    waiting_list_voucher=v,
-                    event_or_subevent=self.subevent or self.event,
-                ),
-                user=user,
-                auth=auth,
-            )
+        self.send_mail(
+            self.event.settings.mail_subject_waiting_list,
+            self.event.settings.mail_text_waiting_list,
+            get_email_context(
+                event=self.event,
+                waiting_list_entry=self,
+                waiting_list_voucher=v,
+                event_or_subevent=self.subevent or self.event,
+            ),
+            user=user,
+            auth=auth,
+        )
 
     def send_mail(self, subject: Union[str, LazyI18nString], template: Union[str, LazyI18nString],
                   context: Dict[str, Any]=None, log_entry_type: str='pretix.waitinglist.email.sent',

src/pretix/base/payment.py

@@ -1125,12 +1125,6 @@ class ManualPayment(BasePaymentProvider):
                     widget=I18nTextarea,
                     validators=[PlaceholderValidator(['{order}', '{amount}', '{currency}', '{amount_with_currency}'])],
                 )),
-                ('invoice_immediately',
-                 forms.BooleanField(
-                     label=_('Create an invoice for orders using bank transfer immediately if the event is otherwise '
-                             'configured to create invoices after payment is completed.'),
-                     required=False,
-                 )),
             ] + list(super().settings_form_fields.items())
         )
         d.move_to_end('_enabled', last=False)
@@ -1170,10 +1164,6 @@ class ManualPayment(BasePaymentProvider):
             format_map(self.settings.get('pending_description', as_type=LazyI18nString), self.format_map(payment.order, payment))
         )
 
-    @property
-    def requires_invoice_immediately(self):
-        return self.settings.get('invoice_immediately', False, as_type=bool)
-
 
 class OffsettingProvider(BasePaymentProvider):
     is_enabled = True

src/pretix/base/pdf.py

@@ -360,7 +360,7 @@ DEFAULT_VARIABLES = OrderedDict((
         "label": _("List of Add-Ons"),
         "editor_sample": _("Add-on 1\nAdd-on 2"),
         "evaluate": lambda op, order, ev: "\n".join([
-            '{} - {}'.format(p.item.name, p.variation.value) if p.variation else str(p.item.name)
+            '{} - {}'.format(p.item, p.variation) if p.variation else str(p.item)
             for p in (
                 op.addons.all() if 'addons' in getattr(op, '_prefetched_objects_cache', {})
                 else op.addons.select_related('item', 'variation')
@@ -411,7 +411,7 @@ DEFAULT_VARIABLES = OrderedDict((
         "label": _("Validity start date"),
         "editor_sample": _("2017-05-31"),
         "evaluate": lambda op, order, ev: date_format(
-            op.valid_from.astimezone(timezone(ev.settings.timezone)),
+            now().astimezone(timezone(ev.settings.timezone)),
             "SHORT_DATE_FORMAT"
         ) if op.valid_from else ""
     }),
@@ -455,11 +455,6 @@ DEFAULT_VARIABLES = OrderedDict((
             "TIME_FORMAT"
         ) if op.valid_until else ""
     }),
-    ("medium_identifier", {
-        "label": _("Reusable Medium ID"),
-        "editor_sample": "ABC1234DEF4567",
-        "evaluate": lambda op, order, ev: op.linked_media.all()[0].identifier if op.linked_media.all() else "",
-    }),
     ("seat", {
         "label": _("Seat: Full name"),
         "editor_sample": _("Ground floor, Row 3, Seat 4"),
@@ -588,11 +583,10 @@ def variables_from_questions(sender, *args, **kwargs):
 
 
 def _get_attendee_name_part(key, op, order, ev):
-    name_parts = op.attendee_name_parts or (op.addon_to.attendee_name_parts if op.addon_to else {})
     if isinstance(key, tuple):
-        parts = [_get_attendee_name_part(c[0], op, order, ev) for c in key if not (c[0] == 'salutation' and name_parts.get(c[0], '') == "Mx")]
+        parts = [_get_attendee_name_part(c[0], op, order, ev) for c in key if not (c[0] == 'salutation' and op.attendee_name_parts.get(c[0], '') == "Mx")]
         return ' '.join(p for p in parts if p)
-    value = name_parts.get(key, '')
+    value = op.attendee_name_parts.get(key, '')
     if key == 'salutation':
         return pgettext('person_name_salutation', value)
     return value
@@ -623,7 +617,7 @@ def get_variables(event):
     v['attendee_name_for_salutation'] = {
         'label': _("Attendee name for salutation"),
         'editor_sample': _("Mr Doe"),
-        'evaluate': lambda op, order, ev: concatenation_for_salutation(op.attendee_name_parts or (op.addon_to.attendee_name_parts if op.addon_to else {}))
+        'evaluate': lambda op, order, ev: concatenation_for_salutation(op.attendee_name_parts or {})
     }
 
     for key, label, weight in scheme['fields']:
@@ -767,9 +761,6 @@ class Renderer:
         else:
             content = self._get_text_content(op, order, o)
 
-        if len(content) == 0:
-            return
-
         level = 'H'
         if len(content) > 32:
             level = 'M'
@@ -786,16 +777,16 @@ class Renderer:
         qr_y = float(o['bottom']) * mm
         renderPDF.draw(d, canvas, qr_x, qr_y)
 
-        # Add QR content + PDF issuer as a hidden string (fully transparent & very very small)
+        # Add QR content + PDF issuer as a hidden string (fully transparent & off page)
         # This helps automated processing of the PDF file by 3rd parties, e.g. when checking tickets for resale
         data = {
             "issuer": settings.SITE_URL,
             o.get('content', 'secret'): content
         }
         canvas.saveState()
-        canvas.setFont('Open Sans', .01)
+        canvas.setFont('Open Sans', 1)
         canvas.setFillColorRGB(0, 0, 0, 0)
-        canvas.drawString(0 * mm, 0 * mm, json.dumps(data, sort_keys=True))
+        canvas.drawString(-1000 * mm, -1000 * mm, json.dumps(data, sort_keys=True))
         canvas.restoreState()
 
     def _get_ev(self, op, order):

src/pretix/base/plugins.py

@@ -24,11 +24,9 @@ import sys
 from enum import Enum
 from typing import List
 
-import importlib_metadata as metadata
 from django.apps import AppConfig, apps
 from django.conf import settings
 from django.core.exceptions import ImproperlyConfigured
-from packaging.requirements import Requirement
 
 
 class PluginType(Enum):
@@ -83,11 +81,12 @@ class PluginConfig(AppConfig, metaclass=PluginConfigMeta):
             raise ImproperlyConfigured("A pretix plugin config should have a PretixPluginMeta inner class.")
 
         if hasattr(self.PretixPluginMeta, 'compatibility') and not os.environ.get("PRETIX_IGNORE_CONFLICTS") == "True":
-            req = Requirement(self.PretixPluginMeta.compatibility)
-            requirement_version = metadata.version(req.name)
-            if not req.specifier.contains(requirement_version, prereleases=True):
+            import pkg_resources
+            try:
+                pkg_resources.require(self.PretixPluginMeta.compatibility)
+            except pkg_resources.VersionConflict as e:
                 print("Incompatible plugins found!")
                 print("Plugin {} requires you to have {}, but you installed {}.".format(
-                    self.name, req, requirement_version
+                    self.name, e.req, e.dist
                 ))
                 sys.exit(1)

src/pretix/base/services/cart.py

@@ -31,7 +31,6 @@
 # Unless required by applicable law or agreed to in writing, software distributed under the Apache License 2.0 is
 # distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations under the License.
-import re
 import uuid
 from collections import Counter, defaultdict, namedtuple
 from datetime import datetime, time, timedelta
@@ -39,7 +38,6 @@ from decimal import Decimal
 from typing import List, Optional
 
 from celery.exceptions import MaxRetriesExceededError
-from django import forms
 from django.core.exceptions import ValidationError
 from django.db import DatabaseError, transaction
 from django.db.models import Count, Exists, IntegerField, OuterRef, Q, Value
@@ -52,7 +50,6 @@ from django_scopes import scopes_disabled
 
 from pretix.base.channels import get_all_sales_channels
 from pretix.base.i18n import language
-from pretix.base.media import MEDIA_TYPES
 from pretix.base.models import (
     CartPosition, Event, InvoiceAddress, Item, ItemVariation, Seat,
     SeatCategoryMapping, Voucher,
@@ -138,7 +135,6 @@ error_messages = {
     'some_subevent_ended': gettext_lazy(
         'The booking period for one of the events in your cart has ended. The affected '
         'positions have been removed from your cart.'),
-    'price_not_a_number': gettext_lazy('The entered price is not a number.'),
     'price_too_high': gettext_lazy('The entered price is to high.'),
     'voucher_invalid': gettext_lazy('This voucher code is not known in our database.'),
     'voucher_min_usages': gettext_lazy(
@@ -200,8 +196,6 @@ error_messages = {
     'seat_multiple': gettext_lazy('You can not select the same seat multiple times.'),
     'gift_card': gettext_lazy("You entered a gift card instead of a voucher. Gift cards can be entered later on when you're asked for your payment details."),
     'country_blocked': gettext_lazy('One of the selected products is not available in the selected country.'),
-    'media_usage_not_implemented': gettext_lazy('The configuration of this product requires mapping to a physical '
-                                                'medium, which is currently not available online.'),
 }
 
 
@@ -397,13 +391,6 @@ class CartManager:
             if not op.item.is_available() or (op.variation and not op.variation.is_available()):
                 raise CartError(error_messages['unavailable'])
 
-            if op.item.media_policy in (Item.MEDIA_POLICY_NEW, Item.MEDIA_POLICY_REUSE_OR_NEW):
-                mt = MEDIA_TYPES[op.item.media_type]
-                if not mt.medium_created_by_server:
-                    raise CartError(error_messages['media_usage_not_implemented'])
-            elif op.item.media_policy == Item.MEDIA_POLICY_REUSE:
-                raise CartError(error_messages['media_usage_not_implemented'])
-
             if self._sales_channel not in op.item.sales_channels or (op.variation and self._sales_channel not in op.variation.sales_channels):
                 raise CartError(error_messages['unavailable'])
 
@@ -738,18 +725,9 @@ class CartManager:
                 price_after_voucher = listed_price
             custom_price = None
             if item.free_price and i.get('price'):
-                custom_price = re.sub('[^0-9.,]', '', str(i.get('price')))
-                if not custom_price:
-                    raise CartError(error_messages['price_not_a_number'])
-                try:
-                    custom_price = forms.DecimalField(localize=True).to_python(custom_price)
-                except:
-                    try:
-                        custom_price = Decimal(custom_price)
-                    except:
-                        raise CartError(error_messages['price_not_a_number'])
-                if custom_price > 99_999_999_999:
-                    raise CartError(error_messages['price_too_high'])
+                custom_price = Decimal(str(i.get('price')).replace(",", "."))
+                if custom_price > 100000000:
+                    raise ValueError('price_too_high')
 
             op = self.AddOperation(
                 count=i['count'],
@@ -862,18 +840,9 @@ class CartManager:
                 listed_price = get_listed_price(item, variation, cp.subevent)
             custom_price = None
             if item.free_price and a.get('price'):
-                custom_price = re.sub('[^0-9.,]', '', a.get('price'))
-                if not custom_price:
-                    raise CartError(error_messages['price_not_a_number'])
-                try:
-                    custom_price = forms.DecimalField(localize=True).to_python(custom_price)
-                except:
-                    try:
-                        custom_price = Decimal(custom_price)
-                    except:
-                        raise CartError(error_messages['price_not_a_number'])
-                if custom_price > 99_999_999_999:
-                    raise CartError(error_messages['price_too_high'])
+                custom_price = Decimal(str(a.get('price')).replace(",", "."))
+                if custom_price > 100000000:
+                    raise ValueError('price_too_high')
 
             # Fix positions with wrong price (TODO: happens out-of-cartmanager-transaction and therefore a little hacky)
             for ca in current_addons[cp][a['item'], a['variation']]:
@@ -1172,7 +1141,7 @@ class CartManager:
                             custom_price_input=op.custom_price_input,
                             custom_price_input_is_net=op.custom_price_input_is_net,
                             line_price_gross=line_price.gross,
-                            tax_rate=line_price.rate,
+                            tax_rate=line_price.tax,
                             price=line_price.gross,
                         )
                         if self.event.settings.attendee_names_asked:
@@ -1219,7 +1188,7 @@ class CartManager:
                                         custom_price_input=b.custom_price_input,
                                         custom_price_input_is_net=b.custom_price_input_is_net,
                                         line_price_gross=bline_price.gross,
-                                        tax_rate=bline_price.rate,
+                                        tax_rate=bline_price.tax,
                                         price=bline_price.gross,
                                         is_bundled=True
                                     ))

src/pretix/base/services/checkin.py

@@ -693,7 +693,7 @@ def _save_answers(op, answers, given_answers):
 def perform_checkin(op: OrderPosition, clist: CheckinList, given_answers: dict, force=False,
                     ignore_unpaid=False, nonce=None, datetime=None, questions_supported=True,
                     user=None, auth=None, canceled_supported=False, type=Checkin.TYPE_ENTRY,
-                    raw_barcode=None, raw_source_type=None, from_revoked_secret=False):
+                    raw_barcode=None, from_revoked_secret=False):
     """
     Create a checkin for this particular order position and check-in list. Fails with CheckInError if the check in is
     not valid at this time.
@@ -714,53 +714,40 @@ def perform_checkin(op: OrderPosition, clist: CheckinList, given_answers: dict,
     # !!!!!!!!!
 
     dt = datetime or now()
-    force_used = False
 
     if op.canceled or op.order.status not in (Order.STATUS_PAID, Order.STATUS_PENDING):
-        if force:
-            force_used = True
-        else:
-            raise CheckInError(
-                _('This order position has been canceled.'),
-                'canceled' if canceled_supported else 'unpaid'
-            )
+        raise CheckInError(
+            _('This order position has been canceled.'),
+            'canceled' if canceled_supported else 'unpaid'
+        )
 
     if op.blocked:
-        if force:
-            force_used = True
-        else:
-            raise CheckInError(
-                _('This ticket has been blocked.'),  # todo provide reason
-                'blocked'
-            )
+        raise CheckInError(
+            _('This ticket has been blocked.'),  # todo provide reason
+            'blocked'
+        )
 
     if type != Checkin.TYPE_EXIT and op.valid_from and op.valid_from > now():
-        if force:
-            force_used = True
-        else:
-            raise CheckInError(
-                _('This ticket is only valid after {datetime}.').format(
-                    datetime=date_format(op.valid_from.astimezone(clist.event.timezone), 'SHORT_DATETIME_FORMAT')
-                ),
-                'invalid_time',
-                _('This ticket is only valid after {datetime}.').format(
-                    datetime=date_format(op.valid_from.astimezone(clist.event.timezone), 'SHORT_DATETIME_FORMAT')
-                ),
-            )
+        raise CheckInError(
+            _('This ticket is only valid after {datetime}.').format(
+                datetime=date_format(op.valid_from, 'SHORT_DATETIME_FORMAT')
+            ),
+            'invalid_time',
+            _('This ticket is only valid after {datetime}.').format(
+                datetime=date_format(op.valid_from, 'SHORT_DATETIME_FORMAT')
+            ),
+        )
 
     if type != Checkin.TYPE_EXIT and op.valid_until and op.valid_until < now():
-        if force:
-            force_used = True
-        else:
-            raise CheckInError(
-                _('This ticket was only valid before {datetime}.').format(
-                    datetime=date_format(op.valid_until.astimezone(clist.event.timezone), 'SHORT_DATETIME_FORMAT')
-                ),
-                'invalid_time',
-                _('This ticket was only valid before {datetime}.').format(
-                    datetime=date_format(op.valid_until.astimezone(clist.event.timezone), 'SHORT_DATETIME_FORMAT')
-                ),
-            )
+        raise CheckInError(
+            _('This ticket was only valid before {datetime}.').format(
+                datetime=date_format(op.valid_until, 'SHORT_DATETIME_FORMAT')
+            ),
+            'invalid_time',
+            _('This ticket was only valid before {datetime}.').format(
+                datetime=date_format(op.valid_until, 'SHORT_DATETIME_FORMAT')
+            ),
+        )
 
     # Do this outside of transaction so it is saved even if the checkin fails for some other reason
     checkin_questions = list(
@@ -783,57 +770,40 @@ def perform_checkin(op: OrderPosition, clist: CheckinList, given_answers: dict,
         op = opqs.get(pk=op.pk)
 
         if not clist.all_products and op.item_id not in [i.pk for i in clist.limit_products.all()]:
-            if force:
-                force_used = True
-            else:
-                raise CheckInError(
-                    _('This order position has an invalid product for this check-in list.'),
-                    'product'
-                )
-
-        if clist.subevent_id and op.subevent_id != clist.subevent_id:
-            if force:
-                force_used = True
-            else:
-                raise CheckInError(
-                    _('This order position has an invalid date for this check-in list.'),
-                    'product'
-                )
-
-        if op.order.status != Order.STATUS_PAID and op.order.require_approval:
-            if force:
-                force_used = True
-            else:
-                raise CheckInError(
-                    _('This order is not yet approved.'),
-                    'unpaid'
-                )
-        elif op.order.status != Order.STATUS_PAID and not op.order.valid_if_pending and not (
+            raise CheckInError(
+                _('This order position has an invalid product for this check-in list.'),
+                'product'
+            )
+        elif clist.subevent_id and op.subevent_id != clist.subevent_id:
+            raise CheckInError(
+                _('This order position has an invalid date for this check-in list.'),
+                'product'
+            )
+        elif op.order.status != Order.STATUS_PAID and not force and op.order.require_approval:
+            raise CheckInError(
+                _('This order is not yet approved.'),
+                'unpaid'
+            )
+        elif op.order.status != Order.STATUS_PAID and not force and not op.order.valid_if_pending and not (
             ignore_unpaid and clist.include_pending and op.order.status == Order.STATUS_PENDING
         ):
-            if force:
-                force_used = True
-            else:
-                raise CheckInError(
-                    _('This order is not marked as paid.'),
-                    'unpaid'
-                )
+            raise CheckInError(
+                _('This order is not marked as paid.'),
+                'unpaid'
+            )
 
-        if type == Checkin.TYPE_ENTRY and clist.rules:
+        if type == Checkin.TYPE_ENTRY and clist.rules and not force:
             rule_data = LazyRuleVars(op, clist, dt)
             logic = _get_logic_environment(op.subevent or clist.event)
             if not logic.apply(clist.rules, rule_data):
-                if force:
-                    force_used = True
-                else:
-                    reason = _logic_explain(clist.rules, op.subevent or clist.event, rule_data)
-                    raise CheckInError(
-                        _('Entry not permitted: {explanation}.').format(
-                            explanation=reason
-                        ),
-                        'rules',
-                        reason=reason
-                    )
+                reason = _logic_explain(clist.rules, op.subevent or clist.event, rule_data)
+                raise CheckInError(
+                    _('Entry not permitted: {explanation}.').format(
+                        explanation=reason
+                    ),
+                    'rules',
+                    reason=reason
+                )
 
         if require_answers and not force and questions_supported:
             raise RequiredQuestionsError(
@@ -867,10 +837,9 @@ def perform_checkin(op: OrderPosition, clist: CheckinList, given_answers: dict,
                 device=device,
                 gate=device.gate if device else None,
                 nonce=nonce,
-                forced=force and (not entry_allowed or from_revoked_secret or force_used),
+                forced=force and (not entry_allowed or from_revoked_secret),
                 force_sent=force,
                 raw_barcode=raw_barcode,
-                raw_source_type=raw_source_type,
             )
             op.order.log_action('pretix.event.checkin', data={
                 'position': op.id,

src/pretix/base/services/mail.py

@@ -95,18 +95,6 @@ class SendMailException(Exception):
     pass
 
 
-def clean_sender_name(sender_name: str) -> str:
-    # Emails with @ in their sender name are rejected by some mailservers (e.g. Microsoft) because it looks like
-    # a phishing attempt.
-    sender_name = sender_name.replace("@", " ")
-
-    # Emails with excessively long sender names are rejected by some mailservers
-    if len(sender_name) > 75:
-        sender_name = sender_name[:75] + "..."
-
-    return sender_name
-
-
 def mail(email: Union[str, Sequence[str]], subject: str, template: Union[str, LazyI18nString],
          context: Dict[str, Any] = None, event: Event = None, locale: str = None, order: Order = None,
          position: OrderPosition = None, *, headers: dict = None, sender: str = None, organizer: Organizer = None,
@@ -208,13 +196,17 @@ def mail(email: Union[str, Sequence[str]], subject: str, template: Union[str, La
             settings.MAIL_FROM
         )
         if event:
-            sender_name = clean_sender_name(event.settings.mail_from_name or str(event.name))
+            sender_name = event.settings.mail_from_name or str(event.name)
+            if len(sender_name) > 75:
+                sender_name = sender_name[:75] + "..."
             sender = formataddr((sender_name, sender))
         elif organizer:
-            sender_name = clean_sender_name(organizer.settings.mail_from_name or str(organizer.name))
+            sender_name = organizer.settings.mail_from_name or str(organizer.name)
+            if len(sender_name) > 75:
+                sender_name = sender_name[:75] + "..."
             sender = formataddr((sender_name, sender))
         else:
-            sender = formataddr((clean_sender_name(settings.PRETIX_INSTANCE_NAME), sender))
+            sender = formataddr((settings.PRETIX_INSTANCE_NAME, sender))
 
         subject = raw_subject = str(subject).replace('\n', ' ').replace('\r', '')[:900]
         signature = ""

src/pretix/base/services/orders.py

@@ -47,8 +47,7 @@ from django.core.cache import cache
 from django.core.exceptions import ValidationError
 from django.db import transaction
 from django.db.models import (
-    Count, Exists, F, IntegerField, Max, Min, OuterRef, Q, QuerySet, Sum,
-    Value,
+    Count, Exists, F, IntegerField, Max, Min, OuterRef, Q, Sum, Value,
 )
 from django.db.models.functions import Coalesce, Greatest
 from django.db.transaction import get_connection
@@ -62,7 +61,6 @@ from pretix.api.models import OAuthApplication
 from pretix.base.channels import get_all_sales_channels
 from pretix.base.email import get_email_context
 from pretix.base.i18n import get_language_without_region, language
-from pretix.base.media import MEDIA_TYPES
 from pretix.base.models import (
     CartPosition, Device, Event, GiftCard, Item, ItemVariation, Membership,
     Order, OrderPayment, OrderPosition, Quota, Seat, SeatCategoryMapping, User,
@@ -190,7 +188,6 @@ error_messages = {
         'min'
     ),
     'addon_no_multi': gettext_lazy('You can select every add-ons from the category %(cat)s for the product %(base)s at most once.'),
-    'addon_already_checked_in': gettext_lazy('You cannot remove the position %(addon)s since it has already been checked in.'),
 }
 
 logger = logging.getLogger(__name__)
@@ -391,15 +388,9 @@ def approve_order(order, user=None, send_mail: bool=True, auth=None, force=False
             if order.total == Decimal('0.00'):
                 email_template = order.event.settings.mail_text_order_approved_free
                 email_subject = order.event.settings.mail_subject_order_approved_free
-                email_attendees = order.event.settings.mail_send_order_approved_free_attendee
-                email_attendee_template = order.event.settings.mail_text_order_approved_free_attendee
-                email_attendee_subject = order.event.settings.mail_subject_order_approved_free_attendee
             else:
                 email_template = order.event.settings.mail_text_order_approved
                 email_subject = order.event.settings.mail_subject_order_approved
-                email_attendees = order.event.settings.mail_send_order_approved_attendee
-                email_attendee_template = order.event.settings.mail_text_order_approved_attendee
-                email_attendee_subject = order.event.settings.mail_subject_order_approved_attendee
 
             email_context = get_email_context(event=order.event, order=order)
             try:
@@ -412,19 +403,6 @@ def approve_order(order, user=None, send_mail: bool=True, auth=None, force=False
             except SendMailException:
                 logger.exception('Order approved email could not be sent')
 
-            if email_attendees:
-                for p in order.positions.all():
-                    if p.addon_to_id is None and p.attendee_email and p.attendee_email != order.email:
-                        email_attendee_context = get_email_context(event=order.event, order=order, position=p)
-                        try:
-                            p.send_mail(
-                                email_attendee_subject, email_attendee_template, email_attendee_context,
-                                'pretix.event.order.email.order_approved', user,
-                                attach_tickets=True,
-                            )
-                        except SendMailException:
-                            logger.exception('Order approved email could not be sent to attendee')
-
     return order.pk
 
 
@@ -1451,7 +1429,7 @@ class OrderChangeManager:
     MembershipOperation = namedtuple('MembershipOperation', ('position', 'membership'))
     CancelOperation = namedtuple('CancelOperation', ('position', 'price_diff'))
     AddOperation = namedtuple('AddOperation', ('item', 'variation', 'price', 'addon_to', 'subevent', 'seat', 'membership',
-                                               'valid_from', 'valid_until', 'is_bundled'))
+                                               'valid_from', 'valid_until'))
     SplitOperation = namedtuple('SplitOperation', ('position',))
     FeeValueOperation = namedtuple('FeeValueOperation', ('fee', 'value', 'price_diff'))
     AddFeeOperation = namedtuple('AddFeeOperation', ('fee', 'price_diff'))
@@ -1629,7 +1607,6 @@ class OrderChangeManager:
                                            override_tax_rate=new_rate)
                 self._totaldiff += new_tax.gross - pos.price
                 self._operations.append(self.PriceOperation(pos, new_tax, new_tax.gross - pos.price))
-                self._invoice_dirty = True
 
     def cancel_fee(self, fee: OrderFee):
         self._totaldiff -= fee.value
@@ -1681,7 +1658,6 @@ class OrderChangeManager:
         except TaxRule.SaleNotAllowed:
             raise OrderError(self.error_messages['tax_rule_country_blocked'])
 
-        is_bundled = False
         if price is None:
             raise OrderError(self.error_messages['product_invalid'])
         if item.variations.exists() and not variation:
@@ -1690,10 +1666,7 @@ class OrderChangeManager:
             raise OrderError(self.error_messages['addon_to_required'])
         if addon_to:
             if not item.category or item.category_id not in addon_to.item.addons.values_list('addon_category', flat=True):
-                if addon_to.item.bundles.filter(bundled_item=item, bundled_variation=variation).exists():
-                    is_bundled = True
-                else:
-                    raise OrderError(self.error_messages['addon_invalid'])
+                raise OrderError(self.error_messages['addon_invalid'])
         if self.order.event.has_subevents and not subevent:
             raise OrderError(self.error_messages['subevent_required'])
 
@@ -1718,7 +1691,7 @@ class OrderChangeManager:
         if seat:
             self._seatdiff.update([seat])
         self._operations.append(self.AddOperation(item, variation, price, addon_to, subevent, seat, membership,
-                                                  valid_from, valid_until, is_bundled))
+                                                  valid_from, valid_until))
 
     def split(self, position: OrderPosition):
         if self.order.event.settings.invoice_include_free or position.price != Decimal('0.00'):
@@ -1728,19 +1701,7 @@ class OrderChangeManager:
         for a in position.addons.all():
             self._operations.append(self.SplitOperation(a))
 
-    def set_addons(self, addons, limit_main_positions=None):
-        """
-        This is a convenience method to change the add-on products selected on an order. The input structure is similar
-        to CartManager.set_addons. It will automatically compute the correct operations to add, cancel, or change
-        positions on the order. Every existing add-on not in the input will be canceled. Availability of the
-        products is validated (with some exceptions).
-
-        :param addons: A list of dictionaries with the keys ``"addon_to"``, ``"item"``, ``"variation"`` (all ID values),
-                       ``"count"``, and ``"price"``.
-        :param limit_main_positions: By default, the method works on all methods of the order. If you set this to a
-                                     queryset or a list of positions, all other positions and their add-ons will be kept
-                                     untouched.
-        """
+    def set_addons(self, addons):
         if self._operations:
             raise ValueError("Setting addons should be the first/only operation")
 
@@ -1752,13 +1713,7 @@ class OrderChangeManager:
         quota_diff = Counter()  # Quota -> Number of usages
         available_categories = defaultdict(set)  # OrderPos -> Category IDs to choose from
         price_included = defaultdict(dict)  # OrderPos -> CategoryID -> bool(price is included)
-        if isinstance(limit_main_positions, QuerySet):
-            toplevel_qs = limit_main_positions
-        elif limit_main_positions is not None:
-            toplevel_qs = self.order.positions.filter(pk__in=[p.pk for p in limit_main_positions])
-        else:
-            toplevel_qs = self.order.positions
-        toplevel_op = toplevel_qs.filter(
+        toplevel_op = self.order.positions.filter(
             addon_to__isnull=True
         ).prefetch_related(
             'addons', 'item__addons', 'item__addons__addon_category'
@@ -1922,12 +1877,6 @@ class OrderChangeManager:
                     for a in current_addons[cp][k][:current_num - input_num]:
                         if a.canceled:
                             continue
-                        if a.checkins.exists():
-                            raise OrderError(
-                                error_messages['addon_already_checked_in'] % {
-                                    'addon': str(a.item.name),
-                                }
-                            )
                         self.cancel(a)
 
     def _check_seats(self):
@@ -2249,7 +2198,6 @@ class OrderChangeManager:
                     tax_value=op.price.tax, tax_rule=op.item.tax_rule,
                     positionid=nextposid, subevent=op.subevent, seat=op.seat,
                     used_membership=op.membership, valid_from=op.valid_from, valid_until=op.valid_until,
-                    is_bundled=op.is_bundled,
                 )
                 nextposid += 1
                 self.order.log_action('pretix.event.order.changed.add', user=self.user, auth=self.auth, data={
@@ -2936,32 +2884,3 @@ def signal_listener_issue_memberships(sender: Event, order: Order, **kwargs):
     for p in order.positions.all():
         if p.item.grant_membership_type_id:
             create_membership(order.customer, p)
-
-
-@receiver(order_placed, dispatch_uid="pretixbase_order_placed_media")
-@receiver(order_changed, dispatch_uid="pretixbase_order_changed_media")
-@transaction.atomic()
-def signal_listener_issue_media(sender: Event, order: Order, **kwargs):
-    from pretix.base.models import ReusableMedium
-
-    for p in order.positions.all():
-        if p.item.media_policy in (Item.MEDIA_POLICY_NEW, Item.MEDIA_POLICY_REUSE_OR_NEW):
-            mt = MEDIA_TYPES[p.item.media_type]
-            if mt.medium_created_by_server and not p.linked_media.exists():
-                rm = ReusableMedium.objects.create(
-                    organizer=sender.organizer,
-                    type=p.item.media_type,
-                    identifier=mt.generate_identifier(sender.organizer),
-                    active=True,
-                    customer=order.customer,
-                    linked_orderposition=p,
-                )
-                rm.log_action(
-                    'pretix.reusable_medium.created',
-                    data={
-                        'by_order': order.code,
-                        'linked_orderposition': p.pk,
-                        'active': True,
-                        'customer': order.customer_id,
-                    }
-                )

src/pretix/base/services/pricing.py

@@ -19,11 +19,9 @@
 # You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
 # <https://www.gnu.org/licenses/>.
 #
-import re
 from decimal import Decimal
 from typing import List, Optional, Tuple
 
-from django import forms
 from django.db.models import Q
 from django.utils.timezone import now
 
@@ -71,17 +69,8 @@ def get_price(item: Item, variation: ItemVariation = None,
                                  subtract_from_gross=bundled_sum)
     elif item.free_price and custom_price is not None and custom_price != "":
         if not isinstance(custom_price, Decimal):
-            custom_price = re.sub('[^0-9.,]', '', str(custom_price))
-            if not custom_price:
-                raise ValueError('price_not_a_number')
-            try:
-                custom_price = forms.DecimalField(localize=True).to_python(custom_price)
-            except:
-                try:
-                    custom_price = Decimal(custom_price)
-                except:
-                    raise ValueError('price_not_a_number')
-        if custom_price > 99_999_999_999:
+            custom_price = Decimal(str(custom_price).replace(",", "."))
+        if custom_price > 100000000:
             raise ValueError('price_too_high')
 
         price = tax_rule.tax(price, invoice_address=invoice_address)

src/pretix/base/services/stats.py

@@ -112,7 +112,7 @@ def dictsum(*dicts) -> dict:
 
 def order_overview(
         event: Event, subevent: SubEvent=None, date_filter='', date_from=None, date_until=None, fees=False,
-        admission_only=False, base_qs=None, base_fees_qs=None,
+        admission_only=False, base_qs=None
 ) -> Tuple[List[Tuple[ItemCategory, List[Item]]], Dict[str, Tuple[Decimal, Decimal]]]:
     items = event.items.all().select_related(
         'category',  # for re-grouping
@@ -233,8 +233,7 @@ def order_overview(
     payment_items = []
 
     if subevent is None and fees:
-        qs = OrderFee.all if base_fees_qs is None else base_fees_qs
-        qs = qs.filter(
+        qs = OrderFee.all.filter(
             order__event=event
         ).annotate(
             status=Case(

src/pretix/base/settings.py

@@ -63,8 +63,7 @@ from rest_framework import serializers
 from pretix.api.serializers.fields import (
     ListMultipleChoiceField, UploadedFileField,
 )
-from pretix.api.serializers.i18n import I18nField, I18nURLField
-from pretix.base.forms import I18nURLFormField
+from pretix.api.serializers.i18n import I18nField
 from pretix.base.models.tax import VAT_ID_COUNTRIES, TaxRule
 from pretix.base.reldate import (
     RelativeDateField, RelativeDateTimeField, RelativeDateWrapper,
@@ -169,84 +168,6 @@ DEFAULTS = {
                         "was not logged in during the purchase.")
         )
     },
-    'reusable_media_active': {
-        'default': 'False',
-        'type': bool,
-        'form_class': forms.BooleanField,
-        'serializer_class': serializers.BooleanField,
-        'form_kwargs': dict(
-            label=_("Activate re-usable media"),
-            help_text=_("The re-usable media feature allows you to connect tickets and gift cards with physical media "
-                        "such as wristbands or chip cards that may be re-used for different tickets or gift cards "
-                        "later.")
-        )
-    },
-    'reusable_media_type_barcode': {
-        'default': 'False',
-        'type': bool,
-        'form_class': forms.BooleanField,
-        'serializer_class': serializers.BooleanField,
-        'form_kwargs': dict(
-            label=_("Active"),
-        )
-    },
-    'reusable_media_type_barcode_identifier_length': {
-        'default': 24,
-        'type': int,
-        'form_class': forms.IntegerField,
-        'serializer_class': serializers.IntegerField,
-        'serializer_kwargs': dict(
-            validators=[
-                MinValueValidator(12),
-                MaxValueValidator(64),
-            ]
-        ),
-        'form_kwargs': dict(
-            label=_('Length of barcodes'),
-            validators=[
-                MinValueValidator(12),
-                MaxValueValidator(64),
-            ],
-            required=True,
-            widget=forms.NumberInput(
-                attrs={
-                    'min': '12',
-                    'max': '64',
-                },
-            ),
-        )
-    },
-    'reusable_media_type_nfc_uid': {
-        'default': 'False',
-        'type': bool,
-        'form_class': forms.BooleanField,
-        'serializer_class': serializers.BooleanField,
-        'form_kwargs': dict(
-            label=_("Active"),
-        )
-    },
-    'reusable_media_type_nfc_uid_autocreate_giftcard': {
-        'default': 'False',
-        'type': bool,
-        'form_class': forms.BooleanField,
-        'serializer_class': serializers.BooleanField,
-        'form_kwargs': dict(
-            label=_("Automatically create a new gift card if a previously unknown chip is seen"),
-        )
-    },
-    'reusable_media_type_nfc_uid_autocreate_giftcard_currency': {
-        'default': 'EUR',
-        'type': str,
-        'form_class': forms.ChoiceField,
-        'serializer_class': serializers.ChoiceField,
-        'serializer_kwargs': dict(
-            choices=[(c.alpha_3, c.alpha_3 + " - " + c.name) for c in settings.CURRENCIES],
-        ),
-        'form_kwargs': dict(
-            choices=[(c.alpha_3, c.alpha_3 + " - " + c.name) for c in settings.CURRENCIES],
-            label=_("Gift card currency"),
-        )
-    },
     'max_items_per_order': {
         'default': '10',
         'type': int,
@@ -290,8 +211,6 @@ DEFAULTS = {
     'system_question_order': {
         'default': {},
         'type': dict,
-        'serializer_class': serializers.DictField,
-        'serializer_kwargs': lambda: dict(read_only=True, allow_empty=True),
     },
     'attendee_names_asked': {
         'default': 'True',
@@ -594,7 +513,6 @@ DEFAULTS = {
         'form_kwargs': dict(
             label=_("Minimum length of invoice number after prefix"),
             help_text=_("The part of your invoice number after your prefix will be filled up with leading zeros up to this length, e.g. INV-001 or INV-00001."),
-            max_value=12,
             required=True,
         )
     },
@@ -1372,10 +1290,9 @@ DEFAULTS = {
         'serializer_class': serializers.BooleanField,
         'form_class': forms.BooleanField,
         'form_kwargs': dict(
-            label=_("Generate tickets for add-on products and bundled products"),
-            help_text=_('By default, tickets are only issued for products selected individually, not for add-on products '
-                        'or bundled products. With this option, a separate ticket is issued for every add-on product '
-                        'or bundled product as well.'),
+            label=_("Generate tickets for add-on products"),
+            help_text=_('By default, tickets are only issued for products selected individually, not for add-on '
+                        'products. With this option, a separate ticket is issued for every add-on product as well.'),
             widget=forms.CheckboxInput(attrs={'data-checkbox-dependency': '#id_ticket_download',
                                               'data-checkbox-dependency-visual': 'on'}),
         )
@@ -1479,19 +1396,6 @@ DEFAULTS = {
         'serializer_class': serializers.BooleanField,
         'form_kwargs': dict(
             label=_("Hide all unavailable dates from calendar or list views"),
-            help_text=_("This option currently only affects the calendar of this event series, not the organizer-wide "
-                        "calendar.")
-        )
-    },
-    'event_calendar_future_only': {
-        'default': 'False',
-        'type': bool,
-        'form_class': forms.BooleanField,
-        'serializer_class': serializers.BooleanField,
-        'form_kwargs': dict(
-            label=_("Hide all past dates from calendar"),
-            help_text=_("This option currently only affects the calendar of this event series, not the organizer-wide "
-                        "calendar.")
         )
     },
     'allow_modifications_after_checkin': {
@@ -1566,32 +1470,6 @@ DEFAULTS = {
             label=_("Do not allow changes after"),
         )
     },
-    'change_allow_user_if_checked_in': {
-        'default': 'False',
-        'type': bool,
-        'form_class': forms.BooleanField,
-        'serializer_class': serializers.BooleanField,
-        'form_kwargs': dict(
-            label=_("Allow change even though the ticket has already been checked in"),
-            help_text=_("By default, order changes are disabled after any ticket in the order has been checked in. "
-                        "If you check this box, this requirement is lifted. It is still not possible to remove an "
-                        "add-on product that has already been checked in individually. Use with care, and preferably "
-                        "only in combination with a limitation on price changes above."),
-        )
-    },
-    'change_allow_attendee': {
-        'default': 'False',
-        'type': bool,
-        'form_class': forms.BooleanField,
-        'serializer_class': serializers.BooleanField,
-        'form_kwargs': dict(
-            label=_("Allow individual attendees to change their ticket"),
-            help_text=_("By default, only the person who ordered the tickets can make any changes. If you check this "
-                        "box, individual attendees can also make changes. However, individual attendees can always "
-                        "only make changes that do not change the total price of the order. Such changes can always "
-                        "only be made by the main customer."),
-        )
-    },
     'cancel_allow_user': {
         'default': 'True',
         'type': bool,
@@ -1607,7 +1485,7 @@ DEFAULTS = {
         'form_class': forms.DecimalField,
         'serializer_class': serializers.DecimalField,
         'serializer_kwargs': dict(
-            max_digits=13, decimal_places=2
+            max_digits=10, decimal_places=2
         ),
         'form_kwargs': dict(
             label=_("Charge a fixed cancellation fee"),
@@ -1632,7 +1510,7 @@ DEFAULTS = {
         'form_class': forms.DecimalField,
         'serializer_class': serializers.DecimalField,
         'serializer_kwargs': dict(
-            max_digits=13, decimal_places=2
+            max_digits=10, decimal_places=2
         ),
         'form_kwargs': dict(
             label=_("Charge a percentual cancellation fee"),
@@ -1666,7 +1544,7 @@ DEFAULTS = {
         'form_class': forms.DecimalField,
         'serializer_class': serializers.DecimalField,
         'serializer_kwargs': dict(
-            max_digits=13, decimal_places=2
+            max_digits=10, decimal_places=2
         ),
         'form_kwargs': dict(
             label=_("Keep a fixed cancellation fee"),
@@ -1687,7 +1565,7 @@ DEFAULTS = {
         'form_class': forms.DecimalField,
         'serializer_class': serializers.DecimalField,
         'serializer_kwargs': dict(
-            max_digits=13, decimal_places=2
+            max_digits=10, decimal_places=2
         ),
         'form_kwargs': dict(
             label=_("Keep a percentual cancellation fee"),
@@ -1726,10 +1604,10 @@ DEFAULTS = {
         'form_class': forms.DecimalField,
         'serializer_class': serializers.DecimalField,
         'serializer_kwargs': dict(
-            max_digits=13, decimal_places=2
+            max_digits=10, decimal_places=2
         ),
         'form_kwargs': dict(
-            max_digits=13, decimal_places=2,
+            max_digits=10, decimal_places=2,
             label=_("Step size for reduction amount"),
             help_text=_('By default, customers can choose an arbitrary amount for you to keep. If you set this to e.g. '
                         '10, they will only be able to choose values in increments of 10.')
@@ -1811,15 +1689,14 @@ DEFAULTS = {
     },
     'privacy_url': {
         'default': None,
-        'type': LazyI18nString,
-        'form_class': I18nURLFormField,
+        'type': str,
+        'form_class': forms.URLField,
         'form_kwargs': dict(
             label=_("Privacy Policy URL"),
             help_text=_("This should point e.g. to a part of your website that explains how you use data gathered in "
                         "your ticket shop."),
-            widget=I18nTextInput,
         ),
-        'serializer_class': I18nURLField,
+        'serializer_class': serializers.URLField,
     },
     'confirm_texts': {
         'default': LazyI18nStringList(),
@@ -2275,26 +2152,6 @@ You can select a payment method and perform the payment here:
 
 {url}
 
-Best regards,
-Your {event} team"""))
-    },
-    'mail_send_order_approved_attendee': {
-        'type': bool,
-        'default': 'False'
-    },
-    'mail_subject_order_approved_attendee': {
-        'type': LazyI18nString,
-        'default': LazyI18nString.from_gettext(gettext_noop("Your event registration: {code}")),
-    },
-    'mail_text_order_approved_attendee': {
-        'type': LazyI18nString,
-        'default': LazyI18nString.from_gettext(gettext_noop("""Hello,
-
-we approved a ticket ordered for you for {event}.
-
-You can view the details and status of your ticket here:
-{url}
-
 Best regards,
 Your {event} team"""))
     },
@@ -2312,26 +2169,6 @@ at our event. As you only ordered free products, no payment is required.
 You can change your order details and view the status of your order at
 {url}
 
-Best regards,
-Your {event} team"""))
-    },
-    'mail_send_order_approved_free_attendee': {
-        'type': bool,
-        'default': 'False'
-    },
-    'mail_subject_order_approved_free_attendee': {
-        'type': LazyI18nString,
-        'default': LazyI18nString.from_gettext(gettext_noop("Your event registration: {code}")),
-    },
-    'mail_text_order_approved_free_attendee': {
-        'type': LazyI18nString,
-        'default': LazyI18nString.from_gettext(gettext_noop("""Hello,
-
-we approved a ticket ordered for you for {event}.
-
-You can view the details and status of your ticket here:
-{url}
-
 Best regards,
 Your {event} team"""))
     },
@@ -3173,13 +3010,6 @@ def concatenation_for_salutation(d):
     return " ".join(filter(None, (salutation, title, given_name, family_name)))
 
 
-def get_name_parts_localized(name_parts, key):
-    value = name_parts.get(key, "")
-    if key == "salutation":
-        return pgettext_lazy("person_name_salutation", value)
-    return value
-
-
 PERSON_NAME_SCHEMES = OrderedDict([
     ('given_family', {
         'fields': (
@@ -3536,12 +3366,7 @@ def validate_organizer_settings(organizer, settings_dict):
     # organizer-settings either.
     #
     # N.B.: When actually fleshing out this stub, adding it to the OrganizerUpdateForm should be considered.
-    """
-    if settings_dict.get('reusable_media_type_ntag_pretix1') and settings_dict.get('reusable_media_type_nfc_uid'):
-        raise ValidationError({
-            'reusable_media_type_nfc_uid': _('This needs to be disabled if other NFC-based types are active.')
-        })
-    """
+    pass
 
 
 def global_settings_object(holder):

src/pretix/base/shredder.py

@@ -383,10 +383,9 @@ class QuestionAnswerShredder(BaseDataShredder):
             d = le.parsed_data
             if 'data' in d:
                 for i, row in enumerate(d['data']):
-                    if isinstance(d['data'], list):
-                        for f in row:
-                            if f not in ('attendee_name', 'attendee_email'):
-                                d['data'][i][f] = '█'
+                    for f in row:
+                        if f not in ('attendee_name', 'attendee_email'):
+                            d['data'][i][f] = '█'
                 le.data = json.dumps(d)
                 le.shredded = True
                 le.save(update_fields=['data', 'shredded'])

src/pretix/base/views/mixins.py

@@ -71,7 +71,6 @@ class BaseQuestionsViewMixin:
             kwargs = self.question_form_kwargs(cr)
             form = self.form_class(event=self.request.event,
                                    prefix=cr.id,
-                                   request=self.request,
                                    cartpos=cartpos,
                                    orderpos=orderpos,
                                    all_optional=self.all_optional,

src/pretix/control/forms/event.py

@@ -39,7 +39,7 @@ from urllib.parse import urlencode, urlparse
 
 from django import forms
 from django.conf import settings
-from django.core.exceptions import NON_FIELD_ERRORS, ValidationError
+from django.core.exceptions import ValidationError
 from django.core.validators import MaxValueValidator
 from django.db.models import Prefetch, Q, prefetch_related_objects
 from django.forms import (
@@ -457,49 +457,7 @@ class EventUpdateForm(I18nModelForm):
         }
 
 
-class EventSettingsValidationMixin:
-
-    def clean(self):
-        data = super().clean()
-        settings_dict = self.obj.settings.freeze()
-        settings_dict.update(data)
-        validate_event_settings(self.obj, settings_dict)
-        return data
-
-    def add_error(self, field, error):
-        # Copied from Django, but with improved handling for validation errors on fields that are not part of this form
-
-        if not isinstance(error, ValidationError):
-            error = ValidationError(error)
-
-        if hasattr(error, 'error_dict'):
-            if field is not None:
-                raise TypeError(
-                    "The argument `field` must be `None` when the `error` "
-                    "argument contains errors for multiple fields."
-                )
-            else:
-                error = error.error_dict
-        else:
-            error = {field or NON_FIELD_ERRORS: error.error_list}
-
-        for field, error_list in error.items():
-            if field != NON_FIELD_ERRORS and field not in self.fields:
-                field = NON_FIELD_ERRORS
-                for e in error_list:
-                    e.message = _('A validation error has occurred on a setting that is not part of this form: {error}').format(error=e.message)
-
-            if field not in self.errors:
-                if field == NON_FIELD_ERRORS:
-                    self._errors[field] = self.error_class(error_class='nonfield')
-                else:
-                    self._errors[field] = self.error_class()
-            self._errors[field].extend(error_list)
-            if field in self.cleaned_data:
-                del self.cleaned_data[field]
-
-
-class EventSettingsForm(EventSettingsValidationMixin, SettingsForm):
+class EventSettingsForm(SettingsForm):
     timezone = forms.ChoiceField(
         choices=((a, a) for a in common_timezones),
         label=_("Event timezone"),
@@ -553,7 +511,6 @@ class EventSettingsForm(EventSettingsValidationMixin, SettingsForm):
         'low_availability_percentage',
         'event_list_type',
         'event_list_available_only',
-        'event_calendar_future_only',
         'frontpage_text',
         'event_info_text',
         'attendee_names_asked',
@@ -615,8 +572,13 @@ class EventSettingsForm(EventSettingsValidationMixin, SettingsForm):
         return data
 
     def clean(self):
-        self.cleaned_data = self._resolve_virtual_keys_input(self.cleaned_data)
         data = super().clean()
+        settings_dict = self.event.settings.freeze()
+        settings_dict.update(data)
+
+        data = self._resolve_virtual_keys_input(data)
+
+        validate_event_settings(self.event, data)
         return data
 
     def __init__(self, *args, **kwargs):
@@ -640,7 +602,6 @@ class EventSettingsForm(EventSettingsValidationMixin, SettingsForm):
             del self.fields['frontpage_subevent_ordering']
             del self.fields['event_list_type']
             del self.fields['event_list_available_only']
-            del self.fields['event_calendar_future_only']
 
         # create "virtual" fields for better UX when editing <name>_asked and <name>_required fields
         self.virtual_keys = []
@@ -727,8 +688,6 @@ class CancelSettingsForm(SettingsForm):
         'change_allow_user_price',
         'change_allow_user_until',
         'change_allow_user_addons',
-        'change_allow_user_if_checked_in',
-        'change_allow_attendee',
     ]
 
     def __init__(self, *args, **kwargs):
@@ -739,7 +698,7 @@ class CancelSettingsForm(SettingsForm):
             ).format(self.obj.settings.giftcard_expiry_years)
 
 
-class PaymentSettingsForm(EventSettingsValidationMixin, SettingsForm):
+class PaymentSettingsForm(SettingsForm):
     auto_fields = [
         'payment_term_mode',
         'payment_term_days',
@@ -771,6 +730,13 @@ class PaymentSettingsForm(EventSettingsValidationMixin, SettingsForm):
             raise ValidationError(_("This field is required."))
         return value
 
+    def clean(self):
+        data = super().clean()
+        settings_dict = self.obj.settings.freeze()
+        settings_dict.update(data)
+        validate_event_settings(self.obj, data)
+        return data
+
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
         self.fields['tax_rate_default'].queryset = self.obj.tax_rules.all()
@@ -818,7 +784,7 @@ class ProviderForm(SettingsForm):
         return cleaned_data
 
 
-class InvoiceSettingsForm(EventSettingsValidationMixin, SettingsForm):
+class InvoiceSettingsForm(SettingsForm):
 
     auto_fields = [
         'invoice_address_asked',
@@ -893,6 +859,13 @@ class InvoiceSettingsForm(EventSettingsValidationMixin, SettingsForm):
         )
         self.fields['invoice_numbers_counter_length'].validators.append(MaxValueValidator(15))
 
+    def clean(self):
+        data = super().clean()
+        settings_dict = self.obj.settings.freeze()
+        settings_dict.update(data)
+        validate_event_settings(self.obj, data)
+        return data
+
 
 def contains_web_channel_validate(val):
     if "web" not in val:
@@ -1191,24 +1164,6 @@ class MailSettingsForm(SettingsForm):
         help_text=_("This will only be sent out for non-free orders. Free orders will receive the free order "
                     "template from below instead."),
     )
-    mail_send_order_approved_attendee = forms.BooleanField(
-        label=_("Send an email to attendees"),
-        help_text=_('If the order contains attendees with email addresses different from the person who orders the '
-                    'tickets, the following email will be sent out to the attendees.'),
-        required=False,
-    )
-    mail_subject_order_approved_attendee = I18nFormField(
-        label=_("Subject sent to attendees"),
-        required=False,
-        widget=I18nTextInput,
-    )
-    mail_text_order_approved_attendee = I18nFormField(
-        label=_("Text sent to attendees"),
-        required=False,
-        widget=I18nTextarea,
-        help_text=_("This will only be sent out for non-free orders. Free orders will receive the free order "
-                    "template from below instead."),
-    )
     mail_subject_order_approved_free = I18nFormField(
         label=_("Subject for approved free order"),
         required=False,
@@ -1221,24 +1176,6 @@ class MailSettingsForm(SettingsForm):
         help_text=_("This will only be sent out for free orders. Non-free orders will receive the non-free order "
                     "template from above instead."),
     )
-    mail_send_order_approved_free_attendee = forms.BooleanField(
-        label=_("Send an email to attendees"),
-        help_text=_('If the order contains attendees with email addresses different from the person who orders the '
-                    'tickets, the following email will be sent out to the attendees.'),
-        required=False,
-    )
-    mail_subject_order_approved_free_attendee = I18nFormField(
-        label=_("Subject sent to attendees"),
-        required=False,
-        widget=I18nTextInput,
-    )
-    mail_text_order_approved_free_attendee = I18nFormField(
-        label=_("Text sent to attendees"),
-        required=False,
-        widget=I18nTextarea,
-        help_text=_("This will only be sent out for free orders. Non-free orders will receive the non-free order "
-                    "template from above instead."),
-    )
     mail_subject_order_denied = I18nFormField(
         label=_("Subject for denied order"),
         required=False,
@@ -1438,10 +1375,7 @@ class TaxRuleLineForm(I18nForm):
     invoice_text = I18nFormField(
         label=_('Text on invoice'),
         required=False,
-        widget=I18nTextInput,
-        widget_kwargs=dict(attrs={
-            'placeholder': _('Text on invoice'),
-        })
+        widget=I18nTextInput
     )
 
 
@@ -1631,7 +1565,7 @@ class QuickSetupProductForm(I18nForm):
     )
     default_price = forms.DecimalField(
         label=_("Price (optional)"),
-        max_digits=13, decimal_places=2, required=False,
+        max_digits=7, decimal_places=2, required=False,
         localize=True,
         widget=forms.TextInput(
             attrs={

src/pretix/control/forms/filter.py

@@ -61,7 +61,7 @@ from pretix.base.models import (
     SubEventMetaValue, Team, TeamAPIToken, TeamInvite, Voucher,
 )
 from pretix.base.signals import register_payment_providers
-from pretix.control.forms.widgets import Select2, Select2ItemVarQuota
+from pretix.control.forms.widgets import Select2
 from pretix.control.signals import order_search_filter_q
 from pretix.helpers.countries import CachedCountries
 from pretix.helpers.database import (
@@ -256,13 +256,9 @@ class OrderFilterForm(FilterForm):
             else:
                 code = Q(code__icontains=Order.normalize_code(u))
 
-            invoice_nos = {u, u.upper()}
-            if u.isdigit():
-                for i in range(2, 12):
-                    invoice_nos.add(u.zfill(i))
-
             matching_invoices = Invoice.objects.filter(
-                Q(invoice_no__in=invoice_nos)
+                Q(invoice_no__iexact=u)
+                | Q(invoice_no__iexact=u.zfill(5))
                 | Q(full_invoice_no__iexact=u)
             ).values_list('order_id', flat=True)
             matching_positions = OrderPosition.objects.filter(
@@ -387,6 +383,8 @@ class OrderFilterForm(FilterForm):
 
         if fdata.get('ordering'):
             qs = qs.order_by(*get_deterministic_ordering(Order, self.get_order_by()))
+        else:
+            qs = qs.order_by('-datetime', '-pk')
 
         if fdata.get('provider'):
             qs = qs.annotate(
@@ -573,12 +571,6 @@ class EventOrderExpertFilterForm(EventOrderFilterForm):
         label=_('Sales channel'),
         required=False,
     )
-    checkin_attention = forms.NullBooleanField(
-        required=False,
-        widget=FilterNullBooleanSelect,
-        label=_('Requires special attention'),
-        help_text=_('Only matches orders with the attention checkbox set directly for the order, not based on the product.'),
-    )
 
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
@@ -699,8 +691,6 @@ class EventOrderExpertFilterForm(EventOrderFilterForm):
             qs = qs.filter(total=fdata.get('total'))
         if fdata.get('email_known_to_work') is not None:
             qs = qs.filter(email_known_to_work=fdata.get('email_known_to_work'))
-        if fdata.get('checkin_attention') is not None:
-            qs = qs.filter(checkin_attention=fdata.get('checkin_attention'))
         if fdata.get('locale'):
             qs = qs.filter(locale=fdata.get('locale'))
         if fdata.get('payment_sum_min') is not None:
@@ -1008,13 +998,9 @@ class OrderPaymentSearchFilterForm(forms.Form):
         if fdata.get('query'):
             u = fdata.get('query')
 
-            invoice_nos = {u, u.upper()}
-            if u.isdigit():
-                for i in range(2, 12):
-                    invoice_nos.add(u.zfill(i))
-
             matching_invoices = Invoice.objects.filter(
-                Q(invoice_no__in=invoice_nos)
+                Q(invoice_no__iexact=u)
+                | Q(invoice_no__iexact=u.zfill(5))
                 | Q(full_invoice_no__iexact=u)
             ).values_list('order_id', flat=True)
 
@@ -1435,62 +1421,6 @@ class CustomerFilterForm(FilterForm):
         return qs.distinct()
 
 
-class ReusableMediaFilterForm(FilterForm):
-    orders = {
-        'type': 'type',
-        'identifier': 'identifier',
-    }
-    query = forms.CharField(
-        label=_('Search query'),
-        widget=forms.TextInput(attrs={
-            'placeholder': _('Search query'),
-            'autofocus': 'autofocus'
-        }),
-        required=False
-    )
-    status = forms.ChoiceField(
-        label=_('Status'),
-        required=False,
-        choices=(
-            ('', _('All')),
-            ('active', _('active')),
-            ('disabled', _('disabled')),
-            ('expired', _('expired')),
-        )
-    )
-
-    def __init__(self, *args, **kwargs):
-        kwargs.pop('request')
-        super().__init__(*args, **kwargs)
-
-    def filter_qs(self, qs):
-        fdata = self.cleaned_data
-
-        if fdata.get('query'):
-            query = fdata.get('query')
-            qs = qs.filter(
-                Q(identifier__icontains=query)
-                | Q(customer__identifier__icontains=query)
-                | Q(customer__external_identifier__istartswith=query)
-                | Q(linked_orderposition__order__code__icontains=query)
-                | Q(linked_giftcard__secret__icontains=query)
-            )
-
-        if fdata.get('status') == 'active':
-            qs = qs.filter(Q(expires__gt=now()) | Q(expires__isnull=False), active=True)
-        elif fdata.get('status') == 'disabled':
-            qs = qs.filter(active=False)
-        elif fdata.get('status') == 'expired':
-            qs = qs.filter(expires__lte=now())
-
-        if fdata.get('ordering'):
-            qs = qs.order_by(self.get_order_by())
-        else:
-            qs = qs.order_by("identifier", "type", "organizer")
-
-        return qs.distinct()
-
-
 class TeamFilterForm(FilterForm):
     orders = {
         'name': 'name',
@@ -2274,30 +2204,7 @@ class CheckinFilterForm(FilterForm):
         super().__init__(*args, **kwargs)
 
         self.fields['device'].queryset = self.event.organizer.devices.all().order_by('device_id')
-        self.fields['device'].widget = Select2(
-            attrs={
-                'data-model-select2': 'generic',
-                'data-select2-url': reverse('control:organizer.devices.select2', kwargs={
-                    'organizer': self.event.organizer.slug,
-                }),
-                'data-placeholder': _('All devices'),
-            }
-        )
-        self.fields['device'].widget.choices = self.fields['device'].choices
-        self.fields['device'].label = _('Device')
-
         self.fields['gate'].queryset = self.event.organizer.gates.all()
-        self.fields['gate'].widget = Select2(
-            attrs={
-                'data-model-select2': 'generic',
-                'data-select2-url': reverse('control:organizer.gates.select2', kwargs={
-                    'organizer': self.event.organizer.slug,
-                }),
-                'data-placeholder': _('All gates'),
-            }
-        )
-        self.fields['gate'].widget.choices = self.fields['gate'].choices
-        self.fields['gate'].label = _('Gate')
 
         self.fields['checkin_list'].queryset = self.event.checkin_lists.all()
         self.fields['checkin_list'].widget = Select2(
@@ -2324,20 +2231,6 @@ class CheckinFilterForm(FilterForm):
                 choices.append((str(i.pk), str(i)))
         self.fields['itemvar'].choices = choices
 
-        self.fields['itemvar'].choices = choices
-        self.fields['itemvar'].widget = Select2ItemVarQuota(
-            attrs={
-                'data-model-select2': 'generic',
-                'data-select2-url': reverse('control:event.items.itemvar.select2', kwargs={
-                    'event': self.event.slug,
-                    'organizer': self.event.organizer.slug,
-                }),
-                'data-placeholder': _('All products')
-            }
-        )
-        self.fields['itemvar'].required = False
-        self.fields['itemvar'].widget.choices = self.fields['itemvar'].choices
-
     def filter_qs(self, qs):
         fdata = self.cleaned_data
 

src/pretix/control/forms/item.py

@@ -168,7 +168,6 @@ class QuestionForm(I18nModelForm):
             'valid_date_min',
             'valid_date_max',
             'valid_file_portrait',
-            'valid_string_length_max',
         ]
         widgets = {
             'valid_datetime_min': SplitDateTimePickerWidget(),
@@ -402,8 +401,6 @@ class ItemCreateForm(I18nModelForm):
                 'validity_dynamic_duration_months',
                 'validity_dynamic_start_choice',
                 'validity_dynamic_start_choice_day_limit',
-                'media_type',
-                'media_policy',
             )
             for f in fields:
                 setattr(self.instance, f, getattr(src, f))
@@ -595,10 +592,6 @@ class ItemUpdateForm(I18nModelForm):
             del self.fields['grant_membership_duration_days']
             del self.fields['grant_membership_duration_months']
 
-        if not self.event.settings.reusable_media_active:
-            del self.fields['media_type']
-            del self.fields['media_policy']
-
     def clean(self):
         d = super().clean()
         if d['issue_giftcard']:
@@ -642,8 +635,6 @@ class ItemUpdateForm(I18nModelForm):
                     _("The start of validity must be before the end of validity.")
                 )
 
-        Item.clean_media_settings(self.event, d.get('media_policy'), d.get('media_type'), d.get('issue_giftcard'))
-
         return d
 
     def clean_picture(self):
@@ -702,8 +693,6 @@ class ItemUpdateForm(I18nModelForm):
             'validity_dynamic_duration_months',
             'validity_dynamic_start_choice',
             'validity_dynamic_start_choice_day_limit',
-            'media_policy',
-            'media_type',
         ]
         field_classes = {
             'available_from': SplitDateTimeField,

src/pretix/control/forms/orders.py

@@ -167,7 +167,7 @@ class CancelForm(ForceQuotaConfirmationForm):
     )
     cancellation_fee = forms.DecimalField(
         required=False,
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         localize=True,
         label=_('Keep a cancellation fee of'),
         help_text=_('If you keep a fee, all positions within this order will be canceled and the order will be reduced '
@@ -213,7 +213,7 @@ class MarkPaidForm(ConfirmPaymentForm):
     )
     amount = forms.DecimalField(
         required=True,
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         localize=True,
         label=_('Payment amount'),
     )
@@ -318,7 +318,7 @@ class OrderPositionAddForm(forms.Form):
     )
     price = forms.DecimalField(
         required=False,
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         localize=True,
         label=_('Gross price'),
         help_text=_("Including taxes, if any. Keep empty for the product's default price")
@@ -444,7 +444,7 @@ class OrderPositionChangeForm(forms.Form):
     )
     price = forms.DecimalField(
         required=False,
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         localize=True,
         label=_('New price (gross)')
     )
@@ -566,7 +566,7 @@ class OrderPositionChangeForm(forms.Form):
 class OrderFeeChangeForm(forms.Form):
     value = forms.DecimalField(
         required=False,
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         localize=True,
         label=_('New price (gross)')
     )
@@ -731,7 +731,7 @@ class OrderRefundForm(forms.Form):
         )
     )
     partial_amount = forms.DecimalField(
-        required=False, max_digits=13, decimal_places=2,
+        required=False, max_digits=10, decimal_places=2,
         localize=True
     )
 
@@ -820,18 +820,18 @@ class EventCancelForm(forms.Form):
     )
     keep_fee_fixed = forms.DecimalField(
         label=_("Keep a fixed cancellation fee"),
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         required=False
     )
     keep_fee_per_ticket = forms.DecimalField(
         label=_("Keep a fixed cancellation fee per ticket"),
         help_text=_("Free tickets and add-on products are not counted"),
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         required=False
     )
     keep_fee_percentage = forms.DecimalField(
         label=_("Keep a percentual cancellation fee"),
-        max_digits=13, decimal_places=2,
+        max_digits=10, decimal_places=2,
         required=False
     )
     keep_fees = forms.MultipleChoiceField(

src/pretix/control/forms/organizer.py

@@ -41,14 +41,10 @@ from django.core.exceptions import ValidationError
 from django.db.models import Q
 from django.forms import inlineformset_factory
 from django.forms.utils import ErrorDict
-from django.urls import reverse
 from django.utils.crypto import get_random_string
-from django.utils.html import conditional_escape
 from django.utils.safestring import mark_safe
 from django.utils.translation import gettext_lazy as _, pgettext_lazy
-from django_scopes.forms import (
-    SafeModelChoiceField, SafeModelMultipleChoiceField,
-)
+from django_scopes.forms import SafeModelMultipleChoiceField
 from i18nfield.forms import (
     I18nFormField, I18nFormSetMixin, I18nTextarea, I18nTextInput,
 )
@@ -66,18 +62,15 @@ from pretix.base.forms.questions import (
 from pretix.base.forms.widgets import SplitDateTimePickerWidget
 from pretix.base.models import (
     Customer, Device, EventMetaProperty, Gate, GiftCard, Membership,
-    MembershipType, OrderPosition, Organizer, ReusableMedium, Team,
+    MembershipType, Organizer, Team,
 )
 from pretix.base.models.customers import CustomerSSOClient, CustomerSSOProvider
 from pretix.base.models.organizer import OrganizerFooterLink
-from pretix.base.settings import (
-    PERSON_NAME_SCHEMES, PERSON_NAME_TITLE_GROUPS, validate_organizer_settings,
-)
+from pretix.base.settings import PERSON_NAME_SCHEMES, PERSON_NAME_TITLE_GROUPS
 from pretix.control.forms import ExtFileField, SplitDateTimeField
 from pretix.control.forms.event import (
     SafeEventMultipleChoiceField, multimail_validate,
 )
-from pretix.control.forms.widgets import Select2
 from pretix.multidomain.models import KnownDomain
 from pretix.multidomain.urlreverse import build_absolute_uri
 
@@ -215,7 +208,6 @@ class TeamForm(forms.ModelForm):
         fields = ['name', 'all_events', 'limit_events', 'can_create_events',
                   'can_change_teams', 'can_change_organizer_settings',
                   'can_manage_gift_cards', 'can_manage_customers',
-                  'can_manage_reusable_media',
                   'can_change_event_settings', 'can_change_items',
                   'can_view_orders', 'can_change_orders', 'can_checkin_orders',
                   'can_view_vouchers', 'can_change_vouchers']
@@ -397,12 +389,6 @@ class OrganizerSettingsForm(SettingsForm):
         'cookie_consent_dialog_text_secondary',
         'cookie_consent_dialog_button_yes',
         'cookie_consent_dialog_button_no',
-        'reusable_media_active',
-        'reusable_media_type_barcode',
-        'reusable_media_type_barcode_identifier_length',
-        'reusable_media_type_nfc_uid',
-        'reusable_media_type_nfc_uid_autocreate_giftcard',
-        'reusable_media_type_nfc_uid_autocreate_giftcard_currency',
     ]
 
     organizer_logo_image = ExtFileField(
@@ -445,26 +431,6 @@ class OrganizerSettingsForm(SettingsForm):
             ))
             for k, v in PERSON_NAME_TITLE_GROUPS.items()
         ]
-        self.fields['reusable_media_active'].label = mark_safe(
-            conditional_escape(self.fields['reusable_media_active'].label) +
-            ' ' +
-            '<span class="label label-info">{}</span>'.format(_('experimental'))
-        )
-        self.fields['reusable_media_active'].help_text = mark_safe(
-            conditional_escape(self.fields['reusable_media_active'].help_text) +
-            ' ' +
-            '<br/><span class="fa fa-flask"></span> ' +
-            _('This feature is currently in an experimental stage. It only supports very limited use cases and might '
-              'change at any point.')
-        )
-
-    def clean(self):
-        data = super().clean()
-        settings_dict = self.obj.settings.freeze()
-        settings_dict.update(data)
-
-        validate_organizer_settings(self.obj, data)
-        return data
 
 
 class MailSettingsForm(SettingsForm):
@@ -660,116 +626,6 @@ class GiftCardUpdateForm(forms.ModelForm):
         }
 
 
-class SafeOrderPositionChoiceField(forms.ModelChoiceField):
-    def __init__(self, queryset, **kwargs):
-        queryset = queryset.model.all.none()
-        super().__init__(queryset, **kwargs)
-
-    def label_from_instance(self, op):
-        return f'{op.order.code}-{op.positionid} ({str(op.item) + ((" - " + str(op.variation)) if op.variation else "")})'
-
-
-class ReusableMediumUpdateForm(forms.ModelForm):
-    error_messages = {
-        'duplicate': _("An medium with this type and identifier is already registered."),
-    }
-
-    class Meta:
-        model = ReusableMedium
-        fields = ['active', 'expires', 'customer', 'linked_giftcard', 'linked_orderposition', 'notes']
-        field_classes = {
-            'expires': SplitDateTimeField,
-            'customer': SafeModelChoiceField,
-            'linked_giftcard': SafeModelChoiceField,
-            'linked_orderposition': SafeOrderPositionChoiceField,
-        }
-        widgets = {
-            'expires': SplitDateTimePickerWidget,
-        }
-
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-        organizer = self.instance.organizer
-
-        self.fields['linked_orderposition'].queryset = OrderPosition.all.filter(order__event__organizer=organizer).all()
-        self.fields['linked_orderposition'].widget = Select2(
-            attrs={
-                'data-model-select2': 'generic',
-                'data-select2-url': reverse('control:organizer.ticket_select2', kwargs={
-                    'organizer': organizer.slug,
-                }),
-                'data-placeholder': _('Ticket')
-            }
-        )
-        self.fields['linked_orderposition'].widget.choices = self.fields['linked_orderposition'].choices
-        self.fields['linked_orderposition'].required = False
-
-        self.fields['linked_giftcard'].queryset = organizer.issued_gift_cards.all()
-        self.fields['linked_giftcard'].widget = Select2(
-            attrs={
-                'data-model-select2': 'generic',
-                'data-select2-url': reverse('control:organizer.giftcards.select2', kwargs={
-                    'organizer': organizer.slug,
-                }),
-                'data-placeholder': _('Gift card')
-            }
-        )
-        self.fields['linked_giftcard'].widget.choices = self.fields['linked_giftcard'].choices
-        self.fields['linked_giftcard'].required = False
-
-        if organizer.settings.customer_accounts:
-            self.fields['customer'].queryset = organizer.customers.all()
-            self.fields['customer'].widget = Select2(
-                attrs={
-                    'data-model-select2': 'generic',
-                    'data-select2-url': reverse('control:organizer.customers.select2', kwargs={
-                        'organizer': organizer.slug,
-                    }),
-                    'data-placeholder': _('Customer')
-                }
-            )
-            self.fields['customer'].widget.choices = self.fields['customer'].choices
-            self.fields['customer'].required = False
-        else:
-            del self.fields['customer']
-
-    def clean(self):
-        identifier = self.cleaned_data.get('identifier')
-        type = self.cleaned_data.get('type')
-
-        if identifier is not None and type is not None:
-            try:
-                self.instance.organizer.reusable_media.exclude(pk=self.instance.pk).get(
-                    identifier=identifier,
-                    type=type,
-                )
-            except ReusableMedium.DoesNotExist:
-                pass
-            else:
-                raise forms.ValidationError(
-                    self.error_messages['duplicate'],
-                    code='duplicate',
-                )
-
-        return self.cleaned_data
-
-
-class ReusableMediumCreateForm(ReusableMediumUpdateForm):
-
-    class Meta:
-        model = ReusableMedium
-        fields = ['active', 'type', 'identifier', 'expires', 'linked_orderposition', 'linked_giftcard', 'customer', 'notes']
-        field_classes = {
-            'expires': SplitDateTimeField,
-            'customer': SafeModelChoiceField,
-            'linked_giftcard': SafeModelChoiceField,
-            'linked_orderposition': SafeOrderPositionChoiceField,
-        }
-        widgets = {
-            'expires': SplitDateTimePickerWidget,
-        }
-
-
 class CustomerUpdateForm(forms.ModelForm):
     error_messages = {
         'duplicate': _("An account with this email address is already registered."),

src/pretix/control/forms/vouchers.py

@@ -350,8 +350,6 @@ class VoucherBulkForm(VoucherForm):
                 reader = csv.DictReader(StringIO(raw), dialect=dialect)
             except csv.Error as e:
                 raise ValidationError(_('CSV parsing failed: {error}.').format(error=str(e)))
-            if len(reader.fieldnames) == 1 and ',' in reader.fieldnames[0]:
-                raise ValidationError(_('CSV input was not recognized to have multiple columns, maybe you have some invalid quoted field in your input.'))
             if 'email' not in reader.fieldnames:
                 raise ValidationError(_('CSV input needs to contain a field with the header "{header}".').format(header="email"))
             unknown_fields = [f for f in reader.fieldnames if f not in ('email', 'name', 'tag', 'number')]