Fix required-if references as well

src/pretix/control/logdisplay.py

@@ -338,7 +338,7 @@ class CheckinErrorLogEntryType(OrderLogEntryType):
         else:
             data['list'] = _("(unknown)")
 
-        data['barcode'] = data.get('barcode', '')[:16]
+        data['barcode'] = data.get('barcode')[:16]
         data['posid'] = logentry.parsed_data.get('positionid', '?')
 
         if 'datetime' in data:
@@ -529,7 +529,7 @@ class VoucherRedeemedLogEntryType(VoucherLogEntryType):
         })
         return format_html(
             self.plain,
-            order_code=format_html('<a href="{}">{}</a>', url, data.get('order_code', '?')),
+            order_code=format_html('<a href="{}">{}</a>', url, data('order_code', '?')),
         )
 
 

src/pretix/helpers/metrics/middleware.py

@@ -62,8 +62,7 @@ class MetricsMiddleware(object):
         t0 = time.perf_counter()
         resp = self.get_response(request)
         tdiff = time.perf_counter() - t0
-        if url.url_name:
-            pretix_view_duration_seconds.observe(tdiff, status_code=resp.status_code, method=request.method,
-                                                 url_name=url.namespace + ':' + url.url_name)
+        pretix_view_duration_seconds.observe(tdiff, status_code=resp.status_code, method=request.method,
+                                             url_name=url.namespace + ':' + url.url_name)
 
         return resp

src/pretix/plugins/paypal2/signals.py

@@ -51,8 +51,8 @@ def register_payment_provider(sender, **kwargs):
 class PaypalEventLogEntryType(EventLogEntryType):
     action_type = 'pretix.plugins.paypal.event'
 
-    def display(self, logentry, data):
-        event_type = data.get('event_type')
+    def display(self, logentry):
+        event_type = logentry.parsed_data.get('event_type')
         text = None
         plains = {
             'PAYMENT.SALE.COMPLETED': _('Payment completed.'),