Questions: Increase field size for min/max number

src/pretix/base/migrations/0275_alter_question_valid_number_max_and_more.py

@@ -0,0 +1,23 @@
+# Generated by Django 4.2.17 on 2025-01-13 14:55
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("pretixbase", "0274_tax_codes"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="question",
+            name="valid_number_max",
+            field=models.DecimalField(decimal_places=6, max_digits=30, null=True),
+        ),
+        migrations.AlterField(
+            model_name="question",
+            name="valid_number_min",
+            field=models.DecimalField(decimal_places=6, max_digits=30, null=True),
+        ),
+    ]

src/pretix/base/models/items.py

@@ -1718,10 +1718,10 @@ class Question(LoggedModel):
         'Question', null=True, blank=True, on_delete=models.SET_NULL, related_name='dependent_questions'
     )
     dependency_values = MultiStringField(default=[])
-    valid_number_min = models.DecimalField(decimal_places=6, max_digits=16, null=True, blank=True,
+    valid_number_min = models.DecimalField(decimal_places=6, max_digits=30, null=True, blank=True,
                                            verbose_name=_('Minimum value'),
                                            help_text=_('Currently not supported in our apps and during check-in'))
-    valid_number_max = models.DecimalField(decimal_places=6, max_digits=16, null=True, blank=True,
+    valid_number_max = models.DecimalField(decimal_places=6, max_digits=30, null=True, blank=True,
                                            verbose_name=_('Maximum value'),
                                            help_text=_('Currently not supported in our apps and during check-in'))
     valid_date_min = models.DateField(null=True, blank=True,

src/pretix/control/forms/item.py

@@ -539,8 +539,6 @@ class ItemCreateForm(I18nModelForm):
                     v.pk = None
                     v.item = instance
                     v.save()
-                    if not variation.all_sales_channels:
-                        v.limit_sales_channels.set(variation.limit_sales_channels.all())
                     for mv in variation.meta_values.all():
                         mv.pk = None
                         mv.variation = v

src/tests/control/test_items.py

@@ -673,12 +673,7 @@ class ItemsTest(ItemFormTest):
         with scopes_disabled():
             q = Question.objects.create(event=self.event1, question="Size", type="N")
             q.items.add(self.item2)
-            self.item2.limit_sales_channels.set(self.orga1.sales_channels.filter(identifier__in=["web", "bar"]))
-            self.item2.all_sales_channels = False
-            self.item2.save()
-            self.var2.limit_sales_channels.set(self.orga1.sales_channels.filter(identifier__in=["web"]))
-            self.var2.all_sales_channels = False
-            self.var2.save()
+        self.item2.sales_channels = ["web", "bar"]
         prop = self.event1.item_meta_properties.create(name="Foo")
         self.item2.meta_values.create(property=prop, value="Bar")
 
@@ -695,7 +690,6 @@ class ItemsTest(ItemFormTest):
         with scopes_disabled():
             i_old = Item.objects.get(name__icontains='Business')
             i_new = Item.objects.get(name__icontains='Intermediate')
-            v2_new = i_new.variations.get(value__icontains='Gold')
             assert i_new.category == i_old.category
             assert i_new.description == i_old.description
             assert i_new.active == i_old.active
@@ -704,8 +698,7 @@ class ItemsTest(ItemFormTest):
             assert i_new.require_voucher == i_old.require_voucher
             assert i_new.hide_without_voucher == i_old.hide_without_voucher
             assert i_new.allow_cancel == i_old.allow_cancel
-            assert set(i_new.limit_sales_channels.values_list("identifier", flat=True)) == {"web", "bar"}
-            assert set(v2_new.limit_sales_channels.values_list("identifier", flat=True)) == {"web"}
+            assert set(i_new.limit_sales_channels.all()) == set(i_old.limit_sales_channels.all())
             assert i_new.meta_data == i_old.meta_data == {"Foo": "Bar"}
             assert set(i_new.questions.all()) == set(i_old.questions.all())
             assert set([str(v.value) for v in i_new.variations.all()]) == set([str(v.value) for v in i_old.variations.all()])