Order change manager: Recalculate tax of zero-valued positions (Z#23223874)

Bump version to 2026.3.0.dev0
2026-08-20 12:26:27 +00:00 · 2026-02-26 16:57:32 +01:00 · 2026-02-24 13:37:15 +01:00
3 changed files with 5 additions and 5 deletions
@@ -19,4 +19,4 @@
 # You should have received a copy of the GNU Affero General Public License along with this program.  If not, see
 # <https://www.gnu.org/licenses/>.
 #
-__version__ = "2026.2.1"
+__version__ = "2026.3.0.dev0"
@@ -1121,7 +1121,7 @@ class CheckinViewSet(viewsets.ReadOnlyModelViewSet):
    permission = 'can_view_orders'

    def get_queryset(self):
-        qs = Checkin.all.filter(list__event=self.request.event).select_related(
+        qs = Checkin.all.filter().select_related(
            "position",
            "device",
        )
@@ -1799,8 +1799,6 @@ class OrderChangeManager:
            tax_rule = tax_rules.get(pos.pk, pos.tax_rule)
            if not tax_rule:
                continue
-            if not pos.price:
-                continue

            try:
                new_rate = tax_rule.tax_rate_for(ia)
@@ -1817,7 +1815,9 @@ class OrderChangeManager:
                                           override_tax_rate=new_rate, override_tax_code=new_code)
                self._totaldiff_guesstimate += new_tax.gross - pos.price
                self._operations.append(self.PriceOperation(pos, new_tax, new_tax.gross - pos.price))
-                self._invoice_dirty = True
+                if pos.price:
+                    # We do not consider the invoice dirty if only 0€-valued taxes are changed
+                    self._invoice_dirty = True

    def cancel_fee(self, fee: OrderFee):
        self._totaldiff_guesstimate -= fee.value
Author	SHA1	Message	Date
Raphael Michel	afdb34074d	Order change manager: Recalculate tax of zero-valued positions (Z#23223874)	2026-02-26 16:57:32 +01:00
Raphael Michel	5027f6dd59	Bump version to 2026.3.0.dev0	2026-02-24 13:37:15 +01:00