Webhooks: Allow longer URLs (fixes #5443)

src/pretix/api/migrations/0014_alter_webhook_target_url_and_more.py

@@ -0,0 +1,23 @@
+# Generated by Django 4.2.24 on 2025-11-14 16:21
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("pretixapi", "0013_alter_webhookcallretry_retry_not_before"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="webhook",
+            name="target_url",
+            field=models.URLField(max_length=1024),
+        ),
+        migrations.AlterField(
+            model_name="webhookcall",
+            name="target_url",
+            field=models.URLField(max_length=1024),
+        ),
+    ]

src/pretix/api/models.py

@@ -114,7 +114,7 @@ class OAuthRefreshToken(AbstractRefreshToken):
 class WebHook(models.Model):
     organizer = models.ForeignKey('pretixbase.Organizer', on_delete=models.CASCADE, related_name='webhooks')
     enabled = models.BooleanField(default=True, verbose_name=_("Enable webhook"))
-    target_url = models.URLField(verbose_name=_("Target URL"), max_length=255)
+    target_url = models.URLField(verbose_name=_("Target URL"), max_length=1024)
     all_events = models.BooleanField(default=True, verbose_name=_("All events (including newly created ones)"))
     limit_events = models.ManyToManyField('pretixbase.Event', verbose_name=_("Limit to events"), blank=True)
     comment = models.CharField(verbose_name=_("Comment"), max_length=255, null=True, blank=True)
@@ -140,7 +140,7 @@ class WebHookEventListener(models.Model):
 class WebHookCall(models.Model):
     webhook = models.ForeignKey('WebHook', on_delete=models.CASCADE, related_name='calls')
     datetime = models.DateTimeField(auto_now_add=True)
-    target_url = models.URLField(max_length=255)
+    target_url = models.URLField(max_length=1024)
     action_type = models.CharField(max_length=255)
     is_retry = models.BooleanField(default=False)
     execution_time = models.FloatField(null=True)

src/pretix/control/forms/event.py

@@ -1860,11 +1860,7 @@ class QuickSetupForm(I18nForm):
         self.fields['payment_banktransfer_bank_details'].required = False
         for f in self.fields.values():
             if 'data-required-if' in f.widget.attrs:
-                f.widget.attrs['data-required-if'] += ",#id_payment_banktransfer__enabled"
-
-        self.fields['payment_banktransfer_bank_details'].widget.attrs["data-required-if"] = (
-            "#id_payment_banktransfer_bank_details_type_1,#id_payment_banktransfer__enabled"
-        )
+                del f.widget.attrs['data-required-if']
 
     def clean(self):
         cleaned_data = super().clean()

src/pretix/static/pretixcontrol/js/ui/main.js

@@ -415,24 +415,16 @@ var form_handlers = function (el) {
 
     el.find("input[data-required-if], select[data-required-if], textarea[data-required-if]").each(function () {
         var dependent = $(this),
-            dependencies = $($(this).attr("data-required-if")),
+            dependency = $($(this).attr("data-required-if")),
             update = function (ev) {
-                var enabled = true;
-                dependencies.each(function () {
-                    var dependency = $(this);
-                    var e = (dependency.attr("type") === 'checkbox' || dependency.attr("type") === 'radio') ? dependency.prop('checked') : !!dependency.val();
-                    enabled = enabled && e;
-                });
+                var enabled = (dependency.attr("type") === 'checkbox' || dependency.attr("type") === 'radio') ? dependency.prop('checked') : !!dependency.val();
                 dependent.prop('required', enabled).closest('.form-group').toggleClass('required', enabled).find('.optional').stop().animate({
                     'opacity': enabled ? 0 : 1
                 }, ev ? 500 : 1);
             };
         update();
-        dependencies.each(function () {
-            var dependency = $(this);
-            dependency.closest('.form-group').find('input[name=' + dependency.attr("name") + ']').on("change", update);
-            dependency.closest('.form-group').find('input[name=' + dependency.attr("name") + ']').on("dp.change", update);
-        });
+        dependency.closest('.form-group').find('input[name=' + dependency.attr("name") + ']').on("change", update);
+        dependency.closest('.form-group').find('input[name=' + dependency.attr("name") + ']').on("dp.change", update);
     });
 
     el.find("div.scrolling-choice:not(.no-search)").each(function () {

src/pretix/static/pretixpresale/js/ui/main.js

@@ -514,17 +514,13 @@ $(function () {
     $("input[data-required-if], select[data-required-if], textarea[data-required-if]").each(function () {
         var dependent = $(this),
             dependentLabel = $("label[for="+this.id+"]"),
-            dependencies = $($(this).attr("data-required-if")),
+            dependency = $($(this).attr("data-required-if")),
             update = function (ev) {
-                var enabled = true;
-                dependencies.each(function () {
-                    var dependency = $(this);
-                    var e = (dependency.attr("type") === 'checkbox' || dependency.attr("type") === 'radio') ? dependency.prop('checked') : !!dependency.val();
-                    enabled = enabled && e;
-                });
+                var enabled = (dependency.attr("type") === 'checkbox' || dependency.attr("type") === 'radio') ? dependency.prop('checked') : !!dependency.val();
                 if (!dependent.is("[data-no-required-attr]")) {
                     dependent.prop('required', enabled);
                 }
+                dependent.closest('.form-group').toggleClass('required', enabled);
                 if (enabled) {
                     dependentLabel.append('<i class="label-required">' + gettext('required') + '</i>');
                 }
@@ -533,11 +529,8 @@ $(function () {
                 }
             };
         update();
-        dependencies.each(function () {
-            var dependency = $(this);
-            dependency.closest('.form-group').find('input[name=' + dependency.attr("name") + ']').on("change", update);
-            dependency.closest('.form-group').find('input[name=' + dependency.attr("name") + ']').on("dp.change", update);
-        });
+        dependency.closest('.form-group').find('input[name=' + dependency.attr("name") + ']').on("change", update);
+        dependency.closest('.form-group').find('input[name=' + dependency.attr("name") + ']').on("dp.change", update);
     });
 
     $("input[data-display-dependency], div[data-display-dependency], select[data-display-dependency], textarea[data-display-dependency]").each(function () {