Improve info text (suggestions from code review)

Co-authored-by: luelista <weller@rami.io>

src/pretix/control/views/datasync.py

@@ -82,27 +82,35 @@ class ControlSyncJob(OrderView):
             messages.success(self.request, _('The sync job has been enqueued and will run in the next minutes.'))
         elif self.request.POST.get("cancel_job"):
             with transaction.atomic():
-                job = self.order.queued_sync_jobs.select_for_update(of=OF_SELF).get(
+                try:
-                    pk=self.request.POST.get("cancel_job")
+                    job = self.order.queued_sync_jobs.select_for_update(of=OF_SELF).get(
-                )
+                        pk=self.request.POST.get("cancel_job")
-                if job.in_flight:
+                    )
-                    messages.warning(self.request, _('The sync job is already in progress.'))
+                except OrderSyncQueue.DoesNotExist:
+                    messages.info(self.request, _('The sync job could not be found. It may have been processed in the meantime.'))
                 else:
-                    job.delete()
+                    if job.in_flight:
-                    messages.success(self.request, _('The sync job has been canceled.'))
+                        messages.warning(self.request, _('The sync job is already in progress.'))
+                    else:
+                        job.delete()
+                        messages.success(self.request, _('The sync job has been canceled.'))
         elif self.request.POST.get("run_job_now"):
             with transaction.atomic():
-                job = self.order.queued_sync_jobs.select_for_update(of=OF_SELF).get(
+                try:
-                    pk=self.request.POST.get("run_job_now")
+                    job = self.order.queued_sync_jobs.select_for_update(of=OF_SELF).get(
-                )
+                        pk=self.request.POST.get("run_job_now")
-                if job.in_flight:
+                    )
-                    messages.success(self.request, _('The sync job is already in progress.'))
+                except OrderSyncQueue.DoesNotExist:
+                    messages.info(self.request, _('The sync job could not be found. It may have been processed in the meantime.'))
                 else:
-                    job.not_before = now()
+                    if job.in_flight:
-                    job.need_manual_retry = None
+                        messages.success(self.request, _('The sync job is already in progress.'))
-                    job.save()
+                    else:
-                    sync_single.apply_async(args=(job.pk,))
+                        job.not_before = now()
-                    messages.success(self.request, _('The sync job has been set to run as soon as possible.'))
+                        job.need_manual_retry = None
+                        job.save()
+                        sync_single.apply_async(args=(job.pk,))
+                        messages.success(self.request, _('The sync job has been set to run as soon as possible.'))
 
         return redirect(self.get_order_url())