Fix log entry details for datasync logs without external link (Z#23210015)

src/pretix/base/datasync/datasync.py

@@ -391,7 +391,7 @@ class OutboundSyncProvider:
     def sync_order(self, order):
         if not self.should_sync_order(order):
             logger.debug("Skipping order %r", order)
-            return {}
+            return
 
         logger.debug("Syncing order %r", order)
         positions = list(

src/pretix/control/logdisplay.py

@@ -455,7 +455,7 @@ class OrderDataSyncSuccessLogEntryType(OrderDataSyncLogEntryType):
                     links.append(", ".join(
                         prov.get_external_link_html(logentry.event, obj['external_link_href'], obj['external_link_display_name'])
                         for obj in objs
-                        if obj and 'external_link_href' in obj and 'external_link_display_name' in obj
+                        if obj and obj.get('external_link_href') and obj.get('external_link_display_name')
                     ))
 
         return mark_safe(escape(super().display(logentry, data)) + "".join("<p>" + link + "</p>" for link in links))

src/tests/base/test_datasync.py

@@ -327,26 +327,6 @@ def test_enqueue_order_twice(event):
         SimpleOrderSync.enqueue_order(order, 'testcase_2nd')
 
 
-class DoNothingSync(SimpleOrderSync):
-
-    def should_sync_order(self, order):
-        return False
-
-
-@pytest.mark.django_db
-def test_should_not_sync(event):
-    _register_with_fake_plugin_name(datasync_providers, DoNothingSync, 'testplugin')
-
-    DoNothingSync.fake_api_client = FakeSyncAPI()
-
-    for order in event.orders.order_by("code").all():
-        DoNothingSync.enqueue_order(order, 'testcase')
-
-    sync_all()
-
-    assert DoNothingSync.fake_api_client.fake_database == {}
-
-
 StaticMappingWithAssociations = namedtuple('StaticMappingWithAssociations', (
     'id', 'pretix_model', 'external_object_type', 'pretix_id_field', 'external_id_field', 'property_mappings', 'association_mappings'
 ))