Remove RequiredAction model (#2078)

src/pretix/control/views/dashboards.py

@@ -39,8 +39,7 @@ import pytz
 from django.conf import settings
 from django.contrib.contenttypes.models import ContentType
 from django.db.models import (
-    Count, Exists, IntegerField, Max, Min, OuterRef, Prefetch, Q, Subquery,
-    Sum,
+    Count, IntegerField, Max, Min, OuterRef, Prefetch, Q, Subquery, Sum,
 )
 from django.db.models.functions import Coalesce, Greatest
 from django.dispatch import receiver
@@ -57,7 +56,7 @@ from django.utils.translation import gettext_lazy as _, pgettext, ungettext
 from pretix.base.decimal import round_decimal
 from pretix.base.models import (
     Item, ItemCategory, ItemVariation, Order, OrderPosition, OrderRefund,
-    Question, Quota, RequiredAction, SubEvent, Voucher, WaitingListEntry,
+    Question, Quota, SubEvent, Voucher, WaitingListEntry,
 )
 from pretix.base.services.quotas import QuotaAvailability
 from pretix.base.timeline import timeline_for_event
@@ -349,8 +348,6 @@ def event_index(request, organizer, event):
 
     can_view_orders = request.user.has_event_permission(request.organizer, request.event, 'can_view_orders',
                                                         request=request)
-    can_change_orders = request.user.has_event_permission(request.organizer, request.event, 'can_change_orders',
-                                                          request=request)
     can_change_event_settings = request.user.has_event_permission(request.organizer, request.event,
                                                                   'can_change_event_settings', request=request)
 
@@ -359,12 +356,9 @@ def event_index(request, organizer, event):
         for r, result in event_dashboard_widgets.send(sender=request.event, subevent=subevent, lazy=True):
             widgets.extend(result)
 
-    a_qs = request.event.requiredaction_set.filter(done=False)
-
     ctx = {
         'widgets': rearrange(widgets),
         'subevent': subevent,
-        'actions': a_qs[:5] if can_change_orders else [],
         'comment_form': CommentForm(initial={'comment': request.event.comment}, readonly=not can_change_event_settings),
     }
 
@@ -387,9 +381,6 @@ def event_index(request, organizer, event):
         order__event=request.event
     ).exists()
 
-    for a in ctx['actions']:
-        a.display = a.display(request)
-
     ctx['timeline'] = [
         {
             'date': t.datetime.astimezone(request.event.timezone).date(),
@@ -470,15 +461,10 @@ def annotated_event_query(request, lazy=False):
         'c'
     )
 
-    required_actions = RequiredAction.objects.filter(
-        event=OuterRef('pk'),
-        done=False
-    )
     qs = request.user.get_events_with_any_permission(request)
     if not lazy:
         qs = qs.annotate(
             order_count=Subquery(active_orders, output_field=IntegerField()),
-            has_ra=Exists(required_actions)
         )
     qs = qs.annotate(
         min_from=Min('subevents__date_from'),
@@ -539,9 +525,7 @@ def widgets_for_event_qs(request, qs, user, nmax, lazy=False):
                 else:
                     dr = date_format(event.date_from.astimezone(tz), "DATE_FORMAT")
 
-            if event.has_ra:
-                status = ('danger', _('Action required'))
-            elif not event.live:
+            if not event.live:
                 status = ('warning', _('Shop disabled'))
             elif event.presale_has_ended:
                 status = ('default', _('Sale over'))

src/pretix/control/views/event.py

@@ -66,9 +66,7 @@ from pytz import timezone
 
 from pretix.base.channels import get_all_sales_channels
 from pretix.base.email import get_available_placeholders
-from pretix.base.models import (
-    Event, LogEntry, Order, RequiredAction, TaxRule, Voucher,
-)
+from pretix.base.models import Event, LogEntry, Order, TaxRule, Voucher
 from pretix.base.models.event import EventMetaValue
 from pretix.base.services import tickets
 from pretix.base.services.invoices import build_preview_invoice_pdf
@@ -1048,42 +1046,6 @@ class EventLog(EventPermissionRequiredMixin, PaginationMixin, ListView):
         return ctx
 
 
-class EventActions(EventPermissionRequiredMixin, ListView):
-    template_name = 'pretixcontrol/event/actions.html'
-    model = RequiredAction
-    context_object_name = 'actions'
-    paginate_by = 20
-    permission = 'can_change_orders'
-
-    def get_queryset(self):
-        qs = self.request.event.requiredaction_set.filter(done=False)
-        return qs
-
-    def get_context_data(self, **kwargs):
-        ctx = super().get_context_data()
-        for a in ctx['actions']:
-            a.display = a.display(self.request)
-        return ctx
-
-
-class EventActionDiscard(EventPermissionRequiredMixin, View):
-    permission = 'can_change_orders'
-
-    def get(self, request, **kwargs):
-        action = get_object_or_404(RequiredAction, event=request.event, pk=kwargs.get('id'))
-        action.done = True
-        action.user = request.user
-        action.save()
-        messages.success(self.request, _('The issue has been marked as resolved!'))
-        return redirect(self.get_success_url())
-
-    def get_success_url(self) -> str:
-        return reverse('control:event.index', kwargs={
-            'organizer': self.request.event.organizer.slug,
-            'event': self.request.event.slug
-        })
-
-
 class EventComment(EventPermissionRequiredMixin, View):
     permission = 'can_change_event_settings'