From ea63b50f2e420638d8b2f4068ccff40a4eb8c586 Mon Sep 17 00:00:00 2001 From: Raphael Michel Date: Wed, 31 Oct 2018 10:31:40 +0100 Subject: [PATCH] Bank transfer: consider payments valid even without quota --- src/pretix/plugins/banktransfer/tasks.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/pretix/plugins/banktransfer/tasks.py b/src/pretix/plugins/banktransfer/tasks.py index 7e29ebb050..250c34fe74 100644 --- a/src/pretix/plugins/banktransfer/tasks.py +++ b/src/pretix/plugins/banktransfer/tasks.py @@ -73,12 +73,18 @@ def _handle_transaction(trans: BankTransaction, code: str, event: Event=None, or } try: p.confirm() - except Quota.QuotaExceededException as e: - trans.state = BankTransaction.STATE_ERROR - trans.message = str(e) + except Quota.QuotaExceededException: + trans.state = BankTransaction.STATE_VALID + trans.order.payments.filter( + provider='banktransfer', + state__in=(OrderPayment.PAYMENT_STATE_CREATED, OrderPayment.PAYMENT_STATE_PENDING), + ).update(state=OrderPayment.PAYMENT_STATE_CANCELED) except SendMailException: - trans.state = BankTransaction.STATE_ERROR - trans.message = ugettext_noop('Problem sending email.') + trans.state = BankTransaction.STATE_VALID + trans.order.payments.filter( + provider='banktransfer', + state__in=(OrderPayment.PAYMENT_STATE_CREATED, OrderPayment.PAYMENT_STATE_PENDING), + ).update(state=OrderPayment.PAYMENT_STATE_CANCELED) else: trans.state = BankTransaction.STATE_VALID trans.order.payments.filter(