Offset refunds: Catch exceptions in the right place

src/tests/control/test_orders.py

@@ -1965,6 +1965,48 @@ def test_refund_paid_order_offsetting_to_unknown(client, env):
     assert b'alert-danger' in r.content
 
 
+@pytest.mark.django_db
+def test_refund_paid_order_offsetting_to_expired(client, env):
+    with scopes_disabled():
+        p = env[2].payments.last()
+        p.confirm()
+        client.login(email='dummy@dummy.dummy', password='dummy')
+        o = Order.objects.create(
+            code='BAZ', event=env[0], email='dummy@dummy.test',
+            status=Order.STATUS_EXPIRED,
+            datetime=now(), expires=now() + timedelta(days=10),
+            total=5, locale='en'
+        )
+        o.positions.create(price=5, item=env[3])
+        q = Quota.objects.create(event=env[0], size=0)
+        q.items.add(env[3])
+
+    client.post('/control/event/dummy/dummy/orders/FOO/refund', {
+        'start-partial_amount': '5.00',
+        'start-mode': 'partial',
+        'start-action': 'mark_pending',
+        'refund-offsetting': '5.00',
+        'order-offsetting': 'BAZ',
+        'manual_state': 'pending',
+        'perform': 'on'
+    }, follow=True)
+    p.refresh_from_db()
+    assert p.state == OrderPayment.PAYMENT_STATE_CONFIRMED
+    env[2].refresh_from_db()
+    with scopes_disabled():
+        r = env[2].refunds.last()
+        assert r.provider == "offsetting"
+        assert r.state == OrderRefund.REFUND_STATE_DONE
+        assert r.amount == Decimal('5.00')
+        assert env[2].status == Order.STATUS_PENDING
+        o.refresh_from_db()
+        assert o.status == Order.STATUS_EXPIRED
+        p2 = o.payments.first()
+        assert p2.provider == "offsetting"
+        assert p2.amount == Decimal('5.00')
+        assert p2.state == OrderPayment.PAYMENT_STATE_CONFIRMED
+
+
 @pytest.mark.django_db
 def test_refund_paid_order_offsetting(client, env):
     with scopes_disabled():