CGM_Public/pretix_original
2
0
Fork 1
mirror of https://github.com/pretix/pretix.git synced 2026-05-07 15:34:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

better var names

Browse Source
This commit is contained in:
Mira Weller
2024-06-17 14:10:09 +02:00
parent 715347cb35
commit d9f31aae8c
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/pretix/base/models/items.py
View File

@@ -164,7 +164,7 @@ class ItemCategory(LoggedModel):
match = set(match.pk for match in self.cross_selling_match_products.only('pk')) # TODO prefetch this match = set(match.pk for match in self.cross_selling_match_products.only('pk')) # TODO prefetch this
return (self.items.all(), {}) if any(pos.item.pk in match for pos in cart) else (None, {}) return (self.items.all(), {}) if any(pos.item.pk in match for pos in cart) else (None, {})
if self.cross_selling_condition == 'discounts': if self.cross_selling_condition == 'discounts':
potential_discounts_dict = defaultdict(list) potential_discounts_by_cartpos = defaultdict(list)
from ..services.pricing import apply_discounts from ..services.pricing import apply_discounts
apply_discounts( apply_discounts(
@@ -175,9 +175,11 @@ class ItemCategory(LoggedModel):
cp.listed_price - cp.price_after_voucher) cp.listed_price - cp.price_after_voucher)
for cp in cart for cp in cart
], ],
collect_potential_discounts=potential_discounts_dict collect_potential_discounts=potential_discounts_by_cartpos
) )
potential_discount_infos = dict.fromkeys(info for lst in potential_discounts_dict.values() for info in lst)
# technically, this is a dict, but we use it as an OrderedSet here
potential_discount_set = dict.fromkeys(info for lst in potential_discounts_by_cartpos.values() for info in lst)
# sum up the max_counts and pass them on (also pass on the discount_rules so we can calculate actual discounted prices later): # sum up the max_counts and pass them on (also pass on the discount_rules so we can calculate actual discounted prices later):
# group by benefit product # group by benefit product
@@ -198,7 +200,7 @@ class ItemCategory(LoggedModel):
sorted( sorted(
( (
(item, discount_rule, max_count, i) (item, discount_rule, max_count, i)
for (discount_rule, max_count, i) in potential_discount_infos.keys() for (discount_rule, max_count, i) in potential_discount_set.keys()
for item in discount_rule.benefit_limit_products.all() for item in discount_rule.benefit_limit_products.all()
), ),
key=lambda tup: tup[0].pk key=lambda tup: tup[0].pk