From d0ccc42aff093d14f55a183ab5588e46848dd9f2 Mon Sep 17 00:00:00 2001 From: Felix Rindt Date: Fri, 24 Jul 2020 16:21:12 +0200 Subject: [PATCH] add test for ticket reminder (oops) --- src/pretix/base/services/orders.py | 2 +- src/tests/base/test_orderimport.py | 2 +- src/tests/base/test_orders.py | 7 +++++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/pretix/base/services/orders.py b/src/pretix/base/services/orders.py index 9909edfff7..d492c5d1b1 100644 --- a/src/pretix/base/services/orders.py +++ b/src/pretix/base/services/orders.py @@ -1057,7 +1057,7 @@ def send_download_reminders(sender, **kwargs): if days is None: continue - if o.sales_channel not in event.settings.mail_sales_channel_placed_paid: + if o.sales_channel not in event.settings.mail_sales_channel_ticket_reminder: continue reminder_date = (o.first_date - timedelta(days=days)).replace(hour=0, minute=0, second=0, microsecond=0) diff --git a/src/tests/base/test_orderimport.py b/src/tests/base/test_orderimport.py index 3a8facd75d..3b9f21fb11 100644 --- a/src/tests/base/test_orderimport.py +++ b/src/tests/base/test_orderimport.py @@ -1,5 +1,5 @@ import csv -from _decimal import Decimal +from decimal import Decimal from io import StringIO import pytest diff --git a/src/tests/base/test_orders.py b/src/tests/base/test_orders.py index da0a39d333..65cbbae256 100644 --- a/src/tests/base/test_orders.py +++ b/src/tests/base/test_orders.py @@ -543,6 +543,13 @@ class DownloadReminderTests(TestCase): send_download_reminders(sender=self.event) assert len(djmail.outbox) == 0 + @classscope(attr='o') + def test_not_sent_for_disabled_sales_channel(self): + self.event.settings.mail_days_download_reminder = 2 + self.event.settings.mail_sales_channel_ticket_reminder = [] + send_download_reminders(sender=self.event) + assert len(djmail.outbox) == 0 + class OrderCancelTests(TestCase): def setUp(self):