CGM_Public/pretix_original
2
0
Fork 1
mirror of https://github.com/pretix/pretix.git synced 2026-05-05 15:14:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Voucher list: Optimize SQL query

Browse Source
This commit is contained in:
Raphael Michel
2023-05-25 10:44:47 +02:00
parent faa14a610c
commit cf781fc79e
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/pretix/control/views/vouchers.py
View File

@@ -41,7 +41,7 @@ from django.conf import settings
from django.contrib import messages from django.contrib import messages
from django.core.exceptions import ValidationError from django.core.exceptions import ValidationError
from django.db import connection, transaction from django.db import connection, transaction
from django.db.models import Sum from django.db.models import Exists, OuterRef, Sum
from django.http import ( from django.http import (
Http404, HttpResponse, HttpResponseBadRequest, HttpResponseRedirect, Http404, HttpResponse, HttpResponseBadRequest, HttpResponseRedirect,
JsonResponse, JsonResponse,
@@ -56,9 +56,12 @@ from django.utils.translation import gettext_lazy as _
from django.views.generic import ( from django.views.generic import (
CreateView, ListView, TemplateView, UpdateView, View, CreateView, ListView, TemplateView, UpdateView, View,
) )
from django_scopes import scopes_disabled
from pretix.base.email import get_available_placeholders from pretix.base.email import get_available_placeholders
from pretix.base.models import CartPosition, LogEntry, Voucher from pretix.base.models import (
CartPosition, LogEntry, Voucher, WaitingListEntry,
)
from pretix.base.models.vouchers import generate_codes from pretix.base.models.vouchers import generate_codes
from pretix.base.services.locking import NoLockManager from pretix.base.services.locking import NoLockManager
from pretix.base.services.vouchers import vouchers_send from pretix.base.services.vouchers import vouchers_send
@@ -80,16 +83,17 @@ class VoucherList(PaginationMixin, EventPermissionRequiredMixin, ListView):
template_name = 'pretixcontrol/vouchers/index.html' template_name = 'pretixcontrol/vouchers/index.html'
permission = 'can_view_vouchers' permission = 'can_view_vouchers'
@scopes_disabled() # we have an event check here, and we can save some performance on subqueries
def get_queryset(self): def get_queryset(self):
qs = Voucher.annotate_budget_used_orders(self.request.event.vouchers.filter( qs = Voucher.annotate_budget_used_orders(self.request.event.vouchers.exclude(
waitinglistentries__isnull=True Exists(WaitingListEntry.objects.filter(voucher_id=OuterRef('pk')))
).select_related( ).select_related(
'item', 'variation', 'seat' 'item', 'variation', 'seat'
)) ))
if self.filter_form.is_valid(): if self.filter_form.is_valid():
qs = self.filter_form.filter_qs(qs) qs = self.filter_form.filter_qs(qs)
return qs.distinct() return qs
def get_context_data(self, **kwargs): def get_context_data(self, **kwargs):
ctx = super().get_context_data(**kwargs) ctx = super().get_context_data(**kwargs)