Wider usage of the settings framework (#17)

src/pretix/control/views/event.py

@@ -1,4 +1,5 @@
 from collections import OrderedDict
+from django.conf import settings
 from django.shortcuts import render, redirect
 from django.utils.functional import cached_property
 from django.views.generic.edit import UpdateView
@@ -17,10 +18,6 @@ from pretix.control.permissions import EventPermissionRequiredMixin
 
 
 class EventUpdateForm(VersionedModelForm):
-    timezone = forms.ChoiceField(
-        choices=((a, a) for a in common_timezones),
-        label=_("Default timezone"),
-    )
 
     def clean_slug(self):
         return self.instance.slug
@@ -35,35 +32,122 @@ class EventUpdateForm(VersionedModelForm):
         fields = [
             'name',
             'slug',
-            'locale',
-            'timezone',
             'currency',
             'date_from',
             'date_to',
-            'show_date_to',
-            'show_times',
             'presale_start',
             'presale_end',
-            'payment_term_days',
-            'payment_term_last',
         ]
 
 
+class EventSettingsForm(SettingsForm):
+    show_date_to = forms.BooleanField(
+        label=_("Show event end date"),
+        help_text=_("If disabled, only event's start date will be displayed to the public."),
+        required=False
+    )
+    show_times = forms.BooleanField(
+        label=_("Show dates with time"),
+        help_text=_("If disabled, the event's start and end date will be displayed without the time of day."),
+        required=False
+    )
+    payment_term_days = forms.IntegerField(
+        label='Payment term in days',
+        help_text=_("The number of days after placing an order the user has to pay to preserve his reservation."),
+    )
+    payment_term_last = forms.DateTimeField(
+        label='Last date of payments',
+        help_text=_("The last date any payments are accepted. This has precedence over the number of "
+                    "days configured above."),
+        required=False
+    )
+    last_order_modification_date = forms.DateTimeField(
+        label='Last date of modifications',
+        help_text=_("The last date users can modify details of their orders, such as attendee names or "
+                    "answers to questions."),
+        required=False
+    )
+    timezone = forms.ChoiceField(
+        choices=((a, a) for a in common_timezones),
+        label=_("Default timezone"),
+    )
+    locale = forms.ChoiceField(
+        choices=settings.LANGUAGES,
+        label=_("Default locale"),
+    )
+    user_mail_required = forms.BooleanField(
+        label=_("Require e-mail adresses"),
+        help_text=_("Require all customers to provide an e-mail address."),
+        required=False
+    )
+    attendee_names_asked = forms.BooleanField(
+        label=_("Ask for attendee names"),
+        help_text=_("Ask for a name for all tickets which include admission to the event."),
+        required=False
+    )
+    attendee_names_required = forms.BooleanField(
+        label=_("Require attendee names"),
+        help_text=_("Require customers to fill in the names of all attendees."),
+        required=False
+    )
+    max_items_per_order = forms.IntegerField(
+        min_value=1,
+        label=_("Maximum number of items per order")
+    )
+    reservation_time = forms.IntegerField(
+        min_value=0,
+        label=_("Reservation period"),
+        help_text=_("The number of minutes the items in a user's card are reserved for this user."),
+    )
+    mail_from = forms.EmailField(
+        label=_("Sender address"),
+        help_text=_("Sender address for outgoing e-mails")
+    )
+
+
 class EventUpdate(EventPermissionRequiredMixin, UpdateView):
     model = Event
     form_class = EventUpdateForm
     template_name = 'pretixcontrol/event/settings.html'
     permission = 'can_change_settings'
 
-    def get_object(self, queryset=None) -> Event:
+    @cached_property
+    def object(self) -> Event:
         return self.request.event
 
+    def get_object(self, queryset=None) -> Event:
+        return self.object
+
+    @cached_property
+    def sform(self):
+        return EventSettingsForm(
+            obj=self.object,
+            prefix='settings',
+            data=self.request.POST if self.request.method == 'POST' else None
+        )
+
+    def get_context_data(self, *args, **kwargs) -> dict:
+        context = super().get_context_data(*args, **kwargs)
+        context['sform'] = self.sform
+        return context
+
+    def form_valid(self, form):
+        self.sform.save()
+        return super().form_valid(form)
+
     def get_success_url(self) -> str:
         return reverse('control:event.settings', kwargs={
-            'organizer': self.get_object().organizer.slug,
-            'event': self.get_object().slug,
+            'organizer': self.object.organizer.slug,
+            'event': self.object.slug,
         }) + '?success=true'
 
+    def post(self, request, *args, **kwargs):
+        form = self.get_form()
+        if form.is_valid() and self.sform.is_valid():
+            return self.form_valid(form)
+        else:
+            return self.form_invalid(form)
+
 
 class EventPlugins(EventPermissionRequiredMixin, TemplateView, SingleObjectMixin):
     model = Event