From b6857967a5e08f27ba5322db34a2a90142be3f48 Mon Sep 17 00:00:00 2001
From: luelista <weller@rami.io>
Date: Fri, 27 Mar 2026 11:32:55 +0100
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Richard Schreiber <wiffbi@gmail.com>
---
 .../templates/pretixcontrol/user/2fa_add.html  | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/src/pretix/control/templates/pretixcontrol/user/2fa_add.html b/src/pretix/control/templates/pretixcontrol/user/2fa_add.html
index f7360f3994..901dc6b97a 100644
--- a/src/pretix/control/templates/pretixcontrol/user/2fa_add.html
+++ b/src/pretix/control/templates/pretixcontrol/user/2fa_add.html
@@ -9,13 +9,13 @@
         {% bootstrap_form_errors form %}
         {% bootstrap_field form.name layout='horizontal' %}
 
-        <div class="form-group">
+        <div class="form-group{% if form.devicetype.errors %} has-error{% endif %}">
             <label class="col-md-3 control-label">{% trans "Device type" %}</label>
             <div class="col-md-9">
-                <div class="big-radio radio">
+                <div><div class="big-radio radio">
                     <label>
                         <input type="radio" value="totp" name="{{ form.devicetype.html_name }}" {% if form.devicetype.value == "totp" %}checked{% endif %}>
-                        <strong>{% trans "Smartphone with the Authenticator application" %}</strong><br>
+                        <strong>{% trans "Smartphone with Authenticator app" %}</strong><br>
                         <div class="help-block">
                             {% blocktrans trimmed %}
                                 Use your smartphone with any Time-based One-Time-Password app like freeOTP, Google Authenticator or Proton Authenticator.
@@ -29,11 +29,19 @@
                         <strong>{% trans "WebAuthn-compatible hardware token" %}</strong><br>
                         <div class="help-block">
                             {% blocktrans trimmed %}
-                                Use a hardware token like the Yubikey, or biometric authentication on iOS, macOS and Android.
+                                Use a hardware token like the Yubikey, or other biometric authentication like fingerprint or face recognition.
                             {% endblocktrans %}
                         </div>
                     </label>
-                </div>
+                </div></div>
+
+                {% if form.devicetype.errors %}
+                    <div class="help-block">
+                    {% for error in form.devicetype.errors %}
+                        <p>{{ error|escape }}</p>
+                    {% endfor %}
+                    </div>
+                {% endif %}
             </div>
         </div>