Do not send paid email for free orders

src/pretix/base/payment.py

@@ -609,7 +609,7 @@ class FreeOrderProvider(BasePaymentProvider):
 
     def execute_payment(self, request: HttpRequest, payment: OrderPayment):
         try:
-            payment.confirm()
+            payment.confirm(send_mail=False)
         except Quota.QuotaExceededException as e:
             raise PaymentException(str(e))
 
@@ -636,7 +636,7 @@ class BoxOfficeProvider(BasePaymentProvider):
 
     def execute_payment(self, request: HttpRequest, payment: OrderPayment):
         try:
-            payment.confirm()
+            payment.confirm(send_mail=False)
         except Quota.QuotaExceededException as e:
             raise PaymentException(str(e))
 

src/pretix/base/services/orders.py

@@ -532,7 +532,7 @@ def _create_order(event: Event, email: str, positions: List[CartPosition], now_d
         if payment_provider:
             order.payments.create(
                 state=OrderPayment.PAYMENT_STATE_CREATED,
-                provider=payment_provider,
+                provider=payment_provider.identifier,
                 amount=total,
                 fee=pf
             )