diff --git a/src/pretix/api/views/organizer.py b/src/pretix/api/views/organizer.py index f084a16794..18f6a89358 100644 --- a/src/pretix/api/views/organizer.py +++ b/src/pretix/api/views/organizer.py @@ -249,9 +249,14 @@ class GiftCardViewSet(viewsets.ModelViewSet): def perform_create(self, serializer): value = serializer.validated_data.pop('value') inst = serializer.save(issuer=self.request.organizer) + inst.log_action( + action='pretix.giftcards.created', + user=self.request.user, + auth=self.request.auth, + ) inst.transactions.create(value=value, acceptor=self.request.organizer) inst.log_action( - 'pretix.giftcards.transaction.manual', + action='pretix.giftcards.transaction.manual', user=self.request.user, auth=self.request.auth, data=merge_dicts(self.request.data, {'id': inst.pk}) @@ -269,7 +274,7 @@ class GiftCardViewSet(viewsets.ModelViewSet): inst = serializer.save(secret=serializer.instance.secret, currency=serializer.instance.currency, testmode=serializer.instance.testmode) inst.log_action( - 'pretix.giftcards.modified', + action='pretix.giftcards.modified', user=self.request.user, auth=self.request.auth, data=self.request.data, @@ -282,7 +287,7 @@ class GiftCardViewSet(viewsets.ModelViewSet): diff = value - old_value inst.transactions.create(value=diff, acceptor=self.request.organizer) inst.log_action( - 'pretix.giftcards.transaction.manual', + action='pretix.giftcards.transaction.manual', user=self.request.user, auth=self.request.auth, data={'value': diff} @@ -309,10 +314,13 @@ class GiftCardViewSet(viewsets.ModelViewSet): }, status=status.HTTP_409_CONFLICT) gc.transactions.create(value=value, text=text, info=info, acceptor=self.request.organizer) gc.log_action( - 'pretix.giftcards.transaction.manual', + action='pretix.giftcards.transaction.manual', user=self.request.user, auth=self.request.auth, - data={'value': value, 'text': text} + data={ + 'value': value, + 'text': text + } ) return Response(GiftCardSerializer(gc, context=self.get_serializer_context()).data, status=status.HTTP_200_OK) diff --git a/src/pretix/base/services/orders.py b/src/pretix/base/services/orders.py index 365247483f..60f11d1d9e 100644 --- a/src/pretix/base/services/orders.py +++ b/src/pretix/base/services/orders.py @@ -3131,7 +3131,10 @@ def _try_auto_refund(order, auto_refund=True, manual_refund=False, allow_partial customer=order.customer, testmode=order.testmode ) - giftcard.log_action('pretix.giftcards.created', data={}) + giftcard.log_action( + action='pretix.giftcards.created', + data={} + ) r = order.refunds.create( order=order, payment=None, diff --git a/src/pretix/control/views/orders.py b/src/pretix/control/views/orders.py index 229b04780c..39ab3f54b0 100644 --- a/src/pretix/control/views/orders.py +++ b/src/pretix/control/views/orders.py @@ -1230,7 +1230,11 @@ class OrderRefundView(OrderView): customer=order.customer, testmode=order.testmode ) - giftcard.log_action('pretix.giftcards.created', user=self.request.user, data={}) + giftcard.log_action( + action='pretix.giftcards.created', + user=self.request.user, + data={} + ) refunds.append(OrderRefund( order=order, payment=None, diff --git a/src/pretix/control/views/organizer.py b/src/pretix/control/views/organizer.py index 3d84cb5687..e12ec88946 100644 --- a/src/pretix/control/views/organizer.py +++ b/src/pretix/control/views/organizer.py @@ -1669,9 +1669,12 @@ class GiftCardAcceptanceInviteView(OrganizerDetailViewMixin, OrganizerPermission active=False, ) self.request.organizer.log_action( - 'pretix.giftcards.acceptance.acceptor.invited', - data={'acceptor': form.cleaned_data['acceptor'].slug, - 'reusable_media': form.cleaned_data['reusable_media']}, + action='pretix.giftcards.acceptance.acceptor.invited', + data={ + 'acceptor': form.cleaned_data['acceptor'].slug, + 'issuer': self.request.organizer.slug, + 'reusable_media': form.cleaned_data['reusable_media'] + }, user=self.request.user ) messages.success(self.request, _('The selected organizer has been invited.')) @@ -1707,8 +1710,11 @@ class GiftCardAcceptanceListView(OrganizerDetailViewMixin, OrganizerPermissionRe ).delete() if done: self.request.organizer.log_action( - 'pretix.giftcards.acceptance.acceptor.removed', - data={'acceptor': request.POST.get("delete_acceptor")}, + action='pretix.giftcards.acceptance.acceptor.removed', + data={ + 'acceptor': request.POST.get("delete_acceptor"), + 'issuer': self.request.organizer.slug + }, user=request.user ) messages.success(self.request, _('The selected connection has been removed.')) @@ -1718,8 +1724,11 @@ class GiftCardAcceptanceListView(OrganizerDetailViewMixin, OrganizerPermissionRe ).delete() if done: self.request.organizer.log_action( - 'pretix.giftcards.acceptance.issuer.removed', - data={'issuer': request.POST.get("delete_acceptor")}, + action='pretix.giftcards.acceptance.issuer.removed', + data={ + 'issuer': request.POST.get("delete_acceptor"), + 'acceptor': self.request.organizer.slug + }, user=request.user ) messages.success(self.request, _('The selected connection has been removed.')) @@ -1729,8 +1738,11 @@ class GiftCardAcceptanceListView(OrganizerDetailViewMixin, OrganizerPermissionRe ).update(active=True) if done: self.request.organizer.log_action( - 'pretix.giftcards.acceptance.issuer.accepted', - data={'issuer': request.POST.get("accept_issuer")}, + action='pretix.giftcards.acceptance.issuer.accepted', + data={ + 'issuer': request.POST.get("accept_issuer"), + 'acceptor': self.request.organizer.slug + }, user=request.user ) messages.success(self.request, _('The selected connection has been accepted.')) @@ -1836,7 +1848,7 @@ class GiftCardDetailView(OrganizerDetailViewMixin, OrganizerPermissionRequiredMi acceptor=request.organizer, ) self.object.log_action( - 'pretix.giftcards.transaction.manual', + action='pretix.giftcards.transaction.manual', data={ 'value': value, 'text': request.POST.get('text') @@ -1888,15 +1900,22 @@ class GiftCardCreateView(OrganizerDetailViewMixin, OrganizerPermissionRequiredMi messages.success(self.request, _('The gift card has been created and can now be used.')) form.instance.issuer = self.request.organizer super().form_valid(form) - form.instance.transactions.create( - acceptor=self.request.organizer, - value=form.cleaned_data['value'] + form.instance.log_action( + action='pretix.giftcards.created', + user=self.request.user, ) - form.instance.log_action('pretix.giftcards.created', user=self.request.user, data={}) if form.cleaned_data['value']: - form.instance.log_action('pretix.giftcards.transaction.manual', user=self.request.user, data={ - 'value': form.cleaned_data['value'] - }) + form.instance.transactions.create( + acceptor=self.request.organizer, + value=form.cleaned_data['value'] + ) + form.instance.log_action( + action='pretix.giftcards.transaction.manual', + user=self.request.user, + data={ + 'value': form.cleaned_data['value'] + } + ) return redirect(reverse( 'control:organizer.giftcard', kwargs={ @@ -1924,7 +1943,11 @@ class GiftCardUpdateView(OrganizerDetailViewMixin, OrganizerPermissionRequiredMi def form_valid(self, form): messages.success(self.request, _('The gift card has been changed.')) super().form_valid(form) - form.instance.log_action('pretix.giftcards.modified', user=self.request.user, data=dict(form.cleaned_data)) + form.instance.log_action( + action='pretix.giftcards.modified', + user=self.request.user, + data=dict(form.cleaned_data) + ) return redirect(reverse( 'control:organizer.giftcard', kwargs={