Fixed #132 -- Reverse payment fee calculation

src/tests/base/test_payment.py

@@ -0,0 +1,54 @@
+import time
+from decimal import Decimal
+
+import pytest
+from django.utils.timezone import now
+from tests.testdummy.payment import DummyPaymentProvider
+
+from pretix.base.models import Event, EventLock, Organizer
+from pretix.base.services import locking
+
+
+@pytest.fixture
+def event():
+    o = Organizer.objects.create(name='Dummy', slug='dummy')
+    event = Event.objects.create(
+        organizer=o, name='Dummy', slug='dummy',
+        date_from=now()
+    )
+    return event
+
+
+@pytest.mark.django_db
+def test_payment_fee_forward(event):
+    prov = DummyPaymentProvider(event)
+    prov.settings.set('_fee_abs', Decimal('0.30'))
+    prov.settings.set('_fee_percent', Decimal('5.00'))
+    prov.settings.set('_fee_reverse_calc', False)
+    assert prov.calculate_fee(Decimal('100.00')) == Decimal('5.30')
+
+
+@pytest.mark.django_db
+def test_payment_fee_reverse_percent(event):
+    prov = DummyPaymentProvider(event)
+    prov.settings.set('_fee_abs', Decimal('0.00'))
+    prov.settings.set('_fee_percent', Decimal('5.00'))
+    prov.settings.set('_fee_reverse_calc', True)
+    assert prov.calculate_fee(Decimal('100.00')) == Decimal('5.26')
+
+
+@pytest.mark.django_db
+def test_payment_fee_reverse_percent_and_abs(event):
+    prov = DummyPaymentProvider(event)
+    prov.settings.set('_fee_abs', Decimal('0.30'))
+    prov.settings.set('_fee_percent', Decimal('2.90'))
+    prov.settings.set('_fee_reverse_calc', True)
+    assert prov.calculate_fee(Decimal('100.00')) == Decimal('3.30')
+
+
+@pytest.mark.django_db
+def test_payment_fee_reverse_percent_and_abs_default(event):
+    prov = DummyPaymentProvider(event)
+    prov.settings.set('_fee_abs', Decimal('0.30'))
+    prov.settings.set('_fee_percent', Decimal('2.90'))
+    assert prov.calculate_fee(Decimal('100.00')) == Decimal('3.30')

src/tests/testdummy/payment.py

@@ -0,0 +1,19 @@
+import logging
+
+from pretix.base.payment import BasePaymentProvider
+
+logger = logging.getLogger('tests.testdummy.ticketoutput')
+
+
+class DummyPaymentProvider(BasePaymentProvider):
+    identifier = 'testdummy'
+    verbose_name = 'Test dummy'
+
+    def order_pending_render(self, request, order) -> str:
+        pass
+
+    def payment_is_valid_session(self, request) -> bool:
+        pass
+
+    def checkout_confirm_render(self, request) -> str:
+        pass

src/tests/testdummy/signals.py

@@ -1,9 +1,17 @@
 from django.dispatch import receiver
 
-from pretix.base.signals import register_ticket_outputs
+from pretix.base.signals import (
+    register_payment_providers, register_ticket_outputs,
+)
 
 
 @receiver(register_ticket_outputs, dispatch_uid="output_dummy")
 def register_ticket_outputs(sender, **kwargs):
     from .ticketoutput import DummyTicketOutput
     return DummyTicketOutput
+
+
+@receiver(register_payment_providers, dispatch_uid="payment_dummy")
+def register_ticket_outputs(sender, **kwargs):
+    from .payment import DummyPaymentProvider
+    return DummyPaymentProvider