From 9e85d3c94c0209e9f461330573008ad6e47a6312 Mon Sep 17 00:00:00 2001 From: Raphael Michel Date: Mon, 30 Sep 2019 14:36:50 +0200 Subject: [PATCH] PDF editor: Catch ValueError during float conversion --- src/pretix/control/views/pdf.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/pretix/control/views/pdf.py b/src/pretix/control/views/pdf.py index 866924147a..b2f6d86179 100644 --- a/src/pretix/control/views/pdf.py +++ b/src/pretix/control/views/pdf.py @@ -123,10 +123,16 @@ class BaseEditorView(EventPermissionRequiredMixin, TemplateView): def post(self, request, *args, **kwargs): if "emptybackground" in request.POST: p = PdfFileWriter() - p.addBlankPage( - width=float(request.POST.get('width')) * mm, - height=float(request.POST.get('height')) * mm, - ) + try: + p.addBlankPage( + width=float(request.POST.get('width')) * mm, + height=float(request.POST.get('height')) * mm, + ) + except ValueError: + return JsonResponse({ + "status": "error", + "error": "Invalid height/width given." + }) buffer = BytesIO() p.write(buffer) buffer.seek(0)