CGM_Public/pretix_original
2
0
Fork 1
mirror of https://github.com/pretix/pretix.git synced 2026-05-03 14:54:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

API: Do not write log entry for events when no changes are made (#4090)

Browse Source
This commit is contained in:
Raphael Michel
2024-04-26 13:56:46 +02:00
committed by GitHub
parent 189c77207f
commit 9d57ea8534
3 changed files with 48 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/tests/api/test_events.py
View File

@@ -746,6 +746,20 @@ def test_event_update(token_client, organizer, event, item, meta_prop):
name="Foo"
).exists()
# Noop does not write log
cnt = event.all_logentries().count()
resp = token_client.patch(
'/api/v1/organizers/{}/events/{}/'.format(organizer.slug, event.slug),
{
"date_from": "2018-12-27T10:00:00Z",
"date_to": "2018-12-28T10:00:00Z",
"currency": "DKK",
},
format='json'
)
assert resp.status_code == 200
assert cnt == event.all_logentries().count()
@pytest.mark.django_db
def test_event_test_mode(token_client, organizer, event):
@@ -1252,8 +1266,26 @@ def test_patch_event_settings(token_client, organizer, event):
event.settings.flush()
assert event.settings.imprint_url == 'https://example.com'
assert not event.settings.reusable_media_active
assert event.all_logentries().filter(action_type="pretix.event.settings").count() == 1
mocked.assert_not_called()
# The same settings again do not create a new log entry
resp = token_client.patch(
'/api/v1/organizers/{}/events/{}/settings/'.format(organizer.slug, event.slug),
{
'imprint_url': 'https://example.com',
'confirm_texts': [
{
'de': 'Ich bin mit den AGB einverstanden.'
}
],
'reusable_media_active': True, # readonly, ignored
},
format='json'
)
assert resp.status_code == 200
assert event.all_logentries().filter(action_type="pretix.event.settings").count() == 1
resp = token_client.patch(
'/api/v1/organizers/{}/events/{}/settings/'.format(organizer.slug, event.slug),
{
@@ -1266,6 +1298,7 @@ def test_patch_event_settings(token_client, organizer, event):
event.settings.flush()
mocked.assert_any_call(args=(event.pk,))
assert event.settings.primary_color == '#ff0000'
assert event.all_logentries().filter(action_type="pretix.event.settings").count() == 2
resp = token_client.patch(
'/api/v1/organizers/{}/events/{}/settings/'.format(organizer.slug, event.slug),