From 9c23216bd1de9cbd60cc52d068f08967dc1875a4 Mon Sep 17 00:00:00 2001 From: Raphael Michel Date: Mon, 12 Aug 2019 17:33:05 +0200 Subject: [PATCH] Order creation API: Do not allow empty orders --- src/pretix/api/serializers/order.py | 2 +- src/tests/api/test_orders.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pretix/api/serializers/order.py b/src/pretix/api/serializers/order.py index cb90e4001e..a721f995d2 100644 --- a/src/pretix/api/serializers/order.py +++ b/src/pretix/api/serializers/order.py @@ -557,7 +557,7 @@ class CompatibleJSONField(serializers.JSONField): class OrderCreateSerializer(I18nAwareModelSerializer): invoice_address = InvoiceAddressSerializer(required=False) - positions = OrderPositionCreateSerializer(many=True, required=False) + positions = OrderPositionCreateSerializer(many=True, required=True) fees = OrderFeeCreateSerializer(many=True, required=False) status = serializers.ChoiceField(choices=( ('n', Order.STATUS_PENDING), diff --git a/src/tests/api/test_orders.py b/src/tests/api/test_orders.py index df5d6168bb..637156a9f8 100644 --- a/src/tests/api/test_orders.py +++ b/src/tests/api/test_orders.py @@ -159,6 +159,7 @@ TEST_PAYMENTS_RES = [ "created": "2017-12-01T10:00:00Z", "payment_date": "2017-12-01T10:00:00Z", "provider": "stripe", + "payment_url": None, "state": "refunded", "amount": "23.00" }, @@ -167,6 +168,7 @@ TEST_PAYMENTS_RES = [ "created": "2017-12-01T10:00:00Z", "payment_date": None, "provider": "banktransfer", + "payment_url": None, "state": "pending", "amount": "23.00" }