Add a maximum budget to vouchers (#1526)

* Data model changes

* Fix test failures

* Adjustments

* Some tests and API support

* Check when extending orders

* Make things more deterministic, fix style

* Do not apply negative discounts

* Update price_before_voucher on item/subevent changes

* Add tests for price_before_voucher in combination with free price

* Fix InvoiceAddress.DoesNotExist

src/tests/base/test_models.py

@@ -795,6 +795,31 @@ class VoucherTestCase(BaseQuotaTestCase):
         v = Voucher.objects.create(event=self.event, price_mode='percent', value=Decimal('23.00'))
         assert v.calculate_price(Decimal('100.00')) == Decimal('77.00')
 
+    @classscope(attr='o')
+    def test_calculate_price_max_discount(self):
+        v = Voucher.objects.create(event=self.event, price_mode='subtract', value=Decimal('10.00'))
+        assert v.calculate_price(Decimal('23.42'), max_discount=Decimal('5.00')) == Decimal('18.42')
+
+    @classscope(attr='o')
+    def test_calculate_budget_used(self):
+        v = Voucher.objects.create(event=self.event, price_mode='sset', value=Decimal('20.00'))
+
+        order = Order.objects.create(
+            status=Order.STATUS_PENDING, event=self.event,
+            datetime=now() - timedelta(days=5), expires=now() + timedelta(days=5), total=46,
+        )
+        OrderPosition.objects.create(order=order, item=self.item1, voucher=v, price=Decimal('20.00'),
+                                     price_before_voucher=Decimal('23.00'))
+        assert v.budget_used() == Decimal('3.00')
+
+        order = Order.objects.create(
+            status=Order.STATUS_PAID, event=self.event,
+            datetime=now() - timedelta(days=5), expires=now() + timedelta(days=5), total=46,
+        )
+        OrderPosition.objects.create(order=order, item=self.item1, voucher=v, price=Decimal('20.00'),
+                                     price_before_voucher=Decimal('23.00'))
+        assert v.budget_used() == Decimal('6.00')
+
 
 class OrderTestCase(BaseQuotaTestCase):
     def setUp(self):

src/tests/base/test_orders.py

@@ -878,6 +878,36 @@ class OrderChangeManagerTests(TestCase):
         assert self.op1.tax_value == Decimal('3.67')
         assert self.op1.tax_rule == self.shirt.tax_rule
 
+    @classscope(attr='o')
+    def test_change_item_change_price_before_voucher(self):
+        self.op1.voucher = self.event.vouchers.create(item=self.shirt, redeemed=1, price_mode='set', value='5.00')
+        self.op1.price = Decimal('5.00')
+        self.op1.price_before_voucher = Decimal('23.00')
+        self.op1.save()
+        p = self.op1.price
+        self.ocm.change_item(self.op1, self.shirt, None)
+        self.ocm.commit()
+        self.op1.refresh_from_db()
+        self.order.refresh_from_db()
+        assert self.op1.item == self.shirt
+        assert self.op1.price == p
+        assert self.op1.price_before_voucher == Decimal('12.00')
+
+    @classscope(attr='o')
+    def test_change_item_change_price_before_voucher_minimum_value(self):
+        self.op1.voucher = self.event.vouchers.create(item=self.shirt, redeemed=1, price_mode='set', value='20.00')
+        self.op1.price = Decimal('20.00')
+        self.op1.price_before_voucher = Decimal('23.00')
+        self.op1.save()
+        p = self.op1.price
+        self.ocm.change_item(self.op1, self.shirt, None)
+        self.ocm.commit()
+        self.op1.refresh_from_db()
+        self.order.refresh_from_db()
+        assert self.op1.item == self.shirt
+        assert self.op1.price == p
+        assert self.op1.price_before_voucher == Decimal('20.00')
+
     @classscope(attr='o')
     def test_change_item_success(self):
         self.ocm.change_item(self.op1, self.shirt, None)