From 8ca544064b8bd81a6950bcd5c8221a7dc2bec731 Mon Sep 17 00:00:00 2001 From: Felix Rindt Date: Fri, 18 Sep 2020 16:16:33 +0200 Subject: [PATCH] Fix #1759: order import increasing positionids (#1776) --- src/pretix/base/services/orderimport.py | 2 +- src/tests/base/test_orderimport.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pretix/base/services/orderimport.py b/src/pretix/base/services/orderimport.py index 5db3eb03b1..ed463d2b3b 100644 --- a/src/pretix/base/services/orderimport.py +++ b/src/pretix/base/services/orderimport.py @@ -103,7 +103,7 @@ def import_orders(event: Event, fileid: str, settings: dict, locale: str, user) order._address.name_parts = {'_scheme': event.settings.name_scheme} orders.append(order) - position = OrderPosition() + position = OrderPosition(positionid=len(order._positions) + 1) position.attendee_name_parts = {'_scheme': event.settings.name_scheme} position.meta_info = {} order._positions.append(position) diff --git a/src/tests/base/test_orderimport.py b/src/tests/base/test_orderimport.py index 643fc47df7..76eccc28a6 100644 --- a/src/tests/base/test_orderimport.py +++ b/src/tests/base/test_orderimport.py @@ -130,6 +130,7 @@ def test_import_as_one_order(user, event, item): assert event.orders.count() == 1 o = event.orders.get() assert o.positions.count() == 3 + assert set(pos.positionid for pos in o.positions.all()) == {1, 2, 3} @pytest.mark.django_db