Fixed payment and ticketoutput enable/disable switches and their

implications

src/pretix/base/forms.py

@@ -75,8 +75,8 @@ class SettingsForm(forms.Form):
     This form is meant to be used for modifying Event- or OrganizerSettings
     """
     BOOL_CHOICES = (
-        ('True', _('enabled')),
         ('False', _('disabled')),
+        ('True', _('enabled')),
     )
 
     def __init__(self, *args, **kwargs):

src/pretix/base/payment.py

@@ -98,10 +98,9 @@ class BasePaymentProvider:
         """
         return OrderedDict([
             ('_enabled',
-             forms.ChoiceField(
+             forms.BooleanField(
                  label=_('Enable payment method'),
                  required=False,
-                 choices=SettingsForm.BOOL_CHOICES,
              )),
             ('_fee_abs',
              forms.DecimalField(

src/pretix/base/ticketoutput.py

@@ -86,10 +86,9 @@ class BaseTicketOutput:
         """
         return OrderedDict([
             ('_enabled',
-             forms.ChoiceField(
+             forms.BooleanField(
                  label=_('Enable output'),
                  required=False,
-                 choices=SettingsForm.BOOL_CHOICES,
              )),
         ])
 

src/pretix/presale/views/checkout.py

@@ -174,6 +174,8 @@ class PaymentDetails(EventViewMixin, CartDisplayMixin, EventLoginRequiredMixin,
                     return redirect(self.get_confirm_url())
                 else:
                     return self.get(request, *args, **kwargs)
+        messages.error(self.request, _("Please select a payment method."))
+        return self.get(request, *args, **kwargs)
 
     def get_context_data(self, **kwargs):
         ctx = super().get_context_data(**kwargs)