From 833cd32578495ebd4d47fd34ec30d4988f5e9d32 Mon Sep 17 00:00:00 2001 From: Alexander Schwartz Date: Tue, 4 Feb 2020 17:09:12 +0100 Subject: [PATCH] Comparison for file extensions should be case insensitive (#1563) --- src/pretix/base/models/orders.py | 2 +- src/pretix/control/forms/__init__.py | 2 +- src/pretix/control/views/orderimport.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pretix/base/models/orders.py b/src/pretix/base/models/orders.py index 8ec4cfe9c3..95ae8e5333 100644 --- a/src/pretix/base/models/orders.py +++ b/src/pretix/base/models/orders.py @@ -900,7 +900,7 @@ class QuestionAnswer(models.Model): @property def is_image(self): - return any(self.file.name.endswith(e) for e in ('.jpg', '.png', '.gif', '.tiff', '.bmp', '.jpeg')) + return any(self.file.name.lower().endswith(e) for e in ('.jpg', '.png', '.gif', '.tiff', '.bmp', '.jpeg')) @property def file_name(self): diff --git a/src/pretix/control/forms/__init__.py b/src/pretix/control/forms/__init__.py index 72945781ab..cda5e3f187 100644 --- a/src/pretix/control/forms/__init__.py +++ b/src/pretix/control/forms/__init__.py @@ -79,7 +79,7 @@ class ClearableBasenameFileInput(forms.ClearableFileInput): @property def is_img(self): - return any(self.file.name.endswith(e) for e in ('.jpg', '.jpeg', '.png', '.gif')) + return any(self.file.name.lower().endswith(e) for e in ('.jpg', '.jpeg', '.png', '.gif')) def __str__(self): return os.path.basename(self.file.name).split('.', 1)[-1] diff --git a/src/pretix/control/views/orderimport.py b/src/pretix/control/views/orderimport.py index 14ff903466..d3ce0ff783 100644 --- a/src/pretix/control/views/orderimport.py +++ b/src/pretix/control/views/orderimport.py @@ -29,7 +29,7 @@ class ImportView(EventPermissionRequiredMixin, TemplateView): 'event': request.event.slug, 'organizer': request.organizer.slug, })) - if not request.FILES['file'].name.endswith('.csv'): + if not request.FILES['file'].name.lower().endswith('.csv'): messages.error(request, _('Please only upload CSV files.')) return redirect(reverse('control:event.orders.import', kwargs={ 'event': request.event.slug,