From 76b018997277add503a7234e08554527e9fc608e Mon Sep 17 00:00:00 2001 From: Raphael Michel Date: Tue, 23 Jun 2015 21:17:32 +0200 Subject: [PATCH] Fixed a versioning bug in the property editor --- src/pretix/control/views/item.py | 3 +-- src/tests/control/test_items.py | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/pretix/control/views/item.py b/src/pretix/control/views/item.py index 983a73b8ae..9d644c2a64 100644 --- a/src/pretix/control/views/item.py +++ b/src/pretix/control/views/item.py @@ -271,8 +271,7 @@ class PropertyUpdate(EventPermissionRequiredMixin, UpdateView): f.instance.pk = None for i, f in enumerate(formset.ordered_forms): - if f.instance.pk is not None: - f.instance = f.instance.clone() + f.save(commit=False) f.instance.position = i f.instance.save() diff --git a/src/tests/control/test_items.py b/src/tests/control/test_items.py index be2da16424..b767d1ca8a 100644 --- a/src/tests/control/test_items.py +++ b/src/tests/control/test_items.py @@ -147,7 +147,7 @@ class PropertiesTest(ItemFormTest): assert str(PropertyValue.objects.current.get(identity=p2.identity).value) == 'red' assert str(PropertyValue.objects.as_of(t1).get(identity=p1.identity).value) == 'S' assert not PropertyValue.objects.current.filter(identity=p1.identity).exists() - assert Property.objects.as_of(t1).get(identity=c.identity).name == 'Size' + assert str(Property.objects.as_of(t1).get(identity=c.identity).name) == 'Size' def test_delete(self): c = Property.objects.create(event=self.event1, name="Size")