From 7162366478ebfa98f590e21ef67f7ce3848c06fe Mon Sep 17 00:00:00 2001 From: Raphael Michel Date: Mon, 15 Jun 2015 19:06:42 +0200 Subject: [PATCH] Fixes #68 -- Crash caused by uncategorized items in order overview --- src/pretix/control/views/orders.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pretix/control/views/orders.py b/src/pretix/control/views/orders.py index 2eae453c98..cdd5b430f9 100644 --- a/src/pretix/control/views/orders.py +++ b/src/pretix/control/views/orders.py @@ -8,7 +8,7 @@ from django.http import HttpResponse from django.shortcuts import redirect, render from django.utils.functional import cached_property from django.views.generic import ListView, DetailView, TemplateView -from pretix.base.models import Order, Quota, OrderPosition +from pretix.base.models import Order, Quota, OrderPosition, ItemCategory from pretix.base.services.orders import mark_order_paid from pretix.base.signals import register_payment_providers from pretix.control.forms.orders import ExtendForm @@ -258,11 +258,12 @@ class OverView(EventPermissionRequiredMixin, TemplateView): item.num_refunded = sum(var.num_refunded for var in item.all_variations) item.num_paid = sum(var.num_paid for var in item.all_variations) + nonecat = ItemCategory(name=_('Uncategorized')) # Regroup those by category ctx['items_by_category'] = sorted( [ # a group is a tuple of a category and a list of items - (cat, [i for i in items if i.category == cat]) + (cat if cat is not None else nonecat, [i for i in items if i.category == cat]) for cat in set([i.category for i in items]) # insert categories into a set for uniqueness # a set is unsorted, so sort again by category