From 70f71c80776e369e18c1ef2f462ea9c49c1e342d Mon Sep 17 00:00:00 2001 From: Raphael Michel Date: Mon, 16 Jun 2025 10:49:08 +0200 Subject: [PATCH] Email: Remove more characters from sender name (Z#23197264) (#5248) * Email: Remove more characters from sender name (Z#23197264) * fix typo --------- Co-authored-by: Richard Schreiber --- src/pretix/base/services/mail.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/pretix/base/services/mail.py b/src/pretix/base/services/mail.py index 29f681bd49..73cfedbbd4 100644 --- a/src/pretix/base/services/mail.py +++ b/src/pretix/base/services/mail.py @@ -96,12 +96,19 @@ class SendMailException(Exception): def clean_sender_name(sender_name: str) -> str: + # Even though we try to properly escape sender names, some characters seem to cause problems when the escaping + # fails due to some forwardings, etc. + # Emails with @ in their sender name are rejected by some mailservers (e.g. Microsoft) because it looks like # a phishing attempt. sender_name = sender_name.replace("@", " ") # Emails with : in their sender name are treated by Microsoft like emails with no From header at all, leading # to a higher spam likelihood. sender_name = sender_name.replace(":", " ") + # Emails with , in their sender name look like multiple senders + sender_name = sender_name.replace(",", "") + # Emails with " in their sender name could be escaped, but somehow create issues in reality + sender_name = sender_name.replace("\"", "") # Emails with excessively long sender names are rejected by some mailservers if len(sender_name) > 75: