From 6f92f2324f415bd9ca583f892d0926dc7a8f5650 Mon Sep 17 00:00:00 2001
From: Richard Schreiber <schreiber@rami.io>
Date: Mon, 12 May 2025 15:20:52 +0200
Subject: [PATCH] Fix JavaScript-based required label

---
 src/pretix/static/pretixbase/js/addressform.js | 8 ++++++++
 src/pretix/static/pretixpresale/js/ui/main.js  | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/pretix/static/pretixbase/js/addressform.js b/src/pretix/static/pretixbase/js/addressform.js
index fe29408037..59645a9c0f 100644
--- a/src/pretix/static/pretixbase/js/addressform.js
+++ b/src/pretix/static/pretixbase/js/addressform.js
@@ -51,6 +51,13 @@ $(function () {
                         const required = 'required' in options && options.required && isRequired && visible;
                         dependent.closest(".form-group").toggle(visible).toggleClass('required', required);
                         dependent.prop("required", required);
+                        const label = dependent.closest(".form-group").find("label");
+                        const labelRequired = label.find(".label-required");
+                        if (!required) {
+                            labelRequired.remove();
+                        } else if (!labelRequired.length) {
+                            label.append('<i class="label-required">' + gettext('required') + '</i>')
+                        }
                     }
                     for (var k in dependents) dependents[k].prop("disabled", false);
                 }).always(function() {
@@ -64,6 +71,7 @@ $(function () {
 
                         dependent.closest(".form-group").toggle(visible).toggleClass('required', required);
                         dependent.prop("required", required);
+                        dependent.closest(".form-group").find("label .label-required").remove();
                     }
                 });
             };
diff --git a/src/pretix/static/pretixpresale/js/ui/main.js b/src/pretix/static/pretixpresale/js/ui/main.js
index d1867bfe1a..1ae8458c66 100644
--- a/src/pretix/static/pretixpresale/js/ui/main.js
+++ b/src/pretix/static/pretixpresale/js/ui/main.js
@@ -551,7 +551,7 @@ $(function () {
                 }
                 dependent.closest('.form-group').toggleClass('required', enabled);
                 if (enabled) {
-                    dependentLabel.append('<i class="sr-only label-required">, ' + gettext('required') + '</i>');
+                    dependentLabel.append('<i class="label-required">' + gettext('required') + '</i>');
                 }
                 else {
                     dependentLabel.find(".label-required").remove();