From 695e817f9964a61b6b16267f36b96e5887c24f49 Mon Sep 17 00:00:00 2001 From: Mira Date: Wed, 19 Mar 2025 14:10:41 +0100 Subject: [PATCH] Fix Exception when displaying mail_history (PRETIXEU-BB0) (#4934) * Fix Exception when displaying mail_history Log entries of type pretix.plugins.banktransfer.order.email.invoice had type(invoices) == int instead of list * Update src/pretix/control/views/orders.py Co-authored-by: Richard Schreiber --------- Co-authored-by: Raphael Michel Co-authored-by: Richard Schreiber --- src/pretix/control/views/orders.py | 7 +++++-- src/pretix/plugins/banktransfer/payment.py | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/pretix/control/views/orders.py b/src/pretix/control/views/orders.py index cd0327a4fd..cca5fef1f4 100644 --- a/src/pretix/control/views/orders.py +++ b/src/pretix/control/views/orders.py @@ -2491,10 +2491,13 @@ class OrderEmailHistory(EventPermissionRequiredMixin, OrderViewMixin, ListView): def get_context_data(self, **kwargs): ctx = super().get_context_data(**kwargs) for l in ctx["logs"]: - if l.parsed_data.get("invoices"): + invoice_ids = l.parsed_data.get("invoices") + if invoice_ids: + if type(invoice_ids) is int: + invoice_ids = [invoice_ids] l.parsed_invoices = Invoice.objects.filter( event=self.request.event, - pk__in=l.parsed_data["invoices"], + pk__in=invoice_ids, ) if l.parsed_data.get("attach_other_files"): l.parsed_other_files = [ diff --git a/src/pretix/plugins/banktransfer/payment.py b/src/pretix/plugins/banktransfer/payment.py index 6697515f6b..7848ce58c0 100644 --- a/src/pretix/plugins/banktransfer/payment.py +++ b/src/pretix/plugins/banktransfer/payment.py @@ -410,7 +410,7 @@ class BankTransfer(BasePaymentProvider): 'message': email_content, 'position': None, 'recipient': email, - 'invoices': invoice.pk, + 'invoices': [invoice.pk], 'attach_tickets': False, 'attach_ical': False, }