From 654be0db34cee07912f71a526a109d3b61558800 Mon Sep 17 00:00:00 2001 From: Raphael Michel Date: Thu, 3 Jan 2019 09:34:15 +0100 Subject: [PATCH] Stripe: Prevent race condition between ReturnView and webhook --- src/pretix/plugins/stripe/views.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/pretix/plugins/stripe/views.py b/src/pretix/plugins/stripe/views.py index 1b3dd9122a..8b20a01e19 100644 --- a/src/pretix/plugins/stripe/views.py +++ b/src/pretix/plugins/stripe/views.py @@ -429,6 +429,12 @@ class ReturnView(StripeOrderView, View): finally: if 'payment_stripe_token' in request.session: del request.session['payment_stripe_token'] + elif src.status == 'consumed' and (self.payment.info_data.get('id', '').startswith('py_') or + self.payment.info_data.get('id', '').startswith('ch_')): + # Webhook was faster, wow! ;) + if 'payment_stripe_token' in request.session: + del request.session['payment_stripe_token'] + return self._redirect_to_order() else: self.payment.state = OrderPayment.PAYMENT_STATE_FAILED self.payment.info = str(src)