CGM_Public/pretix_original
2
0
Fork 1
mirror of https://github.com/pretix/pretix.git synced 2026-05-04 15:04:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid unneccesary logs in some highly-used API endpoints

Browse Source
This commit is contained in:
Raphael Michel
2019-06-09 23:54:13 +02:00
parent b2274039b3
commit 61e111742d
3 changed files with 30 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/pretix/api/views/item.py
View File

@@ -65,6 +65,10 @@ class ItemViewSet(ConditionalListView, viewsets.ModelViewSet):
return ctx
def perform_update(self, serializer):
if serializer.data == self.get_serializer(instance=serializer.instance).data:
# Performance optimization: If nothing was changed, we do not need to save or log anything.
# This costs us a few cycles on save, but avoids thousands of lines in our log.
return
serializer.save(event=self.request.event)
serializer.instance.log_action(
'pretix.event.item.changed',
@@ -452,6 +456,11 @@ class QuotaViewSet(ConditionalListView, viewsets.ModelViewSet):
return ctx
def perform_update(self, serializer):
if serializer.data == self.get_serializer(instance=serializer.instance).data:
# Performance optimization: If nothing was changed, we do not need to save or log anything.
# This costs us a few cycles on save, but avoids thousands of lines in our log.
return
current_subevent = serializer.instance.subevent
serializer.save(event=self.request.event)
request_subevent = serializer.instance.subevent