Fix #2090 -- Test mode for memberships

src/pretix/control/forms/organizer.py

@@ -560,7 +560,7 @@ class MembershipUpdateForm(forms.ModelForm):
 
     class Meta:
         model = Membership
-        fields = ['membership_type', 'date_start', 'date_end', 'attendee_name_parts']
+        fields = ['testmode', 'membership_type', 'date_start', 'date_end', 'attendee_name_parts']
         field_classes = {
             'date_start': SplitDateTimeField,
             'date_end': SplitDateTimeField,
@@ -573,6 +573,9 @@ class MembershipUpdateForm(forms.ModelForm):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
+        if self.instance and self.instance.pk:
+            del self.fields['testmode']
+
         self.fields['membership_type'].queryset = self.instance.customer.organizer.membership_types.all()
         self.fields['attendee_name_parts'] = NamePartsFormField(
             max_length=255,

src/pretix/control/logdisplay.py

@@ -325,6 +325,7 @@ def pretixcontrol_logentry_display(sender: Event, logentry: LogEntry, **kwargs):
         'pretix.customer.changed': _('The account has been changed.'),
         'pretix.customer.membership.created': _('A membership for this account has been added.'),
         'pretix.customer.membership.changed': _('A membership of this account has been changed.'),
+        'pretix.customer.membership.deleted': _('A membership of this account has been deleted.'),
         'pretix.customer.anonymized': _('The account has been disabled and anonymized.'),
         'pretix.customer.password.resetrequested': _('A new password has been requested.'),
         'pretix.customer.password.set': _('A new password has been set.'),

src/pretix/control/templates/pretixcontrol/organizers/customer.html

@@ -82,6 +82,7 @@
                         <tr>
                             <td>
                                 {{ m.membership_type.name }}
+                                {% if m.testmode %}<span class="label label-warning">{% trans "TEST MODE" %}</span>{% endif %}
                             </td>
                             <td>
                                 {{ m.date_start|date:"SHORT_DATETIME_FORMAT" }}
@@ -118,6 +119,14 @@
                                         class="btn btn-default">
                                     <i class="fa fa-edit"></i>
                                 </a>
+                                {% if m.testmode %}
+                                    <a href="{% url "control:organizer.customer.membership.delete" organizer=request.organizer.slug customer=customer.identifier id=m.pk %}"
+                                            data-toggle="tooltip"
+                                            title="{% trans "Delete" %}"
+                                            class="btn btn-danger">
+                                        <i class="fa fa-trash"></i>
+                                    </a>
+                                {% endif %}
                             </td>
                         </tr>
                     {% endfor %}

src/pretix/control/templates/pretixcontrol/organizers/customer_membership.html

@@ -7,6 +7,7 @@
 {% block inner %}
     <h1>
         {% trans "Membership" %}
+        {% if membership.testmode %}<span class="label label-warning">{% trans "TEST MODE" %}</span>{% endif %}
     </h1>
     <div class="panel panel-primary items">
         <div class="panel-heading">

src/pretix/control/templates/pretixcontrol/organizers/customer_membership_delete.html

@@ -0,0 +1,31 @@
+{% extends "pretixcontrol/organizers/base.html" %}
+{% load i18n %}
+{% load bootstrap3 %}
+{% block title %}
+    {% trans "Membership" %}
+{% endblock %}
+{% block inner %}
+    <h1>
+        {% trans "Membership" %}
+        {% if membership.testmode %}<span class="label label-warning">{% trans "TEST MODE" %}</span>{% endif %}
+    </h1>
+    <form action="" method="post" class="form-horizontal">
+        {% csrf_token %}
+        {% if is_allowed %}
+            <p>{% blocktrans %}Are you sure you want to delete this membership?{% endblocktrans %}
+                {% else %}
+            <p>{% blocktrans %}This membership cannot be deleted since it has been used in an order. Change its end date to the past instead.{% endblocktrans %}
+        {% endif %}
+        </p>
+        <div class="form-group submit-group">
+            <a href="{% url "control:organizer.customer" organizer=request.organizer.slug customer=membership.customer.identifier %}" class="btn btn-default btn-cancel">
+                {% trans "Cancel" %}
+            </a>
+            {% if is_allowed %}
+                <button type="submit" class="btn btn-danger btn-save">
+                    {% trans "Delete" %}
+                </button>
+            {% endif %}
+        </div>
+    </form>
+{% endblock %}

src/pretix/control/urls.py

@@ -141,6 +141,8 @@ urlpatterns = [
             organizer.MembershipCreateView.as_view(), name='organizer.customer.membership.add'),
     re_path(r'^organizer/(?P<organizer>[^/]+)/customer/(?P<customer>[^/]+)/membership/(?P<id>[^/]+)/edit$',
             organizer.MembershipUpdateView.as_view(), name='organizer.customer.membership.edit'),
+    re_path(r'^organizer/(?P<organizer>[^/]+)/customer/(?P<customer>[^/]+)/membership/(?P<id>[^/]+)/delete$',
+            organizer.MembershipDeleteView.as_view(), name='organizer.customer.membership.delete'),
     re_path(r'^organizer/(?P<organizer>[^/]+)/customer/(?P<customer>[^/]+)/anonymize$',
             organizer.CustomerAnonymizeView.as_view(), name='organizer.customer.anonymize'),
     re_path(r'^organizer/(?P<organizer>[^/]+)/giftcards$', organizer.GiftCardListView.as_view(), name='organizer.giftcards'),

src/pretix/control/views/orders.py

@@ -535,6 +535,7 @@ class OrderDelete(OrderView):
                     'organizer': self.request.organizer.slug,
                 }))
             except ProtectedError:
+                logger.exception('Could not delete order')
                 messages.error(self.request, _('The order could not be deleted as some constraints (e.g. data created '
                                                'by plug-ins) do not allow it.'))
                 return self.get(self.request, *self.args, **self.kwargs)

src/pretix/control/views/organizer.py

@@ -1887,6 +1887,45 @@ class MembershipUpdateView(OrganizerDetailViewMixin, OrganizerPermissionRequired
         })
 
 
+class MembershipDeleteView(OrganizerDetailViewMixin, OrganizerPermissionRequiredMixin, DeleteView):
+    template_name = 'pretixcontrol/organizers/customer_membership_delete.html'
+    permission = 'can_manage_customers'
+    context_object_name = 'membership'
+    form_class = MembershipUpdateForm
+
+    def get_object(self, queryset=None):
+        return get_object_or_404(
+            Membership,
+            customer__organizer=self.request.organizer,
+            customer__identifier=self.kwargs.get('customer'),
+            testmode=True,
+            pk=self.kwargs.get('id')
+        )
+
+    def get_context_data(self, **kwargs):
+        ctx = super().get_context_data(**kwargs)
+        ctx['is_allowed'] = self.object.allow_delete()
+        return ctx
+
+    @transaction.atomic
+    def delete(self, request, *args, **kwargs):
+        self.object = self.get_object()
+        self.customer = self.object.customer
+        success_url = self.get_success_url()
+        if self.object.allow_delete():
+            self.object.cartposition_set.all().delete()
+            self.object.customer.log_action('pretix.customer.membership.deleted', user=self.request.user)
+            self.object.delete()
+            messages.success(request, _('The selected object has been deleted.'))
+        return redirect(success_url)
+
+    def get_success_url(self):
+        return reverse('control:organizer.customer', kwargs={
+            'organizer': self.request.organizer.slug,
+            'customer': self.customer.identifier,
+        })
+
+
 class MembershipCreateView(OrganizerDetailViewMixin, OrganizerPermissionRequiredMixin, CreateView):
     template_name = 'pretixcontrol/organizers/customer_membership.html'
     permission = 'can_manage_customers'