From 49097037dacce62cdeaafc1cddad330d9bc77c06 Mon Sep 17 00:00:00 2001
From: Raphael Michel <michel@rami.io>
Date: Wed, 16 Nov 2022 11:50:29 +0100
Subject: [PATCH] PPv2: Improve displaying errors

---
 .../pretixplugins/paypal2/control.html        | 34 +++++++++++++------
 1 file changed, 24 insertions(+), 10 deletions(-)

diff --git a/src/pretix/plugins/paypal2/templates/pretixplugins/paypal2/control.html b/src/pretix/plugins/paypal2/templates/pretixplugins/paypal2/control.html
index 8c35bdd48e..9ed7c9f57b 100644
--- a/src/pretix/plugins/paypal2/templates/pretixplugins/paypal2/control.html
+++ b/src/pretix/plugins/paypal2/templates/pretixplugins/paypal2/control.html
@@ -2,17 +2,31 @@
 
 {% if payment_info %}
     <dl class="dl-horizontal">
-        <dt>{% trans "Sale ID" %}</dt>
-        <dd>{{ payment_info.purchase_units.0.payments.captures.0.id }}</dd>
+        {% if payment_info.purchase_units.0.payments %}
+            <dt>{% trans "Sale ID" %}</dt>
+            <dd>{{ payment_info.purchase_units.0.payments.captures.0.id }}</dd>
+        {% endif %}
         <dt>{% trans "Status" %}</dt>
         <dd>{{ payment_info.status }}</dd>
-        <dt>{% trans "Payer" %}</dt>
-        <dd>{{ payment_info.payer.email_address }}</dd>
-        <dt>{% trans "Last update" %}</dt>
-        <dd>{{ payment_info.purchase_units.0.payments.captures.0.update_time }}</dd>
-        <dt>{% trans "Total value" %}</dt>
-        <dd>{{ payment_info.purchase_units.0.payments.captures.0.amount.value }}</dd>
-        <dt>{% trans "Currency" %}</dt>
-        <dd>{{ payment_info.purchase_units.0.payments.captures.0.amount.currency_code }}</dd>
+        {% if payment_info.payer %}
+            <dt>{% trans "Payer" %}</dt>
+            <dd>{{ payment_info.payer.email_address }}</dd>
+        {% endif %}
+        {% if payment_info.error %}
+            <dt>{% trans "Error" %}</dt>
+            <dd>[{{ payment_info.error.name }}] {{ payment_info.error.message }}</dd>
+            {% for d in payment_info.error.details %}
+                <dt>{% trans "Error" %}</dt>
+                <dd>[{{ d.issue }}] {{ d.description }}</dd>
+            {% endfor %}
+        {% endif %}
+        {% if payment_info.purchase_units.0.payments %}
+            <dt>{% trans "Last update" %}</dt>
+            <dd>{{ payment_info.purchase_units.0.payments.captures.0.update_time }}</dd>
+            <dt>{% trans "Total value" %}</dt>
+            <dd>{{ payment_info.purchase_units.0.payments.captures.0.amount.value }}</dd>
+            <dt>{% trans "Currency" %}</dt>
+            <dd>{{ payment_info.purchase_units.0.payments.captures.0.amount.currency_code }}</dd>
+        {% endif %}
     </dl>
 {% endif %}