From 465171f32308424c646268b12127f493a1c8993b Mon Sep 17 00:00:00 2001
From: Martin Gross <gross@rami.io>
Date: Thu, 22 May 2025 17:13:11 +0200
Subject: [PATCH] WebAuthN: Replace sr-only with hidden css-class

---
 .../control/templates/pretixcontrol/auth/login_2fa.html       | 2 +-
 .../templates/pretixcontrol/user/2fa_confirm_webauthn.html    | 2 +-
 src/pretix/control/templates/pretixcontrol/user/reauth.html   | 2 +-
 src/pretix/static/pretixcontrol/js/ui/webauthn.js             | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/pretix/control/templates/pretixcontrol/auth/login_2fa.html b/src/pretix/control/templates/pretixcontrol/auth/login_2fa.html
index daea99f0dc..760769b3a5 100644
--- a/src/pretix/control/templates/pretixcontrol/auth/login_2fa.html
+++ b/src/pretix/control/templates/pretixcontrol/auth/login_2fa.html
@@ -14,7 +14,7 @@
             <input class="form-control" name="token" placeholder="{% trans "Token" %}" autocomplete="one-time-code"
                     type="text" required="required" autofocus="autofocus" id="webauthn-response">
         </div>
-        <div class="sr-only alert alert-danger" id="webauthn-error">
+        <div class="alert alert-danger hidden" id="webauthn-error">
             {% trans "WebAuthn failed. Check that the correct authentication device is correctly plugged in." %}
         </div>
         {% if jsondata %}
diff --git a/src/pretix/control/templates/pretixcontrol/user/2fa_confirm_webauthn.html b/src/pretix/control/templates/pretixcontrol/user/2fa_confirm_webauthn.html
index 25cbdcd2b5..1b064b8aab 100644
--- a/src/pretix/control/templates/pretixcontrol/user/2fa_confirm_webauthn.html
+++ b/src/pretix/control/templates/pretixcontrol/user/2fa_confirm_webauthn.html
@@ -22,7 +22,7 @@
         <button class="btn btn-primary sr-only" type="submit"></button>
     </form>
 
-    <div class="sr-only alert alert-danger" id="webauthn-error">
+    <div class="alert alert-danger hidden" id="webauthn-error">
         {% trans "Device registration failed." %}
     </div>
     <script type="text/json" id="webauthn-enroll">
diff --git a/src/pretix/control/templates/pretixcontrol/user/reauth.html b/src/pretix/control/templates/pretixcontrol/user/reauth.html
index b234fe61f0..797e5ef58d 100644
--- a/src/pretix/control/templates/pretixcontrol/user/reauth.html
+++ b/src/pretix/control/templates/pretixcontrol/user/reauth.html
@@ -18,7 +18,7 @@
         <input class="form-control" id="webauthn-response" name="webauthn"
                 type="hidden">
         {% if jsondata %}
-            <div class="sr-only alert alert-danger" id="webauthn-error">
+            <div class="alert alert-danger hidden" id="webauthn-error">
                 {% trans "WebAuthn failed. Check that the correct authentication device is correctly plugged in." %}
             </div>
             <p><small>
diff --git a/src/pretix/static/pretixcontrol/js/ui/webauthn.js b/src/pretix/static/pretixcontrol/js/ui/webauthn.js
index a1722a2d4f..497c4bb1f6 100644
--- a/src/pretix/static/pretixcontrol/js/ui/webauthn.js
+++ b/src/pretix/static/pretixcontrol/js/ui/webauthn.js
@@ -145,7 +145,7 @@ const startRegister = async (e) => {
             publicKey: publicKeyCredentialCreateOptions
         });
     } catch (err) {
-        $("#webauthn-error").removeClass("sr-only");
+        $("#webauthn-error").removeClass("hidden");
         return console.error("Error creating credential:", err);
     }
 
@@ -170,7 +170,7 @@ const startLogin = async (e) => {
             publicKey: transformedCredentialRequestOptions,
         });
     } catch (err) {
-        $("#webauthn-error").removeClass("sr-only");
+        $("#webauthn-error").removeClass("hidden");
         return console.error("Error when creating credential:", err);
     }