A11y improvements (#2081)

Co-authored-by: Raphael Michel <michel@rami.io>
Co-authored-by: Raphael Michel <mail@raphaelmichel.de>

src/pretix/base/forms/questions.py

@@ -52,7 +52,7 @@ from django.core.exceptions import ValidationError
 from django.core.files.uploadedfile import SimpleUploadedFile
 from django.core.validators import MaxValueValidator, MinValueValidator
 from django.db.models import QuerySet
-from django.forms import Select
+from django.forms import Select, widgets
 from django.utils import translation
 from django.utils.formats import date_format
 from django.utils.html import escape
@@ -154,8 +154,9 @@ class NamePartsWidget(forms.MultiWidget):
                     final_attrs,
                     id='%s_%s' % (id_, i),
                     title=self.scheme['fields'][i][1],
-                    placeholder=self.scheme['fields'][i][1],
                 )
+                if not isinstance(widget, widgets.Select):
+                    these_attrs['placeholder'] = self.scheme['fields'][i][1]
                 if self.scheme['fields'][i][0] in REQUIRED_NAME_PARTS:
                     if self.field.required:
                         these_attrs['required'] = 'required'

src/pretix/base/models/event.py

@@ -57,6 +57,7 @@ from django.urls import reverse
 from django.utils.crypto import get_random_string
 from django.utils.formats import date_format
 from django.utils.functional import cached_property
+from django.utils.html import format_html
 from django.utils.timezone import make_aware, now
 from django.utils.translation import gettext, gettext_lazy as _
 from django_scopes import ScopedManager, scopes_disabled
@@ -145,7 +146,7 @@ class EventMixin:
             ("SHORT_" if short else "") + ("DATETIME_FORMAT" if self.settings.show_times and show_times else "DATE_FORMAT")
         )
 
-    def get_date_range_display(self, tz=None, force_show_end=False) -> str:
+    def get_date_range_display(self, tz=None, force_show_end=False, as_html=False) -> str:
         """
         Returns a formatted string containing the start date and the end date
         of the event with respect to the current locale and to the ``show_date_to``
@@ -153,8 +154,17 @@ class EventMixin:
         """
         tz = tz or self.timezone
         if (not self.settings.show_date_to and not force_show_end) or not self.date_to:
+            if as_html:
+                return format_html(
+                    "<time datetime=\"{}\">{}</time>",
+                    _date(self.date_from.astimezone(tz), "Y-m-d"),
+                    _date(self.date_from.astimezone(tz), "DATE_FORMAT"),
+                )
             return _date(self.date_from.astimezone(tz), "DATE_FORMAT")
-        return daterange(self.date_from.astimezone(tz), self.date_to.astimezone(tz))
+        return daterange(self.date_from.astimezone(tz), self.date_to.astimezone(tz), as_html)
+
+    def get_date_range_display_as_html(self, tz=None, force_show_end=False) -> str:
+        return self.get_date_range_display(tz, force_show_end, as_html=True)
 
     def get_time_range_display(self, tz=None, force_show_end=False) -> str:
         """