From 3da2cd8e39d13035237e670fbb616fc6a3dc5f8f Mon Sep 17 00:00:00 2001 From: Raphael Michel Date: Thu, 30 Apr 2026 12:47:10 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Richard Schreiber --- src/pretix/control/forms/item.py | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/pretix/control/forms/item.py b/src/pretix/control/forms/item.py index 98b96dd427..9d905e96c3 100644 --- a/src/pretix/control/forms/item.py +++ b/src/pretix/control/forms/item.py @@ -394,17 +394,18 @@ class QuotaBulkEditForm(QuotaForm): continue fields.add(k) - for obj in objs: - if k == 'itemvars': - selected_items = set(list(self.event.items.filter(id__in=[ - i.split('-')[0] for i in self.cleaned_data['itemvars'] - ]))) - selected_variations = list(ItemVariation.objects.filter(item__event=self.event, id__in=[ - i.split('-')[1] for i in self.cleaned_data['itemvars'] if '-' in i - ])) + if k == 'itemvars': + selected_items = set(list(self.event.items.filter(id__in=[ + i.split('-')[0] for i in self.cleaned_data['itemvars'] + ]))) + selected_variations = list(ItemVariation.objects.filter(item__event=self.event, id__in=[ + i.split('-')[1] for i in self.cleaned_data['itemvars'] if '-' in i + ])) + for obj in objs: obj.items.set(selected_items) obj.variations.set(selected_variations) - else: + else: + for obj in objs: setattr(obj, k, self.cleaned_data[k]) fields = [f for f in fields if f != 'itemvars']