Remove deprecated auto_checkin_sales_channels (#4587)

* Remove deprecated auto_checkin_sales_channels

* Fix Query count

src/tests/api/test_checkin.py

@@ -252,9 +252,8 @@ def test_list_list(token_client, organizer, event, clist, item, subevent, django
     res = dict(TEST_LIST_RES)
     res["id"] = clist.pk
     res["limit_products"] = [item.pk]
-    res["auto_checkin_sales_channels"] = []
 
-    with django_assert_num_queries(12):
+    with django_assert_num_queries(11):
         resp = token_client.get('/api/v1/organizers/{}/events/{}/checkinlists/'.format(organizer.slug, event.slug))
     assert resp.status_code == 200
     assert [res] == resp.data['results']
@@ -292,7 +291,6 @@ def test_list_detail(token_client, organizer, event, clist, item):
 
     res["id"] = clist.pk
     res["limit_products"] = [item.pk]
-    res["auto_checkin_sales_channels"] = []
     resp = token_client.get('/api/v1/organizers/{}/events/{}/checkinlists/{}/'.format(organizer.slug, event.slug,
                                                                                       clist.pk))
     assert resp.status_code == 200
@@ -327,9 +325,6 @@ def test_list_create(token_client, organizer, event, item, item_on_wrong_event):
             "limit_products": [item.pk],
             "all_products": False,
             "subevent": None,
-            "auto_checkin_sales_channels": [
-                "web"
-            ]
         },
         format='json'
     )
@@ -339,7 +334,6 @@ def test_list_create(token_client, organizer, event, item, item_on_wrong_event):
         assert cl.name == "VIP"
         assert cl.limit_products.count() == 1
         assert not cl.all_products
-        assert cl.auto_checkin_sales_channels.filter(identifier="web").exists()
 
     resp = token_client.post(
         '/api/v1/organizers/{}/events/{}/checkinlists/'.format(organizer.slug, event.slug),
@@ -369,24 +363,6 @@ def test_list_create_with_subevent(token_client, organizer, event, event3, item,
     )
     assert resp.status_code == 201
 
-    resp = token_client.post(
-        '/api/v1/organizers/{}/events/{}/checkinlists/'.format(organizer.slug, event.slug),
-        {
-            "name": "VIP",
-            "limit_products": [item.pk],
-            "all_products": True,
-            "subevent": subevent.pk,
-            "auto_checkin_sales_channels": [
-                "web"
-            ]
-        },
-        format='json'
-    )
-    assert resp.status_code == 201
-    with scopes_disabled():
-        cl = CheckinList.objects.get(pk=resp.data['id'])
-        assert cl.auto_checkin_sales_channels.filter(identifier="web").exists()
-
     resp = token_client.post(
         '/api/v1/organizers/{}/events/{}/checkinlists/'.format(organizer.slug, event.slug),
         {
@@ -440,20 +416,6 @@ def test_list_update(token_client, organizer, event, clist):
         cl = CheckinList.objects.get(pk=resp.data['id'])
     assert cl.name == "VIP"
 
-    resp = token_client.patch(
-        '/api/v1/organizers/{}/events/{}/checkinlists/{}/'.format(organizer.slug, event.slug, clist.pk),
-        {
-            "auto_checkin_sales_channels": [
-                "web"
-            ],
-        },
-        format='json'
-    )
-    assert resp.status_code == 200
-    with scopes_disabled():
-        cl = CheckinList.objects.get(pk=resp.data['id'])
-        assert cl.auto_checkin_sales_channels.filter(identifier="web").exists()
-
 
 @pytest.mark.django_db
 def test_list_all_items_positions(token_client, organizer, event, clist, clist_all, item, other_item, order, django_assert_num_queries):

src/tests/api/test_order_create.py

@@ -165,13 +165,6 @@ def order(event, item, taxrule, question):
         return o
 
 
-@pytest.fixture
-def clist_autocheckin(event):
-    c = event.checkin_lists.create(name="Default", all_products=True)
-    c.auto_checkin_sales_channels.add(event.organizer.sales_channels.get(identifier="web"))
-    return c
-
-
 ORDER_CREATE_PAYLOAD = {
     "email": "dummy@dummy.test",
     "phone": "+49622112345",
@@ -548,36 +541,6 @@ def test_order_create_positionids_addons_simulated(token_client, organizer, even
     ]
 
 
-@pytest.mark.django_db
-def test_order_create_autocheckin(token_client, organizer, event, item, quota, question, clist_autocheckin):
-    res = copy.deepcopy(ORDER_CREATE_PAYLOAD)
-    res['positions'][0]['item'] = item.pk
-    res['positions'][0]['answers'][0]['question'] = question.pk
-    resp = token_client.post(
-        '/api/v1/organizers/{}/events/{}/orders/'.format(
-            organizer.slug, event.slug
-        ), format='json', data=res
-    )
-    assert resp.status_code == 201
-    with scopes_disabled():
-        o = Order.objects.get(code=resp.data['code'])
-        assert clist_autocheckin.auto_checkin_sales_channels.contains(organizer.sales_channels.get(identifier="web"))
-        assert o.positions.first().checkins.first().auto_checked_in
-
-    clist_autocheckin.auto_checkin_sales_channels.clear()
-
-    resp = token_client.post(
-        '/api/v1/organizers/{}/events/{}/orders/'.format(
-            organizer.slug, event.slug
-        ), format='json', data=res
-    )
-    assert resp.status_code == 201
-    with scopes_disabled():
-        o = Order.objects.get(code=resp.data['code'])
-        assert clist_autocheckin.auto_checkin_sales_channels.count() == 0
-        assert o.positions.first().checkins.count() == 0
-
-
 @pytest.mark.django_db
 def test_order_create_require_approval_free(token_client, organizer, event, item, quota, question):
     res = copy.deepcopy(ORDER_CREATE_PAYLOAD)

src/tests/api/test_orders.py

@@ -180,13 +180,6 @@ def order2(event2, item2):
         return o
 
 
-@pytest.fixture
-def clist_autocheckin(event):
-    c = event.checkin_lists.create(name="Default", all_products=True)
-    c.auto_checkin_sales_channels.add(event.organizer.sales_channels.get(identifier="web"))
-    return c
-
-
 TEST_ORDERPOSITION_RES = {
     "id": 1,
     "order": "FOO",