From 3903a0e5b66aded899389582bd93baad1cdbbd88 Mon Sep 17 00:00:00 2001 From: Lukas Bockstaller Date: Wed, 10 Dec 2025 09:45:21 +0100 Subject: [PATCH] pass existing `opqs` into `filter_qs` Co-authored-by: Richard Schreiber --- src/pretix/control/forms/item.py | 6 +----- src/pretix/control/views/item.py | 9 +++++---- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/pretix/control/forms/item.py b/src/pretix/control/forms/item.py index 94a8380a69..2724f002aa 100644 --- a/src/pretix/control/forms/item.py +++ b/src/pretix/control/forms/item.py @@ -353,13 +353,9 @@ class QuestionAnswerFilterForm(forms.Form): raise forms.ValidationError(_("Selected subevent isn't part of the date range.")) return cleaned_data - def filter_qs(self): + def filter_qs(self, opqs): fdata = self.cleaned_data - opqs = OrderPosition.objects.filter( - order__event=self.event, - ) - subevent = fdata.get('subevent', None) date_range = fdata.get('date_range', None) diff --git a/src/pretix/control/views/item.py b/src/pretix/control/views/item.py index c09f85cc47..6fe15da471 100644 --- a/src/pretix/control/views/item.py +++ b/src/pretix/control/views/item.py @@ -671,10 +671,11 @@ class QuestionView(EventPermissionRequiredMixin, ChartContainingView, DetailView return QuestionAnswerFilterForm(event=self.request.event, data=self.request.GET) def get_answer_statistics(self): - if not self.filter_form.is_valid(): - return - - opqs = self.filter_form.filter_qs() + opqs = OrderPosition.objects.filter( + order__event=self.event, + ) + if self.filter_form.is_valid(): + opqs = self.filter_form.filter_qs(opqs) qs = QuestionAnswer.objects.filter( question=self.object, orderposition__isnull=False,