Allow to exclude items from ticket generation explicitly

src/pretix/control/forms/item.py

@@ -297,6 +297,16 @@ class ItemCreateForm(I18nModelForm):
         ]
 
 
+class TicketNullBooleanSelect(forms.NullBooleanSelect):
+    def __init__(self, attrs=None):
+        choices = (
+            ('1', _('Choose automatically depending on event settings')),
+            ('2', _('Yes, if ticket generation is enabled in general')),
+            ('3', _('Never')),
+        )
+        super(forms.NullBooleanSelect, self).__init__(attrs, choices)
+
+
 class ItemUpdateForm(I18nModelForm):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
@@ -340,6 +350,7 @@ class ItemUpdateForm(I18nModelForm):
             'max_per_order',
             'min_per_order',
             'checkin_attention',
+            'generate_tickets',
             'original_price'
         ]
         field_classes = {
@@ -349,6 +360,7 @@ class ItemUpdateForm(I18nModelForm):
         widgets = {
             'available_from': SplitDateTimePickerWidget(),
             'available_until': SplitDateTimePickerWidget(attrs={'data-date-after': '#id_available_from_0'}),
+            'generate_tickets': TicketNullBooleanSelect()
         }
 
 

src/pretix/control/templates/pretixcontrol/item/index.html

@@ -43,6 +43,7 @@
                     <legend>{% trans "Additional settings" %}</legend>
                     {% bootstrap_field form.original_price addon_after=request.event.currency layout="control" %}
                     {% bootstrap_field form.require_approval layout="control" %}
+                    {% bootstrap_field form.generate_tickets layout="control" %}
                     {% for f in plugin_forms %}
                         {% bootstrap_form f layout="control" %}
                     {% endfor %}

src/pretix/control/templates/pretixcontrol/order/index.html

@@ -257,20 +257,18 @@
                                 {% endif %}
                                 {% if not line.canceled %}
                                     <div class="position-buttons">
-                                        {% if not line.addon_to or request.event.settings.ticket_download_addons %}
-                                            {% if line.item.admission or request.event.settings.ticket_download_nonadm %}
-                                                {% for b in download_buttons %}
-                                                    <form action="{% url "control:event.order.download.ticket" code=order.code event=request.event.slug organizer=request.event.organizer.slug position=line.pk output=b.identifier %}"
-                                                            method="post" data-asynctask data-asynctask-download
-                                                            class="form-inline helper-display-inline">
-                                                        {% csrf_token %}
-                                                        <button type="submit"
-                                                                class="btn btn-xs btn-default">
-                                                            <span class="fa {{ b.icon }}"></span> {{ b.text }}
-                                                        </button>
-                                                    </form>
-                                                {% endfor %}
-                                            {% endif %}
+                                        {% if line.generate_ticket %}
+                                            {% for b in download_buttons %}
+                                                <form action="{% url "control:event.order.download.ticket" code=order.code event=request.event.slug organizer=request.event.organizer.slug position=line.pk output=b.identifier %}"
+                                                        method="post" data-asynctask data-asynctask-download
+                                                        class="form-inline helper-display-inline">
+                                                    {% csrf_token %}
+                                                    <button type="submit"
+                                                            class="btn btn-xs btn-default">
+                                                        <span class="fa {{ b.icon }}"></span> {{ b.text }}
+                                                    </button>
+                                                </form>
+                                            {% endfor %}
                                         {% endif %}
                                         {% eventsignal event "pretix.control.signals.order_position_buttons" order=order position=line request=request %}
                                     </div>

src/pretix/control/views/orders.py

@@ -301,10 +301,8 @@ class OrderDownload(AsyncAction, OrderView):
             return self.error(_('You requested an invalid ticket output type.'))
         if not self.order_position:
             raise Http404(_('Unknown order code or not authorized to access this order.'))
-        if 'position' in kwargs and (self.order_position.addon_to and not self.request.event.settings.ticket_download_addons):
-            return self.error(_('Ticket download is not enabled for add-on products.'))
-        if 'position' in kwargs and (not self.order_position.item.admission and not self.request.event.settings.ticket_download_nonadm):
-            return self.error(_('Ticket download is not enabled for non-admission products.'))
+        if 'position' in kwargs and not self.order_position.generate_ticket:
+            return self.error(_('Ticket download is not enabled for this product.'))
 
         ct = self.get_last_ct()
         if ct: