From 1ddfe06b923d28148ab344b41aab7f4d5f530d27 Mon Sep 17 00:00:00 2001 From: luelista Date: Mon, 7 Apr 2025 09:50:57 +0200 Subject: [PATCH] Apply suggestions from code review --- src/pretix/base/services/orders.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pretix/base/services/orders.py b/src/pretix/base/services/orders.py index 4be1017866..863f9bfdf0 100644 --- a/src/pretix/base/services/orders.py +++ b/src/pretix/base/services/orders.py @@ -1563,7 +1563,7 @@ class OrderChangeManager: FeeValueOperation = namedtuple('FeeValueOperation', ('fee', 'value', 'price_diff')) AddFeeOperation = namedtuple('AddFeeOperation', ('fee', 'price_diff')) CancelFeeOperation = namedtuple('CancelFeeOperation', ('fee', 'price_diff')) - RegenerateSecretOperation = namedtuple('RegenerateSecretOperation', ('position', 'force_secret')) + RegenerateSecretOperation = namedtuple('RegenerateSecretOperation', ('position',)) ChangeSecretOperation = namedtuple('ChangeSecretOperation', ('position', 'new_secret')) ChangeValidFromOperation = namedtuple('ChangeValidFromOperation', ('position', 'valid_from')) ChangeValidUntilOperation = namedtuple('ChangeValidUntilOperation', ('position', 'valid_until')) @@ -2432,7 +2432,7 @@ class OrderChangeManager: elif isinstance(op, self.SplitOperation): split_positions.append(op.position) elif isinstance(op, self.RegenerateSecretOperation): - op.position.web_secret = op.force_secret or generate_secret() + op.position.web_secret = generate_secret() op.position.save(update_fields=["web_secret"]) assign_ticket_secret( event=self.event, position=op.position, force_invalidate=True, save=True