Allow to enable ticket downloads for pending orders

src/pretix/base/models/orders.py

@@ -420,6 +420,20 @@ class Order(LoggedModel):
                 dl_date = dl_date.datetime(self.event)
         return dl_date
 
+    @property
+    def ticket_download_available(self):
+        return self.event.settings.ticket_download and (
+            self.event.settings.ticket_download_date is None
+            or now() > self.ticket_download_date
+        ) and (
+            self.status == Order.STATUS_PAID
+            or (
+                (self.event.settings.ticket_download_pending or self.total == Decimal("0.00")) and
+                self.status == Order.STATUS_PENDING and
+                not self.require_approval
+            )
+        )
+
     @property
     def payment_term_last(self):
         tz = pytz.timezone(self.event.settings.timezone)

src/pretix/base/services/orders.py

@@ -634,7 +634,7 @@ def _perform_order(event: str, payment_provider: str, position_ids: List[str],
                 email_subject, email_template, email_context,
                 log_entry,
                 invoices=[invoice] if invoice and event.settings.invoice_email_attachment else [],
-                attach_tickets=(payment_provider == 'free')
+                attach_tickets=True
             )
         except SendMailException:
             logger.exception('Order received email could not be sent')

src/pretix/base/services/tickets.py

@@ -1,7 +1,6 @@
 import logging
 import os
 from datetime import timedelta
-from decimal import Decimal
 
 from django.core.files.base import ContentFile
 from django.utils.timezone import now
@@ -155,11 +154,7 @@ def get_tickets_for_order(order):
     can_download = all([r for rr, r in allow_ticket_download.send(order.event, order=order)])
     if not can_download:
         return []
-    if order.status != Order.STATUS_PAID and order.total != Decimal("0.00"):
-        return []
-    if (not order.event.settings.ticket_download
-            or (order.event.settings.ticket_download_date is not None
-                and now() < order.ticket_download_date)):
+    if not order.ticket_download_available:
         return []
 
     providers = [